summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-08-20Use builder for std pap policyKrishnajinka10-139/+366
Modify constructor in stdpappolicy to use builder this will fix the sonar issue related with more than 7 parameters method parameters Issue-ID: POLICY-1016 Change-Id: Id736a66e5ea48f0f233cffb640cdce8aaa8f2c0d Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-15Merge "Junit Coverage for Import Black List Entries"Jorge Hernandez1-68/+36
2018-08-14Junit Coverage for Import Black List Entriesrb71471-68/+36
Issue-ID: POLICY-901 Change-Id: I3776d3c4ed01bb27ed930c074c370361e33b100a Signed-off-by: rb7147 <rb7147@att.com>
2018-08-14Merge "Resolved the Sonar issues"Jorge Hernandez2-92/+92
2018-08-14Resolved the Sonar issuesrb71472-92/+92
Issue-ID: POLICY-901 Change-Id: I30e1d075dd8eb4739bcb5aa1f2503a016900ff75 Signed-off-by: rb7147 <rb7147@att.com>
2018-08-14Optimize PAP policy constructor with builderKrishnajinka10-353/+386
Fix sonar issue about constructor using more than 7 params. Use builder parameters object for setting the attributes of std pap policy.Recommit1 Issue-ID: POLICY-1016 Change-Id: Id9631a42813960baa78df4ab0c0f6706244c3180 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-13Merge "Modify std pap policy to use builder in constr"Pamela Dragosh7-87/+255
2018-08-13Merge "Fix comparison issues in onap pap rest"Pamela Dragosh13-2067/+2461
2018-08-13Modify std pap policy to use builder in constrKrishnajinka7-87/+255
Fix sonar issue about constructor using more than 7 params. Use builder parameters object for setting the attributes of std pap policy.Rework2 Issue-ID: POLICY-1016 Change-Id: If26f7daa8d5b5d387238aad74daeddd49a8b95bb Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-11Fix comparison issues in onap pap restkrishnajinka13-2067/+2461
Fix issues about incorrect comparison in pap rest modules indicated by analysis tools.Rework to fix review comments1 Issue-ID: POLICY-1016 Change-Id: I7a0ee45a721307fc3ba89ab65e807613a3df2542 Signed-off-by: krisjinka <kris.jinka@samsung.com>
2018-08-10Add PAP Policy parameter builder xacml policykrishnajinka15-1814/+2235
Fix Sonar flagged major issue about 14 params instead of 9 in the constructor of std pap policy class. Commit5 for modify constrctor.fix test Issue-ID: POLICY-1016 Change-Id: I79c8482b7fc4e203cb18402ba2b5a68a120c57b1 Signed-off-by: krisjinka <kris.jinka@samsung.com>
2018-08-08Fix sonar issue with constrctr in xacml compkrishnajinka3-318/+550
Fix sonar issue of Method has 9 parameters, which is greater than 7 authorized in StdPDPPolicy. Make the actual sonar fix Issue-ID: POLICY-1016 Change-Id: Ibc79ddce81a6209ec190c7f393557e9c569df453 Signed-off-by: krisjinka <kris.jinka@samsung.com>
2018-08-07Resolve sonar issue in Policy parametersKrishnajinka3-1903/+2064
Fix sonar issue of Method has 9 parameters, which is greater than 7 authorized in PolicyParameters class and related test class.Rework2 Issue-ID: POLICY-1016 Change-Id: I3096566d958e093439bcc95d92f1fe92e0ac57be Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-06Modify Policy manager servlet for sonar issuesKrishnajinka1-103/+100
Fix basic sonar issues in policy manager servlet major and minor issues reported by sonar Basic refactoring Issue-ID: POLICY-1016 Change-Id: If3c19943c04d9af43807090b6340547d69ca6a19 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-03Merge "Modify ONAP PAP REST classes basic checkstyle"Pamela Dragosh71-13730/+13730
2018-08-03Merge "Fix major sonar issues in SDK APP admin mod"Jorge Hernandez3-479/+524
2018-08-03Modify ONAP PAP REST classes basic checkstyleKrishnajinka71-13730/+13730
Modify tabs to space for checkstyle issue fix in ONAP PAP REST module. It helps future reviews and refactoring. Remaining classes Issue-ID: POLICY-1014 Change-Id: I677eadac9e8364b388be922024528c27fd1e2545 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-03Fix major sonar issues in SDK APP admin modKrishnajinka3-479/+524
Fix Sonar reported major issues regarding extracting constants, method complexity, duplicated code blocks, more than 3 nested control blocks. Rework3 after self review. Issue-ID: POLICY-1016 Change-Id: Icbf940c966c51a8ef4319a94a3832cb1e8c360ba Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-02Convert tabs to space in ONAP PAP REST1Krishnajinka29-9382/+9382
Modify tabs to space for checkstyle issue fix in ONAP PAP REST module. It helps future reviews and refactoring Issue-ID: POLICY-1014 Change-Id: Idcf45689565f039c76a3ef0f40ad9a46b41bd8d6 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-31Merge "Copy policy-endpoints from drools-pdp to common"Pamela Dragosh1-4/+3
2018-07-31Merge "Convert tabs to spaces basic refactoring"Jorge Hernandez141-14589/+14589
2018-07-31Merge "Fix major sonar issues in SDK APP"Pamela Dragosh2-666/+714
2018-07-31Convert tabs to spaces basic refactoringKrishnajinka141-14589/+14589
Change tabs into spaces for checkstyle fixes in ONAP REST module of policy engine. These changes come in way for review. Hence doing them before refactoring is better. Issue-ID: POLICY-1014 Change-Id: I31a372ae527946927157bc23b576f3066679b0ae Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-31Fix major sonar issues in SDK APPKrishnajinka2-666/+714
Fix major issues reported by sonar in POLICY SDK APP files such as CreateBRMSParamController, PolicyManagerServlet. Also modify tabs to space. Rework2 based on review comments Issue-ID: POLICY-1016 Change-Id: I5407ade1ce9f597fa91d9ca18506f5ac2d8b1411 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-30Copy policy-endpoints from drools-pdp to commonmmis1-4/+3
Issue-ID: POLICY-967 Change-Id: I84eba5c06d129cb2a7ef27ed78b63a8ada37805c Signed-off-by: mmis <michael.morris@ericsson.com>
2018-07-28Fix Sonar issues in utils PDP ParseLog reworkKrishnajinka3-216/+230
Fix Major Sonar issues in ParseLog BackupMonitor and ONAP-PDP component. Issues related to nested control statements. Rework2 based on review comments Issue-ID: POLICY-1013 Change-Id: I10edb242b45a649df902a4e7c1aba0a285b8b7fb Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-27Merge "Copy policy-endpoints from drools-pdp to common"Pamela Dragosh2-7/+8
2018-07-26Merge "Fix nested stmts issue of Sonar"Jorge Hernandez2-1336/+1336
2018-07-26Merge "Refactor code for nested stmts in policy std"Jorge Hernandez4-466/+509
2018-07-26Copy policy-endpoints from drools-pdp to commonmmis2-7/+8
Replaced references to classes deleted from drools-pdp with references to the corresponding classes in polcy-common Issue-ID: POLICY-967 Change-Id: I7bb580af3b3b2eb0ddcab9421c595237fa37282b Signed-off-by: mmis <michael.morris@ericsson.com>
2018-07-26Refactor code for nested stmts in policy stdKrishnajinka4-466/+509
Refactor code for nested control statements in PolicyEngineAPI policy.std package. These issues are flagged by Sonar as Major issues. Rework based on review comments Issue-ID: POLICY-1012 Change-Id: I6925dd5d56b653ef4cefe5ae64686a49f9741125 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-26Fix nested stmts issue of SonarKrishnajinka2-1336/+1336
Policy rest util MSModeUtils have Sonar flagged issues about nesting more than 3 control stmts. Fix these. Also a minor change from prev commit about BrmsPush.java. Rework based on review Issue-ID: POLICY-1009 Change-Id: Ibd3cebcdebf9cf26233e810033793a5315b93272 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-26Merge "Fix issues reported by sonar"Liam Fallon9-1341/+1323
2018-07-25Fix issues reported by sonarKrishnajinka9-1341/+1323
Fix issues related to unused method variables, extract constants, not nest more than 3 control stmts, use try with res in policy engine project. Rework for comments Issue-ID: POLICY-1008 Change-Id: If0953de9e802110df14862707f3b525652cdf112 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-25Merge "Decision BlackList Guard Enhancements"Jorge Hernandez15-244/+1083
2018-07-25Merge "Fix sonar issue about nested stmts"Jorge Hernandez3-281/+306
2018-07-25Fix sonar issue about nested stmtsKrishnajinka3-281/+306
Refactor code to not nest more than 3 condition or loop stmts in policy PolicyEngineUtils. Rework based on review comments Issue-ID: POLICY-1003 Change-Id: I95fcfa0f99c517c02357c85ca39cd2f934e8da4d Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-24Decision BlackList Guard Enhancementsrb714715-244/+1083
While creating a decision Bl Guard Policy we are allowing to add Blacklist entries through file upload for bulk from GUI. Issue-ID: POLICY-901 Change-Id: I4031fd4a96937b9facc330cecf72777d701d4678 Signed-off-by: rb7147 <rb7147@att.com>
2018-07-24Merge "Refactor PolicyNotificationMail for sonar issues"Pamela Dragosh1-118/+152
2018-07-23Add modified copyright noticeKrishnajinka12-646/+658
For the files which are modified add modified copyright notices as per comments from earlier review Issue-ID: POLICY-1002 Change-Id: I873b3ccc986d5f3d138ddb9e9b3c2307a0b127a6 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-23Refactor PolicyNotificationMail for sonar issuesKrishnajinka1-118/+152
SONAR flagged issues related with complexity of method being high and more than 3 nested loops in the PolicyNotificationMail Issue-ID: POLICY-986 Change-Id: Ife3e6b5610cec4bcf3898fdcad4cc2c9a3d61932 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-20FIX SONAR ISSUE NESTED TRY BLOCKSKrishnajinka9-1875/+1925
refactor the code for nested try blocks and rework based on comments and fix nested loops complexity Issue-ID: POLICY-976 Change-Id: Ied02b7838b5e4839a4906f79ff37c4fd6afeccfe Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-17Upgrade tomcat to clear security issuesPamela Dragosh2-3/+3
New security issue has appeared, so we will do minor upgrade. Issue-ID: POLICY-982 Change-Id: I58ee20ec07300ab586017ca2072f63329e6f3417 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-07-17USE TRY WITH RESOURCESKrishnajinka7-4239/+4216
Fix sonar issues to convert try blocks to try with resources plus change tabs 2 space Issue-ID: POLICY-961 Change-Id: I553d6a42f1efaab5b7eb3a53bab945a3360e69bb Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-13Reverting "Merge "fix try block""Jorge Hernandez7-30/+55
This reverts commit 240bbdbdc76e0e91af9f18164eadb2708d14c6fb, reversing changes made to 3ee69f1af0acddd1e06060ad88c0029fe7ceeaaf. Change-Id: I61f07ead1d7d3e89c512a2224efecf9ac440df10 Issue-ID: POLICY-961 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-07-13Merge "fix try block"Jorge Hernandez7-55/+30
2018-07-13fix try blockKrishnajinka7-55/+30
Issue-ID: POLICY-961 Change-Id: Ia1f388368007a4a82a57520dc6ddd99cc484a393 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-12Upgrade Portal SDK to resolve Security IssuesMichael Mokry4-2/+102
Upgraded version in pom to 2.3.1 Added SQL scripts from Portal to Upgrade Portal related db tables Added SQL downgrade script and license header Sorted SQL commands in upgrade script by function_cd per Jim Change-Id: Id6bef295956b6ec5b13d8fbd0006bbfe98c1c0ac Issue-ID: POLICY-918 Signed-off-by: Mike Mokry <mm117s@att.com>
2018-06-29Revert "Fix policy gui missing schema_info table"Joseph Chou1-16/+1
This reverts commit e67481ed648c419a1645d0fc8b98506fe544a454. Change-Id: I092053ec1815cf7ca598b1913663532673125604 Issue-ID: POLICY-898 Signed-off-by: Joseph Chou <jc2555@att.com>
2018-06-27Merge "Address missing files in junit tests"Liam Fallon4-0/+88