diff options
author | Pamela Dragosh <pdragosh@research.att.com> | 2018-02-05 12:50:06 -0500 |
---|---|---|
committer | Pamela Dragosh <pdragosh@research.att.com> | 2018-02-05 12:50:13 -0500 |
commit | fa97f50cf4d6395b49ec2ad275722db81a30953d (patch) | |
tree | 7d6836288f602626d9b874d0dfed6352cb0b5ac3 /PolicyEngineUtils | |
parent | 153ec0fda79b07ca1ecf7016f1e7f4e2c792f04e (diff) |
Technical debt and fix JUnit test
* One statement per line
* private constructor for class with statics
* Fix silly JUnit test
Issue-ID: POLICY-474
Change-Id: Ie760826879febbbc4db4f03079ae1f847f2194dd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Diffstat (limited to 'PolicyEngineUtils')
-rw-r--r-- | PolicyEngineUtils/src/main/java/org/onap/policy/std/NotificationStore.java | 2 | ||||
-rw-r--r-- | PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java | 4 |
2 files changed, 4 insertions, 2 deletions
diff --git a/PolicyEngineUtils/src/main/java/org/onap/policy/std/NotificationStore.java b/PolicyEngineUtils/src/main/java/org/onap/policy/std/NotificationStore.java index 47b23605d..24e126386 100644 --- a/PolicyEngineUtils/src/main/java/org/onap/policy/std/NotificationStore.java +++ b/PolicyEngineUtils/src/main/java/org/onap/policy/std/NotificationStore.java @@ -40,7 +40,7 @@ public class NotificationStore { private static StdPDPNotification notificationRecord = new StdPDPNotification(); - public NotificationStore () { + private NotificationStore () { // Sonar prefers that we have an empty public constructor // as opposed to an implicit public constructor. } diff --git a/PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java b/PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java index c058a7997..0f38232e1 100644 --- a/PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java +++ b/PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java @@ -194,7 +194,9 @@ public class PolicyUtils { return false; } for (char c : number.toCharArray()){ - if (!Character.isDigit(c)) return false; + if (!Character.isDigit(c)) { + return false; + } } return true; } |