Optimize PAP policy constructor with builder

Fix sonar issue about constructor using more than 7 params.
Use builder parameters object for setting the attributes of
std pap policy.Recommit1

Issue-ID: POLICY-1016
Change-Id: Id9631a42813960baa78df4ab0c0f6706244c3180
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>

1 files changed, 73 insertions, 84 deletions

diff --git a/PolicyEngineClient/src/test/java/org/onap/policyengine/BrmsRawPolicyClient.java b/PolicyEngineClient/src/test/java/org/onap/policyengine/BrmsRawPolicyClient.java
index 18d404dc2..60e2c5df7 100644
--- a/PolicyEngineClient/src/test/java/org/onap/policyengine/BrmsRawPolicyClient.java
+++ b/PolicyEngineClient/src/test/java/org/onap/policyengine/BrmsRawPolicyClient.java
@@ -40,92 +40,81 @@ import org.onap.policy.api.PolicyParameters;
 import org.onap.policy.api.PolicyType;
 
 public class BrmsRawPolicyClient {
-	static Boolean isEdit = true;
-	
-	//Reads a File and converts into a String. 
-	private static String readFile( String file ) throws IOException {
-	    BufferedReader reader = new BufferedReader( new FileReader (file));
-	    String         line = null;
-	    StringBuilder  stringBuilder = new StringBuilder();
-	    String         ls = System.getProperty("line.separator");
-
-	    try {
-	        while( ( line = reader.readLine() ) != null ) {
-	            stringBuilder.append( line );
-	            stringBuilder.append( ls );
-	        }
-
-	        return stringBuilder.toString();
-	    } finally {
-	        reader.close();
-	    }
-	}
-	
-	
-	public static void main(String[] args) {
-		try {
-	        PolicyEngine policyEngine = new PolicyEngine("config.properties");
-	        PolicyParameters policyParameters = new PolicyParameters();
-	        Map<String, String> attrib= new HashMap<>();
-	        attrib.put("cpu","80");
-	        attrib.put("memory", "50");
-	        Map<AttributeType, Map<String, String>> attributes = new HashMap<>();
+    static Boolean isEdit = true;
+
+    //Reads a File and converts into a String.
+    private static String readFile( String file ) throws IOException {
+
+        String         line = null;
+        StringBuilder  stringBuilder = new StringBuilder();
+        String         ls = System.getProperty("line.separator");
+
+        try (BufferedReader reader = new BufferedReader( new FileReader (file))) {
+            while( ( line = reader.readLine() ) != null ) {
+                stringBuilder.append( line );
+                stringBuilder.append( ls );
+            }
+            return stringBuilder.toString();
+        }
+    }
+
+
+    public static void main(String[] args) {
+        try {
+            PolicyEngine policyEngine = new PolicyEngine("config.properties");
+            PolicyParameters policyParameters = new PolicyParameters();
+            Map<String, String> attrib= new HashMap<>();
+            attrib.put("cpu","80");
+            attrib.put("memory", "50");
+            Map<AttributeType, Map<String, String>> attributes = new HashMap<>();
             attributes.put(AttributeType.RULE, attrib);
-	        
-	        // Set Policy Type
-	        policyParameters.setPolicyConfigType(PolicyConfigType.BRMS_RAW); //required
-	        policyParameters.setPolicyName("Lakshman.testBRMSRawAPITwo"); //required
-	        policyParameters.setPolicyDescription("This is a sample BRMS Raw policy body");  //optional
-	        policyParameters.setAttributes(attributes);
-	        //policyParameters.setPolicyScope("Lakshman"); //Directory will be created where the Policies are saved... this displays a a subscope on the GUI
-	        policyParameters.setRequestID(UUID.randomUUID());
-	        
+
+            // Set Policy Type
+            policyParameters.setPolicyConfigType(PolicyConfigType.BRMS_RAW); //required
+            policyParameters.setPolicyName("Lakshman.testBRMSRawAPITwo"); //required
+            policyParameters.setPolicyDescription("This is a sample BRMS Raw policy body");  //optional
+            policyParameters.setAttributes(attributes);
+            //policyParameters.setPolicyScope("Lakshman"); //Directory will be created where the Policies are saved... this displays a a subscope on the GUI
+            policyParameters.setRequestID(UUID.randomUUID());
+
             // Set Safe Policy value for Risk Type
-			SimpleDateFormat dateformat3 = new SimpleDateFormat("dd/MM/yyyy");
-			Date date = dateformat3.parse("15/10/2016");
-			policyParameters.setTtlDate(date);
-			// Set Safe Policy value for Guard
-			policyParameters.setGuard(true);
-			// Set Safe Policy value for Risk Level
-			policyParameters.setRiskLevel("5");
-			// Set Safe Policy value for Risk Type
-			policyParameters.setRiskType("PROD");
-	        
-	        File rawBodyFile = null;
-		
-			Path file = Paths.get("C:\\Users\\testuser\\Documents\\API\\com.Config_BRMS_Raw_TestBrmsPolicy.1.txt");
-			rawBodyFile = file.toFile();
-			
-			policyParameters.setConfigBody(readFile(rawBodyFile.toString()));		
-			policyParameters.setConfigBodyType(PolicyType.OTHER);
-			
-			/*public String createUpdateBRMSRawPolicy(String policyName, 
-					String policyDescription, 
-					Map<String,String> dyanamicFieldConfigAttributes,
-					String brmsRawBody, 
-					String policyScope, 
-					Boolean isEdit, 
-					UUID requestID) */
-	
-	        // API method to create Policy or update policy
-	        PolicyChangeResponse response = null;
-	        if (!isEdit) {
-	            response = policyEngine.createPolicy(policyParameters);
-	        } else {
-	        	response = policyEngine.updatePolicy(policyParameters);
-	        }
-	        
-	        if(response.getResponseCode()==200){
-	            System.out.println(response.getResponseMessage());
-	            System.out.println("Policy Created Successfully!");
-	        }else{
-	            System.out.println("Error! " + response.getResponseMessage());
-	        }
-		} catch (Exception e) {
-			System.err.println(e.getMessage());
-		}
-	}
-	
+            SimpleDateFormat dateformat3 = new SimpleDateFormat("dd/MM/yyyy");
+            Date date = dateformat3.parse("15/10/2016");
+            policyParameters.setTtlDate(date);
+            // Set Safe Policy value for Guard
+            policyParameters.setGuard(true);
+            // Set Safe Policy value for Risk Level
+            policyParameters.setRiskLevel("5");
+            // Set Safe Policy value for Risk Type
+            policyParameters.setRiskType("PROD");
+
+            File rawBodyFile = null;
+
+            Path file = Paths.get("C:\\Users\\testuser\\Documents\\API\\com.Config_BRMS_Raw_TestBrmsPolicy.1.txt");
+            rawBodyFile = file.toFile();
+
+            policyParameters.setConfigBody(readFile(rawBodyFile.toString()));
+            policyParameters.setConfigBodyType(PolicyType.OTHER);
+
+            // API method to create Policy or update policy
+            PolicyChangeResponse response = null;
+            if (!isEdit) {
+                response = policyEngine.createPolicy(policyParameters);
+            } else {
+                response = policyEngine.updatePolicy(policyParameters);
+            }
+
+            if(response.getResponseCode()==200){
+                System.out.println(response.getResponseMessage());
+                System.out.println("Policy Created Successfully!");
+            }else{
+                System.out.println("Error! " + response.getResponseMessage());
+            }
+        } catch (Exception e) {
+            System.err.println(e.getMessage());
+        }
+    }
+
 }