Sonar cleanup for PolicyEngineUtils

Changes to resolve some sonar "major" issues in the PolicyEngineUtils
module.

Patch 2: Updated the NotificationStoreTest junit to account for the return
of a "Collections.emptyList()" rather than "null" in StdPDPNotification
class.

Patch 3: Updated the StdPDPNotificationTest junit to account for the
return of a "Collections.emptyList()" rather than "null" in
StdPDPNotifaction class.

Issue-ID: POLICY-474
Change-Id: I925774ac181fd38d1206637f47ab27ba499629ef
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

1 files changed, 3 insertions, 2 deletions

diff --git a/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/StdPDPNotificationTest.java b/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/StdPDPNotificationTest.java
index 6a558006d..23b570e9a 100644
--- a/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/StdPDPNotificationTest.java
+++ b/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/StdPDPNotificationTest.java
@@ -21,6 +21,7 @@
 package org.onap.policy.std.test;
 
 import java.util.Collection;
+import java.util.Collections;
 import java.util.LinkedList;
 
 import org.junit.*;
@@ -115,7 +116,7 @@ public class StdPDPNotificationTest {
 		Collection<LoadedPolicy> result = fixture.getLoadedPolicies();
 
 		// add additional test code here
-		assertEquals(null, result);
+		assertEquals(Collections.EMPTY_LIST, result);
 	}
 
 	/**
@@ -204,7 +205,7 @@ public class StdPDPNotificationTest {
 		Collection<RemovedPolicy> result = fixture.getRemovedPolicies();
 
 		// add additional test code here
-		assertEquals(null, result);
+		assertEquals(Collections.EMPTY_LIST, result);
 	}
 
 	/**