diff options
author | 2019-01-21 16:21:28 -0600 | |
---|---|---|
committer | 2019-01-22 09:10:58 -0600 | |
commit | e598e9708241430648b553f0d3f3b2a146be1bf2 (patch) | |
tree | e568f9c071f9a873c78553850186ec8b59e1dae7 /ONAP-PAP-REST/src/test/java/org | |
parent | 1aeb1d9da9b06a38e6b9760085cb0fc51b8faf18 (diff) |
Increase JUnit Code Coverage for PolicyDBDao
Added Junit tests for PolicyDBDao methods that were not covered after
observing that the code coverage dropped below 50% in SONAR.
Modified license headers with correct copywrite
Change-Id: Iad8e18d978236f4391363d963eb4624744f45099
Issue-ID: POLICY-1448
Signed-off-by: Michael Mokry <michael.mokry@att.com>
Diffstat (limited to 'ONAP-PAP-REST/src/test/java/org')
-rw-r--r-- | ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/components/PolicyDBDaoTest.java | 43 |
1 files changed, 42 insertions, 1 deletions
diff --git a/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/components/PolicyDBDaoTest.java b/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/components/PolicyDBDaoTest.java index 89ddf84c5..f7dd92a3e 100644 --- a/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/components/PolicyDBDaoTest.java +++ b/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/components/PolicyDBDaoTest.java @@ -2,7 +2,7 @@ * ============LICENSE_START======================================================= * ONAP-PAP-REST * ================================================================================ - * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved. + * Copyright (C) 2017-2019 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -143,6 +143,47 @@ public class PolicyDBDaoTest extends Mockito{ configFile = d.getConfigFile("Action_mypolicy.xml", "org.onap", pra); Assert.assertEquals("org.onap.Action_mypolicy.json", configFile); } + + @Test + public void getPolicyNameAndVersionFromPolicyFileNameTest() throws PolicyDBException { + String policyName = "com.Decision_testname.1.xml"; + String[] expectedNameAndVersion = new String[2]; + expectedNameAndVersion[0] = "com.Decision_testname"; + expectedNameAndVersion[1] = "1"; + String[] actualNameAndVersion = d.getPolicyNameAndVersionFromPolicyFileName(policyName); + Assert.assertArrayEquals(expectedNameAndVersion, actualNameAndVersion); + } + + @Test + public void getNameScopeAndVersionFromPdpPolicyTest() { + String fileName = "com.Decision_testname.1.xml"; + String[] expectedArray = new String[3]; + expectedArray[0] = "Decision_testname.1.xml"; + expectedArray[2] = "1"; + expectedArray[1] = "com"; + + String[] returnArray = d.getNameScopeAndVersionFromPdpPolicy(fileName); + Assert.assertArrayEquals(expectedArray, returnArray); + } + + @Test + public void getPdpPolicyNameTest() { + String name = "Decision_testname.1.json"; + String scope = "com"; + String expectedFinalname = "com.Decision_testname.1.xml"; + + String finalname = d.getPdpPolicyName(name, scope); + Assert.assertEquals(expectedFinalname, finalname); + } + + @Test + public void getPolicySubFileTest() { + String name = "Config_testname.1.json"; + String subFileType = "Config"; + + Path path = d.getPolicySubFile(name, subFileType); + Assert.assertNull(path); + } @Test public void createFromPolicyObject(){ |