diff options
| author |   Ankitkumar Patel <ankit@research.att.com> | 2018-01-29 22:42:19 -0500 |
|---|---|---|
| committer | Ankitkumar Patel <ankit@research.att.com> | 2018-01-31 15:57:42 -0500 |
| commit | 401b48bc573561f097960a9ca7abe6d788456f28 (patch) | |
| tree | a8f089325447333d535adbc9d23dbf182547845e /ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/CreateNewMicroServiceModel.java | |
| parent | 9301fed7c290f52208922f780fdfe4b5a880b5aa (diff) | |
Fixed the Sonar technical debt.
Fixed the sonar technical dept primarily for the POLICY-REST module, and
accordingly updated the other policy-engine modules for successful built.
Issue-ID: POLICY-476
Change-Id: I0e9bd7209a7f9af247fa409a1682683082f92698
Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
Diffstat (limited to 'ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/CreateNewMicroServiceModel.java')
| -rw-r--r-- | ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/CreateNewMicroServiceModel.java | 22 |
1 files changed, 10 insertions, 12 deletions
diff --git a/ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/CreateNewMicroServiceModel.java b/ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/CreateNewMicroServiceModel.java index aad70e5dd..af7895695 100644 --- a/ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/CreateNewMicroServiceModel.java +++ b/ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/CreateNewMicroServiceModel.java @@ -70,7 +70,7 @@ public class CreateNewMicroServiceModel { this.newModel.setUserCreatedBy(userInfo); String cleanUpFile = null; - HashMap<String, MSAttributeObject> tempMap = new HashMap<>(); + Map<String, MSAttributeObject> tempMap = new HashMap<>(); //Need to delete the file if (importFile.contains(".zip")){ extractFolder(randomID + ".zip"); @@ -143,16 +143,14 @@ public class CreateNewMicroServiceModel { int currentByte; byte data[] = new byte[BUFFER]; - - FileOutputStream fos = new FileOutputStream(destFile); - BufferedOutputStream dest = new BufferedOutputStream(fos, - BUFFER); - - while ((currentByte = is.read(data, 0, BUFFER)) != -1) { - dest.write(data, 0, currentByte); - } - dest.flush(); - dest.close(); + try(FileOutputStream fos = new FileOutputStream(destFile); + BufferedOutputStream dest = new BufferedOutputStream(fos, BUFFER)) { + + while ((currentByte = is.read(data, 0, BUFFER)) != -1) { + dest.write(data, 0, currentByte); + } + dest.flush(); + } is.close(); } @@ -177,7 +175,7 @@ public class CreateNewMicroServiceModel { Map<String, String> successMap = new HashMap<>(); MSAttributeObject mainClass = null; - ArrayList<String> dependency = null; + List<String> dependency = null; String subAttribute = null; if (!classMap.containsKey(this.newModel.getModelName())){ |