Merge "JUnit additions for PDP-REST,REST,SDK-APP"

4 files changed, 200 insertions, 5 deletions

diff --git a/ONAP-PDP-REST/src/test/java/org/onap/policy/pdp/rest/api/models/PDPResponseTest.java b/ONAP-PDP-REST/src/test/java/org/onap/policy/pdp/rest/api/models/PDPResponseTest.java
new file mode 100644
index 000000000..a48791cf0
--- /dev/null
+++ b/ONAP-PDP-REST/src/test/java/org/onap/policy/pdp/rest/api/models/PDPResponseTest.java
@@ -0,0 +1,82 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * ONAP Policy Engine
+ * ================================================================================
+ * Copyright (C) 2018 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.policy.pdp.rest.api.models;
+
+import static org.junit.Assert.assertEquals;
+import java.util.HashMap;
+import java.util.Map;
+import org.junit.Test;
+import org.onap.policy.api.PolicyConfigStatus;
+import org.onap.policy.api.PolicyDecision;
+import org.onap.policy.api.PolicyResponseStatus;
+import org.onap.policy.api.PolicyType;
+
+public class PDPResponseTest {
+  @Test
+  public void testSetAndGet() {
+    // Test values
+    String message = "testMessage";
+    String config = "testConfig";
+    String policyName = "testPolicyName";
+    String policyVersion = "1.0";
+    PolicyResponseStatus policyResponseStatus = PolicyResponseStatus.ACTION_ADVISED;
+    PolicyConfigStatus policyConfigStatus = PolicyConfigStatus.CONFIG_RETRIEVED;
+    PolicyType type = PolicyType.JSON;
+    Map<String, String> property = new HashMap<String, String>();
+    PolicyDecision policyDecision = PolicyDecision.PERMIT;
+
+    PDPResponse response = new PDPResponse();
+
+    response.setStatus(message, policyResponseStatus, policyConfigStatus);
+    response.setConfig(config);
+    assertEquals(config, response.getConfig());
+    response.setType(type);
+    assertEquals(type, response.getType());
+    response.setPolicyConfigStatus(policyConfigStatus);
+    assertEquals(policyConfigStatus, response.getPolicyConfigStatus());
+    response.setPolicyConfigMessage(message);
+    assertEquals(message, response.getPolicyConfigMessage());
+    response.setProperty(property);
+    assertEquals(property, response.getProperty());
+    response.setPolicyName(policyName);
+    assertEquals(policyName, response.getPolicyName());
+    response.setPolicyVersion(policyVersion);
+    assertEquals(policyVersion, response.getPolicyVersion());
+    response.setMatchingConditions(property);
+    assertEquals(property, response.getMatchingConditions());
+    response.setResponseAttributes(property);
+    assertEquals(property, response.getResponseAttributes());
+    response.setPolicyResponseStatus(policyResponseStatus);
+    assertEquals(policyResponseStatus, response.getPolicyResponseStatus());
+    response.setDecision(policyDecision);
+    assertEquals(policyDecision, response.getDecision());
+    response.setDetails(message);
+    assertEquals(message, response.getDetails());
+    response.setActionAdvised(property);
+    assertEquals(property, response.getActionAdvised());
+    response.setActionTaken(property);
+    assertEquals(property, response.getActionTaken());
+    response.setRequestAttributes(property);
+    assertEquals(property, response.getRequestAttributes());
+    response.setPolicyResponseMessage(message);
+    assertEquals(message, response.getPolicyResponseMessage());
+  }
+}
diff --git a/ONAP-REST/src/test/java/org/onap/policy/rest/util/PDPPolicyContainerTest.java b/ONAP-REST/src/test/java/org/onap/policy/rest/util/PDPPolicyContainerTest.java
index 457df7062..9302df3b5 100644
--- a/ONAP-REST/src/test/java/org/onap/policy/rest/util/PDPPolicyContainerTest.java
+++ b/ONAP-REST/src/test/java/org/onap/policy/rest/util/PDPPolicyContainerTest.java
@@ -128,11 +128,11 @@ public class PDPPolicyContainerTest {
   @Test
   public void testPDPPolicyItem() {
     PDPPolicyItem item = container.new PDPPolicyItem(policy);
-    assertEquals(item.getId(), "Config_test");
-    assertEquals(item.getName(), "Config_test.1.xml");
-    assertEquals(item.getVersion(), "1.0");
-    assertEquals(item.getDescription(), "testDescription");
+    assertEquals("Config_test", item.getId());
+    assertEquals("Config_test.1.xml", item.getName());
+    assertEquals("1.0", item.getVersion());
+    assertEquals("testDescription", item.getDescription());
     item.setRoot(true);
-    assertEquals(item.getRoot(), true);
+    assertEquals(true, item.getRoot());
   }
 }
diff --git a/ONAP-SDK-APP/src/test/java/org/onap/portalapp/conf/ExternalAppConfigTest.java b/ONAP-SDK-APP/src/test/java/org/onap/portalapp/conf/ExternalAppConfigTest.java
new file mode 100644
index 000000000..133d4a860
--- /dev/null
+++ b/ONAP-SDK-APP/src/test/java/org/onap/portalapp/conf/ExternalAppConfigTest.java
@@ -0,0 +1,72 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * ONAP Policy Engine
+ * ================================================================================
+ * Copyright (C) 2018 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.portalapp.conf;
+
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+import java.net.MalformedURLException;
+import java.util.Collections;
+import org.junit.Test;
+import org.mockito.Mockito;
+import org.onap.portalapp.scheduler.RegistryAdapter;
+import org.onap.portalsdk.core.scheduler.Registerable;
+import org.onap.portalsdk.workflow.services.WorkflowScheduleService;
+import org.quartz.Trigger;
+import org.springframework.context.ApplicationContext;
+import org.springframework.core.io.UrlResource;
+import org.springframework.web.servlet.config.annotation.InterceptorRegistry;
+import org.springframework.web.servlet.config.annotation.ResourceHandlerRegistry;
+
+public class ExternalAppConfigTest {
+  @Test
+  public void testConfig() throws MalformedURLException {
+    // Setup test data
+    ApplicationContext ctx = Mockito.mock(ApplicationContext.class);
+    UrlResource value = new UrlResource("http://localhost");
+    Mockito.when(ctx.getResource(Mockito.any())).thenReturn(value);
+    ResourceHandlerRegistry registry = new ResourceHandlerRegistry(ctx, null);
+    InterceptorRegistry interceptor = new InterceptorRegistry();
+    RegistryAdapter schedulerRegistryAdapter = new RegistryAdapter();
+    Registerable reg = Mockito.mock(Registerable.class);
+    Mockito.when(reg.getTriggers()).thenReturn(new Trigger[1]);
+    schedulerRegistryAdapter.setRegistry(reg);
+    WorkflowScheduleService workflowScheduleService = Mockito.mock(WorkflowScheduleService.class);
+    schedulerRegistryAdapter.setWorkflowScheduleService(workflowScheduleService);
+    Mockito.when(workflowScheduleService.triggerWorkflowScheduling())
+        .thenReturn(Collections.emptyList());
+
+    // Test constructor
+    ExternalAppConfig config = new ExternalAppConfig();
+    assertNotNull(config);
+
+    // Test set and get
+    config.setApplicationContext(ctx);
+    assertNotNull(config.viewResolver());
+    config.addResourceHandlers(registry);
+    assertNotNull(config.dataAccessService());
+    assertNotNull(config.addTileDefinitions());
+    config.addInterceptors(interceptor);
+    assertNotNull(config.cacheManager());
+    config.setSchedulerRegistryAdapter(schedulerRegistryAdapter);
+    assertNull(config.schedulerFactoryBean());
+    assertNotNull(config.loginStrategy());
+  }
+}
diff --git a/POLICY-SDK-APP/src/test/java/org/onap/policy/conf/HibernateSessionTest.java b/POLICY-SDK-APP/src/test/java/org/onap/policy/conf/HibernateSessionTest.java
new file mode 100644
index 000000000..e590fb3e9
--- /dev/null
+++ b/POLICY-SDK-APP/src/test/java/org/onap/policy/conf/HibernateSessionTest.java
@@ -0,0 +1,41 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * ONAP Policy Engine
+ * ================================================================================
+ * Copyright (C) 2018 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.policy.conf;
+
+import static org.junit.Assert.assertNull;
+import org.hibernate.SessionFactory;
+import org.junit.Test;
+import org.mockito.Mockito;
+import org.onap.policy.controller.PolicyController;
+
+public class HibernateSessionTest {
+  @Test
+  public void testSession() {
+    PolicyController.setLogdbUrl("testURL");
+    PolicyController.setLogdbUserName("testUser");
+    PolicyController.setLogdbPassword("testPass");
+    PolicyController.setLogdbDialect("testDialect");
+    PolicyController.setLogdbDriver("testDriver");
+    SessionFactory factory = Mockito.mock(SessionFactory.class);
+    HibernateSession.setSession(factory);
+    assertNull(HibernateSession.getSession());
+  }
+}