summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJorge Hernandez <jh1730@att.com>2018-02-05 21:39:00 +0000
committerGerrit Code Review <gerrit@onap.org>2018-02-05 21:39:00 +0000
commitfe11ab01afebfa9777c3382d28026c805f7d042b (patch)
treeeca58f3ab67643e5001acbe4e554b4f696ff1bb3
parent3e642d2fcd9a09a8a40918cf0451cfdafe70e968 (diff)
parentfa97f50cf4d6395b49ec2ad275722db81a30953d (diff)
Merge "Technical debt and fix JUnit test"
-rw-r--r--PolicyEngineAPI/src/test/java/org/onap/policy/std/test/NotificationStoreTest.java13
-rw-r--r--PolicyEngineUtils/src/main/java/org/onap/policy/std/NotificationStore.java2
-rw-r--r--PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java4
3 files changed, 4 insertions, 15 deletions
diff --git a/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/NotificationStoreTest.java b/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/NotificationStoreTest.java
index ed7383e1a..a453736ec 100644
--- a/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/NotificationStoreTest.java
+++ b/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/NotificationStoreTest.java
@@ -34,19 +34,6 @@ import static org.junit.Assert.*;
*/
public class NotificationStoreTest {
/**
- * Run the NotificationStore() constructor test.
- *
- * @generatedBy CodePro at 6/1/16 1:40 PM
- */
- @Test
- public void testNotificationStore_1()
- throws Exception {
- NotificationStore result = new NotificationStore();
- assertNotNull(result);
- // add additional test code here
- }
-
- /**
* Run the void recordNotification(StdPDPNotification) method test.
*
* @throws Exception
diff --git a/PolicyEngineUtils/src/main/java/org/onap/policy/std/NotificationStore.java b/PolicyEngineUtils/src/main/java/org/onap/policy/std/NotificationStore.java
index 47b23605d..24e126386 100644
--- a/PolicyEngineUtils/src/main/java/org/onap/policy/std/NotificationStore.java
+++ b/PolicyEngineUtils/src/main/java/org/onap/policy/std/NotificationStore.java
@@ -40,7 +40,7 @@ public class NotificationStore {
private static StdPDPNotification notificationRecord = new StdPDPNotification();
- public NotificationStore () {
+ private NotificationStore () {
// Sonar prefers that we have an empty public constructor
// as opposed to an implicit public constructor.
}
diff --git a/PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java b/PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java
index c058a7997..0f38232e1 100644
--- a/PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java
+++ b/PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java
@@ -194,7 +194,9 @@ public class PolicyUtils {
return false;
}
for (char c : number.toCharArray()){
- if (!Character.isDigit(c)) return false;
+ if (!Character.isDigit(c)) {
+ return false;
+ }
}
return true;
}