summaryrefslogtreecommitdiffstats
path: root/feature-mdc-filters/src/test/java/org/onap/policy/drools/mdc/filters/MdcTopicFilterTest.java
blob: e1a9b9b8383adc79778253b7d1997f2c46dfe267 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
/*
 * ============LICENSE_START=======================================================
 * feature-mdc-filters
 * ================================================================================
 * Copyright (C) 2019-2020 AT&T Intellectual Property. All rights reserved.
 * ================================================================================
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 * ============LICENSE_END=========================================================
 */

package org.onap.policy.drools.mdc.filters;

import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import org.junit.Test;
import org.onap.policy.drools.mdc.filters.MdcTopicFilter.FilterRule;

public class MdcTopicFilterTest {

    /**
     * Test the simple case of having one filter rule for a key.
     */
    @Test
    public void singleFilterOnePathTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);

        FilterRule rule = topicFilter.getFilterRule("requestID");
        assertEquals("requestID", rule.getMdcKey());
        assertEquals("[$.requestID]", rule.getPaths().toString());
    }

    /**
     * Tests having one filter rule with a set of potential paths to the key.
     */
    @Test
    public void singleFilterMultiPathTest() {
        String topicFilterProp = "requestID=$.requestID|$.request-id";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);

        FilterRule rule = topicFilter.getFilterRule("requestID");
        assertEquals("requestID", rule.getMdcKey());
        assertEquals(2, rule.getPaths().size());
        assertEquals("[$.requestID, $.request-id]", rule.getPaths().toString());
    }

    /**
     * Tests having two filter rules that each have one key/path pair.
     */
    @Test
    public void multiFilterSinglePathTest() {
        String topicFilterProp = "requestID=$.requestID,closedLoopControlName=$.closedLoopControlName";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);

        FilterRule rule = topicFilter.getFilterRule("requestID");
        assertEquals("requestID", rule.getMdcKey());
        assertEquals(1, rule.getPaths().size());
        assertEquals("[$.requestID]", rule.getPaths().toString());

        FilterRule rule2 = topicFilter.getFilterRule("closedLoopControlName");
        assertEquals("closedLoopControlName", rule2.getMdcKey());
        assertEquals(1, rule2.getPaths().size());
        assertEquals("[$.closedLoopControlName]", rule2.getPaths().toString());
    }

    /**
     * Tests having two filter rules that each have two key/path pairs.
     */
    @Test
    public void multiFilterMultiPathTest() {
        String topicFilterProp = "requestID=$.requestID|$.body.request-id,"
                + "closedLoopControlName=$.closedLoopControlName"
                + "|$.body.closedLoopControlName";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);

        FilterRule rule = topicFilter.getFilterRule("requestID");
        assertEquals("requestID", rule.getMdcKey());
        assertEquals(2, rule.getPaths().size());
        assertEquals("[$.requestID, $.body.request-id]", rule.getPaths().toString());

        FilterRule rule2 = topicFilter.getFilterRule("closedLoopControlName");
        assertEquals("closedLoopControlName", rule2.getMdcKey());
        assertEquals(2, rule2.getPaths().size());
        assertEquals("[$.closedLoopControlName, $.body.closedLoopControlName]", rule2.getPaths().toString());
    }

    /**
     * Tests that the regex split logic for '|' in the feature code doesn't
     * break parsing when "||" is used as a predicate in a JsonPath query.
     */
    @Test
    public void addOrPredicateFilterTest() {
        String topicFilterProp = "requestID=$.requestID||$.body.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        assertEquals(1, topicFilter.getFilterRule().size());
        assertEquals("requestID", topicFilter.getFilterRule("requestID").getMdcKey());
        assertEquals(Arrays.asList("$.requestID||$.body.requestID"), topicFilter
                .getFilterRule("requestID").getPaths());
    }

    /**
     * Tests getting all filter rules for a given topic.
     */
    @Test
    public void getAllFilterRulesTest() {
        String topicFilterProp = "requestID=$.requestID,subRequestID=$.subRequestID,"
                + "closedLoopControlName=$.closedLoopControlName";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        assertEquals(3, topicFilter.getFilterRule().size());
    }

    /**
     * Tests getting a filter rule by its key.
     */
    @Test
    public void getFilterRuleTest() {
        String topicFilterProp = "requestID=$.requestID,subRequestID=$.subRequestID,"
                + "closedLoopControlName=$.closedLoopControlName";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);

        FilterRule rule = topicFilter.getFilterRule("requestID");
        assertNotNull(rule);
    }

    /**
     * Tests throwing an exception for passing in a null key.
     */
    @Test(expected = IllegalArgumentException.class)
    public void getFilterRuleNullKeyTest() {
        String topicFilterProp = "requestID=$.requestID,subRequestID=$.subRequestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.getFilterRule(null);
    }

    /**
     * Tests throwing an exception for passing in an empty key.
     */
    @Test(expected = IllegalArgumentException.class)
    public void getFilterRuleEmptyKeyTest() {
        String topicFilterProp = "requestID=$.requestID,subRequestID=$.subRequestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.getFilterRule("");
    }

    /**
     * Tests adding a filter rule with a single path.
     */
    @Test
    public void addFilterRuleSinglePathTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);

        String key = "subRequestID";
        String path = "$.subRequestID";
        FilterRule rule = topicFilter.addFilterRule(key, path);
        assertEquals(topicFilter.getFilterRule(key), rule);
    }

    /**
     * Tests adding a filter rule with multiple paths.
     */
    @Test
    public void addFilterRuleMultiPathTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);

        String key = "subRequestID";
        List<String> paths = Arrays.asList("$.subRequestID", "$.sub-request-id");
        FilterRule rule = topicFilter.addFilterRule(key, paths);
        assertEquals(topicFilter.getFilterRule(key), rule);
    }

    /**
     * Tests throwing an exception for passing a null key and a
     * single path.
     */
    @Test(expected = IllegalArgumentException.class)
    public void addFilterRuleNullKeyStringPathTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.addFilterRule(null, "$.subRequestID");
    }

    /**
     * Tests throwing an exception for passing a null key and a list
     * of paths.
     */
    @Test(expected = IllegalArgumentException.class)
    public void addFilterRuleNullKeyPathListTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.addFilterRule(null, Arrays.asList("$.subRequestID"));
    }

    /**
     * Tests throwing an exception for passing an empty key and
     * a single path.
     */
    @Test(expected = IllegalArgumentException.class)
    public void addFilterRuleEmptyKeyStringPathTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.addFilterRule("", "$.subRequestID");
    }

    /**
     * Tests throwing an exception for passing an empty key and
     * a list of paths.
     */
    @Test(expected = IllegalArgumentException.class)
    public void addFilterRuleEmptyKeyPathListTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.addFilterRule("", Arrays.asList("$.subRequestID"));
    }

    /**
     * Tests throwing an exception for passing an empty path string.
     */
    @Test(expected = IllegalArgumentException.class)
    public void addFilterRuleEmptyPathTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.addFilterRule("subRequestID", "");
    }

    /**
     * Tests throwing an exception for passing an empty paths list.
     */
    @Test(expected = IllegalArgumentException.class)
    public void addFilterRuleEmptyPathsTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.addFilterRule("subRequestID", Arrays.asList());
    }

    /**
     * Tests throwing an exception for trying to add a filter with a key that
     * already exists with a single filter.
     */
    @Test(expected = IllegalArgumentException.class)
    public void addExistingFilterRuleStringTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.addFilterRule("requestID", "$.test");
    }

    /**
     * Tests throwing an exception for trying to add a filter with a key that
     * already exists with a list of filters.
     */
    @Test(expected = IllegalArgumentException.class)
    public void addExistingFilterRuleListTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.addFilterRule("requestID", Arrays.asList("$.test"));
    }

    @Test
    public void createFilterRuleExceptionTest() {
        assertThatIllegalArgumentException().isThrownBy(() -> new MdcTopicFilter("invalid filter"))
                        .withMessage("could not parse filter rule");
    }

    /**
     * Tests modifying a filter rule to add a new path.
     */
    @Test
    public void modifyFilterRuleSinglePathTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);

        FilterRule rule = topicFilter.modifyFilterRule("requestID", "$.request-id");
        assertEquals(topicFilter.getFilterRule("requestID"), rule);
        assertEquals(Arrays.asList("$.requestID", "$.request-id"), rule.getPaths());
    }

    /**
     * Tests modifying a filter rule to add a list of new paths.
     */
    @Test
    public void modifyFilterRuleMultiPathTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);

        FilterRule rule = topicFilter.modifyFilterRule("requestID",
                Arrays.asList("$.request-id", "$.requestId"));
        assertEquals(topicFilter.getFilterRule("requestID"), rule);
        assertEquals(
                Arrays.asList("$.requestID", "$.request-id", "$.requestId"),
                rule.getPaths());
    }

    @Test
    public void testModifyFilterRuleMultiPathException() {
        MdcTopicFilter filter = new MdcTopicFilter("abc=$a.value");
        assertThatIllegalArgumentException()
                        .isThrownBy(() -> filter.modifyFilterRule("def", "abc", Arrays.asList("$.b", "$.c")))
                        .withMessage("a filter rule already exists for key: abc");
    }

    /**
     * Tests modifying a filter rule key.
     */
    @Test
    public void modifyFilterRuleKeyTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);

        FilterRule rule = topicFilter.modifyFilterRule("requestID",
                "request-id", Arrays.asList("$.request-id"));
        assertEquals(topicFilter.getFilterRule("request-id"), rule);
        assertEquals("[$.request-id]", rule.getPaths().toString());
    }

    /**
     * Tests throwing an exception when passing a null key and
     * a single path.
     */
    @Test(expected = IllegalArgumentException.class)
    public void modifyFilterRuleNullKeyStringPathTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.modifyFilterRule(null, "$.request-id");
    }

    /**
     * Tests throwing an exception when passing a null key and
     * a list of multiple paths.
     */
    @Test(expected = IllegalArgumentException.class)
    public void modifyFilterRuleNullKeyPathListTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.modifyFilterRule(null, Arrays.asList("$.request-id"));
    }

    /**
     * Tests throwing an exception when passing an empty key and
     * a single path.
     */
    @Test(expected = IllegalArgumentException.class)
    public void modifyFilterRuleEmptyKeyStringPathTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.modifyFilterRule("", "$.request-id");
    }

    /**
     * Tests throwing an exception when passing an empty key and
     * a list of multiple paths.
     */
    @Test(expected = IllegalArgumentException.class)
    public void modifyFilterRuleEmptyKeyPathListTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.modifyFilterRule("", Arrays.asList("$.request-id"));
    }

    /**
     * Tests throwing an exception when passing an empty string path.
     */
    @Test(expected = IllegalArgumentException.class)
    public void modifyFilterRuleEmptyPathStringTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.modifyFilterRule("requestID", "");
    }

    /**
     * Tests throwing an exception when passing an empty list of paths.
     */
    @Test(expected = IllegalArgumentException.class)
    public void modifyFilterRuleEmptyPathListTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.modifyFilterRule("requestID", Arrays.asList());
    }

    /**
     * Tests throwing an exception when passing a key that is
     * not in the filter rules map and a string path.
     */
    @Test(expected = IllegalArgumentException.class)
    public void modifyFilterRuleMissingKeyStringPathTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.modifyFilterRule("request-id", "$.request-id");
    }

    /**
     * Tests throwing an exception when passing a key that is
     * not in the filter rules map and a list of paths.
     */
    @Test(expected = IllegalArgumentException.class)
    public void modifyFilterRuleMissingKeyPathListTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.modifyFilterRule("request-id", Arrays.asList("$.request-id"));
    }


    /**
     * Tests throwing an exception when passing a null oldKey.
     */
    @Test(expected = IllegalArgumentException.class)
    public void modifyFilterRuleNullOldKeyTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.modifyFilterRule(null, "request-id", Arrays.asList("$.request-id"));
    }

    /**
     * Tests throwing an exception when passing an empty oldKey.
     */
    @Test(expected = IllegalArgumentException.class)
    public void modifyFilterRuleEmptyOldKeyTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.modifyFilterRule("", "request-id", Arrays.asList("$.request-id"));
    }

    /**
     * Tests throwing an exception when passing a null newKey.
     */
    @Test(expected = IllegalArgumentException.class)
    public void modifyFilterRuleNullNewKeyTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.modifyFilterRule("requestID", null, Arrays.asList("$.request-id"));
    }

    /**
     * Tests throwing an exception when passing an empty newKey.
     */
    @Test(expected = IllegalArgumentException.class)
    public void modifyFilterRuleEmptyNewKeyTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.modifyFilterRule("requestID", "", Arrays.asList("$.request-id"));
    }

    /**
     * Tests throwing an exception when the old and new key are the same.
     */
    @Test(expected = IllegalArgumentException.class)
    public void modifyFilterRuleSameKeyTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.modifyFilterRule("requestID", "requestID",
                Arrays.asList("$.request-id"));
    }

    /**
     * Tests throwing an exception when passing an empty paths list.
     */
    @Test(expected = IllegalArgumentException.class)
    public void modifyFilterRuleEmptyPathsTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.modifyFilterRule("requestID", "request-id", Arrays.asList());
    }

    /**
     * Tests throwing an exception when the old key doesn't exist
     * in the rules map.
     */
    @Test(expected = IllegalArgumentException.class)
    public void modifyFilterRuleNonExistingOldKeyTest() {
        String topicFilterProp = "requestID=$.requestID";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.modifyFilterRule("request-id", "id", Arrays.asList("$.request-id"));
    }

    /**
     * Tests deleting all filter rules in the rules map.
     */
    @Test
    public void deleteAllFilterRulesTest() {
        String topicFilterProp = "requestID=$.requestID,subRequestID=$.subRequestID,"
                + "closedLoopControlName=$.closedLoopControlName";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);

        assertEquals(3, topicFilter.getFilterRule().size());
        topicFilter.deleteFilterRule();
        assertEquals(0, topicFilter.getFilterRule().size());
    }

    /**
     * Tests deleting a single filter rule by its key from the rules map.
     */
    @Test
    public void deleteFilterRuleTest() {
        String topicFilterProp = "requestID=$.requestID,subRequestID=$.subRequestID,"
                + "closedLoopControlName=$.closedLoopControlName";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);

        assertEquals(3, topicFilter.getFilterRule().size());
        topicFilter.deleteFilterRule("closedLoopControlName");
        assertEquals(2, topicFilter.getFilterRule().size());
    }

    /**
     * Tests throwing an exception if the key is null.
     */
    @Test(expected = IllegalArgumentException.class)
    public void deleteFilterRuleNullKeyTest() {
        String topicFilterProp = "requestID=$.requestID,subRequestID=$.subRequestID,"
                + "closedLoopControlName=$.closedLoopControlName";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.deleteFilterRule(null);
    }

    /**
     * Tests throwing an exception if the key is empty.
     */
    @Test(expected = IllegalArgumentException.class)
    public void deleteFilterRuleEmptyKeyTest() {
        String topicFilterProp = "requestID=$.requestID,subRequestID=$.subRequestID,"
                + "closedLoopControlName=$.closedLoopControlName";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);
        topicFilter.deleteFilterRule("");
    }

    /**
     * Tests finding all results for each filter rule corresponding to a topic.
     */
    @Test
    public void findAllTest() {
        String message = "{\"requestID\":\"38adde30-cc22-11e8-a8d5-f2801f1b9fd1\",\"entity\":\"controller\","
                + "\"controllers\":[{\"name\":\"test-controller\","
                + "\"drools\":{\"groupId\":\"org.onap.policy.drools.test\","
                + "\"artifactId\":\"test\",\"version\":\"0.0.1\"},\"operation\":\"update\"}]}";

        String topicFilterProp = "requestID=$.requestID,controllerName=$.controllers[0].name,"
                + "operation=$.controllers[0].operation";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);

        Map<String, List<String>> results = topicFilter.find(message);
        assertEquals("38adde30-cc22-11e8-a8d5-f2801f1b9fd1",
                results.get("requestID").get(0));
        assertEquals("test-controller", results.get("controllerName").get(0));
        assertEquals("update", results.get("operation").get(0));
    }

    @Test
    public void testFindAllNotFound() {
        String message = "{\"requestID\":\"38adde30-cc22-11e8-a8d5-f2801f1b9fd1\",\"entity\":\"controller\","
                        + "\"controllers\":[{\"name\":\"test-controller\","
                        + "\"drools\":{\"groupId\":\"org.onap.policy.drools.test\","
                        + "\"artifactId\":\"test\",\"version\":\"0.0.1\"},\"operation\":\"update\"}]}";

        String topicFilterProp = "requestID=$.requestID[3]";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);

        assertTrue(topicFilter.find(message).get("requestID").isEmpty());
    }

    /**
     * Tests finding field matches for a filter rule corresponding to a topic.
     */
    @Test
    public void findTest() {
        String message = "{\"requestID\":\"38adde30-cc22-11e8-a8d5-f2801f1b9fd1\",\"entity\":\"controller\","
                + "\"controllers\":[{\"name\":\"test-controller\","
                + "\"drools\":{\"groupId\":\"org.onap.policy.drools.test\","
                + "\"artifactId\":\"test\",\"version\":\"0.0.1\"},\"operation\":\"update\"}]}";

        String topicFilterProp = "requestID=$.requestID,controllerName=$.controllers[0].name,"
                + "operation=$.controllers[0].operation";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);

        List<String> results = topicFilter.find(message, "requestID");
        assertEquals("38adde30-cc22-11e8-a8d5-f2801f1b9fd1", results.get(0));
    }

    @Test
    public void testFindNotFound() {
        String message = "{\"requestID\":\"38adde30-cc22-11e8-a8d5-f2801f1b9fd1\",\"entity\":\"controller\","
                + "\"controllers\":[{\"name\":\"test-controller\","
                + "\"drools\":{\"groupId\":\"org.onap.policy.drools.test\","
                + "\"artifactId\":\"test\",\"version\":\"0.0.1\"},\"operation\":\"update\"}]}";

        String topicFilterProp = "requestID=$.requestID[3]";
        MdcTopicFilter topicFilter = new MdcTopicFilter(topicFilterProp);

        assertTrue(topicFilter.find(message, "requestID").isEmpty());
    }

    @Test
    public void testFilterRuleStringString() {
        FilterRule rule = new FilterRule("hello", "world");

        assertEquals("hello", rule.getMdcKey());
        assertEquals("[world]", rule.getPaths().toString());
    }

    @Test
    public void testFilterRuleMdcKey() {
        FilterRule rule = new FilterRule("abc", "def");

        // check error cases first
        assertThatIllegalArgumentException().isThrownBy(() -> rule.setMdcKey(null))
                        .withMessage(MdcTopicFilter.MDC_KEY_ERROR);
        assertThatIllegalArgumentException().isThrownBy(() -> rule.setMdcKey(""))
                        .withMessage(MdcTopicFilter.MDC_KEY_ERROR);

        // success cases
        rule.setMdcKey("my-mdc-key");
        assertEquals("my-mdc-key", rule.getMdcKey());
    }

    @Test
    public void testFilterRulePaths() {
        FilterRule rule = new FilterRule("abc", "def");

        // check error cases first
        assertThatIllegalArgumentException().isThrownBy(() -> rule.setPaths(null))
                        .withMessage(MdcTopicFilter.JSON_PATH_ERROR);
        assertThatIllegalArgumentException().isThrownBy(() -> rule.setPaths(Collections.emptyList()))
                        .withMessage(MdcTopicFilter.JSON_PATH_ERROR);

        assertThatIllegalArgumentException().isThrownBy(() -> rule.addPaths(null))
                        .withMessage(MdcTopicFilter.JSON_PATH_ERROR);
        assertThatIllegalArgumentException().isThrownBy(() -> rule.addPaths(Collections.emptyList()))
                        .withMessage(MdcTopicFilter.JSON_PATH_ERROR);

        assertThatIllegalArgumentException().isThrownBy(() -> rule.addPath(null))
                        .withMessage(MdcTopicFilter.JSON_PATH_ERROR);
        assertThatIllegalArgumentException().isThrownBy(() -> rule.addPath(""))
                        .withMessage(MdcTopicFilter.JSON_PATH_ERROR);

        // success cases
        rule.setPaths(new ArrayList<>(Arrays.asList("pathA", "pathB")));
        assertEquals("[pathA, pathB]", rule.getPaths().toString());

        rule.addPath("pathC");
        assertEquals("[pathA, pathB, pathC]", rule.getPaths().toString());

        rule.addPaths(Arrays.asList("pathD", "pathE"));
        assertEquals("[pathA, pathB, pathC, pathD, pathE]", rule.getPaths().toString());
    }
}