Age | Commit message (Collapse) | Author | Files | Lines |
|
Issue-ID: POLICY-3952
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I1339de085260124847f328b0aa0e1ca1e5521ced
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
This is to reduce verbosity introduced by lombok @ToString,
Issue-ID: POLICY-3895
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I7b6b3490b508e6ccb094da87d6f0f64a7e859277
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Issue-ID: POLICY-3761
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I9867472784d8f153b6955ce95b34de250f60f558
|
|
The changes to use the generic lombok ToString caused excessive
verbosity when the coder objects are logged, hence restoring
the older manual toString() methods back.
Issue-ID: POLICY-3895
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Idd875172cbb066d13294aeb31fb85577dad127c1
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Issue-ID: POLICY-3706
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I4f473cd8a3852deefee6e449931eabde66bedeba
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Increasing coverage for drools to >= 80%.
Issue-ID: POLICY-3453
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I9d8550a80b87b8c6f68da06246d392260eba1e65
|
|
Issue-ID: POLICY-3610
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Id3011e07045fd485df75184f4a766ca91274f56b
|
|
After switching to lombok ToString, the log messages for the coder class
have become very long. Switched back to the original toString() method,
which only logs the keysets rather than the whole content of the coder
maps.
Left the other additions of lombok ToString in drools-pdp as is, because
they all looked appropriate, upon further review.
Addressed review comments:
- added comment about why lombok isn't used
Issue-ID: POLICY-3397
Change-Id: I08ea8c49908b33fc3b8c8ba6de4ac4bd1474660a
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed sonars:
- use "var"
- override "equals"
- unused imports
Also changed some of the JPA queries to make them typed queries.
Issue-ID: POLICY-3289
Change-Id: Ib3a00be322d8d00ba492673708439cacfe2c7fc4
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-3553
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I9d5d36e35b69a7f47efd2cc4b2abfdd0ba8f2192
|
|
Change-Id: I2dc7f988654d8f7d1b822233e1fbe66e6fbf767d
Issue-ID: POLICY-3538
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Issue-ID: POLICY-3533
Change-Id: I03fc41332d4739d5a4d6cee5f86ba823714336d6
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
using slf4j Marker from common repo
Issue-ID: POLICY-3087
Change-Id: Iefbd6fa9ab2dfa6388508cb6ffd6cf1358b45ccc
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Updated policy-management thru policy-utils.
Issue-ID: POLICY-3397
Change-Id: Ie9498fe912e8338ddc32a40774c3cb63d84f079a
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-3077
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ieae80c77db297271c9de3958d321bfe4b88acce3
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Also modified distributed locking to use the unique name, in case the DB
is shared.
Issue-ID: POLICY-3410
Change-Id: I046a9ffdcb62f3d84d7d388a1e64bcf025fbbf75
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Updates are indentation changes on annotations.
Issue-ID: POLICY-3209
Change-Id: I7b55b2affa3e16afb0c0f8398b902a04f13c4db0
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
The new version of checkstyle identified new issues. Fixed those.
Also addressed sonar "var" issues.
Issue-ID: POLICY-3289
Change-Id: I3a18d3988202dca6f3c87f2aa1810bf803a9d14d
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-3397
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ie0f2009e9c9d219405f5ccbdd648304c66460b1e
|
|
Issue-ID: POLICY-3289
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iad22a581a6bd98e7e210162d30ec7741972669d2
|
|
Issue-ID: POLICY-3289
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Id6d58b5c8ac5f7715286f21274ccf5eea9155fd2
|
|
Issue-ID: POLICY-3230
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I05fb50ef3c4b6da0603e75084554e061a27a2202
|
|
|
|
Issue-ID: POLICY-3230
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I2fd74011b649bca1acbef217bbf6ee222a6352eb
|
|
Issue-ID: POLICY-3257
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ic599b593abbc999c4e6a6fd4bc72acd5ec6e09f9
|
|
Issue-ID: POLICY-3230
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I50a4ee81f0a1c97df25732a4e4507e8b7f8c8e4d
|
|
|
|
Issue-ID: POLICY-3230
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I86a5f1081293a6b3d5f52c4462b947facbd9ee88
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Issue-ID: POLICY-3289
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iaf7423f840fb39a27c3e5fd293159d1336d5557a
|
|
This feature makes the legacy configuration optional.
It was used by brmsgw and other tooling to provision
via its DMaaP channel. The capability to configure
via PdpConfiguration object is kept in the core
preserving backwards compatibility, but the DMaaP
provisioning channel(s) are optional.
Issue-ID: POLICY-2618
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ia7198ac3b2810d85133c06ba5217a9c28e07ac4c
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Issue-ID: POLICY-3160
Change-Id: I37b2b75d010781108e40ae39d3742bc2c2e2fd7e
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-3158
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iee453ea70e0ebd9a82c0126ffedd8f5632783d6f
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
It provides an interface to applications for locking
purposes that always succeeds. It does not deny
acquiring resource locks.
Issue-ID: POLICY-3114
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I6aebb5f40e4176e0ff7b0e6c6d4042a79dd0b7a3
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Apparently, ash doesn't like "[ -z ${xxx} ]" if the content of $xxx
contains spaces. Added quotes around ${xxx}.
Also fixed:
- a couple of "[" "]" mismatches
- a logic error in the selection of upgrade scripts
Issue-ID: POLICY-3117
Change-Id: I99c977825fe9df8a44c288b6307cd3e55c504f86
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-3033
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I626de45b528bb891c79900085bfe783fe248b3fa
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Issue-ID: POLICY-3033
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iaa78aa48064e8288265aeb498279e9d8324538d8
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
|
|
|
|
The dependency upgrades in policy-parent caused some new sonars. In
particular, initMocks() has been deprecated - replaced with calls to the
Mockito Runner. Changed one to openMocks() because using the Runner
caused it to fail on jenkins, but not in the local eclipse.
Also fixed a type safety issue with EMPTY_LIST.
Issue-ID: POLICY-2909
Change-Id: Iea9420190f208d7de3bf3ad531515c92e0fab83f
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-3033
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Id1f02c86be491d5145e74725f76953e294e2975c
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Addressed the following issues:
- log user-controlled data; moved the "NOSONAR" to a different line
- make constructors protected
Issue-ID: POLICY-2909
Change-Id: Ic69c100af777779e791c38cc444dd2ea726258f2
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-3017
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I7e7e384db26e244e2514aec3c3579b7b7f92f8a1
|
|
Issue-ID: POLICY-2762
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ic00d2a548dbc904e044d2310c7d5439a1cb708a5
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
The policy models tosca classes ToscaPolicyIdentifier and
ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA
concept, not just TOSCA policies so they are renamed to
ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion
respectively.
The class ToscaPolicyTypeIdentifier is redundant and is replaced by
ToscaConceptIdentifier.
Issue-ID: POLICY-2900
Change-Id: I677cc1f8730001b300ab2041f2d57c2485cbc4ed
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
this gerrit would be the first step
to not to use any GPL-3.0 and plus license
Issue-ID: POLICY-2847
Change-Id: I09a571f14ef8c6983f9051068c2bad5acc173787
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Addressed the following sonar issues:
- extract common test method
- too many assertions in test method
- don't always return the same value
Issue-ID: POLICY-2616
Change-Id: Iab836cdcd667b35e2db9db7d6ffc7896df33e1c8
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed deploy-artifacts to strip carriage returns from pom.properties
files before attempting to extract variables from them.
Switched to using 'sed' instead of dos2unix.
Issue-ID: POLICY-2823
Change-Id: I1114af13a3262e49b87fb270d5c78cda4de9e5c9
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed more sonars in drools-pdp:
- remove commented code
- don't throw generic Exception
- unused field (made it protected instead of private)
- log conditionally
- cognitive complexity
- too many break/continue
- return empty list instead of null
- Random() is not secure
Fixed more eclipse warnings:
- parameterize generic types
Issue-ID: POLICY-2616-sonars3
Change-Id: Ia5ad769b2ea763568cfae3d81807926d89153b09
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Addressed the following sonars:
- either log or rethrow
- call "remove()" for thread-local-storage
- use assertEquals
- only one method call in exception test
- swap arguments in assertEquals
- add assertion to assertThatThrownBy()
- explain @Ignore
Also addressed eclipse warnings:
- unused fields and methods
Issue-ID: POLICY-2616
Change-Id: I6590c0d2b103885bc933014d48bf5fd92401cd80
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
It follows the same approach that in other policy
components by throwing a runtime-exception vs
System.exit(x).
Issue-ID: POLICY-2752
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iba508fc7095b060373742849e394c8fdd2a2334f
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|