summaryrefslogtreecommitdiffstats
path: root/policy-management/src
AgeCommit message (Collapse)AuthorFilesLines
2021-10-06Check https environment var in telemetry tooljhh1-0/+7
Issue-ID: POLICY-3706 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I4f473cd8a3852deefee6e449931eabde66bedeba Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-09-20Additional tests for Telemetryjhh2-167/+114
Increasing coverage for drools to >= 80%. Issue-ID: POLICY-3453 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I9d8550a80b87b8c6f68da06246d392260eba1e65
2021-09-06Correct paths to logback filtersjhh1-2/+2
Issue-ID: POLICY-3610 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Id3011e07045fd485df75184f4a766ca91274f56b
2021-09-03Reduce coder verbosity in logsJim Hahn1-2/+13
After switching to lombok ToString, the log messages for the coder class have become very long. Switched back to the original toString() method, which only logs the keysets rather than the whole content of the coder maps. Left the other additions of lombok ToString in drools-pdp as is, because they all looked appropriate, upon further review. Addressed review comments: - added comment about why lombok isn't used Issue-ID: POLICY-3397 Change-Id: I08ea8c49908b33fc3b8c8ba6de4ac4bd1474660a Signed-off-by: Jim Hahn <jrh3@att.com>
2021-08-26Fix sonars in drools-pdpJim Hahn2-2/+0
Fixed sonars: - use "var" - override "equals" - unused imports Also changed some of the JPA queries to make them typed queries. Issue-ID: POLICY-3289 Change-Id: Ib3a00be322d8d00ba492673708439cacfe2c7fc4 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-08-23Add prometheus + https in https server configsjhh1-1/+2
Issue-ID: POLICY-3553 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I9d5d36e35b69a7f47efd2cc4b2abfdd0ba8f2192
2021-08-23Fixing drools junits as per policy/common changesa.sreekumar2-2/+4
Change-Id: I2dc7f988654d8f7d1b822233e1fbe66e6fbf767d Issue-ID: POLICY-3538 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-08-10Add SQL_PORT configurationjhh1-2/+6
Issue-ID: POLICY-3533 Change-Id: I03fc41332d4739d5a4d6cee5f86ba823714336d6 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-08-06Use slf4j Marker from common repoTaka Cho4-13/+15
using slf4j Marker from common repo Issue-ID: POLICY-3087 Change-Id: Iefbd6fa9ab2dfa6388508cb6ffd6cf1358b45ccc Signed-off-by: Taka Cho <takamune.cho@att.com>
2021-08-05Use lombok in drools-pdpJim Hahn34-815/+222
Updated policy-management thru policy-utils. Issue-ID: POLICY-3397 Change-Id: Ie9498fe912e8338ddc32a40774c3cb63d84f079a Signed-off-by: Jim Hahn <jrh3@att.com>
2021-07-07nosonar on admin logging level functionjhh1-7/+2
Issue-ID: POLICY-3077 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ieae80c77db297271c9de3958d321bfe4b88acce3 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-06-29Use unique name in drools PdpMessagesJim Hahn1-2/+8
Also modified distributed locking to use the unique name, in case the DB is shared. Issue-ID: POLICY-3410 Change-Id: I046a9ffdcb62f3d84d7d388a1e64bcf025fbbf75 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-28Update policy-drools-pdp for checkstyle 8.43liamfallon1-40/+41
Updates are indentation changes on annotations. Issue-ID: POLICY-3209 Change-Id: I7b55b2affa3e16afb0c0f8398b902a04f13c4db0 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-06-18Fix new checkstyle issues in drools-pdpJim Hahn1-4/+4
The new version of checkstyle identified new issues. Fixed those. Also addressed sonar "var" issues. Issue-ID: POLICY-3289 Change-Id: I3a18d3988202dca6f3c87f2aa1810bf803a9d14d Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-16use lombok NonNull instead of other leaked importsjhh3-3/+3
Issue-ID: POLICY-3397 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ie0f2009e9c9d219405f5ccbdd648304c66460b1e
2021-06-15filter logging input data per sonar security issuejhh2-11/+16
Issue-ID: POLICY-3289 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Iad22a581a6bd98e7e210162d30ec7741972669d2
2021-06-14Use re2j pattern for sonar vulnerabilitiesjhh2-18/+14
Issue-ID: POLICY-3289 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Id6d58b5c8ac5f7715286f21274ccf5eea9155fd2
2021-05-18Fix sonar vulnerabilities logging user inputjhh1-2/+2
Issue-ID: POLICY-3230 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I05fb50ef3c4b6da0603e75084554e061a27a2202
2021-05-14Merge "fix telemetry related sonar security issues"Jim Hahn3-15/+56
2021-05-12disable https server default for telemetryjhh4-88/+11
Issue-ID: POLICY-3230 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I2fd74011b649bca1acbef217bbf6ee222a6352eb
2021-05-12fix telemetry related sonar security issuesjhh3-15/+56
Issue-ID: POLICY-3257 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ic599b593abbc999c4e6a6fd4bc72acd5ec6e09f9
2021-05-10interrupted exception and var usage sonarsjhh1-38/+53
Issue-ID: POLICY-3230 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I50a4ee81f0a1c97df25732a4e4507e8b7f8c8e4d
2021-05-10Merge "sonars policy-utils and feature-lifecycle"Ram Krishna Verma3-45/+32
2021-05-10support no https or authentication in telemetryjhh1-2/+13
Issue-ID: POLICY-3230 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I86a5f1081293a6b3d5f52c4462b947facbd9ee88 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-05-07sonars policy-utils and feature-lifecyclejhh3-45/+32
Issue-ID: POLICY-3289 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Iaf7423f840fb39a27c3e5fd293159d1336d5557a
2021-04-14Add legacy-config new featurejhh1-14/+2
This feature makes the legacy configuration optional. It was used by brmsgw and other tooling to provision via its DMaaP channel. The capability to configure via PdpConfiguration object is kept in the core preserving backwards compatibility, but the DMaaP provisioning channel(s) are optional. Issue-ID: POLICY-2618 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ia7198ac3b2810d85133c06ba5217a9c28e07ac4c Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-04-07Use sh instead of ash in drools-pdpJim Hahn11-22/+22
Issue-ID: POLICY-3160 Change-Id: I37b2b75d010781108e40ae39d3742bc2c2e2fd7e Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-23Update cert stores configurationjhh2-12/+12
Issue-ID: POLICY-3158 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Iee453ea70e0ebd9a82c0126ffedd8f5632783d6f Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-03-09add no locking featurejhh1-0/+3
It provides an interface to applications for locking purposes that always succeeds. It does not deny acquiring resource locks. Issue-ID: POLICY-3114 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I6aebb5f40e4176e0ff7b0e6c6d4042a79dd0b7a3 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-03-02Add quotes around variable in db scriptJim Hahn1-5/+5
Apparently, ash doesn't like "[ -z ${xxx} ]" if the content of $xxx contains spaces. Added quotes around ${xxx}. Also fixed: - a couple of "[" "]" mismatches - a logic error in the selection of upgrade scripts Issue-ID: POLICY-3117 Change-Id: I99c977825fe9df8a44c288b6307cd3e55c504f86 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-19remove TransMetric - not neededjhh7-23/+22
Issue-ID: POLICY-3033 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I626de45b528bb891c79900085bfe783fe248b3fa Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-02-18deploy stats in lifecycle modulejhh1-2/+7
Issue-ID: POLICY-3033 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Iaa78aa48064e8288265aeb498279e9d8324538d8 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-02-12Merge "Fix sonars from dependency upgrade"Pamela Dragosh4-18/+14
2021-02-12Merge "support transaction reports in engine"Ram Krishna Verma11-33/+445
2021-02-12Fix sonars from dependency upgradeJim Hahn4-18/+14
The dependency upgrades in policy-parent caused some new sonars. In particular, initMocks() has been deprecated - replaced with calls to the Mockito Runner. Changed one to openMocks() because using the Runner caused it to fail on jenkins, but not in the local eclipse. Also fixed a type safety issue with EMPTY_LIST. Issue-ID: POLICY-2909 Change-Id: Iea9420190f208d7de3bf3ad531515c92e0fab83f Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-11support transaction reports in enginejhh11-33/+445
Issue-ID: POLICY-3033 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Id1f02c86be491d5145e74725f76953e294e2975c Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-02-10More sonars in drools-pdpJim Hahn1-2/+2
Addressed the following issues: - log user-controlled data; moved the "NOSONAR" to a different line - make constructors protected Issue-ID: POLICY-2909 Change-Id: Ic69c100af777779e791c38cc444dd2ea726258f2 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-01-28sonars - protected constructors and typecastingjhh5-11/+12
Issue-ID: POLICY-3017 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I7e7e384db26e244e2514aec3c3579b7b7f92f8a1
2021-01-14add methods to check if a fact exists.jhh7-20/+110
Issue-ID: POLICY-2762 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ic00d2a548dbc904e044d2310c7d5439a1cb708a5 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-01-04Changed identifiers to concept identifiersliamfallon2-10/+12
The policy models tosca classes ToscaPolicyIdentifier and ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA concept, not just TOSCA policies so they are renamed to ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion respectively. The class ToscaPolicyTypeIdentifier is redundant and is replaced by ToscaConceptIdentifier. Issue-ID: POLICY-2900 Change-Id: I677cc1f8730001b300ab2041f2d57c2485cbc4ed Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-11-30move all bash to ash shell scriptsTaka Cho11-1790/+1765
this gerrit would be the first step to not to use any GPL-3.0 and plus license Issue-ID: POLICY-2847 Change-Id: I09a571f14ef8c6983f9051068c2bad5acc173787 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-09-30Fix new sonars in drools-pdpJim Hahn1-6/+8
Addressed the following sonar issues: - extract common test method - too many assertions in test method - don't always return the same value Issue-ID: POLICY-2616 Change-Id: Iab836cdcd667b35e2db9db7d6ffc7896df33e1c8 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-09-11Handle CR in pom property filesJim Hahn1-0/+1
Fixed deploy-artifacts to strip carriage returns from pom.properties files before attempting to extract variables from them. Switched to using 'sed' instead of dos2unix. Issue-ID: POLICY-2823 Change-Id: I1114af13a3262e49b87fb270d5c78cda4de9e5c9 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-31Fix more sonars in drools-pdpJim Hahn2-21/+30
Fixed more sonars in drools-pdp: - remove commented code - don't throw generic Exception - unused field (made it protected instead of private) - log conditionally - cognitive complexity - too many break/continue - return empty list instead of null - Random() is not secure Fixed more eclipse warnings: - parameterize generic types Issue-ID: POLICY-2616-sonars3 Change-Id: Ia5ad769b2ea763568cfae3d81807926d89153b09 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-25Address more sonars in drools-pdpJim Hahn4-21/+13
Addressed the following sonars: - either log or rethrow - call "remove()" for thread-local-storage - use assertEquals - only one method call in exception test - swap arguments in assertEquals - add assertion to assertThatThrownBy() - explain @Ignore Also addressed eclipse warnings: - unused fields and methods Issue-ID: POLICY-2616 Change-Id: I6590c0d2b103885bc933014d48bf5fd92401cd80 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-24exit jvm when detecting configuration problemsjhh3-2/+97
It follows the same approach that in other policy components by throwing a runtime-exception vs System.exit(x). Issue-ID: POLICY-2752 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Iba508fc7095b060373742849e394c8fdd2a2334f Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-07-21Merge "Support multiple Policy/Controller types using 'controller.type' ↵Jorge Hernandez10-17/+308
property"
2020-07-21Support multiple Policy/Controller types using 'controller.type' propertyStraubs, Ralph (rs8887)10-17/+308
It provides a feature base to allow for custom Policy and Drools Controllers. Issue-ID: POLICY-2415 Change-Id: Ibe3f11e3ecd925537ffd03d2420bb3b8214029c9 Signed-off-by: Straubs, Ralph (rs8887) <rs8887@att.com> Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-07-20Remove jackson from drools-pdpJim Hahn8-83/+3
Issue-ID: POLICY-1528 Change-Id: I616c48d62c63f8f213ec012f8746509471c38f89 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-15Merge "exec pdp-d java process to run in the foreground"Jorge Hernandez1-108/+183