Age | Commit message (Collapse) | Author | Files | Lines |
|
Issue-ID: POLICY-4211
Change-Id: I427171bbc8b14554ebbc63b6eaa1ef237f50b70f
Signed-off-by: pdragosh <pd1248@att.com>
|
|
Issue-ID: POLICY-3366
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I198363e1d301dda8239d00be821c878205b13c7b
|
|
Issue-ID: POLICY-3230
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I86a5f1081293a6b3d5f52c4462b947facbd9ee88
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
(cherry picked from commit 02b765a3c9b854a24b85611f4950f9a57362b462)
|
|
Issue-ID: POLICY-3158
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iee453ea70e0ebd9a82c0126ffedd8f5632783d6f
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
(cherry picked from commit 605ce7bb27bd15f45064418a05599acdea373562)
|
|
It provides an interface to applications for locking
purposes that always succeeds. It does not deny
acquiring resource locks.
Issue-ID: POLICY-3114
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I6aebb5f40e4176e0ff7b0e6c6d4042a79dd0b7a3
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Apparently, ash doesn't like "[ -z ${xxx} ]" if the content of $xxx
contains spaces. Added quotes around ${xxx}.
Also fixed:
- a couple of "[" "]" mismatches
- a logic error in the selection of upgrade scripts
Issue-ID: POLICY-3117
Change-Id: I99c977825fe9df8a44c288b6307cd3e55c504f86
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-3033
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I626de45b528bb891c79900085bfe783fe248b3fa
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Issue-ID: POLICY-3033
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iaa78aa48064e8288265aeb498279e9d8324538d8
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
|
|
Issue-ID: POLICY-3033
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Id1f02c86be491d5145e74725f76953e294e2975c
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Addressed the following issues:
- log user-controlled data; moved the "NOSONAR" to a different line
- make constructors protected
Issue-ID: POLICY-2909
Change-Id: Ic69c100af777779e791c38cc444dd2ea726258f2
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-3017
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I7e7e384db26e244e2514aec3c3579b7b7f92f8a1
|
|
Issue-ID: POLICY-2762
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ic00d2a548dbc904e044d2310c7d5439a1cb708a5
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
The policy models tosca classes ToscaPolicyIdentifier and
ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA
concept, not just TOSCA policies so they are renamed to
ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion
respectively.
The class ToscaPolicyTypeIdentifier is redundant and is replaced by
ToscaConceptIdentifier.
Issue-ID: POLICY-2900
Change-Id: I677cc1f8730001b300ab2041f2d57c2485cbc4ed
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
this gerrit would be the first step
to not to use any GPL-3.0 and plus license
Issue-ID: POLICY-2847
Change-Id: I09a571f14ef8c6983f9051068c2bad5acc173787
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Fixed deploy-artifacts to strip carriage returns from pom.properties
files before attempting to extract variables from them.
Switched to using 'sed' instead of dos2unix.
Issue-ID: POLICY-2823
Change-Id: I1114af13a3262e49b87fb270d5c78cda4de9e5c9
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed more sonars in drools-pdp:
- remove commented code
- don't throw generic Exception
- unused field (made it protected instead of private)
- log conditionally
- cognitive complexity
- too many break/continue
- return empty list instead of null
- Random() is not secure
Fixed more eclipse warnings:
- parameterize generic types
Issue-ID: POLICY-2616-sonars3
Change-Id: Ia5ad769b2ea763568cfae3d81807926d89153b09
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Addressed the following sonars:
- either log or rethrow
- call "remove()" for thread-local-storage
- use assertEquals
- only one method call in exception test
- swap arguments in assertEquals
- add assertion to assertThatThrownBy()
- explain @Ignore
Also addressed eclipse warnings:
- unused fields and methods
Issue-ID: POLICY-2616
Change-Id: I6590c0d2b103885bc933014d48bf5fd92401cd80
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
It follows the same approach that in other policy
components by throwing a runtime-exception vs
System.exit(x).
Issue-ID: POLICY-2752
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iba508fc7095b060373742849e394c8fdd2a2334f
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
property"
|
|
It provides a feature base to allow for custom Policy
and Drools Controllers.
Issue-ID: POLICY-2415
Change-Id: Ibe3f11e3ecd925537ffd03d2420bb3b8214029c9
Signed-off-by: Straubs, Ralph (rs8887) <rs8887@att.com>
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Issue-ID: POLICY-1528
Change-Id: I616c48d62c63f8f213ec012f8746509471c38f89
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2673
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I0a08a2760e4dc5a61a59c7f0f3096db76d42cc29
|
|
Also added serializationId to several classes to address eclipse warnings.
Issue-ID: POLICY-2188
Change-Id: I3df5e8abaad8da9261c0d5cd19a93ed68dceb870
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Update logging code to compliant with logging standard
Issue-ID: POLICY-2578
Change-Id: I98decce81eae95c006d6485bf3440ac9119b2bf5
Signed-off-by: Joseph Chou <jc2555@att.com>
|
|
Issue-ID: POLICY-2305
Change-Id: If056c7e9179e245fafd6badc70ff9eee78fb23b3
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Addressed the following sonar issues:
- use of "synchronized"
- use Files.delete() instead of File.delete()
Issue-ID: POLICY-2305
Change-Id: Id55628fe12d9d764616e57321382a70cb5704ba1
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Addressed the following sonar issues:
- modified code to specify the correct class name in the
getLogger() call
- use equals() instead of "==" for string comparison
- remove deprecated code
- use ',' instead of "," in indexOf
- remove code that is commented out; typically bogus, so the comment
was adjusted to satisfy sonar
- missing assert in junits
- use "{}" instead of concatenation when using logger
- either log or rethrow
- put arguments for assertEquals() in the correct order
- remove "return" statements from the end of void methods
- don't always return the same value; just disabled sonar as
refactoring would have obfuscated the code
- cognitive complexity; used eclipse auto-refactoring to extract
out chunks of code into separate methods
- don't pass array of classes to class.getDeclaredMethod(); use
ellided arguments instead
- fix argument count in logger calls
- remove unnecessary casts
- don't use "volatile"
- make methods "synchronized" to match parent class definitions
Issue-ID: POLICY-2305
Change-Id: Ie96418f696da4ae6c2ca8d4a914371469e695419
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
As native policies introduce temporality in policy types
supported as they are removed and added, the associated
policy types that can be honored at a a given time, may
need to adjust.
A significan portion of this review is dedicated to multi-policy
junits and telemetry instrumentation.
Issue-ID: POLICY-2459
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I62bbc03411446849eaa55c9b1524220dc13c2cb0
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
This will ensure proper invocation of all feature hooks.
Issue-ID: POLICY-2388
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I8d1666bb5e9526faa588e4f613674e080181d4ba
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
- Native Drools Controller Policy support.
- Move domain policies into the policy-domains project.
- Route legacy/compliant operational policies to one or
all controller supporting the policy's policy type.
- Enhancements to scripts to invoke commands external
to the container.
Issue-ID: POLICY-2388
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Id41f04d10a28d2ea86bdd41334e499c28d0438ae
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
This is to support the new actor architecture configuration.
Issue-ID: POLICY-1625
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ieda56be38b8572d75a5fbb3775067ab537310aa1
|
|
Issue-ID: POLICY-2388
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iaaf5e13a5db286928952bcb3e4cc0f526b0b133c
|
|
So, it can be used in drools-application without
a feature dependency.
Issue-ID: POLICY-2360
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I1cf75bdd8739c35ea9b590896b177a519363e3d5
|
|
Since this is going to be used in drools-applications, better
to have it globally, reusing underlying "schema resources" rather
than maintaining one or more instances in drools-applications.
Issue-ID: POLICY-2345
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I0e339e77ea6281308be00381c7eda2cc9f4d6ac1
|
|
Addressing the last minor comment from Jorge on
https://gerrit.onap.org/r/#/c/policy/drools-pdp/+/100774/.
Tested OK with and without proxy settings.
Issue-ID: POLICY-2330
Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca>
Change-Id: Ied9e0324b0f64684ccdefd20d8bed958f468bb72
|
|
This allows the users to build the docker images for drools-pdp
and drools-application using their own CI pipelines if needed.
Issue-ID: POLICY-2330
Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca>
Change-Id: I9ea0161b45d504be4e65a21c95e48dee4a78de3a
|
|
Issue-ID: POLICY-1589
Change-Id: I0ed05c6e471a7da6658e02a4ba3115d3a117cedd
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
|
|
Change-Id: I4828559ff62ffc3ee41f89448a6f7e9914a2a0ba
Issue-ID: POLICY-2308
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Issue-ID: POLICY-2191
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I6f8029c1c771905357971331988a9b8408a93f10
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Injects the callback as a DroolsRunnable into the session, if
there is one. Otherwise, it invokes it via the engine's
thread pool.
Issue-ID: POLICY-2246
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I214480ae675d89e7335dde4eb4abe2684f7ef8ab
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2203
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I5731d4636bd2aaecbc486406298bcba1b19e8f4d
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Eliminated duplicate code issues. Unfortunately, introduced new
sonar issues with lambda expressions.
Issue-ID: POLICY-2203
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Ib5853fab6135d2177da449ef6261a352ee4f203e
|
|
|
|
Addressed more sonar issues in drools-pdp:
- unwrap multiple instances of the same annotation (NamedQuery)
- use lambda instead of anonymous class
- duplicate code; addressed by using annotation instead of toString.
This still leaves other duplicate code.
Issue-ID: POLICY-2203
Change-Id: I8c6ff6562820af638044f134eb8a6725a5f05e8e
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: I22821a5027d01f0965c54b60389d3988ac53ed5c
Issue-ID: POLICY-2203
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Change-Id: I8910a1a4267d824f064b52c6ad08945590bd9617
Issue-ID: POLICY-2203
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
commons-lang does not seem to be packaged anymore
(commons-lang3 still does, which is the desired one).
There are some @SupressWarning that seem to have no effect
that were removed.
Some libraries that were explicitly added are transitively
used now in the latest version of drools, hence some rework
in the dependency and exclude sections. We will need to
generate a clm report to verify.
Issue-ID: POLICY-1407
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I44e09183caca72f5f33bdec0b8fa88b0b4793055
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Sonar issue fixed:
- log or rethrow exception
- empty code block; moved the comment inside the empty "synchronized" block
Change-Id: I55ca87a321b3a1e4079dae6d5a4d44b651cb3086
Issue-ID: POLICY-2203
Signed-off-by: Jim Hahn <jrh3@att.com>
|