aboutsummaryrefslogtreecommitdiffstats
path: root/feature-state-management
AgeCommit message (Collapse)AuthorFilesLines
2021-11-29Update snapshot of policy/drools-pdp to 1.10.1-SNAPSHOTliamfallon1-1/+1
*** This commit is generated by a PF release script *** policy/drools-pdp is update from 1.10.0-SNAPSHOT to 1.10.1-SNAPSHOT Issue-ID: POLICY-3827 Signed-off-by: liamfallon <liam.fallon@est.tech> Change-Id: Id6f59849b88c0f98d874cf853f249738e784316f
2021-10-14Bump policy/drools-pdp to Jakarta 1.10.0-SNAPSHOTliamfallon1-1/+1
Issue-ID: POLICY-3696 Change-Id: Id7723b73aa472c45271e6e1488cc3f0f08349924 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-10-14Bump policy/drools-pdp to 1.9.2-SNAPSHOTliamfallon1-1/+1
Issue-ID: POLICY-3696 Change-Id: I8fc7e6a7c6e9a2f20409a84a1c517e49c9468eb8 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-09-15Bump versions to 1.9.1-SNAPSHOTjhh1-1/+1
Issue-ID: POLICY-3587 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I6d38adccfbee1274ce416cfadbfe306343f5d607
2021-09-03Fix sonar security issues in drools-pdpJim Hahn1-13/+3
Fixed sonar security issues: - set permissions of temporary files; modified to use utility from policy-common Issue-ID: POLICY-3289 Change-Id: I55b70175429052e0dfaf5939fa6b940f191d9267 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-09-01Don't create world-writeable directoryJim Hahn1-32/+11
Fix sonar: - world-writeable directory Issue-ID: POLICY-3289 Change-Id: I421dd9722d8642992ff8f5991f41a341c834ba1d Signed-off-by: Jim Hahn <jrh3@att.com>
2021-08-26Fix sonars in drools-pdpJim Hahn4-24/+21
Fixed sonars: - use "var" - override "equals" - unused imports Also changed some of the JPA queries to make them typed queries. Issue-ID: POLICY-3289 Change-Id: Ib3a00be322d8d00ba492673708439cacfe2c7fc4 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-08-10Add SQL_PORT configurationjhh1-3/+3
Issue-ID: POLICY-3533 Change-Id: I03fc41332d4739d5a4d6cee5f86ba823714336d6 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-08-05Use lombok in drools-pdp #2Jim Hahn5-73/+24
Updated feature-session-persistence thru drools-domains. Issue-ID: POLICY-3397 Change-Id: I0b1c6da8b2301c00dd792675e8cf1f49888edb9f Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-28Update policy-drools-pdp for checkstyle 8.43liamfallon1-2/+3
Updates are indentation changes on annotations. Issue-ID: POLICY-3209 Change-Id: I7b55b2affa3e16afb0c0f8398b902a04f13c4db0 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-05-10interrupted exception and var usage sonarsjhh1-8/+8
Issue-ID: POLICY-3230 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I50a4ee81f0a1c97df25732a4e4507e8b7f8c8e4d
2021-03-12Address plugin-not-found issuesJim Hahn1-38/+3
Removed references to archetype-packaging and lifecycle-mapping, where unnecessary due to pom inheritance. Also removed unnecessary checkstyle plugins. Issue-ID: POLICY-3126 Change-Id: Ia2bc398c7adbf13e925dd6329411310472c7ee35 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-11bump pom versions to 1.9.0-SNAPSHOTjhh1-1/+1
Issue-ID: POLICY-3105 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I0686675cdddf6fb5ce78f792484486f39d705a58
2021-03-10bump poms to 1.8.2-SNAPSHOTjhh1-1/+1
Issue-ID: POLICY-3127 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I0cf960650fbd2010a7c747d4932fdf8226c1fa07
2021-02-24bump poms to 1.8.1-SNAPSHOTjhh1-1/+1
Issue-ID: POLICY-3088 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I2210fcc34c9f69c3ea42c07543ffb9834f719620
2021-02-10More sonars in drools-pdpJim Hahn1-1/+1
Addressed the following issues: - log user-controlled data; moved the "NOSONAR" to a different line - make constructors protected Issue-ID: POLICY-2909 Change-Id: Ic69c100af777779e791c38cc444dd2ea726258f2 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-09Upgrade dependenciesJim Hahn4-8/+13
Changes to eclipselink are incompatible with javax-persistence-api so removed the latter. Also added target-database property. Also replaced string constants with eclipselink constants. Per review comments, moved target-database values to property files. Issue-ID: POLICY-3005 Change-Id: I043203a952d54406a5996c1e8b5ba8936bf558c0 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-10-27Bump drools-pdp master to 1.8.0-SNAPSHOTJim Hahn1-1/+1
Bumping minor version now that guilin branch has been created. Also repointed to snapshot versions for dependencies. Issue-ID: POLICY-2875 Change-Id: Ic3d5b96e610db0487ce316a9397d2f9ecb04bda6 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-10-20Bump drools-pdp to 1.7.5 SNAPSHOTJim Hahn1-1/+1
Issue-ID: POLICY-2869 Change-Id: Id2fcbfcb5435f79b5ebb74a403fd6133d1b79a7c Signed-off-by: Jim Hahn <jrh3@att.com>
2020-10-09bump drools-pdp to 1.7.4-SNAPSHOTTaka Cho1-1/+1
Issue-ID: POLICY-2839 Change-Id: I85d286a012d7b54b8c847d94951703d2e6462e13 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-10-07Bump drools-pdp to 1.7.3 snapshotTaka Cho1-1/+1
Issue-ID: POLICY-2839 Change-Id: I750b5130c421dafd95dc4f323e891384a7815841 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-09-08bump to 1.7.2-SNAPSHOTjhh1-1/+1
Issue-ID: POLICY-2789 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I0fb5ead444c23882454e3a48efea9d936a84e455
2020-08-31Fix more sonars in drools-pdpJim Hahn4-35/+38
Fixed more sonars in drools-pdp: - remove commented code - don't throw generic Exception - unused field (made it protected instead of private) - log conditionally - cognitive complexity - too many break/continue - return empty list instead of null - Random() is not secure Fixed more eclipse warnings: - parameterize generic types Issue-ID: POLICY-2616-sonars3 Change-Id: Ia5ad769b2ea763568cfae3d81807926d89153b09 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-25Address more sonars in drools-pdpJim Hahn1-5/+6
Addressed the following sonars: - either log or rethrow - call "remove()" for thread-local-storage - use assertEquals - only one method call in exception test - swap arguments in assertEquals - add assertion to assertThatThrownBy() - explain @Ignore Also addressed eclipse warnings: - unused fields and methods Issue-ID: POLICY-2616 Change-Id: I6590c0d2b103885bc933014d48bf5fd92401cd80 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-10Bump drools-pdp to 1.7.1-SNAPSHOTTaka Cho1-1/+1
Issue-ID: POLICY-2709 Change-Id: Ifb6232eb428e2cd9c729fef54862779b2ee55bbc Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-21Removing log4j from feature-state-management/pom.xmlUtkarsh Jauhari1-5/+0
Issue-ID: POLICY-2623 Signed-off-by: Utkarsh Jauhari <uj426b@att.com> Change-Id: I5f9e7b67ce39177c4f7211ea0e30d78bc7a95cc3
2020-06-19Address checkstyle version issues in drools-pdpJim Hahn6-21/+13
Also added serializationId to several classes to address eclipse warnings. Issue-ID: POLICY-2188 Change-Id: I3df5e8abaad8da9261c0d5cd19a93ed68dceb870 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-05-21Bump Drools-Pdp to 1.7.0aditya.puthuparambil1-1/+1
Issue-ID: POLICY-2514 Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech> Change-Id: Ib18f045a621ce15f8381607ba87639dd188887e5
2020-05-21Bump Drools-Pdp to 1.6.4aditya.puthuparambil1-1/+1
Issue-ID: POLICY-2514 Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech> Change-Id: Icb874f6b91488c5003e9d22460ce57e37b11dc30
2020-04-24Bump drools-pdp 1.6.3-SNAPSHOTPamela Dragosh1-1/+1
Issue-ID: POLICY-2510 Change-Id: Ic6ce8069e65c9b7606ab3529ee6291bc772a4191 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-14bump to 1.6.2-SNAPSHOTjhh1-1/+1
Issue-ID: POLICY-2378 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I75d0acdc4bfb4f2c1870d3c01591e81ada2b7a5f
2020-04-08Address more sonar issues in drools-pdpJim Hahn1-4/+11
Addressed the following sonar issues: - use of "synchronized" - use Files.delete() instead of File.delete() Issue-ID: POLICY-2305 Change-Id: Id55628fe12d9d764616e57321382a70cb5704ba1 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-06Address sonar issues in drools-pdpJim Hahn3-16/+19
Addressed the following sonar issues: - add "final" to public static fields - commented code; some were bogus - just updated the comments so sonar is happy - use "{}" instead of string concatenation - junit should assert something - when using logger, invoke compute-intensive tasks conditionally - use superclass name instead of subclass name to access static fields - don't always return the same value - remove "transient" from fields of classes that aren't Serializable - don't nest try/catch blocks - use appropriate class name in Logger.getLogger() - use Predicate<T> instead of Function<T,Boolean> - remove unused parameters from private methods - either log or throw - remove duplicate methods - use remove() TLS instead of set(null) - null check is implicit in instanceof check - do something with return value - don't use volatile - don't return "null" list; used Optional instead - add no-arg constructor to non-Serializable superclass - add callSuper=true for EqualsAndHashCode - don't declare "throws XXX" where XXX is a subclass of RuntimeException - remove serialVersionUID field if the class isn't Serializable Also addressed some eclipse warnings: - unused fields - suppress generic typic cast warnings Issue-ID: POLICY-2305 Change-Id: I906d5bf71c1f86531423e23b3667a585cdba45e1 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-03-24Bump drools-pdp to 1.6.1-SNAPSHOTPeyton Puckett1-1/+1
Issue-ID: POLICY-2378 Change-Id: I59fb1860178cc7960f7aa553557d83d60b686ac6 Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
2020-02-26Reapply SQL output feature-state-mgtJim Hahn3-25/+28
Just need to keep the memory DB open until the test completes. Issue-ID: POLICY-2381 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I7833a66d86ea12e46460b37f695c8b4d938a9077
2020-02-26Revert "Cleanup SQL output feature-state-mgt"Pamela Dragosh3-5/+5
This reverts commit 4de095c769c28f3f304d99f132a845993bf58dfa. Reason for revert: Failing to merge Issue-ID: POLICY-2381 Change-Id: Icbb4d75a3876a44f8207fa84410c4d565da34f98 signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-02-25Cleanup SQL output feature-state-mgtPamela Dragosh3-5/+5
use an in-memory database and not store temp files in the development directory. Upgrading to H2 1.4.200 seemed to expose the database issues. mvn clean does NOT remove the sql directory which makes it hard to figure out what is going on. Issue-ID: POLICY-2381 Change-Id: Icab5d9b6f62ed0f9c4e5be91c2b518ab2b442167 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-01-13policy/drools-pdp jdk11 upgradesHockla, Ali (ah999m)2-4/+5
Issue-ID: POLICY-1589 Change-Id: I0ed05c6e471a7da6658e02a4ba3115d3a117cedd Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
2020-01-10Prepare drools-pdp for java 11Jim Hahn1-4/+3
The Observer class has been deprecated. Changed the code to use StateChangeNotifier, instead, in anticipation of a corresponding change in policy/common. Also fixed new issue with missing getSupportedPolicyTypes() method. Issue-ID: POLICY-1406 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I2d3ee29f13bd12a2e16644a1746f066c91c05475
2019-11-08Detemine number of nexus repos to supportPeyton Puckett1-124/+167
Modify RepositoryAudit.java to determine number of additional reposities to support as defined in the feature-state-management.properties file Issue-ID: POLICY-2035 Change-Id: I31edae42025a8167e242535da6eb41c15228bac8 Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
2019-11-04Use jersey dependencies from policy-endpointsliamfallon1-5/+0
There is no need to ahve Jersey dependencies in the PDP POMs as they are inherited fromt he policy-endpoints POM. Issue-ID: POLICY-2209 Change-Id: Iaa51995864eec0bf5b4134719c32e956295084a1 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-09-16Add YAML support to drools-pdp rest servletsJim Hahn1-1/+1
Drools-pdp depends on some of the GsonJackson annotations that cannot be easily worked around via standard gson. Consequently, this continues to use the JacksonHandler for json-encoding, thus it uses the YamlJacksonHandler for yaml-encoding. Added YAML to swagger "consumes" list. Change-Id: Ic70c68bb274222db571b3515cbf1ab22d9ff2366 Issue-ID: POLICY-2081 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-09-10Bump versions for drools-pdp masterJim Hahn1-1/+1
Change-Id: I9882ab12334dc4b548de527ab2d7dbfc22177113 Issue-ID: POLICY-2045 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-08-15Fix more sonar issues in drools-pdpJim Hahn1-216/+272
Addressed issues of cyclomatic complexity and deep nesting by refactoring code into separate methods. In some cases, had to refactor the code into nested classes to avoid passing too many parameters to the newly extracted methods. Addressed issue "too many conditionals" by breaking conditionals apart. Addressed issue "Remove usage of generic wildcard type" by eliminating "? extends" from return values. Addressed issue "Remove this use of 'Thread.sleep()'" in junit tests by introducing latches or using Awaitility. Note: this won't build until ApiUtils has been merged. Change-Id: I0d5596b4cb918a36bc22f426f426bd238195b458 Issue-ID: POLICY-1968 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-08-13Fix sonar issues in drools-pdpJim Hahn2-11/+12
Address sonar issue, "Move constants to a class or enum", by moving them from interfaces to classes: ActiveStandbyFeatureApi StateManagementFeatureApi PolicyResourceLockFeatureApi PolicySessionFeatureApi DroolsController DroolsControllerFeatureApi PolicyControllerFeatureApi PolicyEngineFeatureApi HealthCheck SystemPersistence EventProtocolCoder PolicyController PolicyEngine TestTransaction MdcTransaction Address sonar issue, "Move constants to a class or enum", by change the interface to a class: DroolsProperties Address sonar issue, "Override the "equals" method in this class", by adding equals & hashCode to: DroolsPdpEntity DroolsPdpImpl Use lombok for a number of getters & setters. Address sonar issue, "Define a constant instead of duplicating this literal" in: DroolsPdpsElectionHandler JpaDroolsPdpsConnector MavenDroolsController GenericEventProtocolCoder GsonProtocolCoderToolset RestManager Address sonar issue, "Remove the parentheses around the parameter" in: MavenDroolsController Address sonar issue, "Replace this lambda with a method reference" in: LifecycleFsm Address sonar issue, "Move this constructor to comply with Java Code Conventions" in: LifecycleStateRunning Address sonar issue, "Replace this 'switch' statement by 'if' statements to increase readability", as specified in: PolicyEngineManager Address sonar issue, "Rename field to prevent any misunderstanding/clash with field" in: MdcTransactionImpl Address sonar issue, "Either log or rethrow this exception", in: RestManager Address sonar issue, "Rename this constant name to" uppercase, by replacing enums with static lists in: RestManager Addressed review comments: Fixed license dates. Renamed getSiteName/setSiteName methods to getSite/setSite in the interface to match the field names in the implementation classes. Renamed *Instance classes to *Constants. Next round of review comments. Change-Id: I1c26af9f194833dd773f2b25dc5f60cde163201c Issue-ID: POLICY-1968 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-08-07Bump version of drools-pdpJim Hahn1-1/+1
Updated the remaining *.pom files. Updated java test file that uses the version. Changed versions in *.pom files to all be 1.0.0. Change-Id: Ia75cdfa5704b1e16b3c78e0257e619cd41220f93 Issue-ID: POLICY-1965 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-07-24Add coverage to feature-active-standby-managementJim Hahn3-26/+17
Also removed some logger.isXxx() tests, which should reduce the number of branches that need to be tested. Removed unneeded objects and methods from feature-lifecyle. Change-Id: Ic3eb9c0b63a2ad5585846525eb0ebda81fc55d5e Issue-ID: POLICY-1772 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-07-17Fix checkstyle issues in api-state-managementJim Hahn3-13/+13
Also deleted the checkstyle suppression file. Change-Id: Ib43a75c2e214db61a75173be095c380c7c7488f1 Issue-ID: POLICY-1902 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-07-16Fix checkstyle issues in policy-coreJim Hahn3-5/+5
Also deleted the checkstyle suppression file. Change-Id: I93e9f9154b614b56f7826ec978e1a99bd9369348 Issue-ID: POLICY-1907 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-07-16Merge "Fix checkstyle issues in policy-management"Jorge Hernandez2-2/+2