Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
Issue-ID: POLICY-2510
Change-Id: Ic6ce8069e65c9b7606ab3529ee6291bc772a4191
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2378
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I75d0acdc4bfb4f2c1870d3c01591e81ada2b7a5f
|
|
Addressed the following sonar issues:
- add "final" to public static fields
- commented code; some were bogus - just updated the comments
so sonar is happy
- use "{}" instead of string concatenation
- junit should assert something
- when using logger, invoke compute-intensive tasks conditionally
- use superclass name instead of subclass name to access static fields
- don't always return the same value
- remove "transient" from fields of classes that aren't Serializable
- don't nest try/catch blocks
- use appropriate class name in Logger.getLogger()
- use Predicate<T> instead of Function<T,Boolean>
- remove unused parameters from private methods
- either log or throw
- remove duplicate methods
- use remove() TLS instead of set(null)
- null check is implicit in instanceof check
- do something with return value
- don't use volatile
- don't return "null" list; used Optional instead
- add no-arg constructor to non-Serializable superclass
- add callSuper=true for EqualsAndHashCode
- don't declare "throws XXX" where XXX is a subclass of RuntimeException
- remove serialVersionUID field if the class isn't Serializable
Also addressed some eclipse warnings:
- unused fields
- suppress generic typic cast warnings
Issue-ID: POLICY-2305
Change-Id: I906d5bf71c1f86531423e23b3667a585cdba45e1
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2378
Change-Id: I59fb1860178cc7960f7aa553557d83d60b686ac6
Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
|
|
Issue-ID: POLICY-1589
Change-Id: I0ed05c6e471a7da6658e02a4ba3115d3a117cedd
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
|
|
There is no need to ahve Jersey dependencies in the PDP POMs as they are
inherited fromt he policy-endpoints POM.
Issue-ID: POLICY-2209
Change-Id: Iaa51995864eec0bf5b4134719c32e956295084a1
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Add a common version of Jersey for all Policy Framework components.
Issue-ID: POLICY-2209
Change-Id: Iab5a62475eb73b5e4db8a02cfa029002a7f5f8ea
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Change-Id: I9882ab12334dc4b548de527ab2d7dbfc22177113
Issue-ID: POLICY-2045
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Addressed issues of cyclomatic complexity and deep nesting by
refactoring code into separate methods. In some cases, had to
refactor the code into nested classes to avoid passing too many
parameters to the newly extracted methods.
Addressed issue "too many conditionals" by breaking conditionals
apart.
Addressed issue "Remove usage of generic wildcard type" by eliminating
"? extends" from return values.
Addressed issue "Remove this use of 'Thread.sleep()'" in junit tests
by introducing latches or using Awaitility.
Note: this won't build until ApiUtils has been merged.
Change-Id: I0d5596b4cb918a36bc22f426f426bd238195b458
Issue-ID: POLICY-1968
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Updated the remaining *.pom files.
Updated java test file that uses the version.
Changed versions in *.pom files to all be 1.0.0.
Change-Id: Ia75cdfa5704b1e16b3c78e0257e619cd41220f93
Issue-ID: POLICY-1965
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: I253d3e85a08b893e7a9b168d92752205bcc459f6
Issue-ID: POLICY-1772
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed breakages due to changes made in policy/common to satisfy
sonar.
Change-Id: I26a38340707b2903e089350c31c5dfdb5c019ee0
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Released 1.5.0
Issue-ID: POLICY-1737
Change-Id: I2ebc4255aa7b03b1c402e825bfb714224fb7db84
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Change-Id: I6eb1f0e7dc2c0ac9b4f1594497c321aa57db8ecd
Issue-ID: POLICY-1747
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-1630
Change-Id: Ia77856077ae89f839aa930101c2002ac25f79595
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-1232
Change-Id: I768c9f4e0e1411854fe6aadb52abbc616654127d
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Issue-ID: POLICY-1213
Change-Id: I485c15044ba5cc0d3daceaf0876f543cc5c8af82
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
|
|
These are the remaining submodules that have checkstyle. Pretty
clean compile after this. There were a couple of sonar fixes
in there also.
Issue-ID: POLICY-882
Change-Id: I8191ea1aa261f4a7b9d3d21c108572fd31db1b8c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-967
Change-Id: Ib19d3a89ffa328c39f7871bff59efb3dd1617f7a
Signed-off-by: mmis <michael.morris@ericsson.com>
|
|
Removed policy-endpoints, and 3 classes from policy-core. Replaced
refenences to the deleted classes with references to the corresponding
classes in policy-common
Issue-ID: POLICY-967
Change-Id: I547cde4894424b8f40b7ddd4e2342ebb729cb588
Signed-off-by: mmis <michael.morris@ericsson.com>
|
|
Snapshot updated for Casablanca.
Change-Id: I75c0a41ce2c1a56ab658be8bfd27a5c81977f990
Issue-ID: POLICY-875
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
These reviews must be merged in order because of layering.
This review should be merged SECOND.
Change-Id: I3d3fb84622686b23d435aaf0cd43d307684a4a1f
Issue-ID: POLICY-844
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
These reviews must be merged in order because of layering.
This review should be merged THIRD
Change-Id: Icdb5c18106ade60bbc1eea67a1b42e70ac5383e5
Issue-ID: POLICY-798
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Issue-ID: POLICY-736
Change-Id: Ic293a7347db4e5001a4084e1b98c5d44a145d16c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
configurable log location
metric/audit log for transaction metrics conforming to
new field definition.
support metrics/audits records with custom logback filters
so they are not intrusive with developer log testing.
Change-Id: I7a4dcc6790b85539e613ad8705e731e7298ce106
Issue-ID: POLICY-533
Signed-off-by: Jorge Hernandez <jh1730@att.com>
|
|
Three bugs fixed:
1. Set of static variable in DMaaPSimulatorJaxR
2. Use of opssibly null variable "output" in RepositoryAudit
3. Unreachable statement error in RepositoryAudit
Change-Id: I72e028cfc51a82250afd02fb4109d3dea08072dc
Issue-ID: POLICY-691
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Fixed most of the instances of the following sonar issues:
Moved array designator
Used diamond operator
Changed System.out/err to use a logger
Changed several Thread.sleep() in test code to a single sleep()
Useless assignments
Replaced comparison with "" to string.isEmpty()
Merged if's
Replaced ArrayList with List in method returns
Reordered type modifiers
Reordered constructor methods
Defined constants for literals, or replaced them with method calls
Removed "throws Xxx" for subclasses of RuntimeException
Combined identical "catch" blocks
Re-interrupted the current thread after catching an InterruptedException
Removed tests against the literal "false"
Fix indentation of new makeTopicOperError() method.
Fix exception variable name in new methods, logNoUebEncoder()
and logNoDmaapEncoder().
Change-Id: Iddae5210553662f733b67333b372dec8c3fe2c94
Issue-ID: POLICY-336
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Added a DMaaP simulator for testing applications. One current
limitation is that the simulator does not support multiple "subscribers"
on the same topic; if someone gets a message, that message cannot be
subsequently retrieved by anyone else. The simulator has also not been
tested for concurrent getting and posting.
Also added a way to set the response code DMaaP would return for a get
to test that policy can gracefully handle errors.
It may need some work to become truely its own "feature"
Issue-ID: POLICY-489
Change-Id: I524981bdf5e4e825f13e6197dda11d9498e4f4bf
Signed-off-by: Charles Cole <cc847m@att.com>
|