Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
- some methods should return an empty array.
- avoid the result of a java.util.Map.get()
against null before proceeding with adding
or changing the value in the map.
- Declaring a variable only to immediately
return or throw it is a bad practice.
Issue-ID: POLICY-2616
Change-Id: I21a55c5ea716d8f64dc9155f84cabcfbcf5a22e0
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
- sonar thinks one block of comments are code,
so changed some syntax in comments
- not more than one break or continue statement
Issue-ID: POLICY-2616
Change-Id: Ia35b73584f5a8492320c4beaa069ba7f903ce268
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
- remove unnecessary cast
- A "NullPointerException" could be
thrown; "last" is nullable here
- regexp method name
- remove curly braces and 'return'
Issue-ID: POLICY-2616
Change-Id: Icd6ab0cf1f77cdc8cf1bffb3ae2781702add9ab5
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
|
|
- use '{}' for logger msg
- sonar suggest using use libraries
Awaitility for asynchroneous testing
Issue-ID: POLICY-2616
Change-Id: I09828cdb9467235403f299c6419e8560ca21aefd
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
- A field should not duplicate
the name of its containing class
- Invoke method(s) only conditionally
- add equals and hashcode
- some leftover changes for %n
Issue-ID: POLICY-2616
Change-Id: Icc094c17245e6a163d1158d97890579d76b84aec
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
|
|
|
|
%n is portable across platforms \n is not.
Issue-ID: POLICY-2616
Change-Id: I6daa827b93384c8b25dcb58b87fff116d09a2176
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Use eclipse to generate those two
Overrides in order to avoid sonar
issue
Issue-ID: POLICY-2616
Change-Id: If7e887b99fa44dac5ac5fa6f8c8cfe677238576d
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Remove useless curly braces around statement
Rename the method name
change to '<>'
Issue-ID: POLICY-2616
Change-Id: I679ce7e44b1a8c2c30f78820c12f91f18e5aa944
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Unused parameters are misleading.
Whatever the values passed to such
parameters, the behavior will be the same.
Issue-ID: POLICY-2616
Change-Id: I9a595dca81ce061846fa53adf8086130ffd31a74
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Also added serializationId to several classes to address eclipse warnings.
Issue-ID: POLICY-2188
Change-Id: I3df5e8abaad8da9261c0d5cd19a93ed68dceb870
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
hashCode should be overridden in pairs.
followed by Effective Java:
You must override hashCode() in every class that
overrides equals(). Failure to do so will result
in a violation of the general contract for
Object.hashCode(), which will prevent your class from
functioning properly in conjunction with all
hash-based collections, including HashMap, HashSet, and Hashtable.
Issue-ID: POLICY-2616
Change-Id: I2b29722daab5c520547397aae68d8ebaa71b2c4b
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
remove unused import
rename the method name
Issue-ID: POLICY-2616
Change-Id: I15845159063ec5fa3cfb34a59b9c433ba3201ccc
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Issue-ID: POLICY-2514
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
Change-Id: Ib18f045a621ce15f8381607ba87639dd188887e5
|
|
Issue-ID: POLICY-2514
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
Change-Id: Icb874f6b91488c5003e9d22460ce57e37b11dc30
|
|
Issue-ID: POLICY-2546
Change-Id: Ibddde78d705349b3c8510678f25dfce817b1a091
Signed-off-by: Straubs, Ralph (rs8887) <rs8887@att.com>
|
|
Issue-ID: POLICY-2510
Change-Id: Ic6ce8069e65c9b7606ab3529ee6291bc772a4191
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2378
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I75d0acdc4bfb4f2c1870d3c01591e81ada2b7a5f
|
|
Issue-ID: POLICY-2378
Change-Id: I59fb1860178cc7960f7aa553557d83d60b686ac6
Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
|
|
Fix server-pool junit hang due to hardcoded IP
Issue-ID: POLICY-2425
Change-Id: Icaf54c0bbd81fa755a031df91ee6cf5cdee98f27
Signed-off-by: Joseph Chou <jc2555@att.com>
|
|
Update timeout value in testcase and add logback-test.xml
Issue-ID: POLICY-2351
Change-Id: Idccf87144e137d7a0d18112a5e1442c4b04a0ac2
Signed-off-by: Joseph Chou <jc2555@att.com>
|
|
Issue-ID: POLICY-2351
Change-Id: I8ddde547a73a51c04c8dd9f1d66232e8281599a9
Signed-off-by: Straubs, Ralph (rs8887) <rs8887@att.com>
|