aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-04-14native controller generates invalid propertiesjhh6-36/+166
Additional instrumetation and tests have been added as well. Issue-ID: POLICY-2489 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I65df586f3a44acf3d6f825ebfb8bd73107255a1f Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-04-13Point to fix common/modelsPamela Dragosh1-2/+2
Fixed naming policy string and yaml coder string fix Issue-ID: POLICY-2486 Change-Id: I77dc1593a0d4c744090aa7b89303ea5e76d36ead Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-11Point to released parent, common, modelsPamela Dragosh1-3/+3
Issue-ID: POLICY-2378 Change-Id: Ic80fe0334919361f973c7ae7796c5d8868882fcb Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-09Disable sonar main args for drools-pdpJim Hahn1-1/+6
Issue-ID: POLICY-2305 Change-Id: If056c7e9179e245fafd6badc70ff9eee78fb23b3 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-08Address more sonar issues in drools-pdpJim Hahn4-13/+22
Addressed the following sonar issues: - use of "synchronized" - use Files.delete() instead of File.delete() Issue-ID: POLICY-2305 Change-Id: Id55628fe12d9d764616e57321382a70cb5704ba1 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-08Merge "Address sonar issues in policy-management"Jim Hahn26-184/+191
2020-04-07Address sonar issues in policy-managementJim Hahn26-184/+191
Addressed the following sonar issues: - modified code to specify the correct class name in the getLogger() call - use equals() instead of "==" for string comparison - remove deprecated code - use ',' instead of "," in indexOf - remove code that is commented out; typically bogus, so the comment was adjusted to satisfy sonar - missing assert in junits - use "{}" instead of concatenation when using logger - either log or rethrow - put arguments for assertEquals() in the correct order - remove "return" statements from the end of void methods - don't always return the same value; just disabled sonar as refactoring would have obfuscated the code - cognitive complexity; used eclipse auto-refactoring to extract out chunks of code into separate methods - don't pass array of classes to class.getDeclaredMethod(); use ellided arguments instead - fix argument count in logger calls - remove unnecessary casts - don't use "volatile" - make methods "synchronized" to match parent class definitions Issue-ID: POLICY-2305 Change-Id: Ie96418f696da4ae6c2ca8d4a914371469e695419 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-06Address sonar issues in drools-pdpJim Hahn59-300/+324
Addressed the following sonar issues: - add "final" to public static fields - commented code; some were bogus - just updated the comments so sonar is happy - use "{}" instead of string concatenation - junit should assert something - when using logger, invoke compute-intensive tasks conditionally - use superclass name instead of subclass name to access static fields - don't always return the same value - remove "transient" from fields of classes that aren't Serializable - don't nest try/catch blocks - use appropriate class name in Logger.getLogger() - use Predicate<T> instead of Function<T,Boolean> - remove unused parameters from private methods - either log or throw - remove duplicate methods - use remove() TLS instead of set(null) - null check is implicit in instanceof check - do something with return value - don't use volatile - don't return "null" list; used Optional instead - add no-arg constructor to non-Serializable superclass - add callSuper=true for EqualsAndHashCode - don't declare "throws XXX" where XXX is a subclass of RuntimeException - remove serialVersionUID field if the class isn't Serializable Also addressed some eclipse warnings: - unused fields - suppress generic typic cast warnings Issue-ID: POLICY-2305 Change-Id: I906d5bf71c1f86531423e23b3667a585cdba45e1 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-01Sync controller capabilities as controllers bouncejhh10-99/+534
As native policies introduce temporality in policy types supported as they are removed and added, the associated policy types that can be honored at a a given time, may need to adjust. A significan portion of this review is dedicated to multi-policy junits and telemetry instrumentation. Issue-ID: POLICY-2459 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I62bbc03411446849eaa55c9b1524220dc13c2cb0 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-03-27Merge "Point to latest snapshots"Pamela Dragosh1-2/+2
2020-03-27Point to latest snapshotsPamela Dragosh1-2/+2
Issue-ID: POLICY-2378 Change-Id: I20672bed90931ff9d3cac5f63c238248f8b39406 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-27Merge "native policy use engine for top-down processing"Jorge Hernandez6-49/+116
2020-03-26native policy use engine for top-down processingjhh6-49/+116
This will ensure proper invocation of all feature hooks. Issue-ID: POLICY-2388 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I8d1666bb5e9526faa588e4f613674e080181d4ba Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-03-26Merge "Upgrade jar version to resolve security risk"Jim Hahn3-2/+12
2020-03-25Point to models 2.2.2Pamela Dragosh1-1/+1
Issue-ID: POLICY-2378 Change-Id: Ie8671969f79fc1e2ce767cd4ab9a426eddea5d55 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-25Upgrade jar version to resolve security riskJoseph Chou3-2/+12
Upgrade ant, hibernate-core and commons-configuration Issue-ID: POLICY-2439 Change-Id: I6c22e634e81850ed97c6214ffc202eb68007b8b3 Signed-off-by: Joseph Chou <jc2555@att.com>
2020-03-25remove temp. sudo accessjhh1-2/+0
Issue-ID: POLICY-2370 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I221fb5887d280536fbfef120b0a2cf41813684fc
2020-03-24Bump drools-pdp to 1.6.1-SNAPSHOTPeyton Puckett27-27/+27
Issue-ID: POLICY-2378 Change-Id: I59fb1860178cc7960f7aa553557d83d60b686ac6 Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
2020-03-24Release 1.6.0 drools-pdp docker imagePeyton Puckett1-0/+8
Issue-ID: POLICY-2378 Change-Id: I0408fbf5ff5883a7661329ba28420a773b475f49 Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
2020-03-24Release 1.6.0 drools-pdp artifactsPeyton Puckett1-0/+4
Issue-ID: POLICY-2378 Change-Id: I510fec491f1952e2312e4a018a22d4d3bd2db53c Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
2020-03-24Remove hardcoded version for policy.common.versionPeyton Puckett1-2/+2
Issue-ID: POLICY-2378 Change-Id: Ibe9073fd7cd1b741e197040e32f2de3927b05658 Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
2020-03-24Merge "Point to released artifacts"Pamela Dragosh1-3/+3
2020-03-23Point to released artifactsPamela Dragosh1-3/+3
Issue-ID: POLICY-2378 Change-Id: I9186874a4a4253105f3bff602c5c5b01b7f1d1c3 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-23make policy-id optionaljhh1-3/+1
for legacy operational policies, PAP does not populate the metadata.policy-id field. The metadata structure is empty. Issue-ID: POLICY-2356 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ib726c935a9ea344577dc58638bdd39192c7a10d1
2020-03-22Fix op policies distribution to controllersjhh17-78/+726
Fix a bug when distributing a policy to the right controller plus additional junits to catch similar issues. Issue-ID: POLICY-2356 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I25fefa64ad54c55e6516ae18c6895b6de9407419 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-03-18Merge "ONAP server pool code update"Pamela Dragosh6-79/+226
2020-03-17renew policy certs till 03/17/2021jhh1-0/+0
Issue-ID: POLICY-2402 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ib7112b7ebefcb3a4ce743ec654556bd6cbd789e6
2020-03-17ONAP server pool code updateJoseph Chou6-79/+226
Fix server-pool junit hang due to hardcoded IP Issue-ID: POLICY-2425 Change-Id: Icaf54c0bbd81fa755a031df91ee6cf5cdee98f27 Signed-off-by: Joseph Chou <jc2555@att.com>
2020-03-10policy routing and reorg into policy-domainsjhh63-444/+1634
- Native Drools Controller Policy support. - Move domain policies into the policy-domains project. - Route legacy/compliant operational policies to one or all controller supporting the policy's policy type. - Enhancements to scripts to invoke commands external to the container. Issue-ID: POLICY-2388 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Id41f04d10a28d2ea86bdd41334e499c28d0438ae Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-03-06Add feature-server-pool to the ONAP drools-pdp repository.Chou, Joseph (jc2555)2-2/+35
Update timeout value in testcase and add logback-test.xml Issue-ID: POLICY-2351 Change-Id: Idccf87144e137d7a0d18112a5e1442c4b04a0ac2 Signed-off-by: Joseph Chou <jc2555@att.com>
2020-03-04Add feature-server-pool to the ONAP drools-pdp repository.Straubs, Ralph (rs8887)45-0/+15165
Issue-ID: POLICY-2351 Change-Id: I8ddde547a73a51c04c8dd9f1d66232e8281599a9 Signed-off-by: Straubs, Ralph (rs8887) <rs8887@att.com>
2020-03-03Merge "Undeploy support for drools policies."Jim Hahn6-16/+108
2020-03-03Merge "http server/client management"Jorge Hernandez6-31/+360
2020-03-03Undeploy support for drools policies.jhh6-16/+108
Issue-ID: POLICY-2388 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I4c5ed6752a32c9c2391cf03dd56cb2f1abc32dfd Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-03-03use policy/parent awaitilityPamela Dragosh1-1/+0
This upgrades the version, but seems to work fine. Issue-ID: POLICY-2381 Change-Id: I1f9b930b28c4fdce67921fd31269724a29c26fd6 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-02http server/client managementjhh6-31/+360
This is to support the new actor architecture configuration. Issue-ID: POLICY-1625 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ieda56be38b8572d75a5fbb3775067ab537310aa1
2020-03-01Point to docker 2.0.1Pamela Dragosh1-1/+1
policy/docker is released. Issue-ID: POLICY-2378 Change-Id: I71cb892b988f7cd534fc37c0329f3a0502e73874 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-02-27Undeploy support for native rules PDP-D policies.jhh3-73/+86
Issue-ID: POLICY-2388 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ic829bda9dbbb54d8883df6c642c1895cd7936823
2020-02-27Merge "Undeploy support for native rules PDP-D policies."Jim Hahn13-23/+227
2020-02-26Undeploy support for native rules PDP-D policies.jhh13-23/+227
Issue-ID: POLICY-2388 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Iaaf5e13a5db286928952bcb3e4cc0f526b0b133c
2020-02-26Merge "Add DroolsExecutor for DroolsRunnable"Pamela Dragosh2-13/+75
2020-02-26Merge "narrow rest server data response for lifecycle"Jorge Hernandez2-8/+19
2020-02-26narrow rest server data response for lifecyclejhh2-8/+19
There may be a potential for getting stuck between gson utils, jetty and fsm data. Issue-ID: POLICY-2345 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Iec7d1a9db19d3c2eea830b2a51cd1fb1229c573a
2020-02-26Reapply SQL output feature-state-mgtJim Hahn4-26/+28
Just need to keep the memory DB open until the test completes. Issue-ID: POLICY-2381 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I7833a66d86ea12e46460b37f695c8b4d938a9077
2020-02-26Revert "Cleanup SQL output feature-state-mgt"Pamela Dragosh4-5/+6
This reverts commit 4de095c769c28f3f304d99f132a845993bf58dfa. Reason for revert: Failing to merge Issue-ID: POLICY-2381 Change-Id: Icbb4d75a3876a44f8207fa84410c4d565da34f98 signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-02-25Add DroolsExecutor for DroolsRunnableJim Hahn2-13/+75
Added DroolsExecutor, which is an Executor that works by injecting its commands into drools working memory via DroolsRunnable objects. Issue-ID: POLICY-2385 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I59a57bc431249c84cb08f87089f6239993d7d2c4
2020-02-25Cleanup SQL output feature-state-mgtPamela Dragosh4-6/+5
use an in-memory database and not store temp files in the development directory. Upgrading to H2 1.4.200 seemed to expose the database issues. mvn clean does NOT remove the sql directory which makes it hard to figure out what is going on. Issue-ID: POLICY-2381 Change-Id: Icab5d9b6f62ed0f9c4e5be91c2b518ab2b442167 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-02-21Minor change to pass operational schema validation.jhh2-4/+3
The junit contains a test case for vcpe. Issue-ID: POLICY-2375 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I9d1039e033bf4374d5b6bd5f78bd5ee5a502e3f2 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-02-18pip should point to pip3 in dockerjhh1-0/+1
This causes a problem building the drools-pdp image, failing the actual merge operation and pushing a new image. Issue-ID: POLICY-2181 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ibd6e3ddf469d4e56d330450fb2064200ce504740
2020-02-18Ignore fsm field in policies for serializationjhh2-1/+10
When printing lifecycle fsm state information with telemetry, fsm causes a stack overflow, because of the pointer back to the fsm parent object. This will correct this situation. Issue-ID: POLICY-2345 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: If4e11f37a74fcc763517bc08c4a8e13c1a6561df Signed-off-by: jhh <jorge.hernandez-herrero@att.com>