summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-08-31Merge "Fix sonars in server-pool"Pamela Dragosh10-346/+474
2020-08-28Fix sonars in server-poolJim Hahn10-346/+474
Addressed the following sonars in feature-server-pool: - re-interrupt after catching an InterruptException - reduce cognitive complexity - cognitive complexity - not enough arguments for logger message - use UnaryOperator instead of Function - update static fields via static methods - too many break/continue in for-loop Also fixed some Eclipse warnings: - add parameter to generic types - useless assignments - newInstance() has been deprecated - close streams Issue-ID: POLICY-2616 Change-Id: Ibf6c20e6c2a7eb8c60e1b38f388d86a0f9b8804b Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-28Fix sonar issue in distributed lockingJim Hahn1-1/+2
Fixed sonar issue: - Refactor the code of the lambda to have only one invocation throwing an exception Issue-ID: POLICY-2616 Change-Id: I8d96b95d0da9a780daacec7a4de17167642b03c1 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-26Remove commons-io dependencyPamela Dragosh1-6/+0
Policy parent has this declaration to the latest 2.7 version of commons-io which fixes a sonatype security issue. There is no reason that drools-pdp should be declaring this. Issue-ID: POLICY-2798 Change-Id: Ie7dbe14458be4ead395dfcbebbc1c0cd3ccc4ea6 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-08-25Address more sonars in drools-pdpJim Hahn17-71/+81
Addressed the following sonars: - either log or rethrow - call "remove()" for thread-local-storage - use assertEquals - only one method call in exception test - swap arguments in assertEquals - add assertion to assertThatThrownBy() - explain @Ignore Also addressed eclipse warnings: - unused fields and methods Issue-ID: POLICY-2616 Change-Id: I6590c0d2b103885bc933014d48bf5fd92401cd80 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-25block status operations until controllers readyjhh7-27/+74
Status messages to the PAP won't be send until all mandatory resources specified in the lifecycle.pdp.policytypes property are functional. Issue-ID: POLICY-2669 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ia9d4c678fcfbdb232059d0827235845ee11f1201 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-08-24exit jvm when detecting configuration problemsjhh3-2/+97
It follows the same approach that in other policy components by throwing a runtime-exception vs System.exit(x). Issue-ID: POLICY-2752 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Iba508fc7095b060373742849e394c8fdd2a2334f Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-08-24Merge "remove legacy operational policies support"Jim Hahn20-442/+50
2020-08-21move to alpine from debianTaka Cho1-9/+9
moving to alpine-jdk base for drool-pdp apps csit drools/apps tested in windriver labs: http://10.12.6.96:8080/tmp/tmp.yxBE30uD1m-robot-workdir/report.html 1, httpie has to install via apk 2, http-prompt has to install via pip Issue-ID: POLICY-2787 Change-Id: I3d1bd86c7c2c3c48e9ac2a823b988bb9b1bdf98f Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-08-20remove legacy operational policies supportjhh20-442/+50
Issue-ID: POLICY-2765 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I6066b8040add53ed32572a71854f3f7094bc41d6
2020-07-30Update INFO.yaml in policy-drools-pdpTaka Cho1-12/+16
Verified with Jessica W that the "type" should still be "Addition", even when updating the PTL. Updated to Mature, per TSC. Issue-ID: POLICY-2738 Change-Id: I3a90f3dff643f89cc5eba3a46ba4570dc756bfef Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-07-27Remove more jackson dependencies from drools-pdpJim Hahn2-10/+0
Issue-ID: POLICY-1528 Change-Id: I9b4054cbfd41ec1abe61d6fe459ebb29adaa7a45 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-24Add Ajith to policy/drools-pdp infoJim Hahn1-17/+11
Issue-ID: POLICY-2738 Change-Id: Ib40ad93e6c0562fa60c99c9c6eff5072e355c062 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-21Merge "Support multiple Policy/Controller types using 'controller.type' ↵Jorge Hernandez11-18/+311
property"
2020-07-21Support multiple Policy/Controller types using 'controller.type' propertyStraubs, Ralph (rs8887)11-18/+311
It provides a feature base to allow for custom Policy and Drools Controllers. Issue-ID: POLICY-2415 Change-Id: Ibe3f11e3ecd925537ffd03d2420bb3b8214029c9 Signed-off-by: Straubs, Ralph (rs8887) <rs8887@att.com> Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-07-20Remove jackson from drools-pdpJim Hahn14-99/+4
Issue-ID: POLICY-1528 Change-Id: I616c48d62c63f8f213ec012f8746509471c38f89 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-17Point to SNAPSHOT for drools-pdpJim Hahn1-2/+2
Issue-ID: POLICY-2695 Change-Id: I65fb75dda4dd26a54c593ecb26d7e0950a59e27c Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-17Merge "add exec option to policy usage message"Jorge Hernandez1-1/+1
2020-07-16add exec option to policy usage messagejhh1-1/+1
Issue-ID: POLICY-2673 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I5b3bbc36ea33c30625119a9e624b68c82a91b634
2020-07-15Merge "exec pdp-d java process to run in the foreground"Jorge Hernandez3-211/+316
2020-07-14exec pdp-d java process to run in the foregroundjhh3-211/+316
Issue-ID: POLICY-2673 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I0a08a2760e4dc5a61a59c7f0f3096db76d42cc29
2020-07-13Merge "sonar fix for server pool"Jim Hahn3-25/+24
2020-07-10Bump drools-pdp to 1.7.1-SNAPSHOTTaka Cho27-27/+27
Issue-ID: POLICY-2709 Change-Id: Ifb6232eb428e2cd9c729fef54862779b2ee55bbc Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-07-10release docker 1.7.0Taka Cho1-0/+8
Issue-ID: POLICY-2695 Change-Id: I250bd36079484f9869f39ec000347c106384ebaf Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-07-10release drool-pdp 1.7.0Taka Cho1-0/+4
Issue-ID: POLICY-2709 Change-Id: Ide08c4847a7c41bcb76b6009be59be7ec3621191 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-07-09point to release parent, common and modelTaka Cho1-3/+3
release 1.7.0 Issue-ID: POLICY-270 Change-Id: I4975883ef85ab99345d7f9f32bbc72c091c0573a Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-07-09sonar fix for server poolTaka Cho3-25/+24
- move to a method for nest try and catch - fixed some typos in comments - use constant for the same String - boolean method should be checked - removed unnecessary exceptions Issue-ID: POLICY-2616 Change-Id: I647ee095171feedfd44ca6967676f61842c2c91b Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-07-06Merge "Checkstyle fixes to drools-pdp"Ram Krishna Verma3-12/+9
2020-07-06Merge "Use apache Triple"Ram Krishna Verma6-227/+79
2020-07-06Merge "sonar fix for TargetLock"Jorge Hernandez1-20/+19
2020-07-06Checkstyle fixes to drools-pdpJim Hahn3-12/+9
Issue-ID: POLICY-2696 Change-Id: I7f80737c52e3f16e03803118d92411e4ac39c5fb Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-06Use apache TripleHAHN III6-227/+79
Replaced policy-utils/Triple with apache Triple. Issue-ID: POLICY-2694 Change-Id: I160f90c03f18b7da8dec5d0a00f809bcfb29680b Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-06sonar fix for TargetLockTaka Cho1-20/+19
- duplicating strings to constant - to not log tainted, user-controlled data. Issue-ID: POLICY-2616 Change-Id: Iaa9dd9f9ef839cec58ae60d8464b889a02b8ddb5 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-07-02drools-pdp sonar fixTaka Cho7-37/+39
most of changes are assert statement Issue-ID: POLICY-2616 Change-Id: I3bd3076115d28d8cfabcbe0859cc4b21085e1394 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-07-02Merge "Updating drools pdp dependencies"Jorge Hernandez5-17/+20
2020-07-01Updating drools pdp dependenciesRossC5-17/+20
Issue-ID: POLICY-2387 Change-Id: I5fe17c2514aed5c595d4e2a3d95fbb210a6f229b Signed-off-by: RossC <ross.carter@est.tech>
2020-06-30sonar fix for feature server poolTaka Cho2-50/+67
- reduce cognitive complexity - return a boolean value - Replace this lambda with a method reference - use lombok annotation @EqualsAndHashcode - removed unnecessary exception Issue-ID: POLICY-2616 Change-Id: Ia0c300c2909bbdd232f2a3c758a5709b70f06d1c Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-29Merge "feature-eelf: eelf-core from: 1.0.0 -> 2.0.0-oss"Jim Hahn3-3/+8
2020-06-29Merge "Clean up of Pair classes - drools-pdp"Jim Hahn12-327/+184
2020-06-29feature-eelf: eelf-core from: 1.0.0 -> 2.0.0-ossjhh3-3/+8
Issue-ID: POLICY-2387 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I29d4f07d990797a470bce0898ca67741974f1c00 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-06-29Merge "sonar fix - FeatureServerPool"Jim Hahn1-10/+5
2020-06-29Clean up of Pair classes - drools-pdpwaynedunican12-327/+184
Removed Pair class from drools-pdp and replaced with Apache Common Pair class Issue-ID: POLICY-2202 Change-Id: Ica2a5b734fb6eebfc0713027c1c4dc3b8d3882c8 Signed-off-by: waynedunican <wayne.dunican@est.tech>
2020-06-26Merge "replace an emptyArray and computeIfAbsent instead"Ram Krishna Verma1-24/+13
2020-06-26override central repo with right repositoryjhh1-3/+24
This is to prevent that other poms setting the repository http://repo2.maven.org, which has been decommissioned. The repo1.maven.org is the one to be used, only with https. Issue-ID: POLICY-2677 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I743014ea553f5df829eb0bd7ada2cb3d1fb842bf
2020-06-26replace an emptyArray and computeIfAbsent insteadTaka Cho1-24/+13
- some methods should return an empty array. - avoid the result of a java.util.Map.get() against null before proceeding with adding or changing the value in the map. - Declaring a variable only to immediately return or throw it is a bad practice. Issue-ID: POLICY-2616 Change-Id: I21a55c5ea716d8f64dc9155f84cabcfbcf5a22e0 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-26sonar fix - FeatureServerPoolTaka Cho1-10/+5
- sonar thinks one block of comments are code, so changed some syntax in comments - not more than one break or continue statement Issue-ID: POLICY-2616 Change-Id: Ia35b73584f5a8492320c4beaa069ba7f903ce268 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-26feature server Keyword sonar fixTaka Cho1-10/+15
- remove unnecessary cast - A "NullPointerException" could be thrown; "last" is nullable here - regexp method name - remove curly braces and 'return' Issue-ID: POLICY-2616 Change-Id: Icd6ab0cf1f77cdc8cf1bffb3ae2781702add9ab5 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-26Merge "replace Thread sleep with Awaitility"Jim Hahn2-4/+2
2020-06-25replace Thread sleep with AwaitilityTaka Cho2-4/+2
- use '{}' for logger msg - sonar suggest using use libraries Awaitility for asynchroneous testing Issue-ID: POLICY-2616 Change-Id: I09828cdb9467235403f299c6419e8560ca21aefd Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-25Merge "Upgrade hibernate to clear dom4j sonatype"Pamela Dragosh1-1/+1