summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-03-21Fix bugs identified by Sonar on drools-pdpliamfallon3-59/+74
Three bugs fixed: 1. Set of static variable in DMaaPSimulatorJaxR 2. Use of opssibly null variable "output" in RepositoryAudit 3. Unreachable statement error in RepositoryAudit Change-Id: I72e028cfc51a82250afd02fb4109d3dea08072dc Issue-ID: POLICY-691 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-03-16Merge "Renamed policy-drools docker image"Pamela Dragosh3-15/+15
2018-03-14Update oparent version to 1.1.0liamfallon1-1/+1
Directive from ONAP project that all repos should be updated. Change vierified with a build with .m2 /org/onap cleared. Change-Id: I19d3554bdc9aef4576de1917d5258f23a4ec42d9 Issue-ID: POLICY-693 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-03-14Renamed policy-drools docker imagemmis3-15/+15
Renamed from: onap/policy/policy-drools to onap/policy-drools to enable consistent naming across nexus and docker hub Issue-ID: POLICY-674 Change-Id: Ib0b9df97f398c5c1715f736f11f6481cf6d8427f Signed-off-by: mmis <michael.morris@ericsson.com>
2018-03-14Unit test modified to be order independentliamfallon1-13/+43
The change of dmaap version caused the order of execution of unit tests to change. This triggered an assertion fail in this test. The test has been redesigned to be independent of test invocation order. Also some small Sonar issues fixed. Change-Id: I3b3a5b1cb69785c69f818eab2473fdbfbb85dbd1 Issue-ID: POLICY-694 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-03-14Upgrade dmaap release 1.1.3Pamela Dragosh1-1/+1
Dmaap released this dependency, the snapshot is no longer available. Issue-ID: POLICY-694 Change-Id: Ia376af2e457ae95d5f16a90e6c6f3a08653f4b37 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-03-09Merge "configurable logs dir and creation as root"Pamela Dragosh1-2/+4
2018-03-08configurable logs dir and creation as rootJorge Hernandez1-2/+4
Change-Id: Ib23ee897372f0911394441739da5c7b9e7398910 Issue-ID: POLICY-554 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-03-08Remove filtering from packages/docker/pommmis1-1/+0
Filtering should not be applied in the maven-resources-plugin execution as this incorecttly modifes the scripts copied by this plugin Issue-ID: POLICY-652 Change-Id: I57595711c4a6f4522d679016370012e0dc8833d6 Signed-off-by: mmis <michael.morris@ericsson.com>
2018-03-07Copy files for docker image in packages/docker/pommmis4-37/+44
Copying the files in the pom removes the need to do the copying in various locations the docker build is executed from and allows the docker image be built without building the entire repo (as the install.zip can be pulled from nexus) Issue-ID: POLICY-652 Change-Id: I77d0f76bd1c11261b3d4d8bdd60572e545a98aa1 Signed-off-by: mmis <michael.morris@ericsson.com>
2018-03-05Merge "Update Dockerfile to remove policy-base, policy-os"Pamela Dragosh1-1/+30
2018-03-05Update Dockerfile to remove policy-base, policy-osmmis1-1/+30
Correction to previous commit "Move docker_*.sh scripts into policy/engine" as attempt to build docker image will result in failure to pull the policy-base image from nexus The policy-base and policy-os images are removed in favour of including the contents of those images directly in the policy-pe image Issue-ID: POLICY-651 Change-Id: I46f4ac0d529fc95ea702809eee466af3d1121717 Signed-off-by: mmis <michael.morris@ericsson.com>
2018-03-02Merge "Upgrade dmaap client"Jorge Hernandez1-26/+1
2018-03-02Upgrade dmaap clientPamela Dragosh1-26/+1
This should have security fixes Issue-ID: POLICY-619 Change-Id: I8636117f3f599e0fb86ded8b292112205f5d8c7c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-03-02Move docker_*.sh scripts in policy/drools-pdpmmis10-0/+1396
Added files for building policy-drools docker image Issue-ID: POLICY-623 Change-Id: If335653d6ede74ae808c3fddf84ee96d88a75727 Signed-off-by: mmis <michael.morris@ericsson.com>
2018-02-22Force dependency upgrade and exclusionsPamela Dragosh2-7/+33
LCM security issues are identified with plexus-utils and xstream. There is no clear upgrade to the org.kie.* dependencies with a fix for both of these. We will determine via testing as to whether these exclusions will result in failure. Issue-ID: POLICY-506 Change-Id: I9cefb814bb11a9babc4e4a2e47071ab74a46c011 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-21Merge "interception of facts before injection"Pamela Dragosh2-15/+91
2018-02-20Sonar fixes to drools-pdpJim Hahn50-856/+792
Fixed most of the instances of the following sonar issues: Moved array designator Used diamond operator Changed System.out/err to use a logger Changed several Thread.sleep() in test code to a single sleep() Useless assignments Replaced comparison with "" to string.isEmpty() Merged if's Replaced ArrayList with List in method returns Reordered type modifiers Reordered constructor methods Defined constants for literals, or replaced them with method calls Removed "throws Xxx" for subclasses of RuntimeException Combined identical "catch" blocks Re-interrupted the current thread after catching an InterruptedException Removed tests against the literal "false" Fix indentation of new makeTopicOperError() method. Fix exception variable name in new methods, logNoUebEncoder() and logNoDmaapEncoder(). Change-Id: Iddae5210553662f733b67333b372dec8c3fe2c94 Issue-ID: POLICY-336 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-02-19interception of facts before injectionJorge Hernandez2-15/+91
Added interceptor to drools controller, post-decoding and pre/after injection into kie sessions. The decoded object is passed as is. The set of hooks will be expanded in the future. This is added in the context of logging for POLICY-558 to track control loop transactions, per logging requirements. The idea is that VirtualControlLoopNotifications on the drools-applications area will use it to track control loop transactions, times, etc .. to satisfy logging requirements. This approach also reliefs the drools applications logic, (.drl) for dealing with this. The logic therefore will be isolated into a single feature. Change-Id: Idf840c528e6175be4aaee3bf114091c203b37bc8 Issue-ID: POLICY-558 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-02-19Fix compilation issue due to generic ExceptionJim Hahn1-2/+2
After modifying common to remove generic Exceptions, drools-pdp would no longer compile. Had to modify drools-pdp to accomodate the specific exception. Change-Id: Ib804da2ebfc7dbf5f4035ba3d48832ffe541f902 Issue-ID: POLICY-246 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-02-16Modify sonar settings to include all sub-modulesPamela Dragosh1-104/+181
We are now including all the sub-modules coverage into one file. This will now reflect correct statistics for any sub-module that tests code located in another sub-module. Issue-ID: POLICY-634 Change-Id: I916d90c27b316837284a635087665130dee5437b Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-14Replace bitronix and eclipselink in persistenceJim Hahn17-1111/+1377
Replaced bitronix transaction manager, which is not intended for production, with jboss transaction manager. Eliminated eclipselink so that only hibernate is used for persistence for both JPA and drools-persistence. Added more test cases to EntityMgrTrans to provide coverage for various exception types. Moved object store to features/session-persistence/jta. Wrapped RuntimeException in specific type. Modified test to throw specific exception type. Converted GenSchema from an @Test to a main(). Logged caught exceptions in junit tests. Change-Id: I4b02efc8da43d20b2dbb3c0b25adc382e80474ec Issue-ID: POLICY-191 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-02-13protocol coder and null drools controller junitsJorge Hernandez2-74/+266
Change-Id: Ie26a8cd44a39007e38c9dc8c28418e988df70c77 Issue-ID: POLICY-583 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-02-09Upgrade Jetty to remove security warningPamela Dragosh2-2/+2
This may not be red status, but I felt it was worthwhile to upgrade this. It resolves a timing issue when checking passwords. Issue-ID: POLICY-506 Change-Id: I926d2ee90529130d0c74285f4c4876083eb78f1f Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-08Merge "protocol coder junits"Jorge Hernandez1-0/+242
2018-02-08protocol coder junitsJorge Hernandez1-0/+242
Change-Id: I7a02a8767dbb19724715e057b1da82f7045d6a44 Issue-ID: POLICY-583 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-02-08programatic install of rules artifacts for junitsJorge Hernandez8-54/+26
instead of relying on pom.xml, build settings. since jenkins jobs that generate sonars don't seem to go through a build phase anymore, therefore the preceding artifacts are not available in the local repository, which is required by the tests. Change-Id: Icfd14b2f8a6c6e1ac7d986bd6eb977b2a83b044d Issue-ID: POLICY-621 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-02-08Merge "expose immutable list of filters to its users"Pamela Dragosh7-134/+337
2018-02-08Security issue with jackson-databindPamela Dragosh1-1/+1
I should have upgraded to 2.9.4, my mistake. This has the actual fix in it for the security issue. Issue-ID: POLICY-506 Change-Id: I11d22b83a60789160852e17204ac3c03cb44f6c1 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-07expose immutable list of filters to its usersJorge Hernandez7-134/+337
+ additional related junits Change-Id: I00293cd9aa911dfb3d658cad4ee0441ad3410e9c Issue-ID: POLICY-164 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-02-07Upgrade dependencies to solve security issuesPamela Dragosh1-4/+4
Not guaranteed, but these are dependencies that we can fix that will hopefully close some of the security issues flagged by LF. Issue-ID: POLICY-506 Change-Id: I2ddd5254e53241159f9483b5442cac6f8a1bdbab Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-06Fix sonar issues with RepositoryAuditJim Hahn1-2/+0
Per sonar, removed commented code from RepositoryAudit. Change-Id: Ia81780f7528bd4fc42062454728a2c215709ea45 Issue-ID: POLICY-469 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-02-01Reduce technical debt add coveragePamela Dragosh8-18/+119
* add empty constructor message * remove unnecessary exception declaration * add @FunctionalInterface declaration * switched around public static per java conventions * fixed up JUnit ordering * added some trivial JUnit tests to bump coverage > 70% Issue-ID: POLICY-460 Change-Id: I13b6de29f66d692143b06180feed76dd6332d6cf Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-01Merge "Fix sonar issues in feature-state-management"Jorge Hernandez4-184/+198
2018-02-01Merge "Fix sonar code issues for api-state-management"Jorge Hernandez2-15/+12
2018-02-01Merge "junits+utils to generate/test rules applications"Jorge Hernandez9-1/+497
2018-01-31fix typo when configuring fetch-limit parameterJorge Hernandez2-4/+2
Change-Id: Iea108fe035bea14e2ecd12db68b331dd2d546591 Issue-ID: POLICY-596 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-01-31Fix sonar issues in feature-state-managementJim Hahn4-184/+198
DroolsPDPIntegrityMonitor.java: Modified init() to throw just IntegrityMonitorException. Modified DroolsPDPIntegrityMonitor init() method to throw specific types of exceptions. StateManagementFeature.java: Sonar complained about needing to merge "if" statements, but chose to eliminate the "if(logger.isDebugEnabled())" instead - did this through-out the source file. Removed extra runtime exception from "throws" declaration. DbAudit.java: Fixed sonar issue regarding setting a static variable from within a non-static method. Removed logger.isDebugEnabled() tests where method calls are not involed. Simplified invoke() method complexity as reported by sonar. DroolsPDPIntegrityMonitor.java: Reduced init() complexity reported by sonar. Change-Id: Ib2722b21bbf3aad130af46c8790f40d8777e36be Issue-ID: POLICY-469 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-01-31Fix sonar code issues for api-state-managementJim Hahn2-15/+12
Renamed constants, adding "DO_" prefix or "_STATE" suffix. Removed spurious exceptions from "throws" clauses. Change-Id: I0abd74d736009480614f0653fe5aaf1ddbe77b08 Issue-ID: POLICY-468 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-01-31junits+utils to generate/test rules applicationsJorge Hernandez9-1/+497
1. utilities to generate rules applications and installing in local maven repository programmatically. 2. using these utilities, use policy abstractions, ie. controllers, containers, .. to junit test it. Change-Id: I13c35e631a1120fad503feef2593d32a99e3358f Issue-ID: POLICY-583 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-01-18Resolve bug in DroolsPDPIntegrityMonitorMagnusen, Drew (dm741q)1-8/+20
This fix ensures that the testServices, testRestClasses, tesManaged, and testSwagger properties are all populated in the stateManagementProperties object within DroolsPDPIntegrityMonitor class. Issue-ID: POLICY-564 Change-Id: Ie517b19f61ab084416ce1e6f8418d69dc9e4f85d Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2018-01-08Initialize allSeemsWell CorrectlyKevin McKiou1-3/+8
Patch 1: Correctly initialize DroolsPdpsElectionHandler.allSeemsWell upon the first call to checkWaitTimer(). Issue-ID: POLICY-519 Change-Id: I0b9ad0bfba211d705c2d9f9305694956ca3951b6 Signed-off-by: Kevin McKiou <km097d@att.com>
2017-12-21Merge "Fix issues blocking election handler thread"Jorge Hernandez10-141/+548
2017-12-21Merge "Reduce tech debt in policy-management"Jorge Hernandez11-118/+189
2017-12-19Reduce tech debt in policy-managementMagnusen, Drew (dm741q)11-118/+189
Changes to reduce tech debt in the policy-management module. Issue-ID: POLICY-463 Change-Id: I41f6b66d25a805706e5c9ed2cef2eda256153a37 Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2017-12-14Add a DMaaP simulatorCharles Cole4-0/+541
Added a DMaaP simulator for testing applications. One current limitation is that the simulator does not support multiple "subscribers" on the same topic; if someone gets a message, that message cannot be subsequently retrieved by anyone else. The simulator has also not been tested for concurrent getting and posting. Also added a way to set the response code DMaaP would return for a get to test that policy can gracefully handle errors. It may need some work to become truely its own "feature" Issue-ID: POLICY-489 Change-Id: I524981bdf5e4e825f13e6197dda11d9498e4f4bf Signed-off-by: Charles Cole <cc847m@att.com>
2017-12-13Fix issues blocking election handler threadKevin McKiou10-141/+548
This bug tracks the AT&T bug 355533. The symptom was that drools pdps that were backing each other up were becoming stuck in a standby state. The cause was that the election handler thread was being hung by a call to PolicyEngine.manager.deactivate which shuts down the topic endpoints when the drools pdp operational state transitions to disabled. Related problems were that the election handler heartbeat was NOT blocked when the main thread was blocked and the IntegrityMonitor forward progress counter was NOT blocked from incrementing when the election handler thread was blocked. This prevented the correct failover of the drools pdp to another healthy one. This change fixes the two causes of the thread blockage, moves the election handler heartbeat to the main thread and adds an interface (AllSeemsWell) which is called when the election handler has stalled/resumed. The AllSeemsWell interface will block forward progress counter increments when ALLNOTWELL and will resume forward progress counter increments when ALLSEEMSWELL. In addition, it reduces the run time of the StandbyStateManagementTest from approximately 8 minutes to approximately 2 minutes. Since this changes classes also changed by POLICY-444, this change must be merged before POLICY-444 can be merged. Issue-ID: POLICY-501 Change-Id: I7b8180d11077ccf59b21b6484cb58b5522a3df8f Signed-off-by: Kevin McKiou <km097d@att.com>
2017-12-08Merge "Multiple small changes to reduce technical debt."Jorge Hernandez9-38/+42
2017-12-07Multiple small changes to reduce technical debt.Magnusen, Drew (dm741q)9-38/+42
Made multiple changes across several classes to reduce technical debt in policy-endpoints project. Issue-ID: POLICY-462 Change-Id: I0338b9e98dd5a39492f3880c2e3a5d35b3957811 Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2017-12-05feature-healthcheck technical debtMagnusen, Drew (dm741q)2-49/+119
Made multiple changes to feature-healthcheck module to reduce technical debt identified by sonar. Issue-ID: POLICY-464 Change-Id: Ie168821611db5c0b171114e4fdd90411ce38a796 Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>