summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-09-12Remove unnecessary propertiesPamela Dragosh1-2/+0
In upgrading dmaap client, these properties were found and were unnecessary to be defined here. They are already defined in policy/parent and dmaap/cambria code was moved to policy/common. Issue-ID: POLICY-1116 Change-Id: Ic85b46e556167387acd82af3f21a7446adb43216 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-11Merge "Revert back to Drools 6.5.0.Final"Pamela Dragosh4-14/+13
2018-09-11Revert back to Drools 6.5.0.FinalJim Hahn4-14/+13
Decided to abandon the conversion to Drools 7.9.0.Final. This undoes the associated changes. Change-Id: I457266d09f7e481da5c0415290241a348786f8ea Issue-ID: POLICY-1093 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-10disabling http for configuration servicesJorge Hernandez2-30/+21
per security recommendations. Change-Id: Ic195f8270c2270239408e33e27f87436878e28b4 Signed-off-by: Jorge Hernandez <jh1730@att.com> Issue-ID: POLICY-1104
2018-09-10Switch to drools 7.9.0.FinalJim Hahn4-13/+14
Note: This will break policy/drools-applications until the corresponding change is merged there, too. Reformatted lengthy line. Change-Id: I4ae7838dfbc2d537580636eccc545710b5ebc799 Issue-ID: POLICY-1093 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-10Fix checkstyle policy-corePamela Dragosh22-755/+771
Working on the policy-core submodule in drools pdp. Issue-ID: POLICY-882 Change-Id: I58d418110fe0fda90f97117ef17edfc13d648ccc Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-08Fix checkstyle in utilsPamela Dragosh16-927/+908
Just focusing on the policy-utils submodule. Issue-ID: POLICY-882 Change-Id: I9f2ecac8f435f2d743b1fafc477d320b10852bdc Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-04Fix security issuesPamela Dragosh2-5/+9
Guava was not fully defined correctly. In order to exclude an older version being pulled in, the dependencyManagement needs to come from oparent and not overriden in drools-pdp. Issue-ID: INT-619 Change-Id: I58dfb815f02d61e47552e671540144b7b1ed3df5 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-04Remove guava overridePamela Dragosh1-2/+0
The oparent repo now declares guava for all the ONAP projects to inherit from. Removing the override so we are upgrading to a version without security or license issues. Issue-ID: INT-619 Change-Id: I5ff9745b723db74cf46d63520f7cf00796bb2a01 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-30Merge "handle null drools object in configuration"Pamela Dragosh2-4/+4
2018-08-30Merge "Set parent to policy/parent"Liam Fallon13-1716/+1697
2018-08-29handle null drools object in configurationJim Hahn2-4/+4
Modified code to explicitly check for missing drools object, and to not throw an exception during MDC setup. Change-Id: Iac16f2fc46e2ffff03195985383b09b814fa4008 Issue-ID: POLICY-1082 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-08-29Set parent to policy/parentPamela Dragosh13-1716/+1697
Set the parent to point to policy/parent instead of oparent. Clean up some duplicate management versions. Change-Id: I28957b05b80c9564ad32c958143822b6b0768219 Issue-ID: INT-619 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-28Fixed feature-healthcheck issueMichael Mokry2-4/+4
Modified properties to true for https on PAP and PDP Found a minor typo in do-start.sh that is benign currently but could cause an issue in the future so figured I would clean it up now. Change-Id: I06385d36d69955d49cabeb39b09d75ffeaec2fdc Issue-ID: POLICY-781 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-08-20Merge "https certs with aaf+pdpd containers compatibility"Pamela Dragosh11-11/+110
2018-08-20https certs with aaf+pdpd containers compatibilityJorge Hernandez11-11/+110
Updated license date (jrh3). Change-Id: I1bc244da64f4a1e683f8c6a1be53157474f46ee9 Issue-ID: POLICY-1026 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-08-20Fix sonar issues in drools-pdpKrishnajinka2-589/+536
Fix sonar issues about nested control loops in drools-pdp. Rework1 build failed due to incorrect condition. fixing it Fix checkstyle. Add modified copyright notice Issue-ID: POLICY-1017 Change-Id: I21a4ad9399b1d234b8d5416ab0d595302a441f10 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-06Fix basic Java issue in pdp drools sys compkrishnajinka4-574/+556
Modify pdp drools system component files to fix basic Java warnings from analysis tools. Possibly flagged by Sonar tool as well.Rework based on comments Issue-ID: POLICY-1017 Change-Id: I1f2a5d727d2673cade5f69a07f708e16754c78e4 Signed-off-by: krisjinka <kris.jinka@samsung.com>
2018-07-30Copy policy-endpoints from drools-pdp to commonmmis14-384/+364
Issue-ID: POLICY-967 Change-Id: Ib19d3a89ffa328c39f7871bff59efb3dd1617f7a Signed-off-by: mmis <michael.morris@ericsson.com>
2018-07-25Copy policy-endpoints from drools-pdp to commonmmis92-16498/+7607
Removed policy-endpoints, and 3 classes from policy-core. Replaced refenences to the deleted classes with references to the corresponding classes in policy-common Issue-ID: POLICY-967 Change-Id: I547cde4894424b8f40b7ddd4e2342ebb729cb588 Signed-off-by: mmis <michael.morris@ericsson.com>
2018-07-18Deny subsequent lock()Jim Hahn5-18/+18
This is the final step of separating the lock "refresh" operation from the original "lock" operation. This step entails rejecting subsequent "lock" requests, even by the same owner, when a resource is already locked; "refresh" should now be used, instead, to extend a lock. Modified comments to indicate that the lock can only be extended using "refresh". Change-Id: I406cf60c076dbce87afbd94fb301732359dbd2db Issue-ID: POLICY-872 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-07-18Upgrade jetty to 9.3.24 securityPamela Dragosh3-6/+1
Upgrade to clear security flag in CLM. Removed unnecessary properties already declared Issue-ID: POLICY-987 Change-Id: Iefe4a9b264148a6bd661d5cff3bff6019b0b3def Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-07-17Merge "Distinguish lock from refresh"Jorge Hernandez9-2/+375
2018-07-16Distinguish lock from refreshJim Hahn9-2/+375
This is the first step of separating the lock "refresh" operation from the original "lock" operation. This step entails adding the refresh() method to both the default and the feature-distriubted locking mechanisms. Change method call, in junit test, from lock to refresh. Change branch name in git review. Change-Id: I506de7a96cb3ee786839aca04ad67cdd7378832c Issue-ID: POLICY-872 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-07-13Don't stop controller on dmaap failureJim Hahn11-569/+83
Modified feature-pooling-dmaap so that it continues to work even if it's unable to communicate with the internal DMaaP topic. When that happens, it simply starts processing locally, until communication is re-established and it receives a bucket assignment. Fixed typo in comment. Added to comment for State.internalTopicFailed(). Removed extra space before @Ignore. Change-Id: I9c851c66c9162c608f2df98e11d49fc526539434 Issue-ID: POLICY-878 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-07-03Merge "Fix sonar issues on new code"Jorge Hernandez1-3/+1
2018-07-03Merge "Final piece to remove lock Callback"Pamela Dragosh2-31/+0
2018-07-03Fix sonar issues on new codeJim Hahn1-3/+1
Removed new technical debt. Change-Id: I04e86b85897ab42deca17ecee55f29d48cc24427 Issue-ID: POLICY-872 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-29Final piece to remove lock CallbackJim Hahn2-31/+0
Now that drools-applications no longer uses the lock Callback, it can be removed from drools-pdp. Change-Id: Ie82a6d382b54041ab612e73ad8c96176bd01a9f6 Issue-ID: POLICY-872 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-29Use DB time instead of jvm timeJim Hahn5-29/+65
Modified distributed locking code to use the DB time (i.e., "now()") when determining expiration times of locks. This will eliminate concerns that may arise from different timestamps on different JVMs. As part of the change, the expirationTime column was changed from BIGINT to TIMESTAMP. Rename 1810 sql scripts to 1811, to match release date. Change-Id: Ibfb15742f447133b001e4340027657ac202864a6 Issue-ID: POLICY-872 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-27Add time limit to locking facilityJim Hahn15-1148/+230
Modified the locking facility to add a time limit and remove the callback parameter. This affected both the default facility as well as the distributed locking feature. It will also require a change to the rules for Closed Loop. Changed testUnlock() to try locking with a different owner. Default feature API should be OPER_UNHANDLED. Put a few things back so-as not to break the drools-applications build. They can be removed once drools-applications is updated. Fix newlines in API java. Change-Id: I3ed7835cac6a582493a9bc8f6d1d4f3e6cb6289e Issue-ID: POLICY-872 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-27Merge "Added expiration timer to default locking strategy"Liam Fallon5-16/+371
2018-06-25Added expiration timer to default locking strategyJim Hahn5-16/+371
Fixed comment (missing "}"). Changed default age from 15 hours to 15 minutes. Only increment test time by 1 when testing hashCode. Change-Id: I70ef6cfd34e31ded45b3975f33e5b0ba22afa627 Issue-ID: POLICY-912 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-25Use connection pooling for lockingJim Hahn4-30/+76
Modified distributed locking to use connection pooling. Add comment for new dataSource parameter. Change-Id: I5dc33605797f95072af9b6911a468457f6fd9f3d Issue-ID: POLICY-910 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-20Merge "Remove references to SpecPropertyConfiguration"Pamela Dragosh8-384/+58
2018-06-19Merge "Add setXxx methods for @Property annotation"Liam Fallon5-181/+131
2018-06-19Remove references to SpecPropertyConfigurationJim Hahn8-384/+58
Change-Id: Ib4779611f124277cf8be2b3eddfe41bf69dfd74b Issue-ID: POLICY-907 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-18Add setXxx methods for @Property annotationJim Hahn5-181/+131
We'll be modifying the PropertyConfiguration class so that, instead of directly setting values in private fields, it will use public setXxx methods. Consequently, we have to add the setXxx methods to the PropertyConfiguration subclasses so that they're available when the superclass is modified policy/common. Change-Id: Idff9942eabec182670cbb427b960f6308a2ca30c Issue-ID: POLICY-906 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-18Fix fortify issue with pooling extractor classJim Hahn6-29/+17
The pooling extractor class was using reflection to extract values from private fields. It has been modified to only extract from public fields or to use public getXxx() methods instead. Change-Id: I3aafe9ebfcd41d0e71dc3529030597609b704f53 Issue-ID: POLICY-906 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-05Update drools-pdp to SNAPSHOT-1.3.0liamfallon22-34/+34
Snapshot updated for Casablanca. Change-Id: I75c0a41ce2c1a56ab658be8bfd27a5c81977f990 Issue-ID: POLICY-875 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-24Change extractor log level from warn to infov1.2.32.0.0-ONAPbeijing2.0.0-ONAPJim Hahn1-1/+1
Change-Id: I26ae7c0c83b5e3c6b128af262bd334b09696590d Issue-ID: POLICY-870 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-05-21Update Policy Drools PDP to 1.2.3-SNAPSHOTliamfallon22-22/+22
These reviews must be merged in order because of layering. This review should be merged SECOND. Change-Id: I3d3fb84622686b23d435aaf0cd43d307684a4a1f Issue-ID: POLICY-844 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-16Upgrade 1.2.2 version.propertiesv1.2.2Pamela Dragosh1-1/+1
Upgrading the version.properties Issue-ID: POLICY-798 Change-Id: Ibfbd5b221a8f5a4eb79063b066d458c3512949b8 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-05-16Upgrade SNAPSHOT to 1.2.2liamfallon21-21/+21
These reviews must be merged in order because of layering. This review should be merged THIRD Change-Id: Icdb5c18106ade60bbc1eea67a1b42e70ac5383e5 Issue-ID: POLICY-798 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-14Remove unneeded dependencies from pomsJim Hahn2-0/+10
Changed scope to "provided" for jars that are already included with drools-pdp. Changed scope to "test" for utils-test. Change-Id: Ic2d85706e00e015cc7b0e3a0bd9855753fada64e Issue-ID: POLICY-794 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-05-14automatic upgrade/downgrade features dbJorge Hernandez3-2/+54
add enable and disable scripts to the feature-distributed-locking to upgrade/downgrade their databases when these features are enabled or disabled. Change-Id: Iff9368c915f6da7f7c75d9a5a20ffe27e290e7d3 Issue-ID: POLICY-788 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-05-10Update of StandbyStateManagementTestKevin McKiou1-19/+6
Patch 1: This change modifies StandbyStateManagementTest testPMStandbyStateChangeNotifer() to use a fresh instance of StateManagement to avoid interaction with previous tests. Issue-ID: POLICY-790 Change-Id: I5907ba6b50091bc4f7789f102f48a853d8498ed5 Signed-off-by: Kevin McKiou <km097d@att.com>
2018-05-09Discard Forward to wrong hostJim Hahn4-1/+16
Changed to discard Forward message if the channel does not match the host that received it. Change-Id: I9235bd3b0c5eb264f9b1cfe53552fadf66a0edc2 Issue-ID: POLICY-787 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-05-09Change pooling property namev1.2.1Jim Hahn3-13/+42
Removed "AMSTERDAM_" prefix from pooling topic property name. Added feature-specific conf file with pooling topic property. Enabled distributed locking DB properties. Change distributed locking DB name to "pooling" to match the code. Add default value to feature-specific conf file. Change "_" in default topic name to "-". Change-Id: I53de51787694e5920dc9ced07b5a9ac60bb63e45 Issue-ID: POLICY-782 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-05-08Removed unneeded extractor propertiesJim Hahn1-4/+2
Change-Id: I5a52ba7358d27a2db0176cb02289b1bdcce0e9e2 Issue-ID: POLICY-783 Signed-off-by: Jim Hahn <jrh3@att.com>