summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-06-19drools-pdp sonar issue fixesTaka Cho7-46/+46
fix all assert statements to comply with sonar issue Issue-ID: POLICY-2616 Change-Id: Ia36e3eab7c74d8dfb1ab3fa1395b1f64b173e09a Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-16Merge "reduce sonar issue - 2 rev"Liam Fallon5-26/+31
2020-06-15reduce sonar issue - 2 revTaka Cho5-26/+31
In some conditions for assertTrue, sonarcloud recommends using assertEquals Assert.assertTrue(a.equals(b)); Assert.assertTrue(a == b); Assert.assertTrue(a == null); Assert.assertTrue(a != null); Assert.assertFalse(a.equals(b)); Compliant Solution Assert.assertEquals(a, b); Assert.assertSame(a, b); Assert.assertNull(a); Assert.assertNotNull(a); Assert.assertNotEquals(a, b); Issue-ID: POLICY-2616 Change-Id: Ib362573bd865d1b561916bf64640c8ddeaa02546 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-11Merge "do strict validation before domain conversion"Pamela Dragosh3-5/+58
2020-06-10do strict validation before domain conversionjhh3-5/+58
need to perform a validation pass as the validation combined with putting a domain model object tree together run into problems when dealing with integers that are passed as strings. Issue-ID: POLICY-2577 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I06a2b6e8dc7e0442c2503b6d978deddbf652d830 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-06-10reduce sonar issue - drools-pdpTaka Cho4-10/+10
remove unused import rename the method name Issue-ID: POLICY-2616 Change-Id: I15845159063ec5fa3cfb34a59b9c433ba3201ccc Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-09reduce sonar issueTaka Cho3-40/+42
In some conditions for assertTrue, sonarcloud recommends using assertEquals Assert.assertTrue(a.equals(b)); Assert.assertTrue(a == b); Assert.assertTrue(a == null); Assert.assertTrue(a != null); Assert.assertFalse(a.equals(b)); Compliant Solution Assert.assertEquals(a, b); Assert.assertSame(a, b); Assert.assertNull(a); Assert.assertNotNull(a); Assert.assertNotEquals(a, b); Issue-ID: POLICY-2616 Change-Id: I6a4b0ac76c0816a8d4bf1914dc96210d20cdff03 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-09Merge "Change metrics and transactions layout in logback.xml"Jorge Hernandez5-16/+136
2020-06-05Change metrics and transactions layout in logback.xmlJoseph Chou5-16/+136
Update logging code to compliant with logging standard Issue-ID: POLICY-2578 Change-Id: I98decce81eae95c006d6485bf3440ac9119b2bf5 Signed-off-by: Joseph Chou <jc2555@att.com>
2020-05-28Point to parent SNAPSHOTPamela Dragosh1-1/+1
Issue-ID: POLICY-2319 Change-Id: I9332186e1a163eda1386a41750ae4a5718debba1 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-05-27Use snapshot versionsJim Hahn1-2/+2
Issue-ID: POLICY-1526 Change-Id: Id2d6a737c3481f7ecaac7343ffcdcd58bc2493fc Signed-off-by: Jim Hahn <jrh3@att.com>
2020-05-26Tests must specify serialization providerJim Hahn2-1/+12
When GSON is made the default serialization provider, several junits break. Modified them to specify the GsonJackson provider, which is what the REST classes use in production. Issue-ID: POLICY-1526 Change-Id: If1bcb955d7411cf747a14a0bf1dc069b02e2f2ea Signed-off-by: Jim Hahn <jrh3@att.com>
2020-05-21Bump Drools-Pdp to 1.7.0aditya.puthuparambil27-28/+28
Issue-ID: POLICY-2514 Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech> Change-Id: Ib18f045a621ce15f8381607ba87639dd188887e5
2020-05-21Bump Drools-Pdp to 1.6.4aditya.puthuparambil27-27/+27
Issue-ID: POLICY-2514 Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech> Change-Id: Icb874f6b91488c5003e9d22460ce57e37b11dc30
2020-05-20release docker container6.0.0-ONAPjhh1-0/+8
Issue-ID: POLICY-2514 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ic20bfc53e3216290fc2a75158b2ccd6fdd87863b
2020-05-20Release Drools-Pdp 1.6.3 javaaditya.puthuparambil1-0/+4
Issue-ID: POLICY-2514 Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech> Change-Id: I8dbb9269ebdaa906e19a05efcc4a588164b06667
2020-05-19Merge "Point to released artifacts"Ram Krishna Verma1-3/+3
2020-05-19Point to released artifactsPamela Dragosh1-3/+3
Issue-ID: POLICY-2514 Change-Id: Idf97f7bd6308e954deaa40d33147025dfdac2268 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-05-15Reduce Sonar complaints in 'feature-server-pool'Straubs, Ralph (rs8887)13-1098/+1155
Issue-ID: POLICY-2546 Change-Id: Ibddde78d705349b3c8510678f25dfce817b1a091 Signed-off-by: Straubs, Ralph (rs8887) <rs8887@att.com>
2020-04-24Bump drools-pdp 1.6.3-SNAPSHOTPamela Dragosh27-30/+30
Issue-ID: POLICY-2510 Change-Id: Ic6ce8069e65c9b7606ab3529ee6291bc772a4191 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-24Release drools-pdp 1.6.2 docker imagePamela Dragosh1-0/+8
Issue-ID: POLICY-2510 Change-Id: I31213a695e2fdaf9ae83a1b63e9bc435a7192809 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-24Release drools-pdp 1.6.2 javaPamela Dragosh1-0/+4
Issue-ID: POLICY-2510 Change-Id: I7c9a32c61cc88bca072f035526c16b5019d29e84 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-24Point drools-pdp and release modelsJim Hahn1-1/+1
Issue-ID: POLICY-2510 Change-Id: I86db56cc373269b97822f9e243a189b9272a394e Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-16relax optional 'description' to also allow emptyjhh1-3/+2
description is an optional field, CLAMP users, may not populate it and send an empty string value description: '' This change removes the requirement to be a non-empty string when present. Issue-ID: POLICY-2503 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I0c80368b5b6aa5fe5b1c25516cb9ba0a677d7b9a
2020-04-16Point to new models version in drools-pdpJim Hahn1-1/+1
Issue-ID: POLICY-2501 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I028ad6f018aec4a41810273f597c631983b88052
2020-04-14bump to 1.6.2-SNAPSHOTjhh27-27/+27
Issue-ID: POLICY-2378 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I75d0acdc4bfb4f2c1870d3c01591e81ada2b7a5f
2020-04-14release 1.6.1 docker imagejhh1-0/+8
Issue-ID: POLICY-2378 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I52b40e034427237387d8bc66da6ae10e4878ddda
2020-04-14release 1.6.1 artifactsjhh1-0/+4
Issue-ID: POLICY-2378 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I5de39953b359b0afca71195f7876f44c33997942
2020-04-14Merge "Point to released common/models"Jorge Hernandez1-2/+2
2020-04-14Point to released common/modelsPamela Dragosh1-2/+2
Issue-ID: POLICY-2378 Change-Id: Iba4bac51ab85ba14ac3c28d74b1fa99a49bd8480 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-14native controller generates invalid propertiesjhh6-36/+166
Additional instrumetation and tests have been added as well. Issue-ID: POLICY-2489 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I65df586f3a44acf3d6f825ebfb8bd73107255a1f Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-04-13Point to fix common/modelsPamela Dragosh1-2/+2
Fixed naming policy string and yaml coder string fix Issue-ID: POLICY-2486 Change-Id: I77dc1593a0d4c744090aa7b89303ea5e76d36ead Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-11Point to released parent, common, modelsPamela Dragosh1-3/+3
Issue-ID: POLICY-2378 Change-Id: Ic80fe0334919361f973c7ae7796c5d8868882fcb Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-09Disable sonar main args for drools-pdpJim Hahn1-1/+6
Issue-ID: POLICY-2305 Change-Id: If056c7e9179e245fafd6badc70ff9eee78fb23b3 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-08Address more sonar issues in drools-pdpJim Hahn4-13/+22
Addressed the following sonar issues: - use of "synchronized" - use Files.delete() instead of File.delete() Issue-ID: POLICY-2305 Change-Id: Id55628fe12d9d764616e57321382a70cb5704ba1 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-08Merge "Address sonar issues in policy-management"Jim Hahn26-184/+191
2020-04-07Address sonar issues in policy-managementJim Hahn26-184/+191
Addressed the following sonar issues: - modified code to specify the correct class name in the getLogger() call - use equals() instead of "==" for string comparison - remove deprecated code - use ',' instead of "," in indexOf - remove code that is commented out; typically bogus, so the comment was adjusted to satisfy sonar - missing assert in junits - use "{}" instead of concatenation when using logger - either log or rethrow - put arguments for assertEquals() in the correct order - remove "return" statements from the end of void methods - don't always return the same value; just disabled sonar as refactoring would have obfuscated the code - cognitive complexity; used eclipse auto-refactoring to extract out chunks of code into separate methods - don't pass array of classes to class.getDeclaredMethod(); use ellided arguments instead - fix argument count in logger calls - remove unnecessary casts - don't use "volatile" - make methods "synchronized" to match parent class definitions Issue-ID: POLICY-2305 Change-Id: Ie96418f696da4ae6c2ca8d4a914371469e695419 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-06Address sonar issues in drools-pdpJim Hahn59-300/+324
Addressed the following sonar issues: - add "final" to public static fields - commented code; some were bogus - just updated the comments so sonar is happy - use "{}" instead of string concatenation - junit should assert something - when using logger, invoke compute-intensive tasks conditionally - use superclass name instead of subclass name to access static fields - don't always return the same value - remove "transient" from fields of classes that aren't Serializable - don't nest try/catch blocks - use appropriate class name in Logger.getLogger() - use Predicate<T> instead of Function<T,Boolean> - remove unused parameters from private methods - either log or throw - remove duplicate methods - use remove() TLS instead of set(null) - null check is implicit in instanceof check - do something with return value - don't use volatile - don't return "null" list; used Optional instead - add no-arg constructor to non-Serializable superclass - add callSuper=true for EqualsAndHashCode - don't declare "throws XXX" where XXX is a subclass of RuntimeException - remove serialVersionUID field if the class isn't Serializable Also addressed some eclipse warnings: - unused fields - suppress generic typic cast warnings Issue-ID: POLICY-2305 Change-Id: I906d5bf71c1f86531423e23b3667a585cdba45e1 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-01Sync controller capabilities as controllers bouncejhh10-99/+534
As native policies introduce temporality in policy types supported as they are removed and added, the associated policy types that can be honored at a a given time, may need to adjust. A significan portion of this review is dedicated to multi-policy junits and telemetry instrumentation. Issue-ID: POLICY-2459 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I62bbc03411446849eaa55c9b1524220dc13c2cb0 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-03-27Merge "Point to latest snapshots"Pamela Dragosh1-2/+2
2020-03-27Point to latest snapshotsPamela Dragosh1-2/+2
Issue-ID: POLICY-2378 Change-Id: I20672bed90931ff9d3cac5f63c238248f8b39406 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-27Merge "native policy use engine for top-down processing"Jorge Hernandez6-49/+116
2020-03-26native policy use engine for top-down processingjhh6-49/+116
This will ensure proper invocation of all feature hooks. Issue-ID: POLICY-2388 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I8d1666bb5e9526faa588e4f613674e080181d4ba Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-03-26Merge "Upgrade jar version to resolve security risk"Jim Hahn3-2/+12
2020-03-25Point to models 2.2.2Pamela Dragosh1-1/+1
Issue-ID: POLICY-2378 Change-Id: Ie8671969f79fc1e2ce767cd4ab9a426eddea5d55 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-25Upgrade jar version to resolve security riskJoseph Chou3-2/+12
Upgrade ant, hibernate-core and commons-configuration Issue-ID: POLICY-2439 Change-Id: I6c22e634e81850ed97c6214ffc202eb68007b8b3 Signed-off-by: Joseph Chou <jc2555@att.com>
2020-03-25remove temp. sudo accessjhh1-2/+0
Issue-ID: POLICY-2370 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I221fb5887d280536fbfef120b0a2cf41813684fc
2020-03-24Bump drools-pdp to 1.6.1-SNAPSHOTPeyton Puckett27-27/+27
Issue-ID: POLICY-2378 Change-Id: I59fb1860178cc7960f7aa553557d83d60b686ac6 Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
2020-03-24Release 1.6.0 drools-pdp docker imagePeyton Puckett1-0/+8
Issue-ID: POLICY-2378 Change-Id: I0408fbf5ff5883a7661329ba28420a773b475f49 Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
2020-03-24Release 1.6.0 drools-pdp artifactsPeyton Puckett1-0/+4
Issue-ID: POLICY-2378 Change-Id: I510fec491f1952e2312e4a018a22d4d3bd2db53c Signed-off-by: Peyton Puckett <peyton.puckett@att.com>