summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-07-09Release policy/drools-pdp1.7.0jenkins-releng26-26/+26
2020-07-09point to release parent, common and modelTaka Cho1-3/+3
release 1.7.0 Issue-ID: POLICY-270 Change-Id: I4975883ef85ab99345d7f9f32bbc72c091c0573a Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-07-06Merge "Checkstyle fixes to drools-pdp"Ram Krishna Verma3-12/+9
2020-07-06Merge "Use apache Triple"Ram Krishna Verma6-227/+79
2020-07-06Merge "sonar fix for TargetLock"Jorge Hernandez1-20/+19
2020-07-06Checkstyle fixes to drools-pdpJim Hahn3-12/+9
Issue-ID: POLICY-2696 Change-Id: I7f80737c52e3f16e03803118d92411e4ac39c5fb Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-06Use apache TripleHAHN III6-227/+79
Replaced policy-utils/Triple with apache Triple. Issue-ID: POLICY-2694 Change-Id: I160f90c03f18b7da8dec5d0a00f809bcfb29680b Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-06sonar fix for TargetLockTaka Cho1-20/+19
- duplicating strings to constant - to not log tainted, user-controlled data. Issue-ID: POLICY-2616 Change-Id: Iaa9dd9f9ef839cec58ae60d8464b889a02b8ddb5 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-07-02drools-pdp sonar fixTaka Cho7-37/+39
most of changes are assert statement Issue-ID: POLICY-2616 Change-Id: I3bd3076115d28d8cfabcbe0859cc4b21085e1394 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-07-02Merge "Updating drools pdp dependencies"Jorge Hernandez5-17/+20
2020-07-01Updating drools pdp dependenciesRossC5-17/+20
Issue-ID: POLICY-2387 Change-Id: I5fe17c2514aed5c595d4e2a3d95fbb210a6f229b Signed-off-by: RossC <ross.carter@est.tech>
2020-06-30sonar fix for feature server poolTaka Cho2-50/+67
- reduce cognitive complexity - return a boolean value - Replace this lambda with a method reference - use lombok annotation @EqualsAndHashcode - removed unnecessary exception Issue-ID: POLICY-2616 Change-Id: Ia0c300c2909bbdd232f2a3c758a5709b70f06d1c Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-29Merge "feature-eelf: eelf-core from: 1.0.0 -> 2.0.0-oss"Jim Hahn3-3/+8
2020-06-29Merge "Clean up of Pair classes - drools-pdp"Jim Hahn12-327/+184
2020-06-29feature-eelf: eelf-core from: 1.0.0 -> 2.0.0-ossjhh3-3/+8
Issue-ID: POLICY-2387 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I29d4f07d990797a470bce0898ca67741974f1c00 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-06-29Merge "sonar fix - FeatureServerPool"Jim Hahn1-10/+5
2020-06-29Clean up of Pair classes - drools-pdpwaynedunican12-327/+184
Removed Pair class from drools-pdp and replaced with Apache Common Pair class Issue-ID: POLICY-2202 Change-Id: Ica2a5b734fb6eebfc0713027c1c4dc3b8d3882c8 Signed-off-by: waynedunican <wayne.dunican@est.tech>
2020-06-26Merge "replace an emptyArray and computeIfAbsent instead"Ram Krishna Verma1-24/+13
2020-06-26override central repo with right repositoryjhh1-3/+24
This is to prevent that other poms setting the repository http://repo2.maven.org, which has been decommissioned. The repo1.maven.org is the one to be used, only with https. Issue-ID: POLICY-2677 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I743014ea553f5df829eb0bd7ada2cb3d1fb842bf
2020-06-26replace an emptyArray and computeIfAbsent insteadTaka Cho1-24/+13
- some methods should return an empty array. - avoid the result of a java.util.Map.get() against null before proceeding with adding or changing the value in the map. - Declaring a variable only to immediately return or throw it is a bad practice. Issue-ID: POLICY-2616 Change-Id: I21a55c5ea716d8f64dc9155f84cabcfbcf5a22e0 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-26sonar fix - FeatureServerPoolTaka Cho1-10/+5
- sonar thinks one block of comments are code, so changed some syntax in comments - not more than one break or continue statement Issue-ID: POLICY-2616 Change-Id: Ia35b73584f5a8492320c4beaa069ba7f903ce268 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-26feature server Keyword sonar fixTaka Cho1-10/+15
- remove unnecessary cast - A "NullPointerException" could be thrown; "last" is nullable here - regexp method name - remove curly braces and 'return' Issue-ID: POLICY-2616 Change-Id: Icd6ab0cf1f77cdc8cf1bffb3ae2781702add9ab5 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-26Merge "replace Thread sleep with Awaitility"Jim Hahn2-4/+2
2020-06-25replace Thread sleep with AwaitilityTaka Cho2-4/+2
- use '{}' for logger msg - sonar suggest using use libraries Awaitility for asynchroneous testing Issue-ID: POLICY-2616 Change-Id: I09828cdb9467235403f299c6419e8560ca21aefd Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-25Merge "Upgrade hibernate to clear dom4j sonatype"Pamela Dragosh1-1/+1
2020-06-25Upgrade hibernate to clear dom4j sonatypePamela Dragosh1-1/+1
dom4j 1.3.1 has sonatype issue, 1.3.3 fixed it. hibernate is the dependency that pulls in dom4j, upgrading to latest patch will pull in the fixed dom4j. Issue-ID: POLICY-2675 Change-Id: Ibb80fa7c96df42322bd3dc6c7a1d1d81deb365ab Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-06-24fix sonar issue - feature-serverTaka Cho2-17/+18
- A field should not duplicate the name of its containing class - Invoke method(s) only conditionally - add equals and hashcode - some leftover changes for %n Issue-ID: POLICY-2616 Change-Id: Icc094c17245e6a163d1158d97890579d76b84aec Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-23Merge "need Override equals and hashCode method"Pamela Dragosh1-0/+17
2020-06-23Merge "fix sonar - feature-server"Pamela Dragosh1-5/+5
2020-06-23fix sonar - feature-serverTaka Cho1-5/+5
%n is portable across platforms \n is not. Issue-ID: POLICY-2616 Change-Id: I6daa827b93384c8b25dcb58b87fff116d09a2176 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-22need Override equals and hashCode methodTaka Cho1-0/+17
Use eclipse to generate those two Overrides in order to avoid sonar issue Issue-ID: POLICY-2616 Change-Id: If7e887b99fa44dac5ac5fa6f8c8cfe677238576d Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-22reduce sonar issue - feature-serverTaka Cho1-23/+21
Remove useless curly braces around statement Rename the method name change to '<>' Issue-ID: POLICY-2616 Change-Id: I679ce7e44b1a8c2c30f78820c12f91f18e5aa944 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-22removed unused methods parameterTaka Cho2-3/+2
Unused parameters are misleading. Whatever the values passed to such parameters, the behavior will be the same. Issue-ID: POLICY-2616 Change-Id: I9a595dca81ce061846fa53adf8086130ffd31a74 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-21Removing log4j from feature-state-management/pom.xmlUtkarsh Jauhari1-5/+0
Issue-ID: POLICY-2623 Signed-off-by: Utkarsh Jauhari <uj426b@att.com> Change-Id: I5f9e7b67ce39177c4f7211ea0e30d78bc7a95cc3
2020-06-19Address checkstyle version issues in drools-pdpJim Hahn72-403/+327
Also added serializationId to several classes to address eclipse warnings. Issue-ID: POLICY-2188 Change-Id: I3df5e8abaad8da9261c0d5cd19a93ed68dceb870 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-19Merge "drools-pdp sonar issue fixes"Ram Krishna Verma7-46/+46
2020-06-19drools-pdp sonar issue fixesTaka Cho7-46/+46
fix all assert statements to comply with sonar issue Issue-ID: POLICY-2616 Change-Id: Ia36e3eab7c74d8dfb1ab3fa1395b1f64b173e09a Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-18equals and hashCode should be overridden in pairsTaka Cho1-18/+2
hashCode should be overridden in pairs. followed by Effective Java: You must override hashCode() in every class that overrides equals(). Failure to do so will result in a violation of the general contract for Object.hashCode(), which will prevent your class from functioning properly in conjunction with all hash-based collections, including HashMap, HashSet, and Hashtable. Issue-ID: POLICY-2616 Change-Id: I2b29722daab5c520547397aae68d8ebaa71b2c4b Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-16Merge "reduce sonar issue - 2 rev"Liam Fallon5-26/+31
2020-06-15reduce sonar issue - 2 revTaka Cho5-26/+31
In some conditions for assertTrue, sonarcloud recommends using assertEquals Assert.assertTrue(a.equals(b)); Assert.assertTrue(a == b); Assert.assertTrue(a == null); Assert.assertTrue(a != null); Assert.assertFalse(a.equals(b)); Compliant Solution Assert.assertEquals(a, b); Assert.assertSame(a, b); Assert.assertNull(a); Assert.assertNotNull(a); Assert.assertNotEquals(a, b); Issue-ID: POLICY-2616 Change-Id: Ib362573bd865d1b561916bf64640c8ddeaa02546 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-11Merge "do strict validation before domain conversion"Pamela Dragosh3-5/+58
2020-06-10do strict validation before domain conversionjhh3-5/+58
need to perform a validation pass as the validation combined with putting a domain model object tree together run into problems when dealing with integers that are passed as strings. Issue-ID: POLICY-2577 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I06a2b6e8dc7e0442c2503b6d978deddbf652d830 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-06-10reduce sonar issue - drools-pdpTaka Cho4-10/+10
remove unused import rename the method name Issue-ID: POLICY-2616 Change-Id: I15845159063ec5fa3cfb34a59b9c433ba3201ccc Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-09reduce sonar issueTaka Cho3-40/+42
In some conditions for assertTrue, sonarcloud recommends using assertEquals Assert.assertTrue(a.equals(b)); Assert.assertTrue(a == b); Assert.assertTrue(a == null); Assert.assertTrue(a != null); Assert.assertFalse(a.equals(b)); Compliant Solution Assert.assertEquals(a, b); Assert.assertSame(a, b); Assert.assertNull(a); Assert.assertNotNull(a); Assert.assertNotEquals(a, b); Issue-ID: POLICY-2616 Change-Id: I6a4b0ac76c0816a8d4bf1914dc96210d20cdff03 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-09Merge "Change metrics and transactions layout in logback.xml"Jorge Hernandez5-16/+136
2020-06-05Change metrics and transactions layout in logback.xmlJoseph Chou5-16/+136
Update logging code to compliant with logging standard Issue-ID: POLICY-2578 Change-Id: I98decce81eae95c006d6485bf3440ac9119b2bf5 Signed-off-by: Joseph Chou <jc2555@att.com>
2020-05-28Point to parent SNAPSHOTPamela Dragosh1-1/+1
Issue-ID: POLICY-2319 Change-Id: I9332186e1a163eda1386a41750ae4a5718debba1 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-05-27Use snapshot versionsJim Hahn1-2/+2
Issue-ID: POLICY-1526 Change-Id: Id2d6a737c3481f7ecaac7343ffcdcd58bc2493fc Signed-off-by: Jim Hahn <jrh3@att.com>
2020-05-26Tests must specify serialization providerJim Hahn2-1/+12
When GSON is made the default serialization provider, several junits break. Modified them to specify the GsonJackson provider, which is what the REST classes use in production. Issue-ID: POLICY-1526 Change-Id: If1bcb955d7411cf747a14a0bf1dc069b02e2f2ea Signed-off-by: Jim Hahn <jrh3@att.com>
2020-05-21Bump Drools-Pdp to 1.7.0aditya.puthuparambil27-28/+28
Issue-ID: POLICY-2514 Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech> Change-Id: Ib18f045a621ce15f8381607ba87639dd188887e5