Age | Commit message (Collapse) | Author | Files | Lines |
|
Issue-ID: POLICY-2839
Change-Id: I6110baaf281b82cbbfc384693dd5dc30c6c6d19b
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Addressed the following sonar issues:
- extract common test method
- too many assertions in test method
- don't always return the same value
Issue-ID: POLICY-2616
Change-Id: Iab836cdcd667b35e2db9db7d6ffc7896df33e1c8
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2827
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: If74e7eeb0ab8ff35accbfddb719bd477cd889b06
|
|
Addressed the following sonars:
- move fields from "interface" to "class"
- don't always return the same value
- remove commented-out code
- make constants "final"
- don't synchronize on parameters
Issue-ID: POLICY-2546
Change-Id: If2d410664d956a7efabf3a4dbef96bbf7d24de5e
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2819
Change-Id: I5722330bff9c37ee9dd89d3fce0bd7fbdf975f1b
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed deploy-artifacts to strip carriage returns from pom.properties
files before attempting to extract variables from them.
Switched to using 'sed' instead of dos2unix.
Issue-ID: POLICY-2823
Change-Id: I1114af13a3262e49b87fb270d5c78cda4de9e5c9
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I0fb5ead444c23882454e3a48efea9d936a84e455
|
|
Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I4271ce650490afbe9023f71f6c0ced0194e8d624
|
|
Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I807f85c5ab4398146ddb50a5942623a49eadbd26
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I9ecd6b7d5cc741be5ed304d4a2a181f47c25a391
|
|
In G-rel, using 2.1.0 base.
Issue-ID: POLICY-2789
Change-Id: I3b0b3d98b8915d7e45ec1231f41a7b97836d80c1
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Fixed more sonars in drools-pdp:
- remove commented code
- don't throw generic Exception
- unused field (made it protected instead of private)
- log conditionally
- cognitive complexity
- too many break/continue
- return empty list instead of null
- Random() is not secure
Fixed more eclipse warnings:
- parameterize generic types
Issue-ID: POLICY-2616-sonars3
Change-Id: Ia5ad769b2ea763568cfae3d81807926d89153b09
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Addressed the following sonars in feature-server-pool:
- re-interrupt after catching an InterruptException
- reduce cognitive complexity
- cognitive complexity
- not enough arguments for logger message
- use UnaryOperator instead of Function
- update static fields via static methods
- too many break/continue in for-loop
Also fixed some Eclipse warnings:
- add parameter to generic types
- useless assignments
- newInstance() has been deprecated
- close streams
Issue-ID: POLICY-2616
Change-Id: Ibf6c20e6c2a7eb8c60e1b38f388d86a0f9b8804b
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed sonar issue:
- Refactor the code of the lambda to have only one invocation throwing
an exception
Issue-ID: POLICY-2616
Change-Id: I8d96b95d0da9a780daacec7a4de17167642b03c1
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Policy parent has this declaration to the latest 2.7
version of commons-io which fixes a sonatype security
issue. There is no reason that drools-pdp should be
declaring this.
Issue-ID: POLICY-2798
Change-Id: Ie7dbe14458be4ead395dfcbebbc1c0cd3ccc4ea6
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Addressed the following sonars:
- either log or rethrow
- call "remove()" for thread-local-storage
- use assertEquals
- only one method call in exception test
- swap arguments in assertEquals
- add assertion to assertThatThrownBy()
- explain @Ignore
Also addressed eclipse warnings:
- unused fields and methods
Issue-ID: POLICY-2616
Change-Id: I6590c0d2b103885bc933014d48bf5fd92401cd80
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Status messages to the PAP won't be send until
all mandatory resources specified in the
lifecycle.pdp.policytypes property are functional.
Issue-ID: POLICY-2669
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ia9d4c678fcfbdb232059d0827235845ee11f1201
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
It follows the same approach that in other policy
components by throwing a runtime-exception vs
System.exit(x).
Issue-ID: POLICY-2752
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iba508fc7095b060373742849e394c8fdd2a2334f
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
|
|
moving to alpine-jdk base for
drool-pdp apps
csit drools/apps tested in windriver labs:
http://10.12.6.96:8080/tmp/tmp.yxBE30uD1m-robot-workdir/report.html
1, httpie has to install via apk
2, http-prompt has to install via pip
Issue-ID: POLICY-2787
Change-Id: I3d1bd86c7c2c3c48e9ac2a823b988bb9b1bdf98f
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Issue-ID: POLICY-2765
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I6066b8040add53ed32572a71854f3f7094bc41d6
|
|
Verified with Jessica W that the "type" should still be "Addition",
even when updating the PTL.
Updated to Mature, per TSC.
Issue-ID: POLICY-2738
Change-Id: I3a90f3dff643f89cc5eba3a46ba4570dc756bfef
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Issue-ID: POLICY-1528
Change-Id: I9b4054cbfd41ec1abe61d6fe459ebb29adaa7a45
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2738
Change-Id: Ib40ad93e6c0562fa60c99c9c6eff5072e355c062
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
property"
|
|
It provides a feature base to allow for custom Policy
and Drools Controllers.
Issue-ID: POLICY-2415
Change-Id: Ibe3f11e3ecd925537ffd03d2420bb3b8214029c9
Signed-off-by: Straubs, Ralph (rs8887) <rs8887@att.com>
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Issue-ID: POLICY-1528
Change-Id: I616c48d62c63f8f213ec012f8746509471c38f89
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2695
Change-Id: I65fb75dda4dd26a54c593ecb26d7e0950a59e27c
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Issue-ID: POLICY-2673
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I5b3bbc36ea33c30625119a9e624b68c82a91b634
|
|
|
|
Issue-ID: POLICY-2673
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I0a08a2760e4dc5a61a59c7f0f3096db76d42cc29
|
|
|
|
Issue-ID: POLICY-2709
Change-Id: Ifb6232eb428e2cd9c729fef54862779b2ee55bbc
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Issue-ID: POLICY-2695
Change-Id: I250bd36079484f9869f39ec000347c106384ebaf
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Issue-ID: POLICY-2709
Change-Id: Ide08c4847a7c41bcb76b6009be59be7ec3621191
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
release 1.7.0
Issue-ID: POLICY-270
Change-Id: I4975883ef85ab99345d7f9f32bbc72c091c0573a
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
- move to a method for nest try and catch
- fixed some typos in comments
- use constant for the same String
- boolean method should be checked
- removed unnecessary exceptions
Issue-ID: POLICY-2616
Change-Id: I647ee095171feedfd44ca6967676f61842c2c91b
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
|
|
|
|
|
|
Issue-ID: POLICY-2696
Change-Id: I7f80737c52e3f16e03803118d92411e4ac39c5fb
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Replaced policy-utils/Triple with apache Triple.
Issue-ID: POLICY-2694
Change-Id: I160f90c03f18b7da8dec5d0a00f809bcfb29680b
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
- duplicating strings to constant
- to not log tainted, user-controlled data.
Issue-ID: POLICY-2616
Change-Id: Iaa9dd9f9ef839cec58ae60d8464b889a02b8ddb5
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
most of changes are assert statement
Issue-ID: POLICY-2616
Change-Id: I3bd3076115d28d8cfabcbe0859cc4b21085e1394
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
|
|
Issue-ID: POLICY-2387
Change-Id: I5fe17c2514aed5c595d4e2a3d95fbb210a6f229b
Signed-off-by: RossC <ross.carter@est.tech>
|
|
- reduce cognitive complexity
- return a boolean value
- Replace this lambda with a method reference
- use lombok annotation @EqualsAndHashcode
- removed unnecessary exception
Issue-ID: POLICY-2616
Change-Id: Ia0c300c2909bbdd232f2a3c758a5709b70f06d1c
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
|