summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-05-11[POLICY-12] clean policy-persistence mod warningsJorge Hernandez8-33/+9
Takes care of the following warnings: --IntegrityAuditIntegrationTest.java import org.junit.Ignore is never used import org.openecomp.policy.common.im.AdministrativeStateException is never used import org.openecomp.policy.common.im.IntegrityMonitor is never used import org.openecomp.policy.common.im.StandbyStatusException is never used import org.openecomp.policy.drools.core.DroolsPDPIntegrityMonitor is never used import org.apache.commons.logging.Log is never used import org.apache.commons.logging.LogFactory is never used value of the field IntegrityAuditIntegrationTest.sleepTime is not used --IntegrityMonitorProperties.java import org.apache.commons.logging.Log is never used import org.apache.commons.logging.LogFactory is never used --StandbyStateManagementTest.java import org.openecomp.policy.drools.system.PolicyEngine is never --RepositoryAudit.java import java.nio.file.FileVisitor is never used import java.util.concurrent.Callable is never used --PMStandbyStateChangeNotifier.java import org.openecomp.policy.drools.controller.internal.MavenDroolsController is never used import org.openecomp.policy.drools.event.comm.TopicEndpoint is never used --DroolsSessionEntity.java The serializable class DroolsSessionEntity does not declare a static final serialVersionUID field of type long --DroolsPdpObject.java Comparable is a raw type. References to generic type Comparable<T> should be parameterized Comparable is a raw type. References to generic type Comparable<T> should be parameterized Type safety: The method compareTo(Object) belongs to the raw type Comparable. References to generic type Comparable<T> should be parameterized --DroolsPdpsElectionHandler.java The value of the local variable lowestPriorityPdp is not used Change-Id: Idd563d74c1d6521f7a3759c441f7fe0597011b67 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2017-05-10[POLICY-12] tackle policy-persistence/DBaudit.javaJorge Hernandez1-0/+5
Deals with the following reports: Description Resource Path Location Type Resource leak: 'statement' is not closed at this location DbAudit.java /policy-persistence/src/main/java/org/openecomp/policy/drools/core line 135 Java Problem Description Resource Path Location Type Resource leak: 'statement' is not closed at this location DbAudit.java /policy-persistence/src/main/java/org/openecomp/policy/drools/core line 142 Java Problem Description Resource Path Location Type Resource leak: 'statement' is not closed at this location DbAudit.java /policy-persistence/src/main/java/org/openecomp/policy/drools/core line 160 Java Problem Change-Id: I16c6698ee9b659add11d3bc62abb38a3d1792049 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2017-05-10[POLICY-11] Fact queries with variables + featuresJorge Hernandez11-60/+436
GET/PUT/DELETE operations through REST API. Report on optional features (modules) attached to the engine. Added javadoc comments in Healthcheck module. Change-Id: Ic8d2c06779dda4024e94ad39bb316211522e4e4c Signed-off-by: Jorge Hernandez <jh1730@att.com>
2017-05-09Batch submitRalph Straubs7-223/+522
[US866186 1710] Add the state_audit_interval_ms to the IntegrityMonitor.properties [US866186 1710] Added comments to the state audit property (state_audit_interval_ms) which clarify how to turn it off. [ECOMPD2TD-000] Update version.properties and pom.xml for iter 41 [ECOMPD2TD-000] Update version.properties and pom.xml for iter 41 Revert "[ECOMPD2TD-000] Update version.properties and pom.xml for iter 41" This reverts commit 61367d4c87fa6b153f707361537d9f802fb95a6e. [US250837 1710] Completed first cut of logic changes to PMStandbyStateChangeNotifier so that each segment of logic is only executed if a state change actually occurred. [US250837 1710] First cut on the JUnit for PMStandbyStateChangeNotifier. At this point I am simply checking the operation by inspecting the logs. [US250837 1710] Fixed the JUnit so it is not failing and added a note on how to run the JUnit. [US250837 1710] Added a method to get previousStandbyStatus from PMStandbyStateChangeHandler and began using it in JUnit tests. [US250837 1710] Finished the StandbyStateManagementTest. This uses the previousStandbyStatus value to test the function. [US250837 1710] Clean up of PMStandbyStateChangeNotifier and JUnit test to make static string values that are used throughout. [US250837 1710] Found a couple strings that I missed when converting to static variables. [US250837 1710] Updated PMStandbyStateChangeNotifier and StandbyStateManagementTest [US250837 1710] Added a dedicated db audit persistence unit auditDroolsPU to taylor the classes which will be audited. [ECOMPD2TD-1309] Clean up old persistence data This is an addition to 'policy-persistence' that cleans up 'sessioninfo' records with a 'lastmodificationdate' that is older than a specified time (default = 900 seconds = 15 minutes). [ECOMPD2TD-000] Correction to pom.xml versions Conflicts: version.properties Change-Id: I810d358c07e05fd36fa435a6fbb9e538e78b5011 Signed-off-by: Ralph Straubs <rs8887@att.com>
2017-05-04[POLICY-11] New REST APIs to obtain facts infoJorge Hernandez11-60/+426
The following REST APIs have been added, shown by example: GET policy/pdp/engine/controllers/<controller-name>/drools : drools information for controller named <controller-name> For brevity in URL description, assume: DROOLS-REL-PATH=policy/pdp/engine/controllers/<controller-name>/drools GET ${DROOLS-REL-PATH}/<session-name>[?count=true] fact classes and count for <session-name> in controller <name> GET ${DROOLS-REL-PATH}/<session-name>/<classname> all fact objects of class <classname> for session <session-name> GET ${DROOLS-REL-PATH}/<session-name>/<query-name>/<query-id> all fact objects returned by drools query named <query-name> for the identifier <query-id> (need corresponding query definition in drl is necessary) Change-Id: I2f62931f54a65eec4ef80472ad1af05f30ed83ba Signed-off-by: Jorge Hernandez <jh1730@att.com>
2017-05-03[POLICY-10] remove external repoPamela Dragosh1-21/+3
Change-Id: Icc2c456757418f3ffa28beba9ed26f933236f08e Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-04-28Change name to show Policy Engine for sonar.Pamela Dragosh1-1/+1
Change-Id: I79865c49e52db4619f481c10f3823e7aa5244dd3 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-04-21Batch submit -- force rebuildRalph Straubs63-5090/+3103
[ECOMPD2TD-1126 1707] Delay the start of the election handler by one more update interval to allow updatedDate to be set and recoginized by other nodes. [ECOMPD2TD-1073 1707] Remove pessimistic locks from DB access to prevent DB deadlock [US867397-policy-management-feature-api] Split original FeatureAPI into three service interfaces. These are: - the original FeatureAPI for core - PolicyControllerFeatureAPI (additional interface methods yet to come ..) - PolicyEngineFeatureAPI (additional interface methods yet to come ..) Additional extensions will be done in the future. This is to have equivalent functionality with what it is already there. [US867397-policy-management-feature-api] Split original FeatureAPI into three service interfaces. These are: - the original FeatureAPI for core - PolicyControllerFeatureAPI (additional interface methods yet to come ..) - PolicyEngineFeatureAPI (additional interface methods yet to come ..) Additional extensions will be done in the future. This is to have equivalent functionality with what it is already there. [ECOMPD2TD-1167] Avoid redundant dependencies and remove obsolete sql scripts [ECOMPD2TD-848] Fix copied from ATT droolspdp repo -- add timestamp to metric and audit logs [ECOMPD2TD-1167] update jetty version to 9.3.14 [ECOMPD2TD-1167] pull in policy-core jar as a dependency of policy-management, instead of zip file [ECOMPD2TD-1159] Add property to ignore repository audit errors The property is called 'repository.audit.ignore.errors' -- it resides in 'IntegrityMonitor.properties', and it defaults to 'true'. When true, any errors that occur in the repository audit are logged, but not reported to integrity monitor. [US867397] additional hooks for policy engine, and support operation take over by feature bypassing further feature processing [US867397] additional hooks for policy engine, and support operation take over by feature bypassing further feature processing [US867397] fix reverse return javadoc comment [ECOMPD2TD-1192] Select correct persistent session information This is a modification to 'DroolsPdpsElectionHandler.DesignatedWaiter'. When going active, the list of persistent sessions needs to come from the most recent active DroolsPDP. The most recent active DroolsPDP is tracked in a local variable 'mostRecentPrimary', and the associated list of sessions needs to be extracted just prior to going active. The problem was that the list of sessions was extracted after the current DroolsPDP was set to 'mostRecentPrimary'. [ECOMPD2TD-1073 1707] Remove pessimistic locks from DB access to prevent DB deadlock [US860546] Add workaround for missing logger in message router [US860546] add DME2 properties to PolicyProperties [US860546] add DME2 support, pending unit testing [US860546] updated unit tests for dmaap/DME2 [US860546] removed System.out.println lines from BusConsumer and BusPublisher [US860546] modifications and additions to TopicEndpoint tests [US860546] remove block to append /events to serviceName in BusConsumer, BusPublisher [US860546] removing dmaap unit tests with ATT references [ECOMPD2TD-1167] Audit release repository by default [ECOMPD2TD-000] Cherry-pick versioning fixes from 1707.39.1 release branch [ECOMPD2TD-000] Fix policy-endpoints cambriaClient version [US865296] ECOMP Policy Logging Compliance, remove redundant timestamp from metric and audit log for logging compliance [US865296] ECOMP Policy Logging Compliance, remove TargetVirtualEntity from audit log, provide name to un-used column [US865296] ECOMP Policy Logging Compliance, remove Unused from AuditLogPattern, leave the column blank means un-used. [US000000] Cleanup and performance improvements 1) Changed 'OrderedServiceImpl' to ensure that the same service instance is used in every queue. This gets around the 'ServiceLoader' behavior that generates a new instance for each interface the service implements. 2) In 'PolicySession': add adaptive poll times within Drools sessions. Instead of always polling every 5 seconds, poll frequency increases when rules fire, and decreases when they don't. At present, the poll delay ranges from 100 milliseconds to 5 seconds, but at some point, it would be nice to make this configurable. 3) In 'PolicySession': add tests for 'logger.isDebugEnabled()' in session listener methods -- this results in a significant amount of real-time savings under load. [ECOMPD2TD-1126 1707] Changes to the election handler to deal with situations (race conditions) which can affect the site choice [ECOMPD2TD-1126 1707] Clean up of site afinity logic. Minor changes and a fix of the case where all pdpd are designated or all are hot standby. [ECOMPD2TD-1126 1707] Fixed issue with election handler and got all StandbyStateManagmentTest JUnits working. [ECOMPD2TD-1126 1707] Hopefully final changes to DroolsPdpsElectionHandler and StateManagementTest. Also removed the ResiliencyTestCases since they were redundant. [ECOMPD2TD-1126 1707] Found a minor bug in the computeMostRecentPrimary algorithm which I corrected and added a JUnit to confirm. [ECOMPD2TD-1126 1707] Removed code that was commented out of election handler to improve reability. Added an explanatory note to StandbyStateManagementTest. [US869183] Convert integrity monitor test endpoint to use HttpServletServer [US869183] add swagger-maven-plugin, update swagger annotation for IM test interface [US860371] Modified existing Dmaap and Ueb code to allow for https connectivity. HTTP/HTTPS is configurable via controller.properties file [US860520] Removed extra useHttps() method call from BusConsumer class where the consumer should be using http. Also, restored pom.xml to version at time feature branch was created. [US860520] Removed TopicEndpointTest.java. Added the ability to configure use of self-signed certificates for consumer topics. Functionality cannot be added for publisher at this time. Removed useHttps parameter field from multiple .builder methods to allow for greater ability to build source/sink objects without specifying http vs https connectivity. Other code cleanup and comments [US860520] -Deleted sys.out statements used in testing from BusConsumer/BusPublisher -Moved setProps method outside of if/else stub in BusConsumer -Could not add useHttps or selfSignedCerts to toString methods in BusConsumer -Move setProperty(contenttype, app/json) call outside of if/else branch in BusPublisher -Renamed doesAllowSelfSignedCerts method to is isAllowSelfSignedCerts and moved to BusTopicBase -Moved allowSelfSignedCerts member variable to BusTopicBase class. BusTopicBase is ancestor of SingleThreadedDmapp*/SingleThreadedUeb*/SingleThreadedBus* classes therefore, it will be inherited. -This changed resulted in cascading changes to the subclasses of BusTopicbase -Default is now set to disallow self-signed certs -Added several javadoc param annotations [US869183 1707] Changes to satisfy dependencies and correct pom syntax [ECOMPD2TD-1280] move DroolsPDPIntegrityMonitor.RestManager to its own class [ECOMPD2TD-1278] Resolve duplicate dependency issues (cherry-pick from 1707.40.1) [ECOMPD2TD-1278] revert cambriaClient back to 0.0.1 [ECOMPD2TD-1278] put dmaap version back to 0.2.12 [ECOMPD2TD-1280 1707] Fix Commons-lang3 version and common-modules version Conflicts: policy-endpoints/pom.xml policy-healthcheck/pom.xml policy-persistence/pom.xml pom.xml Change-Id: I803554bc64c55d2e82a3d6ad9120757f287144fb Signed-off-by: Ralph Straubs <rs8887@att.com>
2017-04-12Allow push on custom repoAnaël Closson1-5/+8
Current configuration doesn't give the possibility to fully change where the artifacts should be pushed. This blocks the possibility to push artifacts to a custom repository outside of the LF Change-Id: I573ac8a05b380801b8c6034097ce1e9af18d811c Signed-off-by: Anaël Closson <ac2550@intl.att.com>
2017-04-10javadoc detailsPamela Dragosh1-2/+36
Change-Id: I0d120d4439d9304fa66bf610488c03fdbf3e03c4 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-03-30update to ONAPPamela Dragosh2-2/+2
Change-Id: I70594f85eff2b3b0c5091e1c66f399e7140bcccf Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-03-15fix version.properties to 1.1.0Pamela Dragosh1-1/+1
Change-Id: I23b58deb92198d5ef6ff59858a73304af85d1195 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-03-101.1.0-SNAPSHOTPamela Dragosh10-20/+20
Change-Id: I2289242f6542657c7d69cfe57b20f2e10178caf6 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-03-10upgrade to release-1.0.0Pamela Dragosh10-21/+20
Change-Id: I3fda7cab8bf56d5359dab353e0834874cfed4c94 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-02-23added missing versionPamela Dragosh1-0/+1
Change-Id: Ieb14f966a8393ca3485f58c37f76f0b999a195d1 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-02-23fix pom remove duplicate groupIdPamela Dragosh1-1/+0
Change-Id: I4dc9cda11650f62e3cbd3017205d8d09f5523b7a Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-02-22updating gitignorePamela Dragosh1-0/+2
Change-Id: I0880cbe3560c79c38cc641e44da6e2769f2a870d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-02-22updating gitignorePamela Dragosh1-0/+5
Change-Id: I8eed92eec6f422ce79ecafd1342a5377af8350c5 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-02-17add nexus plugin and reset versionPamela Dragosh2-35/+27
Change-Id: Ie3d674677d18dadcae8b2b97580d4963ff52ed8b Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-02-16forgot nexus propertyPamela Dragosh1-0/+1
Change-Id: Ia958ba7d08bedd171745c0bd2c7322135d0de748 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-02-15added repositories and distribution managementPamela Dragosh1-0/+27
Change-Id: Ice21b292776f432ef70bdcca4e7d14722b905cfb Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-02-14Initial OpenECOMP policy/drools-pdp commitPamela Dragosh203-0/+33981
Change-Id: I0072ccab6f40ed32da39667f9f8523b6d6dad2e2 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-02-14Initial empty repositoryAndrew Grimberg0-0/+0