summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-10-09Regenerate policy keystoreJorge Hernandez1-0/+0
The keystore has been regenerated using the latest tooling from AAF. Previous versions seem to add a bogus " fqdn" which makes the the particular policy.api.simpledemo.onap.org entry invalid. The latest version does not append it. This change is done for consistency with policy/engine for which proper format of this entry is necessary to interact with CLAMP. Drools is never accessed with this identity, therefore the changes are complimentary and do not require release of new artifacts. Change-Id: Ibf6c2e7130dda247ac320f334765e04d369d6b20 Issue-ID: POLICY-1193 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-10-08Add coverage to test-transactionJim Hahn3-26/+470
Fixed bug in test-transaction, wherein it was sometimes using the controller instead of the controller name as the key into the map. Changed test to use latch instead of sleep. Added a little more register/unregister testing. Change-Id: I2647b44cf164038d211063bd499c25af70c2d9d7 Issue-ID: POLICY-1148 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-10-05Add coverage to policy-coreJim Hahn11-138/+391
Added easy junit test coverage cases. Fixed sonar issue: removed sleep from DroolsContainerTest. Fixed sonar bug in ClassExtractors. Change-Id: I942badf17c42346c1735bc3951450fc31c02a769 Issue-ID: POLICY-1148 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-10-05Add junit coverage to PolicyEngine classJim Hahn2-91/+1898
Also fixed a typo in a test comment. Change-Id: I4ad72cc7c103014e6f5920f912c862560af5a331 Issue-ID: POLICY-1148 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-10-04Merge "Add coverage for policy-management"Jorge Hernandez6-42/+1452
2018-10-04Merge "Add more coverage to drools-pdp health check"Pamela Dragosh3-157/+439
2018-10-03Add coverage for policy-managementJim Hahn6-42/+1452
Added coverage for PolicyControllerFactory and AggregatedPolicyController. Fixed some typos in comments. Reformatted some code. Change-Id: I33aea8e1e7dde29bd51218d0ecad7b34047b33e5 Issue-ID: POLICY-1148 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-10-03Add more coverage to drools-pdp health checkJim Hahn3-157/+439
Added getProperties() method to Factory, as the system properties could not be found in the jenkins build, for some reason. Removed Factory, as not needed for junit testing. Change-Id: I5070b9502ae06be6995cccbb005653928591512c Issue-ID: POLICY-1148 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-10-02Merge "Add junit coverage to drools-pdp"Liam Fallon15-52/+609
2018-10-02Recreate latest keystoreJorge Hernandez1-0/+0
Some changes have been made since the first set of stores were generated from the cert manager tooling in the windriver test instance used for this purpose. Change-Id: Ic9a0b056fb2c4e8fb23a0c0e0462087b8b7125da Issue-ID: POLICY-1156 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-10-02Add junit coverage to drools-pdpJim Hahn15-52/+609
Added coverage to distributed locking. Added coverage to test-transaction - still more to do. Added coverage to healthcheck - still more to do. Also fixed "code smell" in pooling. Also fixed "code smell" in session persistence. Fixed typo in comment. Removed unneeded setUp() method from test. Fixed new checkstyle errors. Fixed another new checkstyle error. Change-Id: I0d2ab13fcbd64486af88affb02e114e624c6a3d1 Issue-ID: POLICY-1148 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-10-01Set drools-pdp checkstyle configPamela Dragosh68-1739/+2976
Fixed last remaining checkstyle issues along with setting the pom.xml to the correct path setting. Fixed forbidden summary fragments, not allowed to prepend summary with "This method returns" Issue-ID: POLICY-1153 Change-Id: I267842080494132a7b5507731e14f027a3f6fe44 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-26Use powermock artifacts from parent pomJim Hahn3-39/+0
Change-Id: I0a42dd468b44fc732c526701bb6dd8f8c040233c Issue-ID: POLICY-1148 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-21new sonar issues in drools-pdpJim Hahn4-14/+14
No "@Test" methods - renamed class from XxxTest to XxxMock. Changed functional call syntax. Change-Id: I954c2549705e80c00aed8ecbcb19f386cc8b0310 Issue-ID: POLICY-1137 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-19AAF Configuration in PDP-DJorge Hernandez23-65/+340
AAF is disabled by default until pairwise testing is completed. Change-Id: Ica83873a2605742689ed0c2e06dfade20bef8bf0 Signed-off-by: Jorge Hernandez <jh1730@att.com> Issue-ID: POLICY-1043 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-09-18Fixes for oparent upgradePamela Dragosh2-3/+0
Clean out the defined properties to allow oparent version to pull through. Issue-ID: POLICY-1126 Change-Id: Ib521110493bdb01712d3e81bdfd0128511f748b7 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-17don't begin new transactionJim Hahn2-109/+248
Persistence code was not checking to see if a transaction was already in progress before beginning a transaction. Fix checkstyle issue with comments and parameter for EntityMgrException. Restore other checkstyle fixes. More checkstyle fixes. Rename some variables. Change-Id: Ic820944781571ba2ef411cb86d12fa32fb206124 Issue-ID: POLICY-1106 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-14Use policy/parent mariadb versionPamela Dragosh1-6/+0
Use the same version of mariadb across policy repositories. This will also clear a license issue, albeit a false positive. Issue-ID: POLICY-1061 Change-Id: I4267975518fe9efce9530db687a2cfd3bf872641 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-13Fix checkstyle for features submodules.Pamela Dragosh115-9684/+9949
These are the remaining submodules that have checkstyle. Pretty clean compile after this. There were a couple of sonar fixes in there also. Issue-ID: POLICY-882 Change-Id: I8191ea1aa261f4a7b9d3d21c108572fd31db1b8c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-13Fix checkstyle in policy-managementPamela Dragosh22-3821/+4096
The submodule policy-management checkstyle fixes. There may be one or two sonar fixes in there. Issue-ID: POLICY-882 Change-Id: I9cb43c573c6811dd058943650ba1ea5f6dc880aa Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-12Merge "Remove unnecessary properties"Jorge Hernandez1-2/+0
2018-09-12Remove unnecessary propertiesPamela Dragosh1-2/+0
In upgrading dmaap client, these properties were found and were unnecessary to be defined here. They are already defined in policy/parent and dmaap/cambria code was moved to policy/common. Issue-ID: POLICY-1116 Change-Id: Ic85b46e556167387acd82af3f21a7446adb43216 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-11disable http for healthchecksJorge Hernandez1-0/+1
Change-Id: If1d6d86e7622432d4f8b4de6b1f86bd212adc233 Signed-off-by: Jorge Hernandez <jh1730@att.com> Issue-ID: POLICY-1108
2018-09-11Merge "Revert back to Drools 6.5.0.Final"Pamela Dragosh4-14/+13
2018-09-11Revert back to Drools 6.5.0.FinalJim Hahn4-14/+13
Decided to abandon the conversion to Drools 7.9.0.Final. This undoes the associated changes. Change-Id: I457266d09f7e481da5c0415290241a348786f8ea Issue-ID: POLICY-1093 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-10disabling http for configuration servicesJorge Hernandez2-30/+21
per security recommendations. Change-Id: Ic195f8270c2270239408e33e27f87436878e28b4 Signed-off-by: Jorge Hernandez <jh1730@att.com> Issue-ID: POLICY-1104
2018-09-10Switch to drools 7.9.0.FinalJim Hahn4-13/+14
Note: This will break policy/drools-applications until the corresponding change is merged there, too. Reformatted lengthy line. Change-Id: I4ae7838dfbc2d537580636eccc545710b5ebc799 Issue-ID: POLICY-1093 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-10Fix checkstyle policy-corePamela Dragosh22-755/+771
Working on the policy-core submodule in drools pdp. Issue-ID: POLICY-882 Change-Id: I58d418110fe0fda90f97117ef17edfc13d648ccc Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-08Fix checkstyle in utilsPamela Dragosh16-927/+908
Just focusing on the policy-utils submodule. Issue-ID: POLICY-882 Change-Id: I9f2ecac8f435f2d743b1fafc477d320b10852bdc Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-04Fix security issuesPamela Dragosh2-5/+9
Guava was not fully defined correctly. In order to exclude an older version being pulled in, the dependencyManagement needs to come from oparent and not overriden in drools-pdp. Issue-ID: INT-619 Change-Id: I58dfb815f02d61e47552e671540144b7b1ed3df5 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-04Remove guava overridePamela Dragosh1-2/+0
The oparent repo now declares guava for all the ONAP projects to inherit from. Removing the override so we are upgrading to a version without security or license issues. Issue-ID: INT-619 Change-Id: I5ff9745b723db74cf46d63520f7cf00796bb2a01 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-30Merge "handle null drools object in configuration"Pamela Dragosh2-4/+4
2018-08-30Merge "Set parent to policy/parent"Liam Fallon13-1716/+1697
2018-08-29handle null drools object in configurationJim Hahn2-4/+4
Modified code to explicitly check for missing drools object, and to not throw an exception during MDC setup. Change-Id: Iac16f2fc46e2ffff03195985383b09b814fa4008 Issue-ID: POLICY-1082 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-08-29Set parent to policy/parentPamela Dragosh13-1716/+1697
Set the parent to point to policy/parent instead of oparent. Clean up some duplicate management versions. Change-Id: I28957b05b80c9564ad32c958143822b6b0768219 Issue-ID: INT-619 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-28Fixed feature-healthcheck issueMichael Mokry2-4/+4
Modified properties to true for https on PAP and PDP Found a minor typo in do-start.sh that is benign currently but could cause an issue in the future so figured I would clean it up now. Change-Id: I06385d36d69955d49cabeb39b09d75ffeaec2fdc Issue-ID: POLICY-781 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-08-20Merge "https certs with aaf+pdpd containers compatibility"Pamela Dragosh11-11/+110
2018-08-20https certs with aaf+pdpd containers compatibilityJorge Hernandez11-11/+110
Updated license date (jrh3). Change-Id: I1bc244da64f4a1e683f8c6a1be53157474f46ee9 Issue-ID: POLICY-1026 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-08-20Fix sonar issues in drools-pdpKrishnajinka2-589/+536
Fix sonar issues about nested control loops in drools-pdp. Rework1 build failed due to incorrect condition. fixing it Fix checkstyle. Add modified copyright notice Issue-ID: POLICY-1017 Change-Id: I21a4ad9399b1d234b8d5416ab0d595302a441f10 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-06Fix basic Java issue in pdp drools sys compkrishnajinka4-574/+556
Modify pdp drools system component files to fix basic Java warnings from analysis tools. Possibly flagged by Sonar tool as well.Rework based on comments Issue-ID: POLICY-1017 Change-Id: I1f2a5d727d2673cade5f69a07f708e16754c78e4 Signed-off-by: krisjinka <kris.jinka@samsung.com>
2018-07-30Copy policy-endpoints from drools-pdp to commonmmis14-384/+364
Issue-ID: POLICY-967 Change-Id: Ib19d3a89ffa328c39f7871bff59efb3dd1617f7a Signed-off-by: mmis <michael.morris@ericsson.com>
2018-07-25Copy policy-endpoints from drools-pdp to commonmmis92-16498/+7607
Removed policy-endpoints, and 3 classes from policy-core. Replaced refenences to the deleted classes with references to the corresponding classes in policy-common Issue-ID: POLICY-967 Change-Id: I547cde4894424b8f40b7ddd4e2342ebb729cb588 Signed-off-by: mmis <michael.morris@ericsson.com>
2018-07-18Deny subsequent lock()Jim Hahn5-18/+18
This is the final step of separating the lock "refresh" operation from the original "lock" operation. This step entails rejecting subsequent "lock" requests, even by the same owner, when a resource is already locked; "refresh" should now be used, instead, to extend a lock. Modified comments to indicate that the lock can only be extended using "refresh". Change-Id: I406cf60c076dbce87afbd94fb301732359dbd2db Issue-ID: POLICY-872 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-07-18Upgrade jetty to 9.3.24 securityPamela Dragosh3-6/+1
Upgrade to clear security flag in CLM. Removed unnecessary properties already declared Issue-ID: POLICY-987 Change-Id: Iefe4a9b264148a6bd661d5cff3bff6019b0b3def Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-07-17Merge "Distinguish lock from refresh"Jorge Hernandez9-2/+375
2018-07-16Distinguish lock from refreshJim Hahn9-2/+375
This is the first step of separating the lock "refresh" operation from the original "lock" operation. This step entails adding the refresh() method to both the default and the feature-distriubted locking mechanisms. Change method call, in junit test, from lock to refresh. Change branch name in git review. Change-Id: I506de7a96cb3ee786839aca04ad67cdd7378832c Issue-ID: POLICY-872 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-07-13Don't stop controller on dmaap failureJim Hahn11-569/+83
Modified feature-pooling-dmaap so that it continues to work even if it's unable to communicate with the internal DMaaP topic. When that happens, it simply starts processing locally, until communication is re-established and it receives a bucket assignment. Fixed typo in comment. Added to comment for State.internalTopicFailed(). Removed extra space before @Ignore. Change-Id: I9c851c66c9162c608f2df98e11d49fc526539434 Issue-ID: POLICY-878 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-07-03Merge "Fix sonar issues on new code"Jorge Hernandez1-3/+1
2018-07-03Merge "Final piece to remove lock Callback"Pamela Dragosh2-31/+0
2018-07-03Fix sonar issues on new codeJim Hahn1-3/+1
Removed new technical debt. Change-Id: I04e86b85897ab42deca17ecee55f29d48cc24427 Issue-ID: POLICY-872 Signed-off-by: Jim Hahn <jrh3@att.com>