diff options
| author |   Jim Hahn <jrh3@att.com> | 2018-02-19 16:56:06 -0500 |
|---|---|---|
| committer | Jim Hahn <jrh3@att.com> | 2018-02-20 09:59:15 -0500 |
| commit | a45f8909871dc1ddb75845f067a602951afc8d11 (patch) | |
| tree | fa72aff7ceede971d4e6922f62a503a8ee8924d5 /policy-utils/src/test/java/org/onap | |
| parent | 1708e9a45cb88571613c10b68d392811b2b3f0f4 (diff) | |
Sonar fixes to drools-pdp
Fixed most of the instances of the following sonar issues:
Moved array designator
Used diamond operator
Changed System.out/err to use a logger
Changed several Thread.sleep() in test code to a single sleep()
Useless assignments
Replaced comparison with "" to string.isEmpty()
Merged if's
Replaced ArrayList with List in method returns
Reordered type modifiers
Reordered constructor methods
Defined constants for literals, or replaced them with method calls
Removed "throws Xxx" for subclasses of RuntimeException
Combined identical "catch" blocks
Re-interrupted the current thread after catching an InterruptedException
Removed tests against the literal "false"
Fix indentation of new makeTopicOperError() method.
Fix exception variable name in new methods, logNoUebEncoder()
and logNoDmaapEncoder().
Change-Id: Iddae5210553662f733b67333b372dec8c3fe2c94
Issue-ID: POLICY-336
Signed-off-by: Jim Hahn <jrh3@att.com>
Diffstat (limited to 'policy-utils/src/test/java/org/onap')
| -rw-r--r-- | policy-utils/src/test/java/org/onap/policy/drools/utils/TripleTest.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/policy-utils/src/test/java/org/onap/policy/drools/utils/TripleTest.java b/policy-utils/src/test/java/org/onap/policy/drools/utils/TripleTest.java index cdb93e8a..ff613938 100644 --- a/policy-utils/src/test/java/org/onap/policy/drools/utils/TripleTest.java +++ b/policy-utils/src/test/java/org/onap/policy/drools/utils/TripleTest.java @@ -1,4 +1,4 @@ -/*- +/* * ============LICENSE_START======================================================= * ONAP * ================================================================================ @@ -28,7 +28,7 @@ public class TripleTest { @Test public void test() { Triple<String, String, String> triple = - new Triple("one", "two", "three"); + new Triple<>("one", "two", "three"); Assert.assertTrue("one".equals(triple.first())); Assert.assertTrue("one".equals(triple.getFirst())); |