Fix fortify issues identified in drools

Fix code identified by Fortify as Privacy Violation

Issue-ID: POLICY-442

Change-Id: I6097fb203a53a9643c4c4c38185515b1c8a90282
Signed-off-by: Joseph Chou <jc2555@att.com>

1 files changed, 6 insertions, 9 deletions

diff --git a/policy-utils/src/main/java/org/onap/policy/drools/utils/PropertyUtil.java b/policy-utils/src/main/java/org/onap/policy/drools/utils/PropertyUtil.java
index 84043d8f..d69ea339 100644
--- a/policy-utils/src/main/java/org/onap/policy/drools/utils/PropertyUtil.java
+++ b/policy-utils/src/main/java/org/onap/policy/drools/utils/PropertyUtil.java
@@ -147,17 +147,14 @@ public class PropertyUtil
 	  // add to static table, so this instance can be shared
 	  registrations.put(file, this);
 
-	  if (timer == null)
+	  // still need to create a timer thread
+	  synchronized(PropertyUtil.class)
 		{
-		  // still need to create a timer thread
-		  synchronized(PropertyUtil.class)
+		  // an additional check is added inside the 'synchronized' block,
+		  // just in case someone beat us to it
+		  if (timer == null)
 			{
-			  // an additional check is added inside the 'synchronized' block,
-			  // just in case someone beat us to it
-			  if (timer == null)
-				{
-				  timer = new Timer("PropertyUtil-Timer", true);
-				}
+			  timer = new Timer("PropertyUtil-Timer", true);
 			}
 		}