Address more sonar issues in drools-pdp

Addressed the following sonar issues:
- use of "synchronized"
- use Files.delete() instead of File.delete()

Issue-ID: POLICY-2305
Change-Id: Id55628fe12d9d764616e57321382a70cb5704ba1
Signed-off-by: Jim Hahn <jrh3@att.com>

2 files changed, 3 insertions, 3 deletions

diff --git a/policy-management/src/main/java/org/onap/policy/drools/system/internal/FeatureLockImpl.java b/policy-management/src/main/java/org/onap/policy/drools/system/internal/FeatureLockImpl.java
index 6b0c8a43..799cca7b 100644
--- a/policy-management/src/main/java/org/onap/policy/drools/system/internal/FeatureLockImpl.java
+++ b/policy-management/src/main/java/org/onap/policy/drools/system/internal/FeatureLockImpl.java
@@ -119,7 +119,7 @@ public abstract class FeatureLockImpl extends LockImpl {
      * @return {@code true} if the lock can be freed, {@code false} if the lock is
      *         unavailable
      */
-    protected boolean freeAllowed() {
+    protected synchronized boolean freeAllowed() {
         // do a quick check of the state
         if (isUnavailable()) {
             return false;
@@ -150,7 +150,7 @@ public abstract class FeatureLockImpl extends LockImpl {
      * @return {@code true} if the lock can be extended, {@code false} if the lock is
      *         unavailable
      */
-    protected boolean extendAllowed(int holdSec, LockCallback callback) {
+    protected synchronized boolean extendAllowed(int holdSec, LockCallback callback) {
         if (holdSec < 0) {
             throw new IllegalArgumentException("holdSec is negative");
         }
diff --git a/policy-management/src/main/java/org/onap/policy/drools/system/internal/SimpleLockManager.java b/policy-management/src/main/java/org/onap/policy/drools/system/internal/SimpleLockManager.java
index 1df139e2..c2c921f5 100644
--- a/policy-management/src/main/java/org/onap/policy/drools/system/internal/SimpleLockManager.java
+++ b/policy-management/src/main/java/org/onap/policy/drools/system/internal/SimpleLockManager.java
@@ -227,7 +227,7 @@ public class SimpleLockManager extends LockManager<SimpleLockManager.SimpleLock>
         }
 
         @Override
-        public synchronized boolean free() {
+        public boolean free() {
             if (!freeAllowed()) {
                 return false;
             }