Increase code coverage in policy-core and policy-utils

Issue-ID: POLICY-5068
Change-Id: I598b674fd623ff56c2e7b0316c114e7c270c2b3f
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>

3 files changed, 145 insertions, 113 deletions

diff --git a/policy-management/src/main/java/org/onap/policy/drools/system/internal/LockManager.java b/policy-management/src/main/java/org/onap/policy/drools/system/internal/LockManager.java
index 1683b0f5..fa264426 100644
--- a/policy-management/src/main/java/org/onap/policy/drools/system/internal/LockManager.java
+++ b/policy-management/src/main/java/org/onap/policy/drools/system/internal/LockManager.java
@@ -3,6 +3,7 @@
  * ONAP
  * ================================================================================
  * Copyright (C) 2019, 2021 AT&T Intellectual Property. All rights reserved.
+ * Modifications Copyright (C) 2024 Nordix Foundation.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -122,7 +123,7 @@ public abstract class LockManager<T extends FeatureLockImpl> implements PolicyRe
     /**
      * After performing checks, this invokes
      * {@link #makeLock(LockState, String, String, int, LockCallback)} to create a lock
-     * object, inserts it into the map, and then invokes {@link #finishLock(MgrLock)}.
+     * object, inserts it into the map, and then invokes {@link #finishLock(FeatureLockImpl)}.
      */
     @Override
     public Lock createLock(String resourceId, String ownerKey, int holdSec, LockCallback callback,
diff --git a/policy-management/src/test/java/org/onap/policy/drools/controller/internal/NullDroolsControllerTest.java b/policy-management/src/test/java/org/onap/policy/drools/controller/internal/NullDroolsControllerTest.java
index f61412d9..ccefcc6f 100644
--- a/policy-management/src/test/java/org/onap/policy/drools/controller/internal/NullDroolsControllerTest.java
+++ b/policy-management/src/test/java/org/onap/policy/drools/controller/internal/NullDroolsControllerTest.java
@@ -22,6 +22,7 @@
 package org.onap.policy.drools.controller.internal;
 
 import static org.assertj.core.api.Assertions.assertThatCode;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -36,32 +37,35 @@ import org.onap.policy.drools.controller.DroolsControllerConstants;
 
 class NullDroolsControllerTest {
 
+    private final NullDroolsController controller = new NullDroolsController();
+    private static final String NULL_EXCEPTION = "marked non-null but is null";
+
     @Test
     void testStart() {
-        DroolsController controller = new NullDroolsController();
-        controller.start();
-        assertFalse(controller.isAlive());
-        controller.stop();
-        assertFalse(controller.isAlive());
-        controller.shutdown();
-        assertFalse(controller.isAlive());
-        controller.halt();
-        assertFalse(controller.isAlive());
+        DroolsController controller1 = new NullDroolsController();
+        controller1.start();
+        assertFalse(controller1.isAlive());
+        controller1.stop();
+        assertFalse(controller1.isAlive());
+        controller1.shutdown();
+        assertFalse(controller1.isAlive());
+        controller1.halt();
+        assertFalse(controller1.isAlive());
     }
 
     @Test
     void testSerialize() {
         assertThatCode(() -> new GsonTestUtils().compareGson(new NullDroolsController(),
-                        NullDroolsControllerTest.class)).doesNotThrowAnyException();
+            NullDroolsControllerTest.class)).doesNotThrowAnyException();
     }
 
     @Test
     void testLock() {
-        DroolsController controller = new NullDroolsController();
-        controller.lock();
-        assertFalse(controller.isLocked());
-        controller.unlock();
-        assertFalse(controller.isLocked());
+        DroolsController controller1 = new NullDroolsController();
+        controller1.lock();
+        assertFalse(controller1.isLocked());
+        controller1.unlock();
+        assertFalse(controller1.isLocked());
     }
 
     @Test
@@ -81,78 +85,75 @@ class NullDroolsControllerTest {
 
     @Test
     void getSessionNames() {
-        assertTrue(new NullDroolsController().getSessionNames().isEmpty());
+        assertTrue(controller.getSessionNames().isEmpty());
     }
 
     @Test
     void getCanonicalSessionNames() {
-        assertTrue(new NullDroolsController().getCanonicalSessionNames().isEmpty());
+        assertTrue(controller.getCanonicalSessionNames().isEmpty());
     }
 
     @Test
     void offer() {
-        assertFalse(new NullDroolsController().offer(null, null));
+        assertFalse(controller.offer(null, null));
+        assertFalse(controller.offer(null));
     }
 
     @Test
     void deliver() {
-        var controller = new NullDroolsController();
         assertThrows(IllegalStateException.class, () -> controller.deliver(null, null));
     }
 
     @Test
     void getRecentSourceEvents() {
-        assertEquals(0, new NullDroolsController().getRecentSourceEvents().length);
+        assertEquals(0, controller.getRecentSourceEvents().length);
     }
 
     @Test
     void getRecentSinkEvents() {
-        assertEquals(0, new NullDroolsController().getRecentSinkEvents().length);
+        assertEquals(0, controller.getRecentSinkEvents().length);
     }
 
     @Test
     void getContainer() {
-        assertNull(new NullDroolsController().getContainer());
+        assertNull(controller.getContainer());
     }
 
     @Test
     void getDomains() {
-        assertTrue(new NullDroolsController().getBaseDomainNames().isEmpty());
+        assertTrue(controller.getBaseDomainNames().isEmpty());
     }
 
     @Test
     void ownsCoder() {
-        var controller = new NullDroolsController();
         assertThrows(IllegalStateException.class, () -> controller.ownsCoder(null, 0));
     }
 
     @Test
     void fetchModelClass() {
-        var controller = new NullDroolsController();
         var className = this.getClass().getName();
         assertThrows(IllegalArgumentException.class, () -> controller.fetchModelClass(className));
     }
 
     @Test
     void isBrained() {
-        assertFalse(new NullDroolsController().isBrained());
+        assertFalse(controller.isBrained());
     }
 
     @Test
     void stringify() {
-        assertNotNull(new NullDroolsController().toString());
+        assertNotNull(controller.toString());
     }
 
     @Test
     void updateToVersion() {
-        var controller = new NullDroolsController();
         assertThrows(IllegalArgumentException.class, () ->
             controller.updateToVersion(null, null, null, null, null));
     }
 
     @Test
     void factClassNames() {
-        assertTrue(new NullDroolsController().factClassNames(null).isEmpty());
+        assertTrue(controller.factClassNames(null).isEmpty());
     }
 
     @Test
@@ -162,18 +163,40 @@ class NullDroolsControllerTest {
 
     @Test
     void facts() {
-        assertTrue(new NullDroolsController().facts(null, null, true).isEmpty());
+        assertTrue(controller.facts(null, null, true).isEmpty());
+        assertTrue(controller.facts("sessionName", Object.class).isEmpty());
+
+        assertThatThrownBy(() -> controller.facts(null, Object.class)).hasMessageContaining(NULL_EXCEPTION);
+        assertThatThrownBy(() -> controller.facts("sessionName", null)).hasMessageContaining(NULL_EXCEPTION);
     }
 
     @Test
     void factQuery() {
-        assertTrue(new NullDroolsController().factQuery(null, null, null, false).isEmpty());
+        assertTrue(controller.factQuery(null, null, null, false).isEmpty());
     }
 
     @Test
     void exists() {
         Object o1 = new Object();
-        assertFalse(new NullDroolsController().exists("blah", o1));
-        assertFalse(new NullDroolsController().exists(o1));
+        assertFalse(controller.exists("blah", o1));
+        assertFalse(controller.exists(o1));
+
+        assertThatThrownBy(() -> controller.exists("blah", null)).hasMessageContaining(NULL_EXCEPTION);
+        assertThatThrownBy(() -> controller.exists(null, o1)).hasMessageContaining(NULL_EXCEPTION);
+        assertThatThrownBy(() -> controller.exists(null)).hasMessageContaining(NULL_EXCEPTION);
+    }
+
+    @Test
+    void testDelete() {
+        assertThatThrownBy(() -> controller.delete("sessionName", null)).hasMessageContaining(NULL_EXCEPTION);
+        assertThatThrownBy(() -> controller.delete(null, Object.class)).hasMessageContaining(NULL_EXCEPTION);
+        assertThatThrownBy(() -> controller.delete(null)).hasMessageContaining(NULL_EXCEPTION);
+        Object o1 = null;
+        assertThatThrownBy(() -> controller.delete(o1)).hasMessageContaining(NULL_EXCEPTION);
+
+        assertFalse(controller.delete("sessionName", new Object()));
+        assertFalse(controller.delete("sessionName", Object.class));
+        assertFalse(controller.delete(new Object()));
+        assertFalse(controller.delete(Object.class));
     }
 }
diff --git a/policy-management/src/test/java/org/onap/policy/drools/system/PolicyEngineManagerTest.java b/policy-management/src/test/java/org/onap/policy/drools/system/PolicyEngineManagerTest.java
index 0b88b3f1..138ad9f8 100644
--- a/policy-management/src/test/java/org/onap/policy/drools/system/PolicyEngineManagerTest.java
+++ b/policy-management/src/test/java/org/onap/policy/drools/system/PolicyEngineManagerTest.java
@@ -102,7 +102,7 @@ class PolicyEngineManagerTest {
     private static final Object MY_EVENT = new Object();
 
     private static final GsonTestUtils gson = new GsonMgmtTestBuilder().addTopicSourceMock().addTopicSinkMock()
-                    .addHttpServletServerMock().build();
+        .addHttpServletServerMock().build();
 
     private Properties properties;
     private PolicyEngineFeatureApi prov1;
@@ -579,30 +579,34 @@ class PolicyEngineManagerTest {
         verify(prov1).afterConfigure(mgr);
         verify(prov2).afterConfigure(mgr);
 
+        // other tests
+        checkBeforeAfter(
+            (prov, flag) -> when(prov.beforeConfigure(mgr, properties)).thenReturn(flag),
+            (prov, flag) -> when(prov.afterConfigure(mgr)).thenReturn(flag),
+            () -> mgr.configure(properties),
+            prov -> verify(prov).beforeConfigure(mgr, properties),
+            () -> assertSame(properties, mgr.getProperties()),
+            prov -> verify(prov).afterConfigure(mgr));
+    }
+
+    @Test
+    void testConfigureProperties_InvalidProperties() throws Exception {
         // middle stuff throws exception - still calls afterXxx
-        setUp();
         when(endpoint.addTopicSources(properties)).thenThrow(new IllegalArgumentException(EXPECTED));
         when(endpoint.addTopicSinks(properties)).thenThrow(new IllegalArgumentException(EXPECTED));
         when(serverFactory.build(properties)).thenThrow(new IllegalArgumentException(EXPECTED));
         when(clientFactory.build(properties)).thenThrow(new IllegalArgumentException(EXPECTED));
         mgr.configure(properties);
         verify(prov2).afterConfigure(mgr);
+    }
 
+    @Test
+    void testConfigureProperties_NullProperties() {
         // null properties - nothing should be invoked
-        setUp();
         Properties nullProps = null;
         assertThatIllegalArgumentException().isThrownBy(() -> mgr.configure(nullProps));
         verify(prov1, never()).beforeConfigure(mgr, properties);
         verify(prov1, never()).afterConfigure(mgr);
-
-        // other tests
-        checkBeforeAfter(
-            (prov, flag) -> when(prov.beforeConfigure(mgr, properties)).thenReturn(flag),
-            (prov, flag) -> when(prov.afterConfigure(mgr)).thenReturn(flag),
-            () -> mgr.configure(properties),
-            prov -> verify(prov).beforeConfigure(mgr, properties),
-            () -> assertSame(properties, mgr.getProperties()),
-            prov -> verify(prov).afterConfigure(mgr));
     }
 
     @Test
@@ -631,17 +635,8 @@ class PolicyEngineManagerTest {
     }
 
     @Test
-    void testCreatePolicyController() throws Exception {
-        assertEquals(controller, mgr.createPolicyController(MY_NAME, properties));
-
-        verify(contProv1).beforeCreate(MY_NAME, properties);
-        verify(contProv2).beforeCreate(MY_NAME, properties);
-        verify(controller, never()).lock();
-        verify(contProv1).afterCreate(controller);
-        verify(contProv2).afterCreate(controller);
-
+    void testCreatePolicy_FirstProviderThrowsException() {
         // first provider throws exceptions - same result
-        setUp();
         when(contProv1.beforeCreate(MY_NAME, properties)).thenThrow(new RuntimeException(EXPECTED));
         when(contProv1.afterCreate(controller)).thenThrow(new RuntimeException(EXPECTED));
         assertEquals(controller, mgr.createPolicyController(MY_NAME, properties));
@@ -651,17 +646,11 @@ class PolicyEngineManagerTest {
         verify(controller, never()).lock();
         verify(contProv1).afterCreate(controller);
         verify(contProv2).afterCreate(controller);
+    }
 
-        // locked - same result, but engine locked
-        setUp();
-        mgr.lock();
-        assertEquals(controller, mgr.createPolicyController(MY_NAME, properties));
-        verify(contProv1).beforeCreate(MY_NAME, properties);
-        verify(controller, times(2)).lock();
-        verify(contProv2).afterCreate(controller);
-
+    @Test
+    void testCreatePolicyController_InvalidProperties() throws Exception {
         // empty name in properties - same result
-        setUp();
         properties.setProperty(DroolsPropertyConstants.PROPERTY_CONTROLLER_NAME, "");
         assertEquals(controller, mgr.createPolicyController(MY_NAME, properties));
         verify(contProv1).beforeCreate(MY_NAME, properties);
@@ -677,6 +666,25 @@ class PolicyEngineManagerTest {
         properties.setProperty(DroolsPropertyConstants.PROPERTY_CONTROLLER_NAME, "mistmatched-name");
         assertThatIllegalStateException().isThrownBy(() -> mgr.createPolicyController(MY_NAME, properties));
         verify(contProv1, never()).beforeCreate(MY_NAME, properties);
+    }
+
+    @Test
+    void testCreatePolicyController() throws Exception {
+        assertEquals(controller, mgr.createPolicyController(MY_NAME, properties));
+
+        verify(contProv1).beforeCreate(MY_NAME, properties);
+        verify(contProv2).beforeCreate(MY_NAME, properties);
+        verify(controller, never()).lock();
+        verify(contProv1).afterCreate(controller);
+        verify(contProv2).afterCreate(controller);
+
+        // locked - same result, but engine locked
+        setUp();
+        mgr.lock();
+        assertEquals(controller, mgr.createPolicyController(MY_NAME, properties));
+        verify(contProv1).beforeCreate(MY_NAME, properties);
+        verify(controller, times(2)).lock();
+        verify(contProv2).afterCreate(controller);
 
         // first provider generates controller - stops after first provider
         setUp();
@@ -902,7 +910,7 @@ class PolicyEngineManagerTest {
      * Tests the start() method, after setting some option.
      *
      * @param expectedResult what start() is expected to return
-     * @param setOption function that sets an option
+     * @param setOption      function that sets an option
      * @throws Throwable if an error occurs during setup
      */
     private void testStart(boolean expectedResult, RunnableWithEx setOption) throws Throwable {
@@ -1004,7 +1012,7 @@ class PolicyEngineManagerTest {
      * Tests the stop() method, after setting some option.
      *
      * @param expectedResult what stop() is expected to return
-     * @param setOption function that sets an option
+     * @param setOption      function that sets an option
      * @throws Throwable if an error occurs during setup
      */
     private void testStop(boolean expectedResult, RunnableWithEx setOption) throws Throwable {
@@ -1211,7 +1219,7 @@ class PolicyEngineManagerTest {
      * Tests the lock() method, after setting some option.
      *
      * @param expectedResult what lock() is expected to return
-     * @param setOption function that sets an option
+     * @param setOption      function that sets an option
      * @throws Throwable if an error occurs during setup
      */
     private void testLock(boolean expectedResult, RunnableWithEx setOption) throws Throwable {
@@ -1287,7 +1295,7 @@ class PolicyEngineManagerTest {
      * Tests the unlock() method, after setting some option.
      *
      * @param expectedResult what unlock() is expected to return
-     * @param setOption function that sets an option
+     * @param setOption      function that sets an option
      * @throws Throwable if an error occurs during setup
      */
     private void testUnlock(boolean expectedResult, RunnableWithEx setOption) throws Throwable {
@@ -1411,8 +1419,8 @@ class PolicyEngineManagerTest {
         assertEquals(1, mgr.getStats().getSubgroupStats().get(CONTROLLOOP).getPolicyExecutedFailCount());
 
         Summary.Child.Value summary =
-                PolicyEngineManagerImpl.transLatencySecsSummary
-                        .labels(CONTROLLER1, CONTROLLOOP, POLICY, PdpResponseStatus.FAIL.name()).get();
+            PolicyEngineManagerImpl.transLatencySecsSummary
+                .labels(CONTROLLER1, CONTROLLOOP, POLICY, PdpResponseStatus.FAIL.name()).get();
 
         assertEquals(0, summary.count, 0.0);
         assertEquals(0, summary.sum, 0.0);
@@ -1423,8 +1431,8 @@ class PolicyEngineManagerTest {
         mgr.transaction(CONTROLLER1, CONTROLLOOP, metric);
 
         summary =
-                PolicyEngineManagerImpl.transLatencySecsSummary
-                        .labels(CONTROLLER1, CONTROLLOOP, POLICY, PdpResponseStatus.FAIL.name()).get();
+            PolicyEngineManagerImpl.transLatencySecsSummary
+                .labels(CONTROLLER1, CONTROLLOOP, POLICY, PdpResponseStatus.FAIL.name()).get();
 
         assertEquals(1, summary.count, 0.0);
         assertEquals(5, summary.sum, 0.0);
@@ -1553,7 +1561,7 @@ class PolicyEngineManagerTest {
         mgr.start();
         when(sink1.send(any())).thenThrow(new ArithmeticException(EXPECTED));
         assertThatThrownBy(() -> mgr.deliver(CommInfrastructure.NOOP, MY_TOPIC, MY_EVENT))
-                        .isInstanceOf(ArithmeticException.class);
+            .isInstanceOf(ArithmeticException.class);
 
         /*
          * For remaining tests, have the controller handle delivery.
@@ -1610,7 +1618,7 @@ class PolicyEngineManagerTest {
 
         // unknown topic
         assertThatIllegalStateException()
-                        .isThrownBy(() -> mgr.deliver(CommInfrastructure.NOOP, "unknown-topic", MESSAGE));
+            .isThrownBy(() -> mgr.deliver(CommInfrastructure.NOOP, "unknown-topic", MESSAGE));
 
         // locked
         mgr.lock();
@@ -1737,7 +1745,7 @@ class PolicyEngineManagerTest {
 
         // not configured yet, thus no lock manager
         assertThatIllegalStateException()
-                        .isThrownBy(() -> mgr.createLock(MY_RESOURCE, MY_OWNER, 10, callback, false));
+            .isThrownBy(() -> mgr.createLock(MY_RESOURCE, MY_OWNER, 10, callback, false));
 
         // now configure it and try again
         mgr.configure(properties);
@@ -1745,14 +1753,14 @@ class PolicyEngineManagerTest {
 
         // test illegal args
         assertThatThrownBy(() -> mgr.createLock(null, MY_OWNER, 10, callback, false))
-                        .hasMessageContaining("resourceId");
+            .hasMessageContaining("resourceId");
         assertThatThrownBy(() -> mgr.createLock(MY_RESOURCE, null, 10, callback, false))
-                        .hasMessageContaining("ownerKey");
+            .hasMessageContaining("ownerKey");
         assertThatIllegalArgumentException()
-                        .isThrownBy(() -> mgr.createLock(MY_RESOURCE, MY_OWNER, -1, callback, false))
-                        .withMessageContaining("holdSec");
+            .isThrownBy(() -> mgr.createLock(MY_RESOURCE, MY_OWNER, -1, callback, false))
+            .withMessageContaining("holdSec");
         assertThatThrownBy(() -> mgr.createLock(MY_RESOURCE, MY_OWNER, 10, null, false))
-                        .hasMessageContaining("callback");
+            .hasMessageContaining("callback");
     }
 
     @Test
@@ -1850,19 +1858,19 @@ class PolicyEngineManagerTest {
      * Performs an operation that has a beforeXxx method and an afterXxx method. Tries
      * combinations where beforeXxx and afterXxx return {@code true} and {@code false}.
      *
-     * @param setBefore function to set the return value of a provider's beforeXxx method
-     * @param setAfter function to set the return value of a provider's afterXxx method
-     * @param action invokes the operation
+     * @param setBefore    function to set the return value of a provider's beforeXxx method
+     * @param setAfter     function to set the return value of a provider's afterXxx method
+     * @param action       invokes the operation
      * @param verifyBefore verifies that a provider's beforeXxx method was invoked
      * @param verifyMiddle verifies that the action occurring between the beforeXxx loop
-     *        and the afterXxx loop was invoked
-     * @param verifyAfter verifies that a provider's afterXxx method was invoked
+     *                     and the afterXxx loop was invoked
+     * @param verifyAfter  verifies that a provider's afterXxx method was invoked
      * @throws Exception if an error occurs while calling {@link #setUp()}
      */
     private void checkBeforeAfter(BiConsumer<PolicyEngineFeatureApi, Boolean> setBefore,
-                    BiConsumer<PolicyEngineFeatureApi, Boolean> setAfter, Runnable action,
-                    Consumer<PolicyEngineFeatureApi> verifyBefore, Runnable verifyMiddle,
-                    Consumer<PolicyEngineFeatureApi> verifyAfter) throws Exception {
+                                  BiConsumer<PolicyEngineFeatureApi, Boolean> setAfter, Runnable action,
+                                  Consumer<PolicyEngineFeatureApi> verifyBefore, Runnable verifyMiddle,
+                                  Consumer<PolicyEngineFeatureApi> verifyAfter) throws Exception {
 
         checkBeforeAfter_FalseFalse(setBefore, setAfter, action, verifyBefore, verifyMiddle, verifyAfter);
         checkBeforeAfter_FalseTrue(setBefore, setAfter, action, verifyBefore, verifyMiddle, verifyAfter);
@@ -1875,19 +1883,19 @@ class PolicyEngineManagerTest {
      * Performs an operation that has a beforeXxx method and an afterXxx method. Tries the
      * case where both the beforeXxx and afterXxx methods return {@code false}.
      *
-     * @param setBefore function to set the return value of a provider's beforeXxx method
-     * @param setAfter function to set the return value of a provider's afterXxx method
-     * @param action invokes the operation
+     * @param setBefore    function to set the return value of a provider's beforeXxx method
+     * @param setAfter     function to set the return value of a provider's afterXxx method
+     * @param action       invokes the operation
      * @param verifyBefore verifies that a provider's beforeXxx method was invoked
      * @param verifyMiddle verifies that the action occurring between the beforeXxx loop
-     *        and the afterXxx loop was invoked
-     * @param verifyAfter verifies that a provider's afterXxx method was invoked
+     *                     and the afterXxx loop was invoked
+     * @param verifyAfter  verifies that a provider's afterXxx method was invoked
      * @throws Exception if an error occurs while calling {@link #setUp()}
      */
     private void checkBeforeAfter_FalseFalse(BiConsumer<PolicyEngineFeatureApi, Boolean> setBefore,
-                    BiConsumer<PolicyEngineFeatureApi, Boolean> setAfter, Runnable action,
-                    Consumer<PolicyEngineFeatureApi> verifyBefore, Runnable verifyMiddle,
-                    Consumer<PolicyEngineFeatureApi> verifyAfter) throws Exception {
+                                             BiConsumer<PolicyEngineFeatureApi, Boolean> setAfter, Runnable action,
+                                             Consumer<PolicyEngineFeatureApi> verifyBefore, Runnable verifyMiddle,
+                                             Consumer<PolicyEngineFeatureApi> verifyAfter) throws Exception {
 
         setUp();
 
@@ -1916,19 +1924,19 @@ class PolicyEngineManagerTest {
      * case where the first provider's afterXxx returns {@code true}, while the others
      * return {@code false}.
      *
-     * @param setBefore function to set the return value of a provider's beforeXxx method
-     * @param setAfter function to set the return value of a provider's afterXxx method
-     * @param action invokes the operation
+     * @param setBefore    function to set the return value of a provider's beforeXxx method
+     * @param setAfter     function to set the return value of a provider's afterXxx method
+     * @param action       invokes the operation
      * @param verifyBefore verifies that a provider's beforeXxx method was invoked
      * @param verifyMiddle verifies that the action occurring between the beforeXxx loop
-     *        and the afterXxx loop was invoked
-     * @param verifyAfter verifies that a provider's afterXxx method was invoked
+     *                     and the afterXxx loop was invoked
+     * @param verifyAfter  verifies that a provider's afterXxx method was invoked
      * @throws Exception if an error occurs while calling {@link #setUp()}
      */
     private void checkBeforeAfter_FalseTrue(BiConsumer<PolicyEngineFeatureApi, Boolean> setBefore,
-                    BiConsumer<PolicyEngineFeatureApi, Boolean> setAfter, Runnable action,
-                    Consumer<PolicyEngineFeatureApi> verifyBefore, Runnable verifyMiddle,
-                    Consumer<PolicyEngineFeatureApi> verifyAfter) throws Exception {
+                                            BiConsumer<PolicyEngineFeatureApi, Boolean> setAfter, Runnable action,
+                                            Consumer<PolicyEngineFeatureApi> verifyBefore, Runnable verifyMiddle,
+                                            Consumer<PolicyEngineFeatureApi> verifyAfter) throws Exception {
 
         setUp();
 
@@ -1957,19 +1965,19 @@ class PolicyEngineManagerTest {
      * case where the first provider's beforeXxx returns {@code true}, while the others
      * return {@code false}.
      *
-     * @param setBefore function to set the return value of a provider's beforeXxx method
-     * @param setAfter function to set the return value of a provider's afterXxx method
-     * @param action invokes the operation
+     * @param setBefore    function to set the return value of a provider's beforeXxx method
+     * @param setAfter     function to set the return value of a provider's afterXxx method
+     * @param action       invokes the operation
      * @param verifyBefore verifies that a provider's beforeXxx method was invoked
      * @param verifyMiddle verifies that the action occurring between the beforeXxx loop
-     *        and the afterXxx loop was invoked
-     * @param verifyAfter verifies that a provider's afterXxx method was invoked
+     *                     and the afterXxx loop was invoked
+     * @param verifyAfter  verifies that a provider's afterXxx method was invoked
      * @throws Exception if an error occurs while calling {@link #setUp()}
      */
     private void checkBeforeAfter_TrueFalse(BiConsumer<PolicyEngineFeatureApi, Boolean> setBefore,
-                    BiConsumer<PolicyEngineFeatureApi, Boolean> setAfter, Runnable action,
-                    Consumer<PolicyEngineFeatureApi> verifyBefore, Runnable verifyMiddle,
-                    Consumer<PolicyEngineFeatureApi> verifyAfter) throws Exception {
+                                            BiConsumer<PolicyEngineFeatureApi, Boolean> setAfter, Runnable action,
+                                            Consumer<PolicyEngineFeatureApi> verifyBefore, Runnable verifyMiddle,
+                                            Consumer<PolicyEngineFeatureApi> verifyAfter) throws Exception {
 
         setUp();