[POLICY-9,POLICY-18] warnings + Controller hooks

1. clean up policy-utils warnings.  drools-pdp project has
   no warnings now.

2. add new Policy Controller hooks for feature programmability.

Change-Id: Ie991320e23e73118b235018d15ea66340a841a89
Signed-off-by: Jorge Hernandez <jh1730@att.com>

1 files changed, 6 insertions, 123 deletions

diff --git a/policy-healthcheck/src/main/java/org/openecomp/policy/drools/healthcheck/HealthCheckFeature.java b/policy-healthcheck/src/main/java/org/openecomp/policy/drools/healthcheck/HealthCheckFeature.java
index b2f29392..63216f6d 100644
--- a/policy-healthcheck/src/main/java/org/openecomp/policy/drools/healthcheck/HealthCheckFeature.java
+++ b/policy-healthcheck/src/main/java/org/openecomp/policy/drools/healthcheck/HealthCheckFeature.java
@@ -20,34 +20,24 @@
 
 package org.openecomp.policy.drools.healthcheck;
 
-import java.util.Properties;
-
 import org.openecomp.policy.drools.features.PolicyEngineFeatureAPI;
 import org.openecomp.policy.drools.system.PolicyEngine;
 
+/**
+ * This feature provides healthcheck verification of remotely associated RESTful components
+ */
 public class HealthCheckFeature implements PolicyEngineFeatureAPI {
 	
-	public static final String CONFIGURATION_PROPERTIES_NAME = "policy-healthcheck";
-
 	/**
-	 * {@inheritDoc}
+	 * Properties Configuration Name
 	 */
+	public static final String CONFIGURATION_PROPERTIES_NAME = "policy-healthcheck";
+
 	@Override
 	public int getSequenceNumber() {
 		return 1000;
 	}
 
-	/**
-	 * {@inheritDoc}
-	 */
-	@Override
-	public boolean beforeStart(PolicyEngine engine) throws IllegalStateException {
-		return false;
-	}
-
-	/**
-	 * {@inheritDoc}
-	 */
 	@Override
 	public boolean afterStart(PolicyEngine engine) {
 		try {
@@ -59,17 +49,6 @@ public class HealthCheckFeature implements PolicyEngineFeatureAPI {
 		return false;
 	}
 
-	/**
-	 * {@inheritDoc}
-	 */
-	@Override
-	public boolean beforeShutdown(PolicyEngine engine) {
-		return false;
-	}
-
-	/**
-	 * {@inheritDoc}
-	 */
 	@Override
 	public boolean afterShutdown(PolicyEngine engine) {
 		try {
@@ -80,102 +59,6 @@ public class HealthCheckFeature implements PolicyEngineFeatureAPI {
 		
 		return false;
 	}
-
-	/**
-	 * {@inheritDoc}
-	 */
-	@Override
-	public boolean beforeConfigure(PolicyEngine engine, Properties properties) {
-		return false;
-	}
-
-	/**
-	 * {@inheritDoc}
-	 */
-	@Override
-	public boolean afterConfigure(PolicyEngine engine) {
-		return false;
-	}
-
-	/**
-	 * {@inheritDoc}
-	 */
-	@Override
-	public boolean beforeActivate(PolicyEngine engine) {
-		return false;
-	}
-
-	/**
-	 * {@inheritDoc}
-	 */
-	@Override
-	public boolean afterActivate(PolicyEngine engine) {
-		return false;
-	}
-
-	/**
-	 * {@inheritDoc}
-	 */
-	@Override
-	public boolean beforeDeactivate(PolicyEngine engine) {
-		return false;
-	}
-
-	/**
-	 * {@inheritDoc}
-	 */
-	@Override
-	public boolean afterDeactivate(PolicyEngine engine) {
-		return false;
-	}
-
-	/**
-	 * {@inheritDoc}
-	 */
-	@Override
-	public boolean beforeStop(PolicyEngine engine) {
-		return false;
-	}
-
-	/**
-	 * {@inheritDoc}
-	 */
-	@Override
-	public boolean afterStop(PolicyEngine engine) {
-		return false;
-	}
-
-	/**
-	 * {@inheritDoc}
-	 */
-	@Override
-	public boolean beforeLock(PolicyEngine engine) {
-		return false;
-	}
-
-	/**
-	 * {@inheritDoc}
-	 */
-	@Override
-	public boolean afterLock(PolicyEngine engine) {
-		return false;
-	}
-
-	/**
-	 * {@inheritDoc}
-	 */
-	@Override
-	public boolean beforeUnlock(PolicyEngine engine) {
-		return false;
-	}
-
-	/**
-	 * {@inheritDoc}
-	 */
-	@Override
-	public boolean afterUnlock(PolicyEngine engine) {
-		return false;
-	}
 	
 	/**
 	 * gets the monitor