Sonar cleanup

More sonar cleanup. Resolved some of the simpler issues.

Issue-ID: POLICY-728
Change-Id: If9c4718f10c6d3524239d2a05c09badb791ef2f0
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

4 files changed, 8 insertions, 8 deletions

diff --git a/policy-endpoints/src/main/java/org/onap/policy/drools/event/comm/bus/internal/SingleThreadedDmaapTopicSource.java b/policy-endpoints/src/main/java/org/onap/policy/drools/event/comm/bus/internal/SingleThreadedDmaapTopicSource.java
index 88d67fd2..b0c456da 100644
--- a/policy-endpoints/src/main/java/org/onap/policy/drools/event/comm/bus/internal/SingleThreadedDmaapTopicSource.java
+++ b/policy-endpoints/src/main/java/org/onap/policy/drools/event/comm/bus/internal/SingleThreadedDmaapTopicSource.java
@@ -38,7 +38,7 @@ public class SingleThreadedDmaapTopicSource extends SingleThreadedBusTopicSource
 
 	private static Logger logger = LoggerFactory.getLogger(SingleThreadedDmaapTopicSource.class);
 	
-	protected boolean allowSelfSignedCerts;
+
 	protected final String userName;
 	protected final String password;
 	
diff --git a/policy-endpoints/src/main/java/org/onap/policy/drools/http/client/HttpClientFactory.java b/policy-endpoints/src/main/java/org/onap/policy/drools/http/client/HttpClientFactory.java
index 06aa4630..1094a2fb 100644
--- a/policy-endpoints/src/main/java/org/onap/policy/drools/http/client/HttpClientFactory.java
+++ b/policy-endpoints/src/main/java/org/onap/policy/drools/http/client/HttpClientFactory.java
@@ -50,7 +50,7 @@ public interface HttpClientFactory {
 	/**
 	 * build http client from properties
 	 */
-	public ArrayList<HttpClient> build(Properties properties) 
+	public List<HttpClient> build(Properties properties) 
 			throws KeyManagementException, NoSuchAlgorithmException;
 	
 	/**
@@ -106,7 +106,7 @@ class IndexedHttpClientFactory implements HttpClientFactory {
 	}
 
 	@Override
-	public synchronized ArrayList<HttpClient> build(Properties properties) 
+	public synchronized List<HttpClient> build(Properties properties) 
 	throws KeyManagementException, NoSuchAlgorithmException {
 		ArrayList<HttpClient> clientList = new ArrayList<>();
 		
diff --git a/policy-endpoints/src/main/java/org/onap/policy/drools/http/server/HttpServletServerFactory.java b/policy-endpoints/src/main/java/org/onap/policy/drools/http/server/HttpServletServerFactory.java
index b6366d00..8c35602b 100644
--- a/policy-endpoints/src/main/java/org/onap/policy/drools/http/server/HttpServletServerFactory.java
+++ b/policy-endpoints/src/main/java/org/onap/policy/drools/http/server/HttpServletServerFactory.java
@@ -58,7 +58,7 @@ public interface HttpServletServerFactory {
 	 * @return list of http servers
 	 * @throws IllegalArgumentException when invalid parameters are provided
 	 */
-	public ArrayList<HttpServletServer> build(Properties properties) throws IllegalArgumentException;
+	public List<HttpServletServer> build(Properties properties) throws IllegalArgumentException;
 	
 	/**
 	 * gets a server based on the port
@@ -119,7 +119,7 @@ class IndexedHttpServletServerFactory implements HttpServletServerFactory {
 	}
 	
 	@Override
-	public synchronized ArrayList<HttpServletServer> build(Properties properties) 
+	public synchronized List<HttpServletServer> build(Properties properties) 
 		throws IllegalArgumentException {	
 		
 		ArrayList<HttpServletServer> serviceList = new ArrayList<>();
diff --git a/policy-endpoints/src/test/java/org/onap/policy/drools/http/server/test/HttpClientTest.java b/policy-endpoints/src/test/java/org/onap/policy/drools/http/server/test/HttpClientTest.java
index dd9a7c2b..6a84d142 100644
--- a/policy-endpoints/src/test/java/org/onap/policy/drools/http/server/test/HttpClientTest.java
+++ b/policy-endpoints/src/test/java/org/onap/policy/drools/http/server/test/HttpClientTest.java
@@ -23,7 +23,7 @@ package org.onap.policy.drools.http.server.test;
 import static org.junit.Assert.assertTrue;
 
 import java.io.IOException;
-import java.util.ArrayList;
+import java.util.List;
 import java.util.Properties;
 
 import javax.ws.rs.core.Response;
@@ -180,10 +180,10 @@ public class HttpClientTest {
     httpProperties.setProperty(PolicyProperties.PROPERTY_HTTP_CLIENT_SERVICES + "." + "PDP"
         + PolicyProperties.PROPERTY_MANAGED_SUFFIX, "true");
 
-    final ArrayList<HttpServletServer> servers = HttpServletServer.factory.build(httpProperties);
+    final List<HttpServletServer> servers = HttpServletServer.factory.build(httpProperties);
     assertTrue(servers.size() == 2);
 
-    final ArrayList<HttpClient> clients = HttpClient.factory.build(httpProperties);
+    final List<HttpClient> clients = HttpClient.factory.build(httpProperties);
     assertTrue(clients.size() == 2);
 
     for (final HttpServletServer server : servers) {