diff options
author | Jim Hahn <jrh3@att.com> | 2018-01-31 17:49:08 -0500 |
---|---|---|
committer | Jim Hahn <jrh3@att.com> | 2018-01-31 17:54:01 -0500 |
commit | 4401819b97be13c244dfe206256b59d13c89f7a6 (patch) | |
tree | 8185d79ee850547cd7edc77bb30acb7ec509162d /feature-state-management/src/test | |
parent | 9e2820c5820b3904e03cb7a4cb4292e864b1ca2b (diff) |
Fix sonar issues in feature-state-management
DroolsPDPIntegrityMonitor.java:
Modified init() to throw just IntegrityMonitorException.
Modified DroolsPDPIntegrityMonitor init() method to throw specific
types of exceptions.
StateManagementFeature.java:
Sonar complained about needing to merge "if" statements, but chose
to eliminate the "if(logger.isDebugEnabled())" instead - did this
through-out the source file.
Removed extra runtime exception from "throws" declaration.
DbAudit.java:
Fixed sonar issue regarding setting a static variable from within
a non-static method.
Removed logger.isDebugEnabled() tests where method calls are not involed.
Simplified invoke() method complexity as reported by sonar.
DroolsPDPIntegrityMonitor.java:
Reduced init() complexity reported by sonar.
Change-Id: Ib2722b21bbf3aad130af46c8790f40d8777e36be
Issue-ID: POLICY-469
Signed-off-by: Jim Hahn <jrh3@att.com>
Diffstat (limited to 'feature-state-management/src/test')
-rw-r--r-- | feature-state-management/src/test/java/org/onap/policy/drools/statemanagement/test/StateManagementTest.java | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/feature-state-management/src/test/java/org/onap/policy/drools/statemanagement/test/StateManagementTest.java b/feature-state-management/src/test/java/org/onap/policy/drools/statemanagement/test/StateManagementTest.java index 85e0ed85..b364ef83 100644 --- a/feature-state-management/src/test/java/org/onap/policy/drools/statemanagement/test/StateManagementTest.java +++ b/feature-state-management/src/test/java/org/onap/policy/drools/statemanagement/test/StateManagementTest.java @@ -185,6 +185,7 @@ public class StateManagementTest { /**************Repository Audit Test**************/ logger.debug("\n\ntestStateManagementOperation: Repository Audit\n\n"); try{ + StateManagementProperties.initProperties(fsmProperties); RepositoryAudit repositoryAudit = (RepositoryAudit) RepositoryAudit.getInstance(); repositoryAudit.invoke(fsmProperties); |