diff options
author | 2020-02-04 19:24:26 -0600 | |
---|---|---|
committer | 2020-02-04 19:24:26 -0600 | |
commit | a24aa1615648b0698bb662f64915e8ba2d520e03 (patch) | |
tree | fd2c141aad4446404b89facc23d3445518c637f8 /feature-lifecycle/src/test/java/org/onap | |
parent | 06a1c3040a4a1a88654a91761fda8967806c9fd3 (diff) |
tackle few comments from DomainMaker review
Issue-ID: POLICY-2345
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I325d0c4892d46dad72303e3dcbc38238a029a725
Diffstat (limited to 'feature-lifecycle/src/test/java/org/onap')
-rw-r--r-- | feature-lifecycle/src/test/java/org/onap/policy/drools/domain/models/DroolsPolicyModelsTest.java | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/feature-lifecycle/src/test/java/org/onap/policy/drools/domain/models/DroolsPolicyModelsTest.java b/feature-lifecycle/src/test/java/org/onap/policy/drools/domain/models/DroolsPolicyModelsTest.java index 813acdfa..d99dd089 100644 --- a/feature-lifecycle/src/test/java/org/onap/policy/drools/domain/models/DroolsPolicyModelsTest.java +++ b/feature-lifecycle/src/test/java/org/onap/policy/drools/domain/models/DroolsPolicyModelsTest.java @@ -20,6 +20,8 @@ package org.onap.policy.drools.domain.models; +import static org.junit.Assert.assertNotNull; + import com.openpojo.reflection.PojoClass; import com.openpojo.reflection.filters.FilterChain; import com.openpojo.reflection.filters.FilterClassName; @@ -58,7 +60,8 @@ public class DroolsPolicyModelsTest { @Test public void testBuildDomainPolicyNativeDrools() { /* manually create a native drools policy */ - NativeDroolsPolicy.builder().metadata(Metadata.builder().policyId("policy-id").build()).name("example") + assertNotNull(NativeDroolsPolicy.builder().metadata(Metadata.builder().policyId("policy-id").build()) + .name("example") .type("onap.policies.native.Drools") .typeVersion("1.0.0") .version("1.0.0") @@ -68,19 +71,20 @@ public class DroolsPolicyModelsTest { .rulesArtifact( NativeDroolsRulesArtifact.builder().groupId("org.onap.policy.controlloop") .artifactId("example").version("example").build()).build()) - .build(); + .build()); } @Test public void testBuildDomainPolicyController() { /* manually create a controller policy */ - ControllerPolicy.builder().metadata(Metadata.builder().policyId("policy-id").build()).name("example") + assertNotNull(ControllerPolicy.builder().metadata(Metadata.builder().policyId("policy-id").build()) + .name("example") .version("1.0.0") .type("onap.policies.drools.Controller") .typeVersion("1.0.0") .properties(ControllerProperties.builder().controllerName("example").sourceTopics( new ArrayList<>()).sinkTopics(new ArrayList<>()).build()) - .build(); + .build()); } }
\ No newline at end of file |