diff options
author | rameshiyer27 <ramesh.murugan.iyer@est.tech> | 2023-08-28 17:32:18 +0100 |
---|---|---|
committer | rameshiyer27 <ramesh.murugan.iyer@est.tech> | 2023-08-28 17:32:18 +0100 |
commit | d6f6ebc925506cdf18b903df2cd3cbcef311082d (patch) | |
tree | eda1d495b15f2df896f4f81cbb0e4f1ab7c6f1a3 /feature-lifecycle/src/main/java/org | |
parent | c05015ae25604825d9a1d951e3a2d0981b955eae (diff) |
Remove pdp statistics implementations from drools-pdp
Issue-ID: POLICY-4109
Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech>
Change-Id: I9fd807e4df5392cef680202ad80c7cc269d7b349
Diffstat (limited to 'feature-lifecycle/src/main/java/org')
2 files changed, 0 insertions, 73 deletions
diff --git a/feature-lifecycle/src/main/java/org/onap/policy/drools/lifecycle/LifecycleFsm.java b/feature-lifecycle/src/main/java/org/onap/policy/drools/lifecycle/LifecycleFsm.java index 4ded8dc9..c946f3b2 100644 --- a/feature-lifecycle/src/main/java/org/onap/policy/drools/lifecycle/LifecycleFsm.java +++ b/feature-lifecycle/src/main/java/org/onap/policy/drools/lifecycle/LifecycleFsm.java @@ -61,7 +61,6 @@ import org.onap.policy.drools.system.PolicyController; import org.onap.policy.drools.system.PolicyEngineConstants; import org.onap.policy.models.pdp.concepts.PdpResponseDetails; import org.onap.policy.models.pdp.concepts.PdpStateChange; -import org.onap.policy.models.pdp.concepts.PdpStatistics; import org.onap.policy.models.pdp.concepts.PdpStatus; import org.onap.policy.models.pdp.concepts.PdpUpdate; import org.onap.policy.models.pdp.enums.PdpHealthStatus; @@ -164,9 +163,6 @@ public class LifecycleFsm implements Startable { @Getter protected final Map<ToscaConceptIdentifier, ToscaPolicy> policiesMap = new HashMap<>(); - @Getter - protected final PdpStatistics stats = new PdpStatistics(); - /** * Constructor. */ @@ -206,7 +202,6 @@ public class LifecycleFsm implements Startable { public String getPdpName() { if (this.pdpName == null) { this.pdpName = PolicyEngineConstants.getManager().getPdpName(); - this.stats.setPdpInstanceId(pdpName); } return this.pdpName; @@ -224,7 +219,6 @@ public class LifecycleFsm implements Startable { */ public synchronized void setGroup(String group) { this.group = group; - this.stats.setPdpGroupName(group); } /** @@ -232,7 +226,6 @@ public class LifecycleFsm implements Startable { */ public synchronized void setSubGroup(String subGroup) { this.subGroup = subGroup; - this.stats.setPdpSubGroupName(subGroup); } /* ** FSM events - entry points of events into the FSM ** */ @@ -240,7 +233,6 @@ public class LifecycleFsm implements Startable { @Override public synchronized boolean start() { this.pdpName = PolicyEngineConstants.getManager().getPdpName(); - stats.setPdpInstanceId(pdpName); logger.info("lifecycle event: start engine"); return state.start(); } @@ -462,8 +454,6 @@ public class LifecycleFsm implements Startable { deploymentsCounter.labels(state.state().name(), PrometheusUtils.DEPLOY_OPERATION, PdpResponseStatus.SUCCESS.name()).inc(); - getStats().setPolicyDeployCount(getStats().getPolicyDeployCount() + 1); - getStats().setPolicyDeploySuccessCount(getStats().getPolicyDeploySuccessCount() + 1); return policy; }); } @@ -475,8 +465,6 @@ public class LifecycleFsm implements Startable { deploymentsCounter.labels(state.state().name(), PrometheusUtils.UNDEPLOY_OPERATION, PdpResponseStatus.SUCCESS.name()).inc(); - getStats().setPolicyUndeployCount(getStats().getPolicyUndeployCount() + 1); - getStats().setPolicyUndeploySuccessCount(getStats().getPolicyUndeploySuccessCount() + 1); return null; }); } @@ -485,52 +473,16 @@ public class LifecycleFsm implements Startable { deploymentsCounter.labels(state.state().name(), PrometheusUtils.DEPLOY_OPERATION, PdpResponseStatus.FAIL.name()).inc(); - getStats().setPolicyDeployCount(getStats().getPolicyDeployCount() + 1); - getStats().setPolicyDeployFailCount(getStats().getPolicyDeployFailCount() + 1); } protected void failedUndeployPolicyAction(ToscaPolicy failedPolicy) { deploymentsCounter.labels(state.state().name(), PrometheusUtils.UNDEPLOY_OPERATION, PdpResponseStatus.FAIL.name()).inc(); - getStats().setPolicyUndeployCount(getStats().getPolicyUndeployCount() + 1); - getStats().setPolicyUndeployFailCount(getStats().getPolicyUndeployFailCount() + 1); policiesMap.remove(failedPolicy.getIdentifier()); } - protected void updateDeployCountsAction(Long deployCount, Long deploySuccesses, Long deployFailures) { - PdpStatistics statistics = getStats(); - if (deployCount != null) { - statistics.setPolicyDeployCount(deployCount); - } - - if (deploySuccesses != null) { - statistics.setPolicyDeploySuccessCount(deploySuccesses); - } - - if (deployFailures != null) { - statistics.setPolicyDeployFailCount(deployFailures); - } - } - - protected void updateUndeployCountsAction(Long undeployCount, Long undeploySuccesses, Long undeployFailures) { - PdpStatistics statistics = getStats(); - if (undeployCount != null) { - statistics.setPolicyUndeployCount(undeployCount); - } - - if (undeploySuccesses != null) { - statistics.setPolicyUndeploySuccessCount(undeploySuccesses); - } - - if (undeployFailures != null) { - statistics.setPolicyUndeployFailCount(undeployFailures); - } - } - protected List<ToscaPolicy> resetPoliciesAction() { - updateDeployCountsAction(0L, 0L, 0L); - updateUndeployCountsAction(0L, 0L, 0L); List<ToscaPolicy> policies = new ArrayList<>(getActivePolicies()); policiesMap.clear(); return policies; @@ -671,21 +623,6 @@ public class LifecycleFsm implements Startable { return status; } - /** - * It provides a snapshot of the current statistics. - */ - public PdpStatistics statisticsPayload() { - var updateStats = new PdpStatistics(stats); - updateStats.setTimeStamp(Instant.now()); - - try { - BeanUtils.copyProperties(updateStats, PolicyEngineConstants.getManager().getStats().getGroupStat()); - } catch (IllegalAccessException | InvocationTargetException ex) { - logger.debug("statistics mapping failure", ex); - } - - return updateStats; - } private boolean source() { List<TopicSource> sources = TopicEndpointManager.getManager().addTopicSources(properties); diff --git a/feature-lifecycle/src/main/java/org/onap/policy/drools/server/restful/RestLifecycleManager.java b/feature-lifecycle/src/main/java/org/onap/policy/drools/server/restful/RestLifecycleManager.java index 7282a59b..cad980f5 100644 --- a/feature-lifecycle/src/main/java/org/onap/policy/drools/server/restful/RestLifecycleManager.java +++ b/feature-lifecycle/src/main/java/org/onap/policy/drools/server/restful/RestLifecycleManager.java @@ -375,16 +375,6 @@ public class RestLifecycleManager implements LifecycleApi { return Response.status(Response.Status.OK).entity(Collections.emptyList()).build(); } - /** - * Get current counts. - */ - - @Override - @GET - @Path("statistics") - public Response stats() { - return Response.status(Response.Status.OK).entity(LifecycleFeature.getFsm().statisticsPayload()).build(); - } private Response deployUndeployOperation(String policy, boolean deploy) { var toscaPolicy = getToscaPolicy(policy); |