diff options
author | Taka Cho <takamune.cho@att.com> | 2020-06-09 11:21:31 -0400 |
---|---|---|
committer | Taka Cho <takamune.cho@att.com> | 2020-06-15 12:16:32 -0400 |
commit | 6e22f6ba5a83c8e55bec56798e8e4c7a3d4b002b (patch) | |
tree | 6257a46d109aae731d9f1a98c334251d6cc9d513 /feature-eelf/src/test/java/org | |
parent | 7a64baa7a15c07c2bbb90c41594b82e8c8bfc816 (diff) |
reduce sonar issue - 2 rev
In some conditions for assertTrue, sonarcloud
recommends using assertEquals
Assert.assertTrue(a.equals(b));
Assert.assertTrue(a == b);
Assert.assertTrue(a == null);
Assert.assertTrue(a != null);
Assert.assertFalse(a.equals(b));
Compliant Solution
Assert.assertEquals(a, b);
Assert.assertSame(a, b);
Assert.assertNull(a);
Assert.assertNotNull(a);
Assert.assertNotEquals(a, b);
Issue-ID: POLICY-2616
Change-Id: Ib362573bd865d1b561916bf64640c8ddeaa02546
Signed-off-by: Taka Cho <takamune.cho@att.com>
Diffstat (limited to 'feature-eelf/src/test/java/org')
-rw-r--r-- | feature-eelf/src/test/java/org/onap/policy/drools/eelf/test/EElfTest.java | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/feature-eelf/src/test/java/org/onap/policy/drools/eelf/test/EElfTest.java b/feature-eelf/src/test/java/org/onap/policy/drools/eelf/test/EElfTest.java index c0f271cf..dfa85948 100644 --- a/feature-eelf/src/test/java/org/onap/policy/drools/eelf/test/EElfTest.java +++ b/feature-eelf/src/test/java/org/onap/policy/drools/eelf/test/EElfTest.java @@ -20,6 +20,7 @@ package org.onap.policy.drools.eelf.test; +import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertTrue; @@ -76,11 +77,11 @@ public class EElfTest { * @param slf4jLogger SLF4J Logger */ protected void assertLogLevels(EELFLogger eelfLogger, Logger slf4jLogger) { - assertTrue(slf4jLogger.isDebugEnabled() == eelfLogger.isDebugEnabled()); - assertTrue(slf4jLogger.isInfoEnabled() == eelfLogger.isInfoEnabled()); - assertTrue(slf4jLogger.isErrorEnabled() == eelfLogger.isErrorEnabled()); - assertTrue(slf4jLogger.isWarnEnabled() == eelfLogger.isWarnEnabled()); - assertTrue(slf4jLogger.isTraceEnabled() == eelfLogger.isTraceEnabled()); + assertEquals(slf4jLogger.isDebugEnabled(), eelfLogger.isDebugEnabled()); + assertEquals(slf4jLogger.isInfoEnabled(), eelfLogger.isInfoEnabled()); + assertEquals(slf4jLogger.isErrorEnabled(), eelfLogger.isErrorEnabled()); + assertEquals(slf4jLogger.isWarnEnabled(), eelfLogger.isWarnEnabled()); + assertEquals(slf4jLogger.isTraceEnabled(), eelfLogger.isTraceEnabled()); } @Test |