diff options
| author |   Jim Hahn <jrh3@att.com> | 2020-08-31 08:22:13 -0400 |
|---|---|---|
| committer | Jim Hahn <jrh3@att.com> | 2020-08-31 10:15:07 -0400 |
| commit | d5c365f60e492e37a361654974eba1719146bdc2 (patch) | |
| tree | f717c2198c1aebe0cc03a5d3e9aec653d0d73807 /feature-active-standby-management/src/main/java/org/onap | |
| parent | 7dc71c3d0aedb322aff0cdaaa84340354c41b089 (diff) | |
Fix more sonars in drools-pdp
Fixed more sonars in drools-pdp:
- remove commented code
- don't throw generic Exception
- unused field (made it protected instead of private)
- log conditionally
- cognitive complexity
- too many break/continue
- return empty list instead of null
- Random() is not secure
Fixed more eclipse warnings:
- parameterize generic types
Issue-ID: POLICY-2616-sonars3
Change-Id: Ia5ad769b2ea763568cfae3d81807926d89153b09
Signed-off-by: Jim Hahn <jrh3@att.com>
Diffstat (limited to 'feature-active-standby-management/src/main/java/org/onap')
| -rw-r--r-- | feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/DroolsPdpsElectionHandler.java | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/DroolsPdpsElectionHandler.java b/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/DroolsPdpsElectionHandler.java index acb7cd54..4d40fd5e 100644 --- a/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/DroolsPdpsElectionHandler.java +++ b/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/DroolsPdpsElectionHandler.java @@ -587,10 +587,7 @@ public class DroolsPdpsElectionHandler implements ThreadRunningChecker { * Only call promote if it is not already in the right state. Don't worry about * synching the lower level topic endpoint states. That is done by the * refreshStateAudit. - * Note that we need to fetch the session list from 'mostRecentPrimary' - * at this point -- soon, 'mostRecentPrimary' will be set to this host. */ - //this.sessions = mostRecentPrimary.getSessions(); stateManagementFeature.promote(); } } catch (Exception e) { |