Fix checkstyle issues in api-state-management

Also deleted the checkstyle suppression file.

Change-Id: Ib43a75c2e214db61a75173be095c380c7c7488f1
Issue-ID: POLICY-1902
Signed-off-by: Jim Hahn <jrh3@att.com>

3 files changed, 5 insertions, 36 deletions

diff --git a/api-state-management/checkstyle-suppressions.xml b/api-state-management/checkstyle-suppressions.xml
deleted file mode 100644
index f208c3ab..00000000
--- a/api-state-management/checkstyle-suppressions.xml
+++ /dev/null
@@ -1,30 +0,0 @@
-<?xml version="1.0"?>
-<!--
-  ============LICENSE_START=======================================================
-   Copyright (C) 2018 AT&T Technologies. All rights reserved.
-  ================================================================================
-  Licensed under the Apache License, Version 2.0 (the "License");
-  you may not use this file except in compliance with the License.
-  You may obtain a copy of the License at
-  
-       http://www.apache.org/licenses/LICENSE-2.0
-  
-  Unless required by applicable law or agreed to in writing, software
-  distributed under the License is distributed on an "AS IS" BASIS,
-  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  See the License for the specific language governing permissions and
-  limitations under the License.
-  
-  SPDX-License-Identifier: Apache-2.0
-  ============LICENSE_END=========================================================
--->
-
-<!DOCTYPE suppressions PUBLIC
-     "-//Puppy Crawl//DTD Suppressions 1.0//EN"
-     "http://www.puppycrawl.com/dtds/suppressions_1_0.dtd">
- 
-<suppressions>
-  <suppress checks="AbbreviationAsWordInName"
-    files="StateManagementFeatureAPI.java"
-    lines="1-9999"/>
-</suppressions>
diff --git a/api-state-management/pom.xml b/api-state-management/pom.xml
index 824c3b91..6f8a55a5 100644
--- a/api-state-management/pom.xml
+++ b/api-state-management/pom.xml
@@ -2,7 +2,7 @@
   ============LICENSE_START=======================================================
   ONAP Policy Engine - Drools PDP
   ================================================================================
-  Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+  Copyright (C) 2017, 2019 AT&T Intellectual Property. All rights reserved.
   ================================================================================
   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.
@@ -76,7 +76,6 @@
                             <includeTestResources>true</includeTestResources>
                             <excludes>
                             </excludes>
-                            <suppressionsLocation>${project.baseUri}checkstyle-suppressions.xml</suppressionsLocation>
                             <consoleOutput>true</consoleOutput>
                             <failsOnViolation>true</failsOnViolation>
                             <violationSeverity>warning</violationSeverity>
diff --git a/api-state-management/src/main/java/org/onap/policy/drools/statemanagement/StateManagementFeatureAPI.java b/api-state-management/src/main/java/org/onap/policy/drools/statemanagement/StateManagementFeatureApi.java
index 049b2643..dcb784e3 100644
--- a/api-state-management/src/main/java/org/onap/policy/drools/statemanagement/StateManagementFeatureAPI.java
+++ b/api-state-management/src/main/java/org/onap/policy/drools/statemanagement/StateManagementFeatureApi.java
@@ -36,7 +36,7 @@ import org.onap.policy.common.utils.services.OrderedServiceImpl;
  * optional methods. Most of the methods here are notification only -- these tend to return a 'void'
  * value. In other cases, such as 'activatePolicySession', may
  */
-public interface StateManagementFeatureAPI extends OrderedService, Lockable {
+public interface StateManagementFeatureApi extends OrderedService, Lockable {
 
     public static final String LOCKED = StateManagement.LOCKED;
     public static final String UNLOCKED = StateManagement.UNLOCKED;
@@ -71,8 +71,8 @@ public interface StateManagementFeatureAPI extends OrderedService, Lockable {
      * 'FeatureAPI.impl.getList()' returns an ordered list of objects implementing the 'FeatureAPI'
      * interface.
      */
-    public static OrderedServiceImpl<StateManagementFeatureAPI> impl =
-            new OrderedServiceImpl<>(StateManagementFeatureAPI.class);
+    public static OrderedServiceImpl<StateManagementFeatureApi> impl =
+            new OrderedServiceImpl<>(StateManagementFeatureApi.class);
 
     /**
      * ALL SEEMS/NOT WELL This interface is used to support the concept of All Seems/Not Well. It
@@ -134,7 +134,7 @@ public interface StateManagementFeatureAPI extends OrderedService, Lockable {
     /**
      * Returns the X.731 Standby Status for the named resource
      *
-     * @param String (resourceName)
+     * @param resourceName the resource name
      * @return String (providingservice, hotstandby or coldstandby)
      */
     public String getStandbyStatus(String resourceName);