summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjhh <jorge.hernandez-herrero@att.com>2021-07-07 07:34:56 -0500
committerjhh <jorge.hernandez-herrero@att.com>2021-07-07 09:38:06 -0500
commit62597d6fcdea939c5fdbbc3d870023f1458c8704 (patch)
tree98cd982abb683c6b3768615087fd038e9c53b4cc
parentd8a37f498545b318c61a13999077882258cc472e (diff)
nosonar on admin logging level function
Issue-ID: POLICY-3077 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ieae80c77db297271c9de3958d321bfe4b88acce3 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
-rw-r--r--policy-management/src/main/java/org/onap/policy/drools/controller/internal/NullDroolsController.java9
-rw-r--r--policy-utils/src/main/java/org/onap/policy/drools/utils/logging/LoggerUtil.java12
2 files changed, 13 insertions, 8 deletions
diff --git a/policy-management/src/main/java/org/onap/policy/drools/controller/internal/NullDroolsController.java b/policy-management/src/main/java/org/onap/policy/drools/controller/internal/NullDroolsController.java
index 624a6049..5ac1d6da 100644
--- a/policy-management/src/main/java/org/onap/policy/drools/controller/internal/NullDroolsController.java
+++ b/policy-management/src/main/java/org/onap/policy/drools/controller/internal/NullDroolsController.java
@@ -26,6 +26,7 @@ import java.util.HashMap;
import java.util.List;
import java.util.Map;
import lombok.NonNull;
+import lombok.ToString;
import org.onap.policy.common.endpoints.event.comm.TopicSink;
import org.onap.policy.drools.controller.DroolsController;
import org.onap.policy.drools.controller.DroolsControllerConstants;
@@ -35,6 +36,7 @@ import org.onap.policy.drools.protocol.coders.TopicCoderFilterConfiguration;
/**
* no-op Drools Controller.
*/
+@ToString
public class NullDroolsController implements DroolsController {
@Override
@@ -153,13 +155,6 @@ public class NullDroolsController implements DroolsController {
}
@Override
- public String toString() {
- StringBuilder builder = new StringBuilder();
- builder.append("NullDroolsController []");
- return builder.toString();
- }
-
- @Override
public void updateToVersion(String newGroupId, String newArtifactId, String newVersion,
List<TopicCoderFilterConfiguration> decoderConfigurations,
List<TopicCoderFilterConfiguration> encoderConfigurations)
diff --git a/policy-utils/src/main/java/org/onap/policy/drools/utils/logging/LoggerUtil.java b/policy-utils/src/main/java/org/onap/policy/drools/utils/logging/LoggerUtil.java
index b5e60679..e3f565d2 100644
--- a/policy-utils/src/main/java/org/onap/policy/drools/utils/logging/LoggerUtil.java
+++ b/policy-utils/src/main/java/org/onap/policy/drools/utils/logging/LoggerUtil.java
@@ -21,6 +21,7 @@
package org.onap.policy.drools.utils.logging;
import ch.qos.logback.classic.LoggerContext;
+import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.slf4j.Marker;
import org.slf4j.MarkerFactory;
@@ -30,6 +31,8 @@ import org.slf4j.MarkerFactory;
*/
public class LoggerUtil {
+ private static final Logger LOGGER = LoggerFactory.getLogger(LoggerUtil.class);
+
/**
* Logback configuration file system property.
*/
@@ -86,8 +89,15 @@ public class LoggerUtil {
throw new IllegalArgumentException("no logger " + loggerName);
}
+ LOGGER.warn("setting {} logger to level {}", loggerName, loggerLevel);
+
// use the current log level if the string provided cannot be converted to a valid Level.
- logger.setLevel(ch.qos.logback.classic.Level.toLevel(loggerLevel, logger.getLevel()));
+
+ // NOSONAR: this method is currently used by the telemetry api (which should be authenticated).
+ // It is no more or no less dangerous than an admin changing the logback level on the fly.
+ // This is a controlled admin function that should not cause any risks when the system
+ // is configured properly.
+ logger.setLevel(ch.qos.logback.classic.Level.toLevel(loggerLevel, logger.getLevel())); // NOSONAR
return logger.getLevel().toString();
}