Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
Adding new properties to guard Decision call.
Issue-ID: POLICY-2590
Change-Id: Ie4a37990e062c76ac4d6dd1b904ad354736fd27a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Signed-off-by: Jim Hahn <jrh3@att.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
modelVersion has to be a string
instead an integer
Issue-ID: POLICY-2814
Change-Id: I31c89d69f96076d490c665f4912d25e3892d011a
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
the feature-controlloop-tdjam will be installed in
docker, but disable by default
Issue-ID: POLICY-2415
Change-Id: I563a16bc698ce13eb1df0d8aa1cb7b7e7b8290b3
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
|
|
Modified drools-apps so that guards can be dynamically enabled and
disabled. Due to the current design, there are two properties that
control this:
- an actor-level property: when enabled, the DB connection is created,
otherwise a stub connection is created. This property is NOT dynamic
- an engine-level property: when enabled, the connection created by the
actor is used, otherwise a stub connection is used. This property IS
dynamic
Issue-ID: POLICY-2748
Change-Id: I2a5baf908ce274f2eb46a6a3f01df1b3532038ff
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
the details is on wiki:
https://wiki.onap.org/display/DW/tdjam+Feature+for+Tosca-Driven+Control+Loops
Fixed some eclipse warnings.
Revised the interaction between a manager and its SerialWorkQueue to
address some threading issues. The original code started processing
the event as soon as the manager was created, WHILE it was still being
added to the map. During junit tests, the event responses came back,
within the same thread, which then attempted to remove the manager from
the map. This resulted in a ConcurrentHashMap exception.
Issue-ID: POLICY-2415
Change-Id: I94a4152637be76e5b2aea2d869afd84dfb413a0e
Signed-off-by: Straubs, Ralph (rs8887) <rs8887@att.com>
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Signed-off-by: Taka Cho <takamune.cho@att.com>
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Made the following updates:
- modified feature-controlloop-utils to pull from the usecases
controller instead of the frankfurt controller
- modified ONAPInstance in the xacml-pdp Decision request
- log Step2 property changes as info() instead of error()
- log Lock acquisition as info() instead of warn()
Issue-ID: POLICY-2748
Change-Id: I6b4b5877bbd6731acb761d09d0f0dec85561b163
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2428
Change-Id: I87b66758c8984febcd5fb6e724fac3493f5d4cdf
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Removed usage of policy-yaml and old targetType definition.
Switched to using TOSCA operational policy classes and new
definitions for Target type enum.
Issue-ID: POLICY-2428
Change-Id: I25d1c5219764df27bdae7f2cbeb7ada7bcef4e1e
Signed-off-by: Jim Hahn <jrh3@att.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Added new usecases rules and feature.
Updates per review comments:
- kmodule.xml(s)
Issue-ID: POLICY-2748
Change-Id: I2f5cb05a4269f98a3b0a778730434955f0919b4a
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Created new "usecases" event manager.
Also fixed a couple of sonar issues in the new code.
Issue-ID: POLICY-2748
Change-Id: I17a2c41bbf4f4e8158adbd8aa5e32ef570daa9d3
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Add usecases-specific classes for managing preprocessor steps.
Issue-ID: POLICY-2748
Change-Id: I62a2bf8fbeb656a5017531a3f3de6a6dbad5a004
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Issue-ID: POLICY-2765
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I454365943465863b108ba8668b2bc4b201986959
|
|
Created place-holder for new "usecases" controller. Note: as of yet,
this is still just a normal java project; it will be turned into a
full-fledged kie-based controller in a later review.
Added some Operation and a few other support classes that will be
needed.
Note: the detmTarget() method and it's various supporting methods,
detmXxx(), found in GetTargetEntityOperation2 were cloned from the
pre-existing ControlLoopOperationManager2 class, and modified to fit the
strategy of the new controller. Likewise for the junit tests of those
methods.
Issue-ID: POLICY-2748
Change-Id: Idffa135a11a56bd6afdd2728706fd40168e80912
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Added classes that are event-agnostic and support moving control from
java into rules.
Updates per review comments:
- removed policy scope
Issue-ID: POLICY-2748-event-mgr
Change-Id: Icf811cc25a3975543fc5c725766b7b9df2bb87b0
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2766
Change-Id: I1ff7bbc4e301cfe6fa746f38c839acf83f7584b6
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
1, rename BaseRuleTest to BaseTest.
2, remove drools related code in BaseTest that would use
for tdjam controller.
3, DroolsRuleTest extends BaseTest
that would use for frankfurt controller for drools base.
Issue-ID: POLICY-2750
Change-Id: Ica9637a850de6e929f09532f077ae3e997aa2045
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
|
|
Change-Id: I6d2b17c5379b19b04589da4d7bc4a7f6ebc4d23a
Issue-ID: POLICY-2432
Signed-off-by: uj426b <uj426b@att.com>
|
|
With the advent of the new Actor model, then m2 model is no longer needed
in drools-apps.
Issue-ID: POLICY-2725
Change-Id: I3aa43619391552c00bd4e138aee96ca5d5bd55a8
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Issue-ID: POLICY-2673
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ib1bce9a813435718e83a6671d3790c610c14b709
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Saw this in the log:
java.lang.NoClassDefFoundError:
org/onap/policy/models/decisions/concepts/DecisionRequest
Added decisions jar to the (hopefully correct) pom.
Issue-ID: POLICY-2558
Change-Id: I5a2796b3eda6b3b39b2844cd112f5a18acfa0cf8
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Change-Id: Ia91fad549dfba0b3caa623be18652b93d0bc7fce
Issue-ID: POLICY-2716
Signed-off-by: uj426b <uj426b@att.com>
|
|
Made the following changes to remove usescase and legacy actor
code:
- deleted the usecases controller and feature
- deleted code associated with legacy actors, with the exception
of AaiManager, which is needed by RestControlLoopManager
- moved the contents of the "guard" project into the m2/guard project,
as that is the only thing that still needs it
- modified the m2/GuardContext to get the name of its persistence unit
from the properties so it could be overridden by junit tests
- used eclipselink constants
Also fixed a bug in the properties for the VFC actor.
Addressed review comment:
- removed usecases from Dockerfile
Issue-ID: POLICY-2558
Change-Id: I677d68c9efed9247c3d55773abdcc736b577a6b4
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2695
Change-Id: Iec9af37a01ba35c5b5419399cfb3d3bc80093101
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: Iffecc4655d22b507188ea266e82046f2a82751e8
Issue-ID: POLICY-2703
Signed-off-by: uj426b <uj426b@att.com>
|
|
add isInstanceOf for assertThatThrownBy.
Issue-ID: POLICY-2616
Change-Id: If49255aec6004870d7d2acfeabe258def872c1fa
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Modified drools-apps to use XxxActor instead of XxxActorServiceProvider.
This is the second step of the rename.
Issue-ID: POLICY-2684
Change-Id: Iea60e92f914b7719ac765b086650479be9192d98
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Issue-ID: POLICY-2387
Change-Id: I1c3ee615f0a72a9e7cec8ccc573e27a0cbe3f02c
Signed-off-by: RossC <ross.carter@est.tech>
|
|
- elevate the visibility of readResolve
- test case without assertions
Issue-ID: POLICY-2616
Change-Id: Ifde4b8c5e1281f8625a1203858fbe0467defe353
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
The Pair changes made in drools-pdp also broke drools-apps builds.
Replaced usage of drools.utils.Pair with apache Pair.
Issue-ID: POLICY-2202
Change-Id: I50aaad47c243637688602ae6cb680a929fe3edd9
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
- remove some unused statement
- remove unnecessary check
Issue-ID: POLICY-2616
Change-Id: Ieb2c898a3c6ad7210642aef990b43c9a01fc15b3
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
This is a quick fix to get around a build error in drools-applications
due to "Pair" changes made in policy-common and/or policy-models.
Issue-ID: POLICY-2202
Change-Id: If1cb60947e55d97ef7cfb1d05d69e07c54c71a05
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
- "get" returns a string already
- to avoid sonar issue for duplicated strings
- formating
Issue-ID: POLICY-2616
Change-Id: I1fac65bba5ecb402c784dd585ebcd7992cf31545
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Fixed checkstyle issues that were subsequently reported.
Also fixed a few eclipse warnings.
Also fixed some of the sonar issues in the files that were touched:
- use "{}" in logger calls
- camelcase method names
- use "<?>" instead of generics
- add serialization ID
Issue-ID: POLICY-2188
Change-Id: I5c94a2e26dd74a61a0a919e1c3da17ab02a5bc9d
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2188
Change-Id: Ib90222c537c5440e0de52fa0acbaa99bbcc4772a
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
- unused import
- Hide Utility Class Constructor : Utility classes
should not have a public or default constructor
Issue-ID: POLICY-2616
Change-Id: I338a739b6e9fb5f4b47898566362b8a87201dae3
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
|
|
- unused import
- logger format
- Extract the assignment out of this expression
- Replace this if-then-else statement
by a single return statement
Issue-ID: POLICY-2616
Change-Id: I2d04569a7070f79fc8979274bce2b87b4b2f3e24
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
|
|
swap the arguments
use assertNull
Issue-ID: POLICY-2616
Change-Id: Id5bd0b7acd0914566dfdebdb42fdcaabf9eb3012
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
-using {} in logger in stead
-diamond operator (<>) to reduce
the verbosity of generics code.
-rename this method name to match
the regular expression '^[a-z][a-zA-Z0-9]*$'
Issue-ID: POLICY-2616
Change-Id: I8e722af52b08382ca53190a33a3a27ad1e7d4830
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
|