summaryrefslogtreecommitdiffstats
path: root/controlloop
AgeCommit message (Collapse)AuthorFilesLines
2018-01-29Do not enforce hostname validationAlexis de Talhouët1-2/+11
Change-Id: I1c4e5d58126e35a64140c91c0c3afda5e9b3a5bd Issue-ID: POLICY-510 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2018-01-23Implement JUnit tests for actor.vfcliamfallon2-6/+108
JUnit tests for the VFC actor implemented. Change-Id: Ifcd433a4ce6f46cad46d50f4ce4c7c03e2abec67 Issue-ID: POLICY-455 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-01-22Fix Tech Debt/JUnit on VFC actorliamfallon3-107/+126
Unit test for VFC actor added. Some minor chages to actor service provider class to remove technical debt. Change-Id: I54ee24bcfa1c82f4a18c0035bdff186d4d3ebdf7 Issue-ID: POLICY-455 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-01-22Merge "Fix Tech Debt/JUnit on VFC POJOs"Jorge Hernandez20-196/+996
2018-01-21Fix Tech Debt/JUnit on APPC and APPCLCM actorsliamfallon5-321/+358
Unit test updated to increase coverage on getter methods. Constants added for some string literals to reduce technical debt warnings. Change-Id: I3b175de7c65aa9d342e71adc951d1ee08c9d781b Issue-ID: POLICY-455 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-01-20Fix Tech Debt/JUnit on VFC POJOsliamfallon20-196/+996
Making fields private, fixing field and methods to follow Java guidelines, and adding getter and setter methods. Unit test added for all classes in org.onap.policy.vfc Issue-ID: POLICY-455 Change-Id: I262337a816706cd5243849cd51e57689275545bf Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-01-19Merge "Fix Technical Debt, add Unit tests for SO"Jorge Hernandez42-829/+2390
2018-01-18Merge "Fix Technical Debt, Unit Test for APPCLCM POJOs"Jorge Hernandez14-158/+835
2018-01-18Merge "Fix Tech Debt/JUnit on control loop event POJOs"Jorge Hernandez25-669/+989
2018-01-18Fix Technical Debt, Unit Test for APPCLCM POJOsLiam Fallon14-158/+835
Mainly making fields private, fixing field and methods to follow Java guidelines, and adding getter and setter methods. Unit test added for all classes in org.onap.policy.appclcm Issue-ID: POLICY-455 Change-Id: Iae873f94a236cc9faeac5542a9633ca840b696ed Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
2018-01-18Merge "Fix Technical Debt, basic JUnit tests for Rest"Jorge Hernandez4-85/+233
2018-01-18Fix Technical Debt, add Unit tests for SOvdmeer42-829/+2390
Converted to POJOs, fixed sona lint errors, added JUnit tests POJOs now have only private members and getters/setters This implicated actors, simulators, and existing tests Issue-ID: POLICY-455 Change-Id: I4b80f729565e8675822a890892b15676908f73b4 Signed-off-by: vdmeer.sven <sven.van.der.meer@ericsson.com>
2018-01-18Merge "Fix Technical Debt for TrafficGenerator"Pamela Dragosh5-55/+52
2018-01-18Fix Tech Debt/JUnit on control loop event POJOsLiam Fallon25-669/+989
Mainly making fields private, fixing field and methods to follow Java guidelines, and adding getter and setter methods. Unit test added for all classes in org.onap.policy.controlloop Issue-ID: POLICY-455 Change-Id: I445b7cfaf9eb921a230bbb72b06ff4455fe003ce Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
2018-01-17Fix Technical Debt, basic JUnit tests for Restvdmeer4-85/+233
Basic tests for get and post (not testing full user/pw/body) Issue-ID: POLICY-455 Change-Id: I186ebf969abc239e5056199c2fd8da9f3253d2fc Signed-off-by: vdmeer.sven <sven.van.der.meer@ericsson.com>
2018-01-17Fix Technical Debt for TrafficGeneratorvdmeer5-55/+52
Changed formatting for checkstyle, changed sequence of statements Left empty constructors as requested Issue-ID: POLICY-455 Change-Id: I0e443bba69cede4c006a841d8d34c82391ff1040 Signed-off-by: vdmeer.sven <sven.van.der.meer@ericsson.com>
2018-01-17Added all J Unit tests SDCvdmeer5-0/+622
Issue-ID: POLICY-455 Change-Id: I8192e8a595642e0d36608591d95f21f3ee574d13 Signed-off-by: vdmeer.sven <sven.van.der.meer@ericsson.com>
2018-01-16Fix Sonar Technical Debt, Unit Test for APPC POJOsLiam Fallon19-183/+907
Mainly making fields private, fixing field and methods to follow Java guidelines, and adding getter and setter methods. Unit test added for all classes in org.onap.policy.appc Change-Id: If3db740bc146a09f8f7387f02c12b048ad00b201 Signed-off-by: Liam Fallon <liam.fallon@ericsson.com> Issue-ID: POLICY-455 Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
2018-01-15Restore getters and setters to AAINQResponse classLiam Fallon1-0/+12
Some get and set methods were deleted from this class in error. This patch restores them. Change-Id: I4dfaf1215e56f30a1d62d19624fe4da570e99171 Signed-off-by: Liam Fallon <liam.fallon@ericsson.com> Issue-ID: POLICY-455
2018-01-15Merge "Cleanup of A&AI message model module."Jorge Hernandez74-917/+2067
2017-12-15Add guard junitsTemoc Rodriguez12-18/+555
Added a few junit files which test most functionality in the guard submodule. Some minor bugs were found by the junits and fixed those newly found bugs. Added persistence.xml for use by junits in guard. Issue-ID: POLICY-490 Change-Id: Ied7e276cfd417e1f396b5a6685a2e9acc9efd109 Signed-off-by: Temoc Rodriguez <cr056n@att.com>
2017-12-14Cleanup of A&AI message model module.Liam Fallon74-917/+2067
Fields have been made fields private in POJOs, and wrote JUnit unit tests to bring up code coverage. AAIManager also changed to use non-static methods so that it can be stubbed with Mockito. Change-Id: I871427ced5db8a1dfd6495fef4e6d84adf264e65 Signed-off-by: Liam Fallon <liam.fallon@ericsson.com> Issue-ID: POLICY-455 Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
2017-12-11Merge "Technical Debt in AAI."Pamela Dragosh48-866/+890
2017-12-08remove synchronized calls to avoid race conditionsJorge Hernandez1-26/+0
This is to prevent potential problems where multiple jar versions are updated one after the other. Change-Id: I78835b485e57125efb213cfdefba60351d815916 Issue-ID: POLICY-487 Signed-off-by: Jorge Hernandez <jh1730@att.com> (cherry picked from commit f2715bc0f272e5e657ed8a82c0f4e520a7c7706d)
2017-12-07Remove guard dependency from simulatorsCharles Cole2-23/+22
Removed the deendency on guard from the guard simulator tests so that the guard simulator can be used to test guard functionality. Issue-ID: POLICY-490 Change-Id: Ie67abb85e9844c412c483b1bbf3fb4aa21f3530a Signed-off-by: Charles Cole <cc847m@att.com>
2017-12-06Technical Debt in AAI.Liam Fallon48-866/+890
Eliminate the technical debt identified in the drools-applications/controlloop/common/model-impl/aai module by Sonar Change-Id: I72125baacc217386a4984be04bfc023439eddd13 Signed-off-by: Liam Fallon <liam.fallon@ericsson.com> Issue-ID: POLICY-455 Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
2017-12-06Actor service provider for VFC and Actor Unit TestEEILFN2-3/+15
The service provider in the META-INF/services file for the VFC actor pointed at the APPC actor rather than the VFC actor, this is fixed to now point at the correct actor implementation. Alsothe Actor test POM is missing the actors 'appclcm' and 'vfc', thus excluding them from the unit test Change-Id: I60bfd160952b7663aab355ae9c8b0aa362484874 Signed-off-by: EEILFN <liam.fallon@ericsson.com> Issue-ID: POLICY-455 Signed-off-by: EEILFN <liam.fallon@ericsson.com>
2017-11-21Bump minor versionJessica Wagantall32-32/+32
Bump minor version in preparation for Amsterdam branching. Change-Id: Ia7e97a72053a2d1cd10c0b9d5c179817c3ac7e23 Issue-ID: CIMAN-120 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
2017-11-15Upgrade to 1.1.2-SNAPSHOTPamela Dragosh32-32/+32
Released 1.1.1, now must bump patch by 1 Issue-ID: POLICY-436 Change-Id: I3f5e4c369575f6fe1fa06cabb96a5bd43cb11087 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-11-14Merge "Update SO to use is-base-vf-module=false"v1.1.11.0.0-ONAP1.0.0-AmsterdamPamela Dragosh2-12/+16
2017-11-13Update SO to use is-base-vf-module=falseHockla, Ali (ah999m)2-12/+16
Issue-ID: POLICY-447 Change-Id: I63cd5d20670f224aa4b9220b99ee40aad4f3e50c Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
2017-11-13default archetype tooling to 1.1.1Jorge Hernandez2-15/+11
Change-Id: I84cf9fe9e954a9ee9bac8eaff56169e44154e9c5 Issue-ID: POLICY-446 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2017-11-10Fix SO Request mismatch and udpate AAI NQ responseHockla, Ali (ah999m)2-12/+14
Issue-ID: POLICY-438 Change-Id: I1d27d0e5f7d253aa3cba82f5f4b515c01be35d8b Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
2017-11-09Fix SO Request structureHockla, Ali (ah999m)4-0/+7
Issue-ID: POLICY-438 Change-Id: I05e634782004fff5540b3e6fabb9e22846438cb1 Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
2017-11-09Merge "Fix SO Request body"Jorge Hernandez10-50/+142
2017-11-08Merge "Update SNAPSHOT version"Jorge Hernandez32-32/+32
2017-11-08Fix SO Request bodyHockla, Ali (ah999m)10-50/+142
- Renamed modelNameVersionId to modelVersionId in SOModelInfo - Removed requestID from SO Request body - As a result of this, an SOResponseWrapper was needed in order to attach the control loop event requestId to use in the SOResponse rule in drl (the requestID that is returned in the SO response is a newly generated requestId with no relation to the Policy control loop event requestId as per Arthur) - Updated drl to reflect the above mentioned change - Updated simulator and junits to reflect changes - Added an additional null httpResponse check/logger statement in SOManager and RestManager Issue-ID: POLICY-438 Change-Id: I5f414ba69b60b5565cca9073b47f4c4835e5abbf Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
2017-11-08Fix SO url to remove suffix HTTPS/1.1Hockla, Ali (ah999m)3-3/+3
Issue-ID: POLICY-437 Change-Id: I19679d9782f78ff73e3a90d0c8c95b2b6e9d319f Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
2017-11-08Update SNAPSHOT versionPamela Dragosh32-32/+32
Releasing v1.1.0 so need to update version to 1.1.1 Issue-ID: POLICY-436 Change-Id: I8b85de39bb3a32f5f4faeeb4fcdfb5d95291ae31 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-11-07SNAPSHOT present in policy core and msb depsv1.1.0Jorge Hernandez13-358/+53
Change-Id: I61c8d698f8cf984c648e510997498d41e7d9744a Issue-ID: POLICY-433 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2017-11-03Fix Generic VNF isClosedLoopDisableddaniel3-7/+35
No A&AI queries will be done for enriched events. The event manager now understands prepended "generic-vnf." in front of is-closed-loop-disabled from DCAE onsets. A test case was revised to include sample data from an enriched onset with vnf data based on the VES documentation. Issue-Id: POLICY-350 Change-Id: Id7f59f8b860b9f147087067a2a9a7766f167f7e4 Signed-off-by: Daniel Cruz <dc443y@att.com>
2017-11-03Merge "Made network.log output more verbose."Pamela Dragosh4-9/+8
2017-11-03Made network.log output more verbose.Magnusen, Drew (dm741q)4-9/+8
Incoming values were not expanded in network logs for several drools-applications. Current patch makes them more verbose. Issue-ID: POLICY-410 Change-Id: I64bf88a3b39ea58dceaf24de698c8ae6a9a3f8b2 Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2017-11-03Merge "Write to DB on guard deny"Pamela Dragosh1-0/+1
2017-11-03Merge "Add fix to catch exception"Jorge Hernandez1-21/+33
2017-11-02Write to DB on guard denyTemoc Rodriguez1-0/+1
When an operations was denied by guard, it was not writing to the DB at all. Only in the deny case we start the operation, then setOperationHasGuardDeny, then finish the operation. Had to add start operation just before finishing it. This allows the write to occur at setOperationHasGuardDeny. Issue-ID: POLICY-345 Change-Id: I665b9cfaa684493e39e731102d4d43ecb39fad7c Signed-off-by: Temoc Rodriguez <cr056n@att.com>
2017-11-02Added fix to catch null pointer in SOManagerHockla, Ali (ah999m)1-39/+45
Issue-ID: POLICY-408 Change-Id: I9f6681b8cbafdd9639966d862e7b1df3b729297e Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
2017-11-02Add fix to catch exceptionRitu Sood1-21/+33
Added fix to catch exception caused by NULL url provided to Policy for VFC Change-Id: Ifb8bdf41fbb212acf13d388d041d3cb44143caeb Issue-ID: POLICY-408 Signed-off-by: Ritu Sood <ritu.sood@intel.com>
2017-10-31Merge "Fix Abatement Processing"Pamela Dragosh1-1/+3
2017-10-31Fix Abatement Processingdaniel1-1/+3
The drools engine will now only fire the event rule if the event is an onset. This prevents abatements from being processed as onsets. Issue-Id: POLICY-407 Change-Id: Ic74efa74fbb1dc0e01d7c36a06fdaf48fc8a3238 Signed-off-by: Daniel Cruz <dc443y@att.com>