summaryrefslogtreecommitdiffstats
path: root/controlloop
AgeCommit message (Collapse)AuthorFilesLines
2018-11-30Reduce resp values meth complexityKrishnakumar Jinka4-49/+206
The response values determining method has more complexity reduce it using enums. Fix build fail due to incorrect response value. Modify LCM response code to enum. Fix enum package. Modify status code enum. Add modification copyright notice. Fix review comments. Add serialization key Issue-ID: POLICY-1251 Change-Id: I49909b6dd2810dd864784afab0a328b855131501 Signed-off-by: kris.jinka <kris.jinka@samsung.com> Signed-off-by: krisjinka <kris.jinka@samsung.com>
2018-11-16Remove unused imports in controlpolicykris.jinka12-57/+172
Remove unused imports that got introduced in recent commits Fix issue with compile failure of test class due to dependency in drools-pdp Datamodel classes. Fix test failures due to compile issues Issue-ID: POLICY-1251 Change-Id: Ib8e496ab96aaa5de67e4f84fa8de515b3dc22ea5 Signed-off-by: kris.jinka <kris.jinka@samsung.com>
2018-11-15Merge "Rename test classes in drools-applications"Jorge Hernandez70-73/+73
2018-11-15Rename test classes in drools-applicationsParshad Patel70-73/+73
Make test classes name consistence by putting 'Test' at end as per google java style guide Issue-ID: POLICY-1258 Change-Id: Id79e5d3fe3688f7f2569b7996613595cc6b746e7 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-11-14Merge "Use parameter obj for policy results"3.0.0-ONAP1.3.4Pamela Dragosh3-42/+96
2018-11-13Fix guard history database configurationJorge Hernandez1-4/+4
Change-Id: I70742b9be80a0b0f77730e2453f96f1d3e7826dd Issue-ID: POLICY-1257 Signed-off-by: Jorge Hernandez <jorge.hernandez-herrero@att.com>
2018-11-13Use parameter obj for policy resultskris.jinka3-42/+96
Policy result method uses more params than allowed Use parameter object for setting params instead Issue-ID: POLICY-1251 Change-Id: I6bf1f20896dc5176811bc363a390c682faa06ca4 Signed-off-by: kris.jinka <kris.jinka@samsung.com>
2018-11-12Merge "Close timing loop-hole when YAML updated"Pamela Dragosh11-70/+1122
2018-11-12Use builder for trigger policykrishnajinka3-52/+140
Fix an issue reported by sonar for using more than 7 parameters in the method. Issue-ID: POLICY-1251 Change-Id: I07d668b706a27dcc03e862d08262f2c0269ad4b7 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-11-09Close timing loop-hole when YAML updatedJim Hahn11-70/+1122
Noticed when YAML updates are pushed close together that some Params objects are deleted that should not be. Fixed that by eliminating the "active" list concept and only deleting a Params object that has an associated cleaner. If it has no cleaner, then it can't be deleted, regardless of timing with rule updates. Added more tests for rule updates, including cases to check for event objects being retracted, as well as Params objects being retracted when rules are deleted. Change-Id: I6b744b29fca228022f43e9322ea149b16d097675 Issue-ID: POLICY-1248 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-11-08Merge "Apply builder pattern for policy"Jorge Hernandez4-28/+180
2018-11-07Apply builder pattern for policyKrishnajinka4-28/+180
Fix an issue reported by sonar for using more than 7 parameters in the method. Fix imports order in files. Fix line lengths to less than 120 chars Issue-ID: POLICY-1251 Change-Id: I42defc9d6acf970bb555c4a6c5d172241231e483 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-11-06Merge "Cleanup all Param objects when any rules change"Pamela Dragosh20-278/+1139
2018-11-05Cleanup all Param objects when any rules changeJim Hahn20-278/+1139
Fix license date for new junit test. Updated some comments. Ensured different control loop names in different rule sets of new junit test. Used different mechanism for examining facts in new junit test. Fixed typo in comment. Changed the way new junit checks for existence of facts. Fixed another typo in comment. Updated clean-up rules in CLC template and added junit test to verify that Params are cleaned up appropriately. Removed code that retracts $manager objects so that the manager clean-up rule will be used, instead, thus ensuring that all associated objects are deleted when the manager is deleted. This was done for amsterdam, CLC, and casablanca templates. Added an extra fireAllRules() after calls to fireUntilHalt() to enable clean-up rules to fire in junit tests. Address Josh's review comments. Enhance junit test to compare actual object references to ensure that Param objects are as expected. Change-Id: If1fefd3f57e417180c62a3849defbaa6ae83afc1 Issue-ID: POLICY-1248 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-11-02Exclude commons-collectionsPamela Dragosh1-0/+9
This should have been carried over from template.demo. Issue-ID: POLICY-1228 Change-Id: I8148ae98c9a30d4342482bbba688d6d2e8088892 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-11-02Merge "Re-added requestParams to vDNS policy"Pamela Dragosh6-8/+10
2018-11-02Re-added requestParams to vDNS policyJim Hahn6-8/+10
Undo inadvertent change to compiler test. Change-Id: I1973612f4783936271c3fd74fb978a4f263a14a9 Issue-ID: POLICY-1240 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-11-02Merge "Upgrade xacml 1.0.2"Liam Fallon8-10/+10
2018-11-02Upgrade xacml 1.0.2Pamela Dragosh8-10/+10
This version of xacml only has license changes to the java source files. This will clear ONAP license issues. Issue-ID: POLICY-1228 Change-Id: Ieaff4d52c8046fee8357f7ebc907f2643d77322c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-11-01Changed actor from "MSO" to "SO"Jim Hahn1-13/+5
Also added "VF Module Delete" to the list of recipes for "SO" accepted by the compiler. Removed "AOTS" and "SDNO" from the list of accepted actors, as code does not exist for those actors. Update remaining actors and recipes. Left "AAI" in the list for now, though it has no recipes listed (and no actor.aai code). Also removed "AAI" from the list of accepted actors. Change-Id: I9db56715d8bea3cf86d2112df1e0086777863192 Issue-ID: POLICY-1239 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-10-31Remove single quotes from casablanca templateJim Hahn2-2/+2
The shell scripts used to populate the operational policies for the casablanca template do not work if the yaml includes single quotes. Replaced the single quotes with %27 instead. Change-Id: I31b20708b69153ecb67b7ac8136f464dbf2ce0c6 Issue-ID: POLICY-1240 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-11-01Merge "Added config params to scale-out policy"Pamela Dragosh5-8/+9
2018-11-01Merge "Add /serviceInstances/ to SO URL for scale-out"Pamela Dragosh4-5/+6
2018-10-31Added config params to scale-out policyJim Hahn5-8/+9
Removed requestParameters and reverted name. Change-Id: Ia3470a751b22375206c571204eff8985e630e05f Issue-ID: POLICY-1240 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-10-31Add /serviceInstances/ to SO URL for scale-outJim Hahn4-5/+6
Also reformatted line that was subsequently too long. Change-Id: I5c634c5157f18de64d37a0f451cd65f3002f35d3 Issue-ID: POLICY-1238 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-10-31Set new master version for Dublinliamfallon42-110/+73
Issue-ID: POLICY-1232 Change-Id: I6dfd85e9407c4d7400f593f035c627a303f397de Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-25Fix refering to snapshot in drools-application1.3.1ramverma42-82/+82
Issue-ID: POLICY-1213 Change-Id: I91e4928e33d4e39286bf340e42602890446d9401 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-10-23Add CCVPN policyVidyashree Rama17-0/+698
CCVPN policy Issue-ID: POLICY-1209 Change-Id: I8adea233f8672c9ff43b4a169b50336d9e43c91d Signed-off-by: Vidyashree Rama <vidyashree.rama@huawei.com>
2018-10-09Add missing SDNC and fix JUnit1.3.0Pamela Dragosh2-6/+23
Identified in prior review, ensure all the new actors are in the appropriate pom.xml and minor fix to JUnit for assertEquals vs assertTrue. Issue-ID: POLICY-1191 Change-Id: I5c7505ad795e6e19c99a3aa9cec7ecf688da8316 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-10-09Merge "Add implementation for OOF PCI use case"Pamela Dragosh12-6/+762
2018-10-09Add implementation for OOF PCI use caseSaravanan A12-6/+762
Receive DMaaP message from PCI-Handler MS with PCI Config change recommendations through DCAE_CL_OUTPUT topic. Trigger SDN-R (if allowed by policy) by sending DMaaP request through SDNR-CL topic. When the response is received from SDNR through SDNR-CL-RSP topic, just parse and print. Code review comments addressed Added controller changes into amsterdam too. Change-Id: I93e54d3f44b4266092931a5f05b766cc26f2a869 Issue-ID: POLICY-1089 Signed-off-by: Saravanan A<saravanan.a75@wipro.com>
2018-10-08Remove unused endpoint dependencyPamela Dragosh1-6/+0
This should have been cleaned out when we moved the code into policy/common. The release job fails since it looks for a non-existent release artifact for this. Issue-ID: POLICY-1189 Change-Id: I46c95166ae47cf955cd43f0ce4af8dd40c0251fe Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-10-05Add new actor SDNC to support CCVPN Closed LoopXin Miao41-1/+2093
Issue-ID: POLICY-1183 Change-Id: I1b77b5b9cefca104382d9d84dd00bbd63b20e0f2 Signed-off-by: Xin Miao <xin.miao@huawei.com> Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-10-02Fixing sonar issuesPamela Dragosh14-24/+738
Some trivial functional interface and ordering. Added some missing JUnit tests. Issue-ID: POLICY-1129 Change-Id: Iad6fe757a40819ca39e007b41dae1bf4b3f6cc0c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-10-02Merge "Fix remaining sonar"Pamela Dragosh5-23/+25
2018-10-01Fix remaining sonarPamela Dragosh5-23/+25
Mostly moving variables to their right spot. Issue-ID: POLICY-1129 Change-Id: Iccc084bbb404ffd51bdd0b26b5f8c373c6142fb1 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-28Merge "Add sdnr actor to archetype"Liam Fallon2-8/+18
2018-09-28Merge "Yet more sonar issues in drools-applications"Pamela Dragosh4-32/+30
2018-09-28Merge "Fix more sonar issues"Jorge Hernandez26-369/+401
2018-09-27Add sdnr actor to archetypePamela Dragosh2-8/+18
The casablanca template had the declaration. I made sure the declarations were in the same place. Issue-ID: POLICY-1155 Change-Id: Ie5ab7a04ffc0c3fefbc3edcea9e7a02a062f0dbe Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-27Fix more sonar issuesPamela Dragosh26-369/+401
Most of these are minor issues along with a few others. They have been bugging me so I thought I would get them done. Some also do not show up on sonarlint. Issue-ID: POLICY-1129 Change-Id: I31f2765f6babdfa80b23f0589daacc98da8d2002 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-27Yet more sonar issues in drools-applicationsJoshua Reich4-32/+30
removed unused imports and variable definitions moved variable declarations above methods refactored deeply nested if/while removed code smell due to unecessary use of static keyword moved string literals to left side of comparator fixed logging of exceptions immediately return expression instead of assigning it to the temporary variable Change-Id: Idfd2a2bdf3c2f3bbfcb54a06b713d57bc867b3ab Issue-ID: POLICY-1129 Signed-off-by: Joshua Reich <jreich@research.att.com>
2018-09-27Merge "Use powermock artifacts from parent pom"Jorge Hernandez2-8/+0
2018-09-27Fix for checkstyle declarationsPamela Dragosh11-15/+44
I found the problem with policy-yaml. An exception was occuring due to an extra line between an @return for javadoc vs. just printing a warning. See: https://github.com/checkstyle/checkstyle/issues/2398 I also messed up some of the other declarations in the sub-modules. Copyright Issue-ID: POLICY-1153 Change-Id: I848e0b19340d494775e161bab86ffb60a97d83ab Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-26Use powermock artifacts from parent pomJim Hahn2-8/+0
Change-Id: I0b4f22e2bab30daee9efb12e6de427a93db8ae84 Issue-ID: POLICY-1148 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-25Fix sonar criticalPamela Dragosh1-8/+8
Sonar complains that the password is an actual password when in fact we are doing exactly the fix they suggest. I seem to not have access to resolve it as a false positive. So it seems the better way to do this is rename this to reflect that it is actually a property value. Had to also address 120> due to new variable name size. Issue-ID: POLICY-1135 Change-Id: I2e2a36ed8d7f5c95e912df4f6ed74983cee8a3dd Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-24Fix checkstyle declarationsPamela Dragosh52-690/+1220
I fixed what I thought would be tolerable for this release. Same issue as policy/common I had to defined the checkstyle in each repo where the suppressions were needed. Issue-ID: POLICY-1135 Change-Id: I8f30bee7e9cddc692ddad3cf88acedb2e6b4781b Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-21more sonar issues in drools-applicationsJim Hahn2-18/+65
Modified SO code to not return null lists for various buildXxxParam methods. Fixed commit message. Added additional junit coverage to SO code. Added additional junit coverage to SO code - cover more error cases. Extracted another constant. Change-Id: I65a27f2a1af1cfd8dd98bddab9ca1e862a3fa6fb Issue-ID: POLICY-1129 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-21new sonar issues in drools-applicationsJim Hahn7-71/+54
Don't return null lists from AAI. Transient TargetLock. Extract aai.url, et. al., constants. Don't allocate extra unneeded variable. Re-order fields in xacml attributes. Extract "vserver" constant from simulator. Replace thread sleep with join. Change-Id: Iee1bd182862632af1f131cca5db5b526f5865b9f Issue-ID: POLICY-1129 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-17Add demo for Control Loop Coordination.Joshua Reich18-11/+4105
New PipEngine and Junit test added to guard. Also bug in existing Junit test fixed. All other code added to new directory template.demo.clc Change-Id: Ida2267528bcb9404dc59ff391d45797b591814cc Issue-ID: POLICY-1109 Signed-off-by: Joshua Reich <jreich@research.att.com>