summaryrefslogtreecommitdiffstats
path: root/controlloop
AgeCommit message (Collapse)AuthorFilesLines
2018-10-31Add /serviceInstances/ to SO URL for scale-outJim Hahn4-5/+6
Also reformatted line that was subsequently too long. Change-Id: I5c634c5157f18de64d37a0f451cd65f3002f35d3 Issue-ID: POLICY-1238 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-10-25Fix refering to snapshot in drools-application1.3.1ramverma42-82/+82
Issue-ID: POLICY-1213 Change-Id: I91e4928e33d4e39286bf340e42602890446d9401 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-10-23Add CCVPN policyVidyashree Rama17-0/+698
CCVPN policy Issue-ID: POLICY-1209 Change-Id: I8adea233f8672c9ff43b4a169b50336d9e43c91d Signed-off-by: Vidyashree Rama <vidyashree.rama@huawei.com>
2018-10-09Add missing SDNC and fix JUnit1.3.0Pamela Dragosh2-6/+23
Identified in prior review, ensure all the new actors are in the appropriate pom.xml and minor fix to JUnit for assertEquals vs assertTrue. Issue-ID: POLICY-1191 Change-Id: I5c7505ad795e6e19c99a3aa9cec7ecf688da8316 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-10-09Merge "Add implementation for OOF PCI use case"Pamela Dragosh12-6/+762
2018-10-09Add implementation for OOF PCI use caseSaravanan A12-6/+762
Receive DMaaP message from PCI-Handler MS with PCI Config change recommendations through DCAE_CL_OUTPUT topic. Trigger SDN-R (if allowed by policy) by sending DMaaP request through SDNR-CL topic. When the response is received from SDNR through SDNR-CL-RSP topic, just parse and print. Code review comments addressed Added controller changes into amsterdam too. Change-Id: I93e54d3f44b4266092931a5f05b766cc26f2a869 Issue-ID: POLICY-1089 Signed-off-by: Saravanan A<saravanan.a75@wipro.com>
2018-10-08Remove unused endpoint dependencyPamela Dragosh1-6/+0
This should have been cleaned out when we moved the code into policy/common. The release job fails since it looks for a non-existent release artifact for this. Issue-ID: POLICY-1189 Change-Id: I46c95166ae47cf955cd43f0ce4af8dd40c0251fe Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-10-05Add new actor SDNC to support CCVPN Closed LoopXin Miao41-1/+2093
Issue-ID: POLICY-1183 Change-Id: I1b77b5b9cefca104382d9d84dd00bbd63b20e0f2 Signed-off-by: Xin Miao <xin.miao@huawei.com> Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-10-02Fixing sonar issuesPamela Dragosh14-24/+738
Some trivial functional interface and ordering. Added some missing JUnit tests. Issue-ID: POLICY-1129 Change-Id: Iad6fe757a40819ca39e007b41dae1bf4b3f6cc0c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-10-02Merge "Fix remaining sonar"Pamela Dragosh5-23/+25
2018-10-01Fix remaining sonarPamela Dragosh5-23/+25
Mostly moving variables to their right spot. Issue-ID: POLICY-1129 Change-Id: Iccc084bbb404ffd51bdd0b26b5f8c373c6142fb1 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-28Merge "Add sdnr actor to archetype"Liam Fallon2-8/+18
2018-09-28Merge "Yet more sonar issues in drools-applications"Pamela Dragosh4-32/+30
2018-09-28Merge "Fix more sonar issues"Jorge Hernandez26-369/+401
2018-09-27Add sdnr actor to archetypePamela Dragosh2-8/+18
The casablanca template had the declaration. I made sure the declarations were in the same place. Issue-ID: POLICY-1155 Change-Id: Ie5ab7a04ffc0c3fefbc3edcea9e7a02a062f0dbe Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-27Fix more sonar issuesPamela Dragosh26-369/+401
Most of these are minor issues along with a few others. They have been bugging me so I thought I would get them done. Some also do not show up on sonarlint. Issue-ID: POLICY-1129 Change-Id: I31f2765f6babdfa80b23f0589daacc98da8d2002 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-27Yet more sonar issues in drools-applicationsJoshua Reich4-32/+30
removed unused imports and variable definitions moved variable declarations above methods refactored deeply nested if/while removed code smell due to unecessary use of static keyword moved string literals to left side of comparator fixed logging of exceptions immediately return expression instead of assigning it to the temporary variable Change-Id: Idfd2a2bdf3c2f3bbfcb54a06b713d57bc867b3ab Issue-ID: POLICY-1129 Signed-off-by: Joshua Reich <jreich@research.att.com>
2018-09-27Merge "Use powermock artifacts from parent pom"Jorge Hernandez2-8/+0
2018-09-27Fix for checkstyle declarationsPamela Dragosh11-15/+44
I found the problem with policy-yaml. An exception was occuring due to an extra line between an @return for javadoc vs. just printing a warning. See: https://github.com/checkstyle/checkstyle/issues/2398 I also messed up some of the other declarations in the sub-modules. Copyright Issue-ID: POLICY-1153 Change-Id: I848e0b19340d494775e161bab86ffb60a97d83ab Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-26Use powermock artifacts from parent pomJim Hahn2-8/+0
Change-Id: I0b4f22e2bab30daee9efb12e6de427a93db8ae84 Issue-ID: POLICY-1148 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-25Fix sonar criticalPamela Dragosh1-8/+8
Sonar complains that the password is an actual password when in fact we are doing exactly the fix they suggest. I seem to not have access to resolve it as a false positive. So it seems the better way to do this is rename this to reflect that it is actually a property value. Had to also address 120> due to new variable name size. Issue-ID: POLICY-1135 Change-Id: I2e2a36ed8d7f5c95e912df4f6ed74983cee8a3dd Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-24Fix checkstyle declarationsPamela Dragosh52-690/+1220
I fixed what I thought would be tolerable for this release. Same issue as policy/common I had to defined the checkstyle in each repo where the suppressions were needed. Issue-ID: POLICY-1135 Change-Id: I8f30bee7e9cddc692ddad3cf88acedb2e6b4781b Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-21more sonar issues in drools-applicationsJim Hahn2-18/+65
Modified SO code to not return null lists for various buildXxxParam methods. Fixed commit message. Added additional junit coverage to SO code. Added additional junit coverage to SO code - cover more error cases. Extracted another constant. Change-Id: I65a27f2a1af1cfd8dd98bddab9ca1e862a3fa6fb Issue-ID: POLICY-1129 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-21new sonar issues in drools-applicationsJim Hahn7-71/+54
Don't return null lists from AAI. Transient TargetLock. Extract aai.url, et. al., constants. Don't allocate extra unneeded variable. Re-order fields in xacml attributes. Extract "vserver" constant from simulator. Replace thread sleep with join. Change-Id: Iee1bd182862632af1f131cca5db5b526f5865b9f Issue-ID: POLICY-1129 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-17Add demo for Control Loop Coordination.Joshua Reich18-11/+4105
New PipEngine and Junit test added to guard. Also bug in existing Junit test fixed. All other code added to new directory template.demo.clc Change-Id: Ida2267528bcb9404dc59ff391d45797b591814cc Issue-ID: POLICY-1109 Signed-off-by: Joshua Reich <jreich@research.att.com>
2018-09-17Merge "remove volumeGroup from SO request"Pamela Dragosh1-11/+10
2018-09-17push-policies https for casablanca controllerJorge Hernandez1-11/+11
https support for provisioning policies in experimental casablanca controller Change-Id: Ica711c10298f49b072c6a4f29a889e27cb851275 Signed-off-by: Jorge Hernandez <jh1730@att.com> Issue-ID: POLICY-1120
2018-09-17remove volumeGroup from SO requestJim Hahn1-11/+10
After a new round of discussion with the SO team, it was learned that the SO scale-out request should NOT include the volumeGroup in relatedInstanceList[0]; that item should be eliminated altogether. Re-ordered some imports. Updated license date. Left volumeGroup in TestDemo, as it's a pseudo VID request. Change-Id: I94e82b7e8fe6a41695b99888f291e24b7103687d Issue-ID: POLICY-962 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-17Merge "Option to disable target locking. Needed by CLC."Pamela Dragosh2-34/+70
2018-09-17Merge "Fixed sonar code smell"Liam Fallon1-5/+3
2018-09-17Fixed sonar code smellPiyush Garg1-5/+3
removed unused method parameter aaiResponseWrapper from constructDeleteRequest Change-Id: Ie434130b040732ed4e656c5592fff5b049695d29 Issue-ID: POLICY-1079 Signed-off-by: Piyush Garg <piyush.garg1@amdocs.com>
2018-09-14fix NPE from rule timersJim Hahn2-68/+85
This problem occurs in rules that have "timer(expr)" expressions before the "when" clause. If a working memory element, other than the timer object, appears in the "when" clause and is updated BY ANY RULE, then an NPE is thrown. The solution is to segregate the objects so that rules having "timer(expr)" expressions only refer to one object, the XxxTimer object. In particular, the rule simply sets an "expired" flag in the XxxTimer object and then all other rules check that flag, rather than having their own "timer(expr)" expressions. Corrected comment associated with rule TIMER.FIRED. Change-Id: I9e6c20ee46af99234daee8ece4862edbd41ba714 Issue-ID: POLICY-1106 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-14Option to disable target locking. Needed by CLC.Joshua Reich2-34/+70
When used, the ControlLoopEventManager will set useTargetLock to false converting TargetLock lock/unlock operations to no-ops. Allows CLC-specified logic to coordinate closed loops instead of hard-coded mutual-exclusion enforced by target locking. Change-Id: Ic067c1e1ce47b12d12742ed4bc04d59aa42751d6 Issue-ID: POLICY-953 Signed-off-by: Joshua Reich <jreich@research.att.com>
2018-09-12implement Serializable in additional classesJim Hahn12-16/+322
Change-Id: I5d5acb9d71dc49eaa9fb397da5988ba3d8bd5f1d Issue-ID: POLICY-1106 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-12Add implementation for OOF PCI use caseSaravanan A40-5/+3254
Receive DMaaP message from PCI-Handler MS with PCI Config change recommendations through DCAE_CL_OUTPUT topic. Trigger SDN-R (if allowed by policy) by sending DMaaP request through SDNR-CL topic. When the response is received from SDNR through SDNR-CL-RSP topic, just parse and print. Code review comments addressed Change-Id: If340a23ae18367b7f98e31fe79c09a09e645b2ad Issue-ID: POLICY-1089 Signed-off-by: Saravanan A<saravanan.a75@wipro.com>
2018-09-11disable http for drools apps using dmaapJorge Hernandez4-77/+85
per security guidelines .. Change-Id: I1db4468f20c3bd22a9e5f27fefcb76b55a3b6d89 Signed-off-by: Jorge Hernandez <jh1730@att.com> Issue-ID: POLICY-1105
2018-09-10Added min and max vnf count supportMichael Mokry1-39/+79
Added variables for min and max with associated Constructor, getters and setters We will need to merge this commit before merging the policy/engine commit to avoid compilation errors in policy/engine build Made changes to address Jim Hahn's comments Change-Id: I45357077cfe046028adcc0033ecf29f8cc1a525b Issue-ID: POLICY-1038 Signed-off-by: Mike Mokry <mm117s@att.com>
2018-09-10Fix new sonar issue with vfModuleItemPiyush Garg1-22/+14
find the last non-base vf module item from AAI response and use the same to construct create or delete vf module SO request Change-Id: I3b9b97ac3008f6e4f7952662d9e4262f77dbeec4 Issue-ID: POLICY-1079 Signed-off-by: Piyush Garg <piyush.garg1@amdocs.com>
2018-09-06Merge "Added support for VF Module Delete recipe"Pamela Dragosh18-365/+728
2018-09-05Merge "Added junit test for commitAbatement."Jorge Hernandez3-14/+110
2018-09-05Add appc lcm request formatterGabriel3-5/+152
Formatter is used to dash case recipe in URL and camel case it in body. Issue-ID: POLICY-1083 Change-Id: I908ae93665f3d069b3a032ae378b7775ebe1110a Signed-off-by: Gabriel <adam.krysiak@nokia.com>
2018-09-04Added junit test for commitAbatement.Joshua Reich3-14/+110
Change-Id: Iee71481e357861618bed068f8b8ef37ec0ea2ab8 Issue-ID: POLICY-975 Signed-off-by: Joshua Reich <jreich@research.att.com>
2018-08-31Added support for VF Module Delete recipePiyush Garg18-365/+728
Enhanced SOActorServiceProvider to support VF Module Delete Recipe. Added SOOperationType enum to map the policy recipe with the SO API that we want to call for a recipe. vf module id from non-base vf module is used to construct the delete request url and same will be deleted. Updated SOManager so that it sends request to SO based on the SOOperationType enum value. Enhanced RESTManager to add support for the http delete using new class HttpDeleteWithBody (to allow pass the payload to the SO delete VF module API). Change-Id: I15b678ed9ebc85dfa7cb62bbf23e41c0fe6e4c69 Issue-ID: POLICY-1079 Signed-off-by: Piyush Garg <piyush.garg1@amdocs.com>
2018-08-31pass VF count to guard for scale-outJim Hahn8-49/+157
Also updated license dates. Fixed new checkstyle errors. Change-Id: Ia6153814c4333724185918f76be560aba5a52f96 Issue-ID: POLICY-1084 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-08-31Add code to store abatement events.Joshua Reich3-1/+59
Stores abatement events in history DB. Change-Id: Ifca6acd42cd9eea85e27765bd268a491028e305a Issue-ID: POLICY-975 Signed-off-by: Joshua Reich <jreich@research.att.com>
2018-08-29Fix remaining checkstylePamela Dragosh115-2137/+2840
Lots of formatting, missing javadoc, distance from use, imports must be explicit, ordering of methods. Fixed some abbreviation problems in classes and renamed JUnit tests to fix this. Issue-ID: POLICY-883 Change-Id: I8494f63d88d63c0232aca97f7bcc848816228fb1 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-28Remove overriding dependencies warningsPamela Dragosh10-46/+25
With the move to oparent for dependencies, there are still some warnings in the pom's for overriding managed dependencies. Issue-ID: INT-619 Change-Id: I7ea771cc4536d8dfc77b4d1717e59cf6bfcfcda9 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-28Merge "use new SO API for scale-out"Pamela Dragosh19-248/+421
2018-08-28use new SO API for scale-outJim Hahn19-248/+421
Updated licenses and serialization IDs. Moved hashCode() and equals() methods to be in same location as in the original code so it can be more easily compared. Changed vDNS yaml timeout and retry to 1200 and 0, respectively, to match the original values. Removed extra newline from yaml, to match original yaml. Reformatted source to wrap lines at 120 characters and removing trailing white space. Change-Id: I3f5e59a1f44750347de49164f587d4ffefdee8b4 Issue-ID: POLICY-962 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-08-28Change parent to policy/parentPamela Dragosh17-45/+6
Should be pointing to policy/parent rather than oparent directly. This will automatically support upgrades more easily. Also removing duplicated managed version override warnings from Maven. This is continuing work to support the integration effort to consolidate common versions of java dependencies across all projects. Issue-ID: INT-619 Change-Id: I37ac20e669262d9ac8fff09fd1ac540190b47a30 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>