Age | Commit message (Collapse) | Author | Files | Lines |
|
Addressed the following sonar issues:
- unused imports
- unused method parameters
- superfluous "throws" declaration
- fields within a serializable class must also be serializable; this
was/will be fixed with a change to AaiCqResponse in policy-models
- use logger instead of System.out; turns out that the code that used
System.out is no longer needed. In fact, deleted several classes
that are no longer needed: ControlLoopLogger and ControlLoopPublisher
- cyclomatic complexity and switch/case statements too big; used
eclipse to extract chunks of code into separate methods
- duplicate code
Note: extracted common code and used lambdas to eliminate duplicate
code in PolicyGuardYamlToXacml. However, a better approach would be
to use object-oriented programming, using mini/nested objects to do
the generation. The lambdas would then become abstract methods.
Nevertheless, that would entail significantly more re-write of this
class than desired at this time
Issue-ID: POLICY-2225
Change-Id: Ie503ffd7accbad3e410af602d32b29c0095c3a33
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Conditional checks for enrichment and validation by target-types
PNF specific AAI enrichment
Fixed Unit Tests
Issue-ID: POLICY-1187
Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca>
Change-Id: I78bf73e454828253ca69695f9196047449b4d9d6
|
|
Issue-ID: POLICY-1407
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ia3cd03719b52e2d4e1fad3662090b7c35e2acf1f
|
|
Updates to all references of APPC LCM model code
based on changes in policy models for APPC LCM.
Issue-ID: POLICY-2043
Change-Id: I0102eb27f449578636cfc0bf22124fa863f05724
Signed-off-by: Daniel Cruz <dc443y@att.com>
|
|
Some junits fail, depending on the order. Traced down to
VfwControlLoopCdsTest, which sets the custom query flag, but does
not reset it when the test is complete. Modified the test superclass
to reset it at the start and end of each test class.
Issue-ID: POLICY-2088
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I6c9ba7e37074945141ea64dfd130dc99f376a825
|
|
Modified code to use new Lock API.
Also deleted TargetLock and PolicyGuard, as they are no longer needed.
Issue-ID: POLICY-2113
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I5bc9b7732f9cfc6056789b2902d9f6f838b560be
|
|
* Add request enrichment with aai service instance id and vnf id
* Implement cds grpc request
* Implement VfwControlLoopCdsTest
Issue-ID: POLICY-2088
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: Ib44d447d6a3a70ff800a5760032b676fdfa32d9c
|
|
Change-Id: Ia94e1ba31d0e8b6a980d891df9b26fb6977acc95
Issue-ID: POLICY-2045
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Changes to the DRL file to change the rules to support custom query.
Added new VdnsControlLoop test for custom query, and supporting yaml
request
Issue-ID: POLICY-1858
Change-Id: Ic1b9e771bd36fe0642e9a3439189076a4906a4b8
Signed-off-by: pramod.jamkhedkar <pramod@research.att.com>
|
|
Issue-ID: POLICY-1957
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I90436e2d633bf0e9f6153dd40e164214f309b8dc
|
|
Due to sonar fixes, drools-pdp changed in a way that requires changes
to drools-applications. In the case of template.demo, lots of test cases
had to be modified, so they were refactored to extract common setup and
tear down code.
Fixed checkstyle issues.
Fixed license date.
Change-Id: Ie9e0239b95916ae7ef8c1b669987f7bb07d841b9
Issue-ID: POLICY-1968
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: I79d59efc93e33f7f234092b34cab0ae935d5ab7b
Issue-ID: POLICY-1965
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
This is necessary as the explicit "match-all" regular expressions
causes events to be accepted in error, even when the json field
is not present in the document.
Change-Id: Idf4b408850514f49ebe8375d2870e116e793a935
Issue-ID: POLICY-1830
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Fixed breakages due to changes made in policy/common to satisfy
sonar.
Repointed op.pom to correct parent, which allowed the other version to
be dropped and properties used in the rest of the pom.
Change-Id: Ib19c228c38b7f27fb9e9f508e5cf2566a8939cdd
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Released 1.5.0
Issue-ID: POLICY-1737
Change-Id: I41b9af7672985a681bf4e6ce4ceddc8798caf281
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Modified the rules to set the operational timeout to the overall
CL timeout if the operational timeout is zero.
Added code to check for zero timeout for the overall CL, too.
Change-Id: I28d41632f59e9bc2fce953267883d567abc92a49
Issue-ID: POLICY-1859
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Due to dublin branch.
Issue-ID: POLICY-1747
Change-Id: I650e8e293551b61a047bd3796324749ed366c9a5
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Released 1.4.1
Issue-ID: POLICY-1700
Change-Id: I9fd966de8165a5f387bb74fedc22a7502d82b870
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-1630
Change-Id: I358a9f71dd10eb7b803d28e020911013c060deac
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Added new "streams" payload to vFW policy yaml files.
Removed references to pg-streams.
Also deleted directories that were moved to policy/models.
Also removed references to trafficgenerator.
Updated licenses.
Removed some trailing whitespace.
Change-Id: I6becaa573628eee677f0959fadf86f9a9f032f88
Issue-ID: POLICY-1752
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
The guard PDP REST call must be changed to support the new api.
Needed to clean out quite a bit of unnecessary code. In addition,
there never should be an Indeterminate response coming back anymore.
Issue-ID: POLICY-1730
Change-Id: I14b3ad39a803646cfffaba9b77cc2aac79e79bdf
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Change-Id: Ia23a5b90b452bcafe2a8aa660598697ebfb07431
Issue-ID: POLICY-1691
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Coordination code has been merged into xacml-pdp, this code
is no longer needed.
Change-Id: I96995c89d7248744c4261b7c02348c0d30d545b5
Issue-ID: POLICY-1471
Signed-off-by: Joshua Reich <jreich@research.att.com>
|
|
The drl change is only partial just to recognize Tosca
policies.
Change-Id: I5d3b8071394a9ea14638170e04d74e4c6b4ad028
Issue-ID: POLICY-1642
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Ensure database schema/naming consistent across repos.
Ensure PIP implementation consistent across repos.
Cleanup unused imports and made sure licenses are ok.
Issue-ID: POLICY-1471
Change-Id: I20a325fe3e66e6ae400e603ec366315aea716993
Signed-off-by: Joshua Reich <jreich@research.att.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Takes VFModule info from policy yaml,instead AAI.
Change-Id: If745b3ba32562cbc37571cea29ec7797ee697e88
Issue-ID: POLICY-1545
Signed-off-by: vamshi.nemalikonda <vn00480215@techmahindra.com>
|
|
Added a new control loop for SON ANR changes
Introducing control loop response flow using DCAE_CL_RSP topic
Change-Id: I81d0e92ce2f5c489596ad70d7b523cab0d8436ce
Issue-ID: POLICY-1463
Signed-off-by: Saravanan A <saravanan.a75@wipro.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Update the dependency of model-impl from drools-applications
to policy/models.
Issue-ID: POLICY-1264
Change-Id: I07fcb29501499a97689d2d27c845bf8e411e7825
Signed-off-by: shaoqiu <tim.huang@est.tech>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
update dependencies from policy/models
Issue-ID: POLICY-1264
Change-Id: Idd7809b11ae9e63ca75d49d78a9e7b52a63e49b9
Signed-off-by: Hengye <yehui.wang@est.tech>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
CCVPN Bandwidth on demand policy
Issue-ID: POLICY-1405
Change-Id: I67bceb35e5a849933b3e46772c9cbbbaab1e9a75
Signed-off-by: Vidyashree Rama <vidyashree.rama@huawei.com>
|
|
Change-Id: I41487becd1705fbe725023798a3ea10f4638a6af
Issue-ID: POLICY-1474
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Removed LoggerFactoryWrapper references to use NetLoggerUtil.
Issue-ID: POLICY-1499
Change-Id: I6f7066f4523736672e17d2e1e609c38c44852769
Signed-off-by: Daniel Cruz <dc443y@att.com>
|
|
Created java definition of CoordinationDirective class.
Initial library supports one coordination directive FirstBlocksSecond,
prototype for this directive added as firstBlocksSecond.xml.
Functions for compiling example yaml directive are in SupportUtil.
Change-Id: If7c22402729670403510f1fa2f7f43de6a4a522c
Issue-ID: POLICY-1173
Signed-off-by: Joshua Reich <jreich@research.att.com>
|
|
The controller properties files have been updated to use
json-path filters in support of the drools-pdp infrastructure
changes.
Issue-ID: POLICY-1489
Change-Id: I21a7ff18bc3716bd675a1d740e7acdf971394e92
Signed-off-by: Daniel Cruz <dc443y@att.com>
|
|
Some code still referenced the customJacksonCoder() method, which
has been removed from drools-pdp. However, all the code did was
set the jackson & gson coders to null, which is unnecessary, as
that is the default value for both. Thus the code was removed
altogether so-as not to cause issues in the future.
Updated license dates.
Change-Id: Ie6f6bc8360890485ca50a751477650af7387b397
Issue-ID: POLICY-1429
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
The xacml dependency appeared in multiple drools-applications
pom files, with different exclusion lists. The dependencies
have been consolidated into a single pom, with a combined
exclusion list.
Added comment to the exclusion list.
Change-Id: I2a5a66619b376879b44c5e0ce064d7e52c4482bf
Issue-ID: POLICY-1429
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Instead of abusing constant from Topic interface use new dedicated
helper class to retrive network logger.
Issue-ID: POLICY-1486
Depends-On: Ic1f07466e1ab6abcc00098e617f0e82da19e852d
Change-Id: I453a14c3dda337f2a4d08914ead32b37adc17353
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
|
|
Excluded jackson-databind from xacml.jar dependencies.
Change-Id: Ia3eb25a33013a04e697e98dcfe6064295bfae138
Issue-ID: POLICY-1429
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Renamed a number of fields and methods, in the Guard classes,
to conform to camel-case format.
Also updated some toString() methods to return "xxxId=" instead
of "xxxID=", if the corresponding field names were also xxxId.
Updated license data in one changed file.
Change-Id: Idac58f8744b5523d6daed7f369026495dd357bf8
Issue-ID: POLICY-1140
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Renamed enum class name and various method names in ControlLoopEventManager.
Change-Id: I18b4a7d30a24dfcf3b155fd662433590b9d4c769
Issue-ID: POLICY-1138
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Renamed classes from "SOxxx" to "SoXxx". Also renamed a few method
names to make them camelcase, too.
Updated drl files with above changes.
Change-Id: I06aa303a20911733f870947c55e01f3a2dc66fa3
Issue-ID: POLICY-1143
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Entails renaming VFCxxx classes and updated drl files, as well.
Change-Id: Ib31c61a35536df22772de6090761b22beb1b561b
Issue-ID: POLICY-1145
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Some cleaning on the installation.
feature-controlloop-management will be installed by default and will contain
new capabilities plus common functionality from amsterdam and casablanca.
Change-Id: Ic751d3002b5b05342138c77f61209b6c32010ce9
Issue-ID: POLICY-1367
Signed-off-by: Jorge Hernandez <jorge.hernandez-herrero@att.com>
|
|
Use eclipselink from policy parent.
Change-Id: I468688a79f2f6eb0ca0fd42dc194abc4fb5654f0
Issue-ID: POLICY-1362
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Make test classes name consitence by adding 'Support' or 'Dummy' at start of util or dummy type of test classes
Issue-ID: POLICY-1258
Change-Id: Idea946375ee46f14512d4c4bc29e65adaa4d2b37
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
|
|
Remove unused imports that got introduced in recent commits
Fix issue with compile failure of test class due to dependency
in drools-pdp Datamodel classes. Fix test failures due to
compile issues
Issue-ID: POLICY-1251
Change-Id: Ib8e496ab96aaa5de67e4f84fa8de515b3dc22ea5
Signed-off-by: kris.jinka <kris.jinka@samsung.com>
|
|
Noticed when YAML updates are pushed close together that some
Params objects are deleted that should not be. Fixed that by
eliminating the "active" list concept and only deleting a Params
object that has an associated cleaner. If it has no cleaner,
then it can't be deleted, regardless of timing with rule updates.
Added more tests for rule updates, including cases to check
for event objects being retracted, as well as Params objects
being retracted when rules are deleted.
Change-Id: I6b744b29fca228022f43e9322ea149b16d097675
Issue-ID: POLICY-1248
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Fix license date for new junit test.
Updated some comments.
Ensured different control loop names in different rule sets of new junit
test.
Used different mechanism for examining facts in new junit test.
Fixed typo in comment.
Changed the way new junit checks for existence of facts.
Fixed another typo in comment.
Updated clean-up rules in CLC template and added junit test to verify
that Params are cleaned up appropriately.
Removed code that retracts $manager objects so that the manager clean-up
rule will be used, instead, thus ensuring that all associated objects are
deleted when the manager is deleted. This was done for amsterdam, CLC,
and casablanca templates.
Added an extra fireAllRules() after calls to fireUntilHalt() to enable
clean-up rules to fire in junit tests.
Address Josh's review comments.
Enhance junit test to compare actual object references to ensure that
Param objects are as expected.
Change-Id: If1fefd3f57e417180c62a3849defbaa6ae83afc1
Issue-ID: POLICY-1248
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
This should have been carried over from template.demo.
Issue-ID: POLICY-1228
Change-Id: I8148ae98c9a30d4342482bbba688d6d2e8088892
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|