aboutsummaryrefslogtreecommitdiffstats
path: root/controlloop/common
AgeCommit message (Collapse)AuthorFilesLines
2021-06-14Add event-manager property for Modify NSSIkrishnaa961-0/+1
Issue-ID: POLICY-3369 Signed-off-by: krishnaa96 <krishna.moorthy6@wipro.com> Change-Id: I95965d5fb34352e89174e3fdada7eb816eea279c
2021-06-08Use global dmaap https flag as default configjhh7-39/+40
added some minor cleanup: - spare tabs - env to envd replacement Issue-ID: POLICY-3366 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I7f19ce0dc96a1cb6e98da019360aa7fa0f0ca4b6
2021-06-04Fix drools-apps buildRam Krishna Verma1-2/+2
Issue-ID: POLICY-3338 Change-Id: Iab7f8347bfe796017ea2980d72b73d2752ad5b1e Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-05-07Fix sonars in drools-appsJim Hahn19-97/+75
Fixed: - use "var" - add @Override annotation - change constructor to "protected" - use Xxx.class::isIstance Issue-ID: POLICY-3290 Change-Id: I7f0795af306ea5afb46d12a4fe0b22adcbce683a Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-07Fix build error in drools-apps related to servicesJim Hahn1-1/+2
Apparently, creating the event services in the rule file has broken the junit test of the rules. It appears that the http clients are not yet loaded into the drools-pdp engine by the time the first rule fires, thus the event manager is unable to initialize all of its actors. Modified the junit to not start the rules until after the http clients have been started. Issue-ID: POLICY-3260 Change-Id: I83fe4ea9fa7ca24396019c18f0d77352fbe86db4 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-05EventManagerServices shouldn't be staticJim Hahn11-133/+138
Currently, the event manager uses a static EventManagerServices object, which precludes the possibility of configuring the actors, for each rule set, from using different properties. Modified the code to allow the rules to specify the event services to use on a per manager basis. Issue-ID: POLICY-3260 Change-Id: If493ae1b55cb752f11e0b2f72dced9c4f3883e34 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-04Refactor common code from UsecasesEventManagerJim Hahn9-864/+2067
Created ClEventManagerWithSteps, as a subclass of ControlLoopEventManager. It contains the "Steps" to be performed and also deals with outcomes. Created ClEventManagerWithEvent, as a subclass of that. It contains a VirtualControlLoopEvent object, and uses that to populate data used by the superclass. Updates per review comments: - made loadPolicy() protected - refactored another level to manage operation outcomes Issue-ID: POLICY-3262 Change-Id: Ibf5dd114746ae26e04fe37d562273fc81dd8cfbe Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-03Add releaseLock() method to event managerJim Hahn4-15/+159
Issue-ID: POLICY-3261 Change-Id: I28a5356ebfc4a6ea1792ef35bc603054208bf73b Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-13Make op history classes work with generic eventsJim Hahn7-61/+55
Issue-ID: POLICY-3198 Change-Id: I5b80d35fbb523094ae5464e9c058fd8f2c71ff50 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-08Merge "Minor clean-up of drools-apps"Jim Hahn3-79/+35
2021-04-08Minor clean-up of drools-appsJim Hahn3-79/+35
Made the following minor changes: - removed SupportUtil, as it is no longer needed. - modified junit for exception class to use ExceptionsTester - added junit for another exception class Issue-ID: POLICY-3175 Change-Id: I7375e5bdb47a12f48a53e7df50f0924781c1c4b6 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-07Use sh instead of ash in drools-appsJim Hahn2-4/+4
Issue-ID: POLICY-3160 Change-Id: I92ecec01b99078e2e0651e1adf292913a20e0a30 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-12Remove more unnecessary plugins from drools-appsJim Hahn3-118/+3
Issue-ID: POLICY-3126 Change-Id: I0cb84be5453249557f9092f237be5517d34a80bb Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-12Address plugin-not-found issuesJim Hahn1-38/+1
Removed references to archetype-packaging and lifecycle-mapping, where unnecessary due to pom inheritance. Issue-ID: POLICY-3126 Change-Id: I2eb4f9756b787ce7f9c2d0304710d19d7e778a18 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-11bump pom versions to 1.9.0-SNAPSHOTjhh9-9/+9
Issue-ID: POLICY-3105 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I6cd013177c6aad3e6e91e4ca250876cfde50857b Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-03-10bump poms to 1.8.2-SNAPSHOTjhh9-9/+9
Issue-ID: POLICY-3127 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I2db24d79ab706919e8e3a76e63a8707791a94123
2021-02-25bump poms to 1.8.1-SNAPSHOTjhh9-9/+9
Issue-ID: POLICY-3088 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: If23d78aafd1d91366d96103f1f1f270c6721370b
2021-02-22Merge "remove duplicated test line in transactions module"Jorge Hernandez1-1/+0
2021-02-22remove duplicated test line in transactions modulejhh1-1/+0
Issue-ID: POLICY-3033 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I674ea800fb0c79bb7bb4758bd4ae567b118da279
2021-02-22Merge "support control loop transaction metrics"Ram Krishna Verma2-16/+51
2021-02-19support control loop transaction metricsjhh2-16/+51
Issue-ID: POLICY-3033 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ic13275607a56b36506a0c79d1880603ff374b0c2 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-02-17Use new version of A&AI APIsJim Hahn2-8/+8
Just changed the version numbers; the APIs appear to be the same otherwise. Issue-ID: POLICY-2788 Change-Id: I842d88184a816c7fd24d935488875ba1337a1754 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-12Fix sonars from dependency upgradeJim Hahn21-131/+83
The dependency upgrades in policy-parent caused some new sonars. In particular, initMocks() has been deprecated - replaced with calls to the Mockito Runner. Issue-ID: POLICY-2910 Change-Id: I257b74626f4393aa89d2bf1b7502478422213b71 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-10More sonars in drools-appsJim Hahn3-11/+7
Addressed the following issues: - commented-out code - don't use eq() with verify() - use class::cast lambda Issue-ID: POLICY-2910 Change-Id: I12f4f85fb226f3ddb8305105e988fa90e276e9f6 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-09Merge "Delete unused persistence.xml"Ram Krishna Verma1-43/+0
2021-02-09Delete unused persistence.xmlJim Hahn1-43/+0
Deleted the file, as it is no longer needed. Issue-ID: POLICY-3005 Change-Id: Ia8de5838440c38dc31177e316118db75965d9338 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-09Upgrade dependenciesJim Hahn4-5/+26
Added target-database property. Also moved the db-driver value out of persistence.xml and into properties. Issue-ID: POLICY-3005 Change-Id: I2c9e53c099e400c32d11632f8732e770a7abba9f Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-05Give better messages than NPE for missing dataJim Hahn2-15/+96
When data is not available to actor operations, an NPE is generally thrown. Modified the code to provide more info about what is missing than simply NPE. Issue-ID: POLICY-2913 Change-Id: Ic56376ef5fdd0f2e46c2996405fff9aafa3692b9 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-01-04Changed identifiers to concept identifiersliamfallon2-5/+7
The policy models tosca classes ToscaPolicyIdentifier and ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA concept, not just TOSCA policies so they are renamed to ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion respectively. The class ToscaPolicyTypeIdentifier is redundant and is replaced by ToscaConceptIdentifier. Issue-ID: POLICY-2900 Change-Id: Id5da4e5894a0d646f9f4b68c1e6b0476d4deae05 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-11-23Merge "Use Params makeOutcome() without targetEntity"Ram Krishna Verma2-2/+5
2020-11-20Remove legacy simulatorsJim Hahn14-1596/+0
Drools-apps now uses simulators from policy/models. Deleted the legacy simulators. Issue-ID: POLICY-2804 Change-Id: Ie118237a52a4272d2f86fbb15b320ea2175ac7f4 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-11-20Use Params makeOutcome() without targetEntityJim Hahn2-2/+5
Planning to remove the second flavor of makeOutcome() from the Params, so modifying the drools-apps code to work with the first flavor. Issue-ID: POLICY-2804 Change-Id: Iddb288f7cf53e93919e77aca8afe3869fadb0d37 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-11-20Merge "Delete preprocessed flag from actors"Pamela Dragosh9-12/+27
2020-11-18Delete preprocessed flag from actorsJim Hahn9-12/+27
Removed the "preprocessed" flag from the Actor parameters, now that the actors no longer have a startPreprocess() method. Also removed targetEntity from the parameters. Issue-ID: POLICY-2804 Change-Id: I13bc80e1b6bb22d8d21b176796ca062109ce6658 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-11-18Merge "move all bash to ash shell scripts for drools-apps"Jorge Hernandez2-5/+5
2020-11-16move all bash to ash shell scripts for drools-appsTaka Cho2-5/+5
this gerrit would be the first step to not to use any GPL-3.0 and plus license Issue-ID: POLICY-2847 Change-Id: I6787af6afd4a90d09d3cca86fa2ee7c5b6ea4eb0 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-11-16Make drools-apps event agnosticJim Hahn54-8196/+47
Removed tdjam and frankfurt controllers, which use event-specific actors. Issue-ID: POLICY-2804 Change-Id: Ica05f80bf72d039d9c4903591af7fb3793a81159 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-11-10Allow mixed case in check of prov-statusJim Hahn4-4/+58
Apparently SO/AAI in Frankfurt are setting the prov-status to "active" instead of "ACTIVE". Modified the code to ignore case when comparing. Issue-ID: POLICY-2890-prov-status2 Change-Id: I9e868d320dadcb3ac51570718d10f33d0011ae47 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-11-06Fix upcoming checkstyle issuesPamela Dragosh1-1/+1
When we upgrade to oparent, these will fail as oparent upgrades to 8.37 of puppycrawl which fixes a few bugs that should have flagged these previously. Issue-ID: POLICY-2887 Change-Id: I2ea37eef859aac08f54ffd1f4b1d6b9e702218e9 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-10-27Bump drools-apps master to 1.8.0 SNAPSHOTJim Hahn13-13/+13
Bumping minor version now that guilin branch has been created. Also repointed to snapshot versions for dependencies. Issue-ID: POLICY-2875 Change-Id: Ieb3f8d6ff141d3035141ab8672d3259074f432be Signed-off-by: Jim Hahn <jrh3@att.com>
2020-10-20Bump drools-apps to 1.7.5 SNAPSHOTJim Hahn13-13/+13
Issue-ID: POLICY-2869 Change-Id: I627c5b1c4c5f946c1187a6966b30d3943825fa71 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-10-10bump drools-apps to 1.7.4-SNAPSHOTTaka Cho13-13/+13
Issue-ID: POLICY-2839 Change-Id: Ie0bc82d0f8a09dc4d65e056dc7836870dae58835 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-10-08Bump drools-apps to 1.7.3 snapshotTaka Cho13-13/+13
Issue-ID: POLICY-2839 Change-Id: Iafbc4a301ee8bc2b5fb10f34677f752a87997879 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-10-02Merge "Remove cds actor timeout"Pamela Dragosh1-1/+3
2020-10-01Remove cds actor timeoutRam Krishna Verma1-1/+3
During testing we found that cds actor is picking up the timeout from policy configuration. As discussed, adding a comment for now and we will remove it in next release alog with related code. Issue-ID: POLICY-2843 Change-Id: I63b589bea344ad7f33e6fc0d34f0ab331411146b Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-09-30Fix new sonars in drools-appsJim Hahn10-61/+101
Addressed the following sonars: - too many assertions in test method - rename test class - use static method to modify static field - use already defined constant - code always returns the same value - use assertNotSame - use appropriate class name to access static method - define a constant - extract nested try block - don't always return the same value - use remove() instead of set(null) for thread-local-storage - add @Override Issue-ID: POLICY-2852 Change-Id: Icc62acd4ad57afa2d44ed4cdca504a3ac0810228 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-09-14Release locks between junit testsJim Hahn5-18/+66
Tdjam junits were randomly failing. Traced it down to the fact that the locks were being released asynchronously and thus were not always released when the next test cases requested them. Also simplified logging for tdjam junit tests. Fixed the property file so it isn't overwritten by the junit tests. Changes per review comments: - changed "Pattern" to "pattern" in logback xml Issue-ID: POLICY-2789 Change-Id: I325ec69cf7affa531d3c575e3a34bc0b0e1edac7 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-09-09bump snapshot version to 1.7.2-SNAPSHOTjhh13-13/+13
Issue-ID: POLICY-2789 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I4335cf77bd4a228fe0bec2d5eb529789e8144406
2020-09-09disable TdjamTest junitsjhh1-0/+2
junits consistently fail in staging jobs Issue-ID: POLICY-2789 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I968bd9ec2c3e8278358ef3c487592c0b833cef36
2020-09-09delete guard dependency for tdjamjhh2-9/+0
staging job fails as there is no guard dependency. Issue-ID: POLICY-2789 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I4d803e269c7199ddeb2ebb52df5368259e4f22cd