Age | Commit message (Collapse) | Author | Files | Lines |
|
Created new "usecases" event manager.
Also fixed a couple of sonar issues in the new code.
Issue-ID: POLICY-2748
Change-Id: I17a2c41bbf4f4e8158adbd8aa5e32ef570daa9d3
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Add usecases-specific classes for managing preprocessor steps.
Issue-ID: POLICY-2748
Change-Id: I62a2bf8fbeb656a5017531a3f3de6a6dbad5a004
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Issue-ID: POLICY-2765
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I454365943465863b108ba8668b2bc4b201986959
|
|
Created place-holder for new "usecases" controller. Note: as of yet,
this is still just a normal java project; it will be turned into a
full-fledged kie-based controller in a later review.
Added some Operation and a few other support classes that will be
needed.
Note: the detmTarget() method and it's various supporting methods,
detmXxx(), found in GetTargetEntityOperation2 were cloned from the
pre-existing ControlLoopOperationManager2 class, and modified to fit the
strategy of the new controller. Likewise for the junit tests of those
methods.
Issue-ID: POLICY-2748
Change-Id: Idffa135a11a56bd6afdd2728706fd40168e80912
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Added classes that are event-agnostic and support moving control from
java into rules.
Updates per review comments:
- removed policy scope
Issue-ID: POLICY-2748-event-mgr
Change-Id: Icf811cc25a3975543fc5c725766b7b9df2bb87b0
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2766
Change-Id: I1ff7bbc4e301cfe6fa746f38c839acf83f7584b6
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
1, rename BaseRuleTest to BaseTest.
2, remove drools related code in BaseTest that would use
for tdjam controller.
3, DroolsRuleTest extends BaseTest
that would use for frankfurt controller for drools base.
Issue-ID: POLICY-2750
Change-Id: Ica9637a850de6e929f09532f077ae3e997aa2045
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Change-Id: I6d2b17c5379b19b04589da4d7bc4a7f6ebc4d23a
Issue-ID: POLICY-2432
Signed-off-by: uj426b <uj426b@att.com>
|
|
Saw this in the log:
java.lang.NoClassDefFoundError:
org/onap/policy/models/decisions/concepts/DecisionRequest
Added decisions jar to the (hopefully correct) pom.
Issue-ID: POLICY-2558
Change-Id: I5a2796b3eda6b3b39b2844cd112f5a18acfa0cf8
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Change-Id: Ia91fad549dfba0b3caa623be18652b93d0bc7fce
Issue-ID: POLICY-2716
Signed-off-by: uj426b <uj426b@att.com>
|
|
Made the following changes to remove usescase and legacy actor
code:
- deleted the usecases controller and feature
- deleted code associated with legacy actors, with the exception
of AaiManager, which is needed by RestControlLoopManager
- moved the contents of the "guard" project into the m2/guard project,
as that is the only thing that still needs it
- modified the m2/GuardContext to get the name of its persistence unit
from the properties so it could be overridden by junit tests
- used eclipselink constants
Also fixed a bug in the properties for the VFC actor.
Addressed review comment:
- removed usecases from Dockerfile
Issue-ID: POLICY-2558
Change-Id: I677d68c9efed9247c3d55773abdcc736b577a6b4
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2695
Change-Id: Iec9af37a01ba35c5b5419399cfb3d3bc80093101
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: Iffecc4655d22b507188ea266e82046f2a82751e8
Issue-ID: POLICY-2703
Signed-off-by: uj426b <uj426b@att.com>
|
|
add isInstanceOf for assertThatThrownBy.
Issue-ID: POLICY-2616
Change-Id: If49255aec6004870d7d2acfeabe258def872c1fa
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Modified drools-apps to use XxxActor instead of XxxActorServiceProvider.
This is the second step of the rename.
Issue-ID: POLICY-2684
Change-Id: Iea60e92f914b7719ac765b086650479be9192d98
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2387
Change-Id: I1c3ee615f0a72a9e7cec8ccc573e27a0cbe3f02c
Signed-off-by: RossC <ross.carter@est.tech>
|
|
The Pair changes made in drools-pdp also broke drools-apps builds.
Replaced usage of drools.utils.Pair with apache Pair.
Issue-ID: POLICY-2202
Change-Id: I50aaad47c243637688602ae6cb680a929fe3edd9
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
This is a quick fix to get around a build error in drools-applications
due to "Pair" changes made in policy-common and/or policy-models.
Issue-ID: POLICY-2202
Change-Id: If1cb60947e55d97ef7cfb1d05d69e07c54c71a05
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed checkstyle issues that were subsequently reported.
Also fixed a few eclipse warnings.
Also fixed some of the sonar issues in the files that were touched:
- use "{}" in logger calls
- camelcase method names
- use "<?>" instead of generics
- add serialization ID
Issue-ID: POLICY-2188
Change-Id: I5c94a2e26dd74a61a0a919e1c3da17ab02a5bc9d
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2188
Change-Id: Ib90222c537c5440e0de52fa0acbaa99bbcc4772a
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
logging enhancement
Issue-ID: POLICY-2579
Change-Id: Id1e0230d3cd2ac6d921be86f127f3721c65f3e52
Signed-off-by: Joseph Chou <jc2555@att.com>
|
|
Now that the actor change has been merged, the deprecated properties
can be removed from drools-apps. Done.
Issue-ID: POLICY-2632
Change-Id: If4dafc489c32da4dfccd6ebac97e8e7beac2454d
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Issue-ID: POLICY-2632
Change-Id: I4d20fe6b46432298ba796fe978796d5d74e1eb14
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: Ic336eb24f1f3ecda359f07714e59f075596cc105
Issue-ID: POLICY-2555
Signed-off-by: uj426b <uj426b@att.com>
|
|
|
|
|
|
Now that the changes to the Actors have been merged, the former properties
can be removed, too.
Also fixed guard operator/operation name since it changed from "Guard"
to "Decision".
Issue-ID: POLICY-2629
Change-Id: I1c8d4575be598a8cab12b1aa4ad9b1d3e1f12113
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
|
|
|
|
An "operations" level is being added to the properties for the
CDS and VFC actor. Added the new properties; the old ones can
be deleted once the change to the actors has been merged.
Issue-ID: POLICY-2629
Change-Id: Ib0bb3f62d6a2d3380aa6ec5a6e8b61ddd0a44c00
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
get already returns string
redudant return block
unused import
swap expected argument
use equals method instead
useless assignment for payload
Issue-ID: POLICY-2616
Change-Id: Ie4f07085994420b7ea3f39db89f980f6594f01b7
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
fixed some sonar issues: removed empty method,
put expected value in the 1st argument
Change-Id: I86747938187abda34e9ab41b735d55fbf920ecd8
Issue-ID: POLICY-2616
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
|
|
|
|
In some conditions for assertTrue, sonarcloud
recommends using assertEquals
Assert.assertTrue(a.equals(b));
Assert.assertTrue(a == b);
Assert.assertTrue(a == null);
Assert.assertTrue(a != null);
Assert.assertFalse(a.equals(b));
Compliant Solution
Assert.assertEquals(a, b);
Assert.assertSame(a, b);
Assert.assertNull(a);
Assert.assertNotNull(a);
Assert.assertNotEquals(a, b);
Change-Id: Ic50bf6e961b74abcc698c2cc0347dd0472fefe71
Issue-ID: POLICY-2616
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
Change-Id: I5b48d716dcb17082ad376de1e1fe58b2f4ea4130
Issue-ID: POLICY-2555
Signed-off-by: uj426b <uj426b@att.com>
|
|
The VFC actor doesn't have the same property structure as the
other actors, which meant that the properties listed in the file
were incorrect. Fixed them.
Renamed the operation to "Restart" per review comments.
Issue-ID: POLICY-2407
Change-Id: Icb8ccad518d01a5f23253a9835976eae666566f4
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Modified drools-apps to use constants from the actor classes instead
of hard-coded literals. Only made this change in code that uses the
new actor model, as the old code will be deleted during this release.
Issue-ID: POLICY-1242
Change-Id: Iac718159fd7cf571a48ac620585bf2b8f94c1e5d
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Deleted Dbao and replaced it with the shared class in policy-models.
Also had to update the queries and the persistence.xml accordingly.
Note: with this change, the "database" project is no longer needed,
so it was deleted.
Issue-ID: POLICY-2581
Change-Id: Idfde68b28b3a27f2ee794fa477d15e0f12717373
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
The default provider has been changed to gson, so the provider property
no longer has to be set.
Issue-ID: POLICY-1527
Change-Id: I9b555ed3c3b735ca9622314e1ca06476416bae6e
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Modified drools-apps to generate the SDNR notification using the
SDNR-response provided by the actor in the operation outcome, instead of
using the controlloop-response provided in the operation outcome, as the
latter is deprecated.
Issue-ID: POLICY-2593
Change-Id: I70ee4a4b11345a4295d720250a63f407f51cb0bd
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
When the overall control loop times out, a notification is sent to
POLICY-CL-MGT, but then the event is discarded. Modified the code
to update the operation history, if an operation had been started,
and to generate an SDNR notification, if appropriate.
Applied the same logic for when a lock is lost.
Issue-ID: POLICY-2582
Change-Id: I35510ec8a3cfc6b2ca9be5751896f3c0f7d9bd09
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Change-Id: I1b4b088d276da6aae3b577102470a6d8e3dcdc6a
Issue-ID: POLICY-2514
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|