summaryrefslogtreecommitdiffstats
path: root/controlloop/common/model-impl
AgeCommit message (Collapse)AuthorFilesLines
2017-09-27Create common object to consolidate AAI responseJoseph Chou18-989/+0
Remove duplicate/obsolete code (NQF199) Change-Id: Ibe0d4d958a1fe5ae0bae93f740e8b32196a3b07b Issue-ID: POLICY-228 Signed-off-by: Joseph Chou <jc2555@att.com>
2017-09-25Merge "Create common object to consolidate AAI response"Jorge Hernandez25-0/+1651
2017-09-25Fix Usecase Template for VoLTEdaniel2-3/+16
This includes VoLTE support for the amsterdam template. As of right now all use cases are able to get a final success with guard disabled and no A&AI GET queries. Currently, the GET query is not working in the lab. I will address this in another pull request. Issue-ID: POLICY-259 Change-Id: I216aa84daaa1e93ab12c56ee53283b4cb413a7c3 Signed-off-by: Daniel Cruz<dc443y@att.com>
2017-09-25Create common object to consolidate AAI responseJoseph Chou25-0/+1651
Add Junit test to improve sonar coverage Change-Id: I32688dad756d2cba80559cd1d090e334ebf77aa3 Issue-ID: POLICY-228 Signed-off-by: Joseph Chou <jc2555@att.com>
2017-09-25Merge "Added the Override annotation"Jorge Hernandez3-4/+5
2017-09-25Merge "Fix Blocker/Critical sonar issues"Jorge Hernandez1-0/+1
2017-09-25Added the Override annotationrama-huawei3-4/+5
Added diamond symbol on RHS side Change-Id: I3945e5f2217f74b71fa143b128f271e48b4882a7 Issue-ID: POLICY-239 Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
2017-09-25Merge "Added Override annotation"Jorge Hernandez1-0/+1
2017-09-25Merge "Added private constructor"Jorge Hernandez1-1/+4
2017-09-25Merge "Fix for Sonar major issues"Jorge Hernandez1-1/+2
2017-09-25Merge "Fix for Sonar major issues"Jorge Hernandez1-1/+1
2017-09-25Added Override annotationramanjaneya1-0/+1
Issue-ID: POLICY-239 Change-Id: Ia84e5656744289be52cf22b1b68d870a03b85404 Signed-off-by: ramanjaneya <ramanjaneya.palleti@huawei.com>
2017-09-25Added private constructorramanjaneya1-1/+4
Reorder the modifiers to comply with the Java Language Specification Issue-ID: POLICY-239 Change-Id: I1c156dd420d27c45d496b07841f6375aec1b8de3 Signed-off-by: ramanjaneya <ramanjaneya.palleti@huawei.com>
2017-09-22Merge "Added private constructor"Pamela Dragosh1-0/+3
2017-09-22Merge "Add simple JUnit test for LCMResponse"Pamela Dragosh2-2/+110
2017-09-22Add simple JUnit test for LCMResponsePamela Dragosh2-2/+110
This covers all the methods Issue-ID: POLICY-32 Change-Id: I6da6c54c257f6254f5116c99a64c02dbf0c77e05 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-22Merge "Fix Use Case Testing"Jorge Hernandez2-3/+15
2017-09-22Added private constructorramanjaneya1-0/+4
Issue-ID: POLICY-239 Change-Id: I2ed90fc27c70ae03a772913bf3fefd28b692cec7 Signed-off-by: ramanjaneya <ramanjaneya.palleti@huawei.com>
2017-09-22Added private constructorramanjaneya1-0/+3
Issue-ID: POLICY-239 Change-Id: I261d3aa1b9f67c3e78e1016a84ed64924e306f43 Signed-off-by: ramanjaneya <ramanjaneya.palleti@huawei.com>
2017-09-22Fix Use Case Testingdaniel2-3/+15
These changes are necessary to get the use cases working on an actual PDP. So far vCPE, vFW, and vDNS have been tested successfully on a pdp. These are priliminary tests to just test a FINAL SUCCESS without A&AI GET queries being used. A&AI named queries for vFW and vDNS have been verified to work. Changes in the template were made for SO as there were changes in the JUnit template that did not get reflected in the archetype template. Changes in the code were made in various places to use the environment properties for REST urls, usernames, and passwords. Due to VoLTE not being tested yet, the url for VFC is still hard coded and will be changed later. It has been confirmed with APPC that LCM will have two topics: APPC-LCM-READ and APPC-LCM-WRITE. Policy needs to sink to APPC-LCM-READ and pull from source APPC-LCM-WRITE. This has been reflected in the controller properties file. Issue-ID: POLICY-259 Change-Id: Ib9a8df07ae5ad9d3052c88907c1e522952af474d Signed-off-by: Daniel Cruz <dc443y@att.com>
2017-09-22Create common object to consolidate AAI responseJoseph Chou4-76/+16
Create base object for AAI GET query Change-Id: I874b10f89054d8adcc28b1e601e9ff15ee884784 Issue-ID: POLICY-228 Signed-off-by: Joseph Chou <jc2555@att.com>
2017-09-21Add VFC Response in Working Memory & JUNITRitu Sood5-4/+24
Adding code to insert VFC reponse in working memory and handling that response. Also adding JUNIT and yaml file for VoLTE usecase. Issue-Id: POLICY-212 Change-Id: I74a13272ccd931478d27d80715d8c3ac756fb5c7 Signed-off-by: Ritu Sood <ritu.sood@intel.com>
2017-09-20Merge "Fix for Sonar major issues"Jorge Hernandez1-1/+2
2017-09-20Fix for Sonar major issuesSwapnilPathak1-1/+2
Add override annotation above the method signature. Issue-ID: POLICY-248 Change-Id: I8086a6fc1dc24719c3ffd3785a12c086ab556ae9 Signed-off-by: SwapnilPathak <SP00494485@techmahindra.com>
2017-09-20Fix for Sonar major issuesSwapnilPathak1-1/+1
Move the String literal on left side of string comparison. Issue-ID: POLICY-249 Change-Id: I8086a6fc1dc24719c3ffd3785a12c086ab555ae9 Signed-off-by: SwapnilPathak <SP00494485@techmahindra.com>
2017-09-20Merge "Fixing VFC simulator for junit tests"Pamela Dragosh1-1/+1
2017-09-20Merge "Fix Major sonar issues"Pamela Dragosh1-6/+7
2017-09-20Fix for Sonar major issuesSwapnilPathak1-1/+2
Add override annotation above the method signature. Issue-ID: POLICY-248 Change-Id: I8086a6fc1dc24719c3ffd3785a12c086ab453ae9 Signed-off-by: SwapnilPathak <SP00494485@techmahindra.com>
2017-09-20Fix Major sonar issuesshashikanth1-6/+7
Fix Major sonar issues in policy/drools-applications module https://sonar.onap.org/component_issues?id=org.onap.policy.drools-applications%3Adrools-pdp-apps#resolved=false|severities=MAJOR Add the "@Override" annotation above this method signature "value" is already a string, there's no need to call "toString()" on it Issue-Id:POLICY-239 Change-Id: Ia64ac87c13d88c5d961b943e0b2286b273bd4831 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-19Remove sonar blocker and unused importPamela Dragosh1-5/+3
Remove the 3 sonar blockers and unused import in AAI code. Issue-ID: POLICY-111 Change-Id: I73001a06810ecff3f22da627583a0238c4a09967 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-19Fix Blocker/Critical sonar issuesshashikanth1-0/+1
Fix Blocker/Critical sonar issues in policy/drools-applications module https://sonar.onap.org/component_issues?id=org.onap.policy.drools-applications%3Adrools-pdp-apps#resolved=false|severities=CRITICAL%2CMAJOR Fixed 2 issues, Used isEmpty() to check whether the collection is empty or not. getActor returns a string, there's no need to call toString() Issue-Id:POLICY-111 Change-Id: I645420ee370ceb5fca959f870e76db2390e19929 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-18Merge "Fix sonar critical"Jorge Hernandez2-2/+12
2017-09-18Fixing VFC simulator for junit testsRitu Sood1-1/+1
Added response type to post and removed response id as it is unused. Breaking up from the junit patch for ease of review. Issue-id: POLICY-212 Change-Id: I0c6b0c02b240cfe81246587184fe6a589dcc2367 Signed-off-by: Ritu Sood <ritu.sood@intel.com>
2017-09-15Fix sonar criticalPamela Dragosh2-2/+12
Last transient/serializable issues. Throw a dedicated exception for DateUtil class Unused imports Make the enclosing method "static" or remove this set. Issue-ID: POLICY-115 Change-Id: I366f85922c4d4d290b320e0b88678c805de59872 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-15Merge "ONAP AAI GET Query code"Jorge Hernandez2-2/+141
2017-09-15ONAP AAI GET Query codeJoseph Chou2-2/+141
Update ControlLoopEventManager to raise exception on null AAI response Issue-ID: POLICY-103 Change-Id: Iebe8b03269a1801c4293600920aa267490cea1af Signed-off-by: Joseph Chou <jc2555@att.com>
2017-09-15Fix sonar criticalsPamela Dragosh10-18/+22
Either re-interrupt this method or rethrow Exception Transient/Serializable issues Unused imports logging exceptions Issue-ID: POLICY-115 Change-Id: I4c8a0c780e2f6c6e8218c1457f18470f7d95919c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-15Merge "Modify AAI simulator to support new requests"Pamela Dragosh3-0/+15
2017-09-15Modify AAI simulator to support new requestsCharles Cole3-0/+15
Updated the AAI simulator to support new AAI queries. Also, modified the post response to allow multiple responses. Added code to ensure the simulators were able to sucessfully start up. Change-Id: I3e855b5e54c073f55fbaadc0064c140695fc1a58 Issue-ID: POLICY-200 Signed-off-by: Charles Cole <cc847m@att.com>
2017-09-14Clear eclipse warnings and sonarPamela Dragosh7-40/+20
Removing warnings introduced with A&AI code. This should also address sonar criticals and majors. Issue-ID: POLICY-140 Change-Id: I3f8186dd9c5aa52bfbb061bf95d67b5614b3fb2e Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-14Added changes for vDNS Use CaseHockla, Ali (ah999m)22-40/+41
-Renamed remaining MSO classes and packages to SO and modified drl accordingly -Connected SO Interface to SO Simulator -Added vDNS Control Loop junit -Modified SOActorServiceProvider to reflect AAI class changes (POLICY-103) Issue-ID: POLICY-102 Change-Id: Iea5d3f096c4ccfedde68e79d7593d66331127aaf Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
2017-09-13Merge "ONAP code for AAI, consolidate name and get query"Jorge Hernandez28-12/+1521
2017-09-12ONAP code for AAI, consolidate name and get queryJoseph Chou28-12/+1521
Adding AAI GET query feature to support ONAP project (1 commit) Issue-ID: POLICY-103 Change-Id: I0a55f41c3edd7a0bc0562ae4e12a19f262a50d74 Signed-off-by: Joseph Chou <jc2555@att.com>
2017-09-12Fixing VFC Model response classRitu Sood3-41/+10
Fixed the response class for VFC response and also removed the Ignore test case. Change-Id: I4373e86399089b7a3d743be4d19f76cc37d1ceea Issue-id: POLICY-57 Signed-off-by: Ritu Sood <ritu.sood@intel.com>
2017-09-08Set this class as serializablePamela Dragosh1-1/+7
Fixing sonar critical to make this simple class serializable. Issue-ID: POLICY-115 Change-Id: I6a3cf8b1c8c27f434e26d9f2909b2ef38c72825b Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-08Merge "Clearing sonar critical for missing serialization"Pamela Dragosh2-2/+14
2017-09-08Clearing sonar critical for missing serializationPamela Dragosh2-2/+14
These classes should be serializable in order to remove the sonar critical. Also clearing unused import/code messages. Issue-ID: POLICY-115 Change-Id: I25e504f6edae9fb38080e7d4d33b2b3e4cde4637 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-08Added changes for vDNS Use Case - MSO InterfaceHockla, Ali (ah999m)24-832/+964
Rebased and fixed merge conflicts Issue-ID: POLICY-102 Change-Id: Icc36a2cf6391aa9137593bc04f0d4543798b7ccd Signed-off-by: Ali Hockla <ah999m@att.com> Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com> Signed-off-by: HOCKLA <ah999m@att.com> Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
2017-09-06Add APPC LCM Interfacedaniel18-5/+1611
The LCM model code and service provider code is implemented. This model code is now used for the vCPE use case scenario. The vFW use case is still using the legacy APPC API as request by APPC for Policy to use in R1. The APPC service provider now generates a demo legacy APPC request with pg-streams. An A&AI named query is implemented for the vFW use case. The code for obtaining the generic-vnf.vnf-id is not in use until we set up the A&AI simulator to work without having cyclical depenncies inside the POMs. JUnits for the vFW and vCPE use cases are now supported. These JUnits test the complete flow of each scenario. A&AI testing is not supported in the JUnit test yet. These JUnits use a target type of VM as VNF is not supported yet. This will be changed when the Target Lock supports VNF. Amended to fix Sonar blockers. Issue-ID: POLICY-104 Change-Id: I46869c5fd5094919da55ad563d608fe6d4b6fea7 Signed-off-by: Daniel Cruz <dc443y@att.com>
2017-08-29Fix New Sonar Blocker for Drools-ApplicationsMike Babinski1-2/+7
Add null checks to stop possible null pointer exceptions. Issue-ID: POLICY-111 Change-Id: Idafb078edf984712e5d5a4d54763f2723e17c09f Signed-off-by: Mike Babinski <mb1915@att.com>