Age | Commit message (Collapse) | Author | Files | Lines |
|
This commit mops up the technical debt issues in
drools-applications that are reaistic to fix witout
major surgery on the code.
note: warnings on non compliant Java class names that are used in
yaml serializaiton and deserailization are ignored.
note: warnings on complexity figures for equals() methods are ignored.
Issue-ID: POLICY-455
Change-Id: I99ccda4bd9932ceb5ccbcfd2778730234b55d7a5
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
The naming of Maven modules in drools-applications was not
aligned with the directory structure in the git repository
of drools-applications. Therefore it was difficult to
see the strucutre of the repository in Eclipse and other
IDEs. This change amends the Maven module IDs to
reflect the repository directory structure.
This patch reset fixes the previos patch set, where many
references to maven modules internally in drools-applciations
were missed. See also changes in engine and docker repos.
Updated to reflect repo directory structure in maven
artifact groups.
Issue-ID: POLICY-238
Change-Id: I8ab1a7ecdb664045222bbbfda269135e3e449109
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
There were some duplicate dependencies in the POMs that were causing warnings.
These have been removed. In cases where the revision of the duplicate
dependencies were different,the latest revision was used.
The scope of the "junit" dependency was "provided" in some POMs. These have been
corrected with the scope of "test" being used for junit dependencies.
Issue-ID: POLICY-238
Change-Id: Ib1cc6f040b0c4d7f2b39ae02bc6fb4590d395809
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Upgrade httpclient to 4.5.5 - the latest version.
Issue-ID: POLICY-612
Change-Id: I5e79918bc447889b1dbcd1bf897c3324f6a0cc0d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
|
|
Unit test expanded for SO POJOs, technical debt removed in SO actor and VFC pojos.
Change-Id: I23b886c40c1ac6ac8dc2ebbaade315b71cca9dd0
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Issue-ID: POLICY-455
|
|
Change-Id: I1c4e5d58126e35a64140c91c0c3afda5e9b3a5bd
Issue-ID: POLICY-510
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
|
|
JUnit tests for the VFC actor implemented.
Change-Id: Ifcd433a4ce6f46cad46d50f4ce4c7c03e2abec67
Issue-ID: POLICY-455
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
|
|
Unit test updated to increase coverage on getter methods.
Constants added for some string literals to reduce technical debt warnings.
Change-Id: I3b175de7c65aa9d342e71adc951d1ee08c9d781b
Issue-ID: POLICY-455
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Making fields private, fixing field and methods to follow Java guidelines, and adding getter and setter methods.
Unit test added for all classes in org.onap.policy.vfc
Issue-ID: POLICY-455
Change-Id: I262337a816706cd5243849cd51e57689275545bf
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
|
|
|
|
|
|
Mainly making fields private, fixing field and methods to follow Java guidelines, and adding getter and setter methods. Unit test added for all classes in org.onap.policy.appclcm
Issue-ID: POLICY-455
Change-Id: Iae873f94a236cc9faeac5542a9633ca840b696ed
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
|
|
|
|
Converted to POJOs, fixed sona lint errors, added JUnit tests
POJOs now have only private members and getters/setters
This implicated actors, simulators, and existing tests
Issue-ID: POLICY-455
Change-Id: I4b80f729565e8675822a890892b15676908f73b4
Signed-off-by: vdmeer.sven <sven.van.der.meer@ericsson.com>
|
|
|
|
Mainly making fields private, fixing field and methods to follow Java guidelines, and adding getter and setter methods. Unit test added for all classes in org.onap.policy.controlloop
Issue-ID: POLICY-455
Change-Id: I445b7cfaf9eb921a230bbb72b06ff4455fe003ce
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
|
|
Basic tests for get and post
(not testing full user/pw/body)
Issue-ID: POLICY-455
Change-Id: I186ebf969abc239e5056199c2fd8da9f3253d2fc
Signed-off-by: vdmeer.sven <sven.van.der.meer@ericsson.com>
|
|
Changed formatting for checkstyle, changed sequence of statements
Left empty constructors as requested
Issue-ID: POLICY-455
Change-Id: I0e443bba69cede4c006a841d8d34c82391ff1040
Signed-off-by: vdmeer.sven <sven.van.der.meer@ericsson.com>
|
|
Issue-ID: POLICY-455
Change-Id: I8192e8a595642e0d36608591d95f21f3ee574d13
Signed-off-by: vdmeer.sven <sven.van.der.meer@ericsson.com>
|
|
Mainly making fields private, fixing field and methods to follow Java guidelines, and adding getter and setter methods. Unit test added for all classes in org.onap.policy.appc
Change-Id: If3db740bc146a09f8f7387f02c12b048ad00b201
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
Issue-ID: POLICY-455
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
|
|
Some get and set methods were deleted from this class in error. This patch restores them.
Change-Id: I4dfaf1215e56f30a1d62d19624fe4da570e99171
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
Issue-ID: POLICY-455
|
|
Fields have been made fields private in POJOs, and wrote JUnit unit tests to bring up code coverage. AAIManager also changed to use non-static methods so that it can be stubbed with Mockito.
Change-Id: I871427ced5db8a1dfd6495fef4e6d84adf264e65
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
Issue-ID: POLICY-455
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
|
|
Eliminate the technical debt identified in the drools-applications/controlloop/common/model-impl/aai module by Sonar
Change-Id: I72125baacc217386a4984be04bfc023439eddd13
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
Issue-ID: POLICY-455
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
|
|
Bump minor version in preparation for Amsterdam
branching.
Change-Id: Ia7e97a72053a2d1cd10c0b9d5c179817c3ac7e23
Issue-ID: CIMAN-120
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
|
|
Released 1.1.1, now must bump patch by 1
Issue-ID: POLICY-436
Change-Id: I3f5e4c369575f6fe1fa06cabb96a5bd43cb11087
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-438
Change-Id: I05e634782004fff5540b3e6fabb9e22846438cb1
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
|
|
|
|
|
|
- Renamed modelNameVersionId to modelVersionId in SOModelInfo
- Removed requestID from SO Request body
- As a result of this, an SOResponseWrapper was needed in order to
attach the control loop event requestId to use in the SOResponse
rule in drl (the requestID that is returned in the SO response
is a newly generated requestId with no relation to the Policy
control loop event requestId as per Arthur)
- Updated drl to reflect the above mentioned change
- Updated simulator and junits to reflect changes
- Added an additional null httpResponse check/logger statement in SOManager and RestManager
Issue-ID: POLICY-438
Change-Id: I5f414ba69b60b5565cca9073b47f4c4835e5abbf
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
|
|
Issue-ID: POLICY-437
Change-Id: I19679d9782f78ff73e3a90d0c8c95b2b6e9d319f
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
|
|
Releasing v1.1.0 so need to update version to 1.1.1
Issue-ID: POLICY-436
Change-Id: I8b85de39bb3a32f5f4faeeb4fcdfb5d95291ae31
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Change-Id: I61c8d698f8cf984c648e510997498d41e7d9744a
Issue-ID: POLICY-433
Signed-off-by: Jorge Hernandez <jh1730@att.com>
|
|
Incoming values were not expanded in network logs for several
drools-applications. Current patch makes them more verbose.
Issue-ID: POLICY-410
Change-Id: I64bf88a3b39ea58dceaf24de698c8ae6a9a3f8b2
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
|
|
|
|
Issue-ID: POLICY-408
Change-Id: I9f6681b8cbafdd9639966d862e7b1df3b729297e
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
|
|
Added fix to catch exception caused by
NULL url provided to Policy for VFC
Change-Id: Ifb8bdf41fbb212acf13d388d041d3cb44143caeb
Issue-ID: POLICY-408
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
|
|
Issue-ID: POLICY-401
Change-Id: Id1be63d2f61bc0d9d8f15df7573af2c7307c1c31
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
|
|
Issue-ID: POLICY-385
Change-Id: I142877a3173a028738b1aa2aea9521f6208bab38
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
|
|
Now reject an event if the AAI get query for the event fails. Added test
cases for this behavior.
Fixed some issues from my previous pull request.
Issue-Id: POLICY-314
Change-Id: I674e95302a271423c307a88d061064e12e491a7a
Signed-off-by: Charles Cole <cc847m@att.com>
|
|
Added logger statments to network.log for AAI, SO,
PDPX Guard, and VFC for all inbound/outbound traffic.
Issue-Id: POLICY-356
Change-Id: I802d45d8136f987b4304baa8f17e166b1c8df165
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
|
|
Errors from AAI after a Named query now throw an AAIEXception. This is
caught in the template to allow the resources to be removed from memory
and a final failure to be thrown.
Issue-ID: POLICY-314
Change-Id: I319d29ef537b2d01ca288622aac1d9dbbe05f5eb
Signed-off-by: Charles Cole <cc847m@att.com>
|
|
Control loop junits now use the actual PolicyEngine instead of a
simulation, allowing them to work with the archetype template
Issue-ID: POLICY-101
Change-Id: I910961996aaf831f4e91b7d7173d05fdfdd77683
Signed-off-by: Charles Cole <cc847m@att.com>
|
|
per Scott's feedback, see JIRA ticket notes
Change-Id: I5e9a5a6f98fceabc58911a3673d1b889604b5a92
Issue-ID: POLICY-300
Signed-off-by: Jorge Hernandez <jh1730@att.com>
|
|
|
|
|
|
Fix major sonar issues in policy/drools-applications module
https://sonar.onap.org/component_issues?id=org.onap.policy.drools-applications%3Adrools-pdp-apps#resolved=false|severities=MAJOR|rules=squid%3AS1161
Added "@Override" annotation above this method signature.
Issue-Id:POLICY-239
Change-Id: I578d0e740a6c04ba02df400a3abc99f9b774908a
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
|
|
Fix major sonar issues in policy/drools-applications module
https://sonar.onap.org/component_issues?id=org.onap.policy.drools-applications%3Adrools-pdp-apps#resolved=false|severities=MAJOR|rules=squid%3AS1161
Added the "@Override" annotation above this method signature.
Issue-Id:POLICY-239
Change-Id: Ibb71db82d78b0df02d5d6416ac3f3f00a3780695
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
|