Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
Due to sonar fixes, drools-pdp changed in a way that requires changes
to drools-applications. In the case of template.demo, lots of test cases
had to be modified, so they were refactored to extract common setup and
tear down code.
Fixed checkstyle issues.
Fixed license date.
Change-Id: Ie9e0239b95916ae7ef8c1b669987f7bb07d841b9
Issue-ID: POLICY-1968
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Addressed sonar issue, "Move constants to a class or enum.", by
moving the "manager" object from the ControlLoopMetrics interface
into a utility class, ControlLoopMetricsManager.
Addressed sonar issue, "duplicated blocks of code must be removed.",
by refactoring PolicyGuardYamlToXacml, extracing common functions.
Addressed sonar issue, "Remove this unused import", in
RestControlLoopManager.
Addressed sonar issue, "Refactor this method to throw at most one
checked exception", in event manager.
Fixed likely new sonar issue with assigning to a parameter.
Moved logging line to more appropriate place.
Addressed reviewer comment:
Use "replace" instead of "replaceAll", thus avoiding escaping
Change-Id: I47db957c83c1b3e2bd2330474e261987c6f0aac6
Issue-ID: POLICY-1967
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: I79d59efc93e33f7f234092b34cab0ae935d5ab7b
Issue-ID: POLICY-1965
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Now that feature APIs have been renamed to XxxApi in drools-pdp,
the same must be done with the META-INF files in drools-applications.
Also updated references to XxxApi class names within java code.
Change-Id: I7ccc09c36f9b903327b5e92189d0bf2956da6cea
Issue-ID: POLICY-1074
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Released 1.5.0
Issue-ID: POLICY-1737
Change-Id: I41b9af7672985a681bf4e6ce4ceddc8798caf281
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Replaced sleep() calls with awaitability.await(). Also shortened
the timeout, for the test, from 10s to 2s.
Change-Id: I5d9cb84b405782f174b6230294e5d6a47938c4b8
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Added coverage to:
- feature-controlloop-management
Fixed sonar issues, but didn't add coverage to:
- feature-controlloop-trans
- eventmanager
- guard
Change-Id: I12f09c4a533e838c6fb9762ba56194e51ce864eb
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Due to dublin branch.
Issue-ID: POLICY-1747
Change-Id: I650e8e293551b61a047bd3796324749ed366c9a5
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Released 1.4.1
Issue-ID: POLICY-1700
Change-Id: I9fd966de8165a5f387bb74fedc22a7502d82b870
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-1630
Change-Id: I358a9f71dd10eb7b803d28e020911013c060deac
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
The drl change is only partial just to recognize Tosca
policies.
Change-Id: I5d3b8071394a9ea14638170e04d74e4c6b4ad028
Issue-ID: POLICY-1642
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Update the dependency of model-impl from drools-applications
to policy/models.
Issue-ID: POLICY-1264
Change-Id: I07fcb29501499a97689d2d27c845bf8e411e7825
Signed-off-by: shaoqiu <tim.huang@est.tech>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Extracted CacheBasedControlLoopMetricsManager into its own class file.
Change-Id: I075d423192eb7a8d44cad7ccae8db8fcfe2715f7
Issue-ID: POLICY-1139
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-1232
Change-Id: I6dfd85e9407c4d7400f593f035c627a303f397de
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Issue-ID: POLICY-1213
Change-Id: I91e4928e33d4e39286bf340e42602890446d9401
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
|
|
|
|
Mostly moving variables to their right spot.
Issue-ID: POLICY-1129
Change-Id: Iccc084bbb404ffd51bdd0b26b5f8c373c6142fb1
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Most of these are minor issues along with a few others.
They have been bugging me so I thought I would get them
done. Some also do not show up on sonarlint.
Issue-ID: POLICY-1129
Change-Id: I31f2765f6babdfa80b23f0589daacc98da8d2002
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
I found the problem with policy-yaml. An exception was
occuring due to an extra line between an @return for
javadoc vs. just printing a warning.
See: https://github.com/checkstyle/checkstyle/issues/2398
I also messed up some of the other declarations in the
sub-modules.
Copyright
Issue-ID: POLICY-1153
Change-Id: I848e0b19340d494775e161bab86ffb60a97d83ab
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
I fixed what I thought would be tolerable for this release.
Same issue as policy/common I had to defined the checkstyle
in each repo where the suppressions were needed.
Issue-ID: POLICY-1135
Change-Id: I8f30bee7e9cddc692ddad3cf88acedb2e6b4781b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Lots of formatting, missing javadoc, distance from use,
imports must be explicit, ordering of methods.
Fixed some abbreviation problems in classes and renamed
JUnit tests to fix this.
Issue-ID: POLICY-883
Change-Id: I8494f63d88d63c0232aca97f7bcc848816228fb1
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Should be pointing to policy/parent rather than oparent
directly. This will automatically support upgrades more
easily. Also removing duplicated managed version override
warnings from Maven.
This is continuing work to support the integration effort
to consolidate common versions of java dependencies across
all projects.
Issue-ID: INT-619
Change-Id: I37ac20e669262d9ac8fff09fd1ac540190b47a30
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Spacing, missing javadoc
Issue-ID: POLICY-883
Change-Id: Ice65c6c1baf0bb7c6273411f078bacfe3496b89b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Replaced references to classes deleted from drools-pdp with references to the
corresponding in policy-common
Issue-ID: POLICY-967
Change-Id: Ia9d2ac704e6b7c434e5a9e7aee6d7dcf9198e4f2
Signed-off-by: mmis <michael.morris@ericsson.com>
|
|
Snapshot updated for Casablanca.
Issue-ID: POLICY-875
Change-Id: I0307282c4eabdb9ccd03282f918f4cd727ac4f86
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
|
|
- reduce memory footprint
- avoid verbose logging from cache when
the object is not in the cache to
invalidate it.
Change-Id: I819cfbcfe32f5afdd238397c79ccd5cebd4534b8
Issue-ID: POLICY-852
Signed-off-by: Jorge Hernandez <jh1730@att.com>
|
|
These reviews must be merged in order because of layering.
This review should be merged THIRD.
Issue-ID: POLICY-844
Change-Id: I61d128f3244cd420abab15ab70c5c0e9d9afa625
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
These reviews must be merged in order because of layering.
This review should be merged FOURTH
PLD added version.properties
Change-Id: If7af7b3ae37166e88af92c0d1f1c558e5b60ab8e
Issue-ID: POLICY-798
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
I removed a couple of empty README and added licenses.
Issue-ID: POLICY-741
Change-Id: I10aad3536d02b738a1dc606f7311de6b3a2777cd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-736
Change-Id: I2bc455510e925764d18a1d8e96e072bdadb251c6
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Removed checkstyle warnings from:
policy/drools-applications/controlloop/common/model-impl/appc
policy/drools-applications/controlloop/common/model-impl/appclcm
policy/drools-applications/controlloop/common/model-impl/events
including changes to template files due to renamed methods
Issue-ID: POLICY-705
Change-Id: Ieb93baf43268aa608f204eef1a610354f2adec32
Signed-off-by: mmis <michael.morris@ericsson.com>
|
|
Change-Id: I3b411ee2855a1ffe94ffc67fccfb1e475335d036
Issue-ID: POLICY-533
Signed-off-by: Jorge Hernandez <jh1730@att.com>
|
|
This is the first of 2 code inspections.
This review contains though most of the work.
It keeps tracks of all in progress transactions
by intercepting all notifications. From that
appropriate metrics can be obtained and logged.
The actual logging of the metrics and enablement
of the feature at install time will come in a
subsequent review.
Change-Id: Ie5c8adfbdeae72758da7da8a1b4133cd4818c6fb
Issue-ID: POLICY-533
Signed-off-by: Jorge Hernandez <jh1730@att.com>
|