Age | Commit message (Collapse) | Author | Files | Lines |
|
added some minor cleanup:
- spare tabs
- env to envd replacement
Issue-ID: POLICY-3366
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I7f19ce0dc96a1cb6e98da019360aa7fa0f0ca4b6
|
|
Fixed:
- use "var"
- add @Override annotation
- change constructor to "protected"
- use Xxx.class::isIstance
Issue-ID: POLICY-3290
Change-Id: I7f0795af306ea5afb46d12a4fe0b22adcbce683a
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Just changed the version numbers; the APIs appear to be the same
otherwise.
Issue-ID: POLICY-2788
Change-Id: I842d88184a816c7fd24d935488875ba1337a1754
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Addressed the following issues:
- commented-out code
- don't use eq() with verify()
- use class::cast lambda
Issue-ID: POLICY-2910
Change-Id: I12f4f85fb226f3ddb8305105e988fa90e276e9f6
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Removed tdjam and frankfurt controllers, which use event-specific
actors.
Issue-ID: POLICY-2804
Change-Id: Ica05f80bf72d039d9c4903591af7fb3793a81159
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
During testing we found that cds actor is picking up the timeout from policy configuration.
As discussed, adding a comment for now and we will remove it in next release alog with related code.
Issue-ID: POLICY-2843
Change-Id: I63b589bea344ad7f33e6fc0d34f0ab331411146b
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Made the following updates:
- modified feature-controlloop-utils to pull from the usecases
controller instead of the frankfurt controller
- modified ONAPInstance in the xacml-pdp Decision request
- log Step2 property changes as info() instead of error()
- log Lock acquisition as info() instead of warn()
Issue-ID: POLICY-2748
Change-Id: I6b4b5877bbd6731acb761d09d0f0dec85561b163
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Made the following changes to remove usescase and legacy actor
code:
- deleted the usecases controller and feature
- deleted code associated with legacy actors, with the exception
of AaiManager, which is needed by RestControlLoopManager
- moved the contents of the "guard" project into the m2/guard project,
as that is the only thing that still needs it
- modified the m2/GuardContext to get the name of its persistence unit
from the properties so it could be overridden by junit tests
- used eclipselink constants
Also fixed a bug in the properties for the VFC actor.
Addressed review comment:
- removed usecases from Dockerfile
Issue-ID: POLICY-2558
Change-Id: I677d68c9efed9247c3d55773abdcc736b577a6b4
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2188
Change-Id: Ib90222c537c5440e0de52fa0acbaa99bbcc4772a
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Now that the actor change has been merged, the deprecated properties
can be removed from drools-apps. Done.
Issue-ID: POLICY-2632
Change-Id: If4dafc489c32da4dfccd6ebac97e8e7beac2454d
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2632
Change-Id: I4d20fe6b46432298ba796fe978796d5d74e1eb14
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Now that the changes to the Actors have been merged, the former properties
can be removed, too.
Also fixed guard operator/operation name since it changed from "Guard"
to "Decision".
Issue-ID: POLICY-2629
Change-Id: I1c8d4575be598a8cab12b1aa4ad9b1d3e1f12113
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
An "operations" level is being added to the properties for the
CDS and VFC actor. Added the new properties; the old ones can
be deleted once the change to the actors has been merged.
Issue-ID: POLICY-2629
Change-Id: Ib0bb3f62d6a2d3380aa6ec5a6e8b61ddd0a44c00
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
The VFC actor doesn't have the same property structure as the
other actors, which meant that the properties listed in the file
were incorrect. Fixed them.
Renamed the operation to "Restart" per review comments.
Issue-ID: POLICY-2407
Change-Id: Icb8ccad518d01a5f23253a9835976eae666566f4
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
The default provider has been changed to gson, so the provider property
no longer has to be set.
Issue-ID: POLICY-1527
Change-Id: I9b555ed3c3b735ca9622314e1ca06476416bae6e
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Currently, the default serialization provider for HTTP clients
is jackson, which encodes null fields in requests. Unfortunately,
SO does not like the null fields.
Fixed this by modifying the SO config parameters to use the GSON
serialization provider.
Issue-ID: POLICY-2568
Change-Id: I6c2e7c985f23e09940d89409c2a84303bfd54b8a
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2560
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I6cd3de9238793fef671c9e058c494c179d4cb25c
|
|
Added properties needed by A&AI PNF Operation.
Issue-ID: POLICY-2505
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I58966faf9eb9900123a085bf8093050440c15170
|
|
Issue-ID: POLICY-2504
Change-Id: I4dec3dfd62fa230ad8f0de66c0d1b71e5393bcbd
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
CDS actor properties in drools-apps did not match the properties
in the actor, itself. Fixed them (as best I could be inspection).
Issue-ID: POLICY-2501
Change-Id: Ibb4ac5ee59762bd740342c1d54fc472a9fca8968
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2468
Change-Id: Ibf4d3e5f62fa3106028dcf85050c270b8eab0a89
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Some of the new actors were modified to get their path prefixes
from the property files. In addition, the models code was modified
to allow an empty "path", so that is now used, where appropriate.
Issue-ID: POLICY-2441
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I4573c5e2a506fb67be9bd040ce047612007fd969
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
The http client property files had "username", but the correct
property name is "userName". Fixed.
Also updated the models version to the latest snapshot to pick
up the fix to the APPC actor.
Issue-ID: POLICY-2441
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I4d64efcb5b639526beb145ee0231c6d650098d0f
|
|
When a trailing "/" is added to the CONTEXT_URI, it will likely
break the usecases SO operations. Thus the SO_URL is being
reinstituted for this one actor.
Issue-ID: POLICY-2441
Change-Id: I360d1701a0615309a27afbdf7da83f68505626d4
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Added a trailing "/" to the context URI for the various actors.
Updated the properties to accomodate it.
Also fixed the "path" for a couple of actors; the path property
only applies at the individual operation level, not at the actor
level.
Issue-ID: POLICY-2441
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I4e8c4cd07de5ac075dbfa56d83116e1e87bdee1c
|
|
Issue-ID: POLICY-2441
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Id81638d76d0bf71d49d8663ee569b43bfbe6b1aa
|
|
The context URI path for the various actors needs to be
configurable via properties specified in the OOM charts.
Issue-ID: POLICY-2441
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I7348d0c4f47a33dbc806ad117f35b96c887b5394
|
|
Flipped the flag(s) to enable guard checks in the various junit
tests for the Usecases and Frankfurt controllers. Note: the guard
checks use the guard simulator.
Modified new actor code to not include operation history on first
"guard denied" report (i.e., make it work like usecases does).
Issue-ID: POLICY-2434
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I2897da4a0c8fb76fa00cb0f6cf8562c0703005d3
|
|
Fleshed out more of SDNC properties. Still don't know what the
"path" should be.
Added SDNR.
Removed invalid topic sources and sinks.
Changed some types from source to sink (or vice versa).
Issue-ID: POLICY-2434
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I80d22243111eaf4cabb59823d327060f83bc2c28
|
|
Default to "false". Can override in CSITs.
Issue-ID: POLICY-2434
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I72d8d5a87adef2cd66d8afb78117264fb4c05e9a
|
|
|
|
Fixed various sonar issues, including moving some
code to policy-common.
Fixed some eclipse warnings, including deprecated junit APIs.
Issue-ID: POLICY-2426
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I10b40c1e5af62308f2e4c315e4d399aafff2998f
|
|
Issue-ID: POLICY-2421
Change-Id: I0e61e7b3272f5c7babceb41e4e249716af4529cf
Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
|
|
Note: VcpeTest and VfwTest are not included, as they depend on updates
to the APPC and APPC-LCM Actors.
Added feature-controlloop-frankfurt.
Added HTTP client property files to feature-controlloop-management.
Updates per review comments:
- pom changes
- simplify FrankfurtBase
- rename event-svc-http.properties
- change "usescases" to "frankfurt"
- use blanks for CDS property defaults
- trailing spaces in http-client files
- add https property to http-client files
Added newlines to config files that appear to be missing them (based
on feedback from gerrit).
Issue-ID: POLICY-2385
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Ib4a4d75461c734ae47309e41dc9d099e8815d55d
|
|
native policies will require topics configured at installation
(there's no policy to add them). This configuration style
also cleans the installation tidier (topics can
be overriden or new ones added when being placed in the mounted config
directory).
Issue-ID: POLICY-2181
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I87fd6889c651147e9229b3487db8c95b34516dfd
|
|
Tosca Compliant and Toscal Legacy Operational policies are
both supported for backwards compatibility.
vCPE usecase junits to support 2 equivalent policies,
one tosca compliant and the other one legacy.
Issue-ID: POLICY-2360
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iafbfc92bbec42e6a3fe4ceb4a9a17c85e636ea14
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
This class is only useful under drools applications and
eventually will be deprecated to accommodate the new
Operational Policy Types.
Issue-ID: POLICY-2146
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I68927cb144a33fac6fe330be15fe60aee32b15a1
|
|
Removing all the related files and necessary modifications for removing named query. The code now only supports Custom Query.
Issue-ID: POLICY-2125
Change-Id: I2d376eb955d69f45c39ad4d4a1cfacb4d620ca8e
Signed-off-by: pramod.jamkhedkar <pramod@research.att.com>
|
|
* Add request enrichment with aai service instance id and vnf id
* Implement cds grpc request
* Implement VfwControlLoopCdsTest
Issue-ID: POLICY-2088
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: Ib44d447d6a3a70ff800a5760032b676fdfa32d9c
|
|
Issue-ID: POLICY-1371
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ief22f9d99acbd9c3d7335e59045d45c64296f783
|
|
Issue-ID: POLICY-1957
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I90436e2d633bf0e9f6153dd40e164214f309b8dc
|
|
Due to sonar fixes, drools-pdp changed in a way that requires changes
to drools-applications. In the case of template.demo, lots of test cases
had to be modified, so they were refactored to extract common setup and
tear down code.
Fixed checkstyle issues.
Fixed license date.
Change-Id: Ie9e0239b95916ae7ef8c1b669987f7bb07d841b9
Issue-ID: POLICY-1968
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Addressed sonar issue, "Move constants to a class or enum.", by
moving the "manager" object from the ControlLoopMetrics interface
into a utility class, ControlLoopMetricsManager.
Addressed sonar issue, "duplicated blocks of code must be removed.",
by refactoring PolicyGuardYamlToXacml, extracing common functions.
Addressed sonar issue, "Remove this unused import", in
RestControlLoopManager.
Addressed sonar issue, "Refactor this method to throw at most one
checked exception", in event manager.
Fixed likely new sonar issue with assigning to a parameter.
Moved logging line to more appropriate place.
Addressed reviewer comment:
Use "replace" instead of "replaceAll", thus avoiding escaping
Change-Id: I47db957c83c1b3e2bd2330474e261987c6f0aac6
Issue-ID: POLICY-1967
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-1956
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Icceab57db9c19364afbedbf63ecc8e52c1572cba
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Now that feature APIs have been renamed to XxxApi in drools-pdp,
the same must be done with the META-INF files in drools-applications.
Also updated references to XxxApi class names within java code.
Change-Id: I7ccc09c36f9b903327b5e92189d0bf2956da6cea
Issue-ID: POLICY-1074
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Added coverage to:
- feature-controlloop-management
Fixed sonar issues, but didn't add coverage to:
- feature-controlloop-trans
- eventmanager
- guard
Change-Id: I12f09c4a533e838c6fb9762ba56194e51ce864eb
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Per javadocs, getName() should generally be used instead of
Class.getCanonicalName(). This change only applies to classes; it
does not apply to File objects.
Change-Id: Ie402ab9239b2d5149c420d495f16bb82417d2d25
Issue-ID: POLICY-1646
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: Ieae5fe567bcb4fcbd0e439dcd6ff71e2435af702
Issue-ID: POLICY-1731
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
* Fix simple sonar bug for logging errors
* Private constructors to hide implicit.
* Not enough arguments for debug statement
* Upgrade to policy/parent released version
Issue-ID: POLICY-1700
Change-Id: Id8040c2aa0abdbe4946db60f97cb279974817447
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Changes in event manager to support Aai custom query
Issue-ID: POLICY-1278
Change-Id: I693dd6b94f1fa6f24b08a389db099914636cf2ba
Signed-off-by: pramod.jamkhedkar <pramod@research.att.com>
|