Age | Commit message (Collapse) | Author | Files | Lines |
|
Issue-ID: POLICY-1233
Change-Id: Ibe63bee81db2427d07ec97db601083ed1a0423cd
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Issue-ID: POLICY-1213
Change-Id: I91e4928e33d4e39286bf340e42602890446d9401
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
|
|
I fixed what I thought would be tolerable for this release.
Same issue as policy/common I had to defined the checkstyle
in each repo where the suppressions were needed.
Issue-ID: POLICY-1135
Change-Id: I8f30bee7e9cddc692ddad3cf88acedb2e6b4781b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Modified SO code to not return null lists for various buildXxxParam
methods.
Fixed commit message.
Added additional junit coverage to SO code.
Added additional junit coverage to SO code - cover more error cases.
Extracted another constant.
Change-Id: I65a27f2a1af1cfd8dd98bddab9ca1e862a3fa6fb
Issue-ID: POLICY-1129
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Don't return null lists from AAI.
Transient TargetLock.
Extract aai.url, et. al., constants.
Don't allocate extra unneeded variable.
Re-order fields in xacml attributes.
Extract "vserver" constant from simulator.
Replace thread sleep with join.
Change-Id: Iee1bd182862632af1f131cca5db5b526f5865b9f
Issue-ID: POLICY-1129
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
After a new round of discussion with the SO team, it was learned that
the SO scale-out request should NOT include the volumeGroup in
relatedInstanceList[0]; that item should be eliminated altogether.
Re-ordered some imports.
Updated license date.
Left volumeGroup in TestDemo, as it's a pseudo VID request.
Change-Id: I94e82b7e8fe6a41695b99888f291e24b7103687d
Issue-ID: POLICY-962
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
removed unused method parameter aaiResponseWrapper from
constructDeleteRequest
Change-Id: Ie434130b040732ed4e656c5592fff5b049695d29
Issue-ID: POLICY-1079
Signed-off-by: Piyush Garg <piyush.garg1@amdocs.com>
|
|
find the last non-base vf module item from AAI response and use the same
to construct create or delete vf module SO request
Change-Id: I3b9b97ac3008f6e4f7952662d9e4262f77dbeec4
Issue-ID: POLICY-1079
Signed-off-by: Piyush Garg <piyush.garg1@amdocs.com>
|
|
Enhanced SOActorServiceProvider to support VF Module Delete Recipe.
Added SOOperationType enum to map the policy recipe with the SO API that
we want to call for a recipe. vf module id from non-base vf module is
used to construct the delete request url and same will be deleted.
Updated SOManager so that it sends request to SO based on the
SOOperationType enum value.
Enhanced RESTManager to add support for the http delete using new class
HttpDeleteWithBody (to allow pass the payload to the SO delete VF module API).
Change-Id: I15b678ed9ebc85dfa7cb62bbf23e41c0fe6e4c69
Issue-ID: POLICY-1079
Signed-off-by: Piyush Garg <piyush.garg1@amdocs.com>
|
|
Lots of formatting, missing javadoc, distance from use,
imports must be explicit, ordering of methods.
Fixed some abbreviation problems in classes and renamed
JUnit tests to fix this.
Issue-ID: POLICY-883
Change-Id: I8494f63d88d63c0232aca97f7bcc848816228fb1
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
|
|
Updated licenses and serialization IDs.
Moved hashCode() and equals() methods to be in same location as in the
original code so it can be more easily compared.
Changed vDNS yaml timeout and retry to 1200 and 0, respectively, to match
the original values.
Removed extra newline from yaml, to match original yaml.
Reformatted source to wrap lines at 120 characters and removing trailing
white space.
Change-Id: I3f5e59a1f44750347de49164f587d4ffefdee8b4
Issue-ID: POLICY-962
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Should be pointing to policy/parent rather than oparent
directly. This will automatically support upgrades more
easily. Also removing duplicated managed version override
warnings from Maven.
This is continuing work to support the integration effort
to consolidate common versions of java dependencies across
all projects.
Issue-ID: INT-619
Change-Id: I37ac20e669262d9ac8fff09fd1ac540190b47a30
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Methods were added to AaiNqResponseWrapper to extract VF modules
and generate the new VF module name. This step modifies the SO
code to use those methods. It was also determined that the SO
code needs the VF module container object, not just the VF module,
itself. As a result, AaiNqResponseWrapper was modified to return
a list of the containers instead of a list of the VF modules.
Also modified the AAI simulator to return two VF modules in the
response to the vserver named query. As part of that, a method
was added to the simulator so that JSON responses can be read from
files rather than having to convert them to Java Strings.
Modified simulator to work even if vnf-id is null.
Change-Id: I68fdf07ea80ee0daf9e16403e35b11710315a8a8
Issue-ID: POLICY-1037
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
The AAI vserver named-query was being done as a preliminary step for the
SO request. However, it will now be needed during the guard query, which
happens much earlier. Thus it has been moved from the SO classes into
the event manager class, where it is retrieved in a lazy fashion and
cached.
Also removed some trailing white space.
Update licenses.
Make test method private.
Change-Id: Id7353a2e0f2d42601d5142cb92961528fa21aa94
Issue-ID: POLICY-1011
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Found few issues while going through the code. Fixing
these issues in the controlloop package classes
Issue-ID: POLICY-1017
Change-Id: I24d0ce1257ad689c3e9d9b7a3bea07eeb65383f1
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Replaced references to classes deleted from drools-pdp with references to the
corresponding in policy-common
Issue-ID: POLICY-967
Change-Id: Ia9d2ac704e6b7c434e5a9e7aee6d7dcf9198e4f2
Signed-off-by: mmis <michael.morris@ericsson.com>
|
|
Snapshot updated for Casablanca.
Issue-ID: POLICY-875
Change-Id: I0307282c4eabdb9ccd03282f918f4cd727ac4f86
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
These reviews must be merged in order because of layering.
This review should be merged THIRD.
Issue-ID: POLICY-844
Change-Id: I61d128f3244cd420abab15ab70c5c0e9d9afa625
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
These reviews must be merged in order because of layering.
This review should be merged FOURTH
PLD added version.properties
Change-Id: If7af7b3ae37166e88af92c0d1f1c558e5b60ab8e
Issue-ID: POLICY-798
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
The requestId keeps creeping into this code. For the instance
Id appending, we need a better strategy that conforms with robot
test scripts in order to do multiple scale ups.
Issue-ID: POLICY-793
Change-Id: Iab5d7608d5ee049cb6dd0508108bf77c2982db47
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
It seems this field is missing possibly from refactoring code.
Issue-ID: POLICY-792
Change-Id: I6d13feb12a383d32dce3bbba431e32ad0b9d1e19
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
I removed a couple of empty README and added licenses.
Issue-ID: POLICY-741
Change-Id: I10aad3536d02b738a1dc606f7311de6b3a2777cd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-736
Change-Id: I2bc455510e925764d18a1d8e96e072bdadb251c6
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Removed checkstyle warnings from:
policy/drools-applications/controlloop/common/model-impl/appc
policy/drools-applications/controlloop/common/model-impl/appclcm
policy/drools-applications/controlloop/common/model-impl/events
including changes to template files due to renamed methods
Issue-ID: POLICY-705
Change-Id: Ieb93baf43268aa608f204eef1a610354f2adec32
Signed-off-by: mmis <michael.morris@ericsson.com>
|
|
Removed checkstyle warnings from
policy/drools-applications/controlloop/common/model-impl/aai
including renaming classes:
AAI* -> Aai*
PNF* -> Pnf*
and renaming some methods in those classes
Issue-ID: POLICY-705
Change-Id: I2d59a668728aa58a2c9fbe78c44e924e6cfb4531
Signed-off-by: mmis <michael.morris@ericsson.com>
|
|
Removed checkstyle warnings in:
policy/drools-applications/controlloop/common/actors
policy/drools-applications/controlloop/common/eventmanager
policy/drools-applications/controlloop/common/feature-controlloop-utils
Issue-ID: POLICY-705
Change-Id: Iccf99b291bc62bc3ba2082ccdb4c1f9e12107896
Signed-off-by: mmis <michael.morris@ericsson.com>
|
|
Modified SoActorServiceProvider.constructRequest() method so that it
iterates over extra properties instead of hard coding array values.
Issue-ID: POLICY-443
Change-Id: I37d6be9dc595bd8d5e9f9f3f63d6890ef1b2f8b3
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
|
|
Generation of Unique values for attribute vf-module-name for every scale out operation
Change-Id: I5274361c2f5a4136020a384dbe4a4009607f589a
Issue-ID: POLICY-610
Signed-off-by: SwapnilPathak <SP00494485@techmahindra.com>
|
|
The naming of Maven modules in drools-applications was not
aligned with the directory structure in the git repository
of drools-applications. Therefore it was difficult to
see the strucutre of the repository in Eclipse and other
IDEs. This change amends the Maven module IDs to
reflect the repository directory structure.
This patch reset fixes the previos patch set, where many
references to maven modules internally in drools-applciations
were missed. See also changes in engine and docker repos.
Updated to reflect repo directory structure in maven
artifact groups.
Issue-ID: POLICY-238
Change-Id: I8ab1a7ecdb664045222bbbfda269135e3e449109
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
|
|
|
|
Unit test for actor service provider added and technical debt removed.
Change-Id: I9573f1c3ff0252b166e06caaa88eb679a1fc7347
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Issue-ID: POLICY-455
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Unit test expanded for SO POJOs, technical debt removed in SO actor and VFC pojos.
Change-Id: I23b886c40c1ac6ac8dc2ebbaade315b71cca9dd0
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Issue-ID: POLICY-455
|
|
Unit test for SO actor added. SO actor service provider class refactored to remove technical debt.
Change-Id: I6186ede5661ce483917184f03ee44d57a124b6a4
Issue-ID: POLICY-455
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
|
|
Converted to POJOs, fixed sona lint errors, added JUnit tests
POJOs now have only private members and getters/setters
This implicated actors, simulators, and existing tests
Issue-ID: POLICY-455
Change-Id: I4b80f729565e8675822a890892b15676908f73b4
Signed-off-by: vdmeer.sven <sven.van.der.meer@ericsson.com>
|
|
Mainly making fields private, fixing field and methods to follow Java guidelines, and adding getter and setter methods. Unit test added for all classes in org.onap.policy.controlloop
Issue-ID: POLICY-455
Change-Id: I445b7cfaf9eb921a230bbb72b06ff4455fe003ce
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
|
|
Fields have been made fields private in POJOs, and wrote JUnit unit tests to bring up code coverage. AAIManager also changed to use non-static methods so that it can be stubbed with Mockito.
Change-Id: I871427ced5db8a1dfd6495fef4e6d84adf264e65
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
Issue-ID: POLICY-455
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
|
|
Eliminate the technical debt identified in the drools-applications/controlloop/common/model-impl/aai module by Sonar
Change-Id: I72125baacc217386a4984be04bfc023439eddd13
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
Issue-ID: POLICY-455
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
|
|
Bump minor version in preparation for Amsterdam
branching.
Change-Id: Ia7e97a72053a2d1cd10c0b9d5c179817c3ac7e23
Issue-ID: CIMAN-120
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
|
|
Released 1.1.1, now must bump patch by 1
Issue-ID: POLICY-436
Change-Id: I3f5e4c369575f6fe1fa06cabb96a5bd43cb11087
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-447
Change-Id: I63cd5d20670f224aa4b9220b99ee40aad4f3e50c
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
|
|
Issue-ID: POLICY-438
Change-Id: I1d27d0e5f7d253aa3cba82f5f4b515c01be35d8b
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
|
|
Issue-ID: POLICY-438
Change-Id: I05e634782004fff5540b3e6fabb9e22846438cb1
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
|
|
|
|
- Renamed modelNameVersionId to modelVersionId in SOModelInfo
- Removed requestID from SO Request body
- As a result of this, an SOResponseWrapper was needed in order to
attach the control loop event requestId to use in the SOResponse
rule in drl (the requestID that is returned in the SO response
is a newly generated requestId with no relation to the Policy
control loop event requestId as per Arthur)
- Updated drl to reflect the above mentioned change
- Updated simulator and junits to reflect changes
- Added an additional null httpResponse check/logger statement in SOManager and RestManager
Issue-ID: POLICY-438
Change-Id: I5f414ba69b60b5565cca9073b47f4c4835e5abbf
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
|
|
Releasing v1.1.0 so need to update version to 1.1.1
Issue-ID: POLICY-436
Change-Id: I8b85de39bb3a32f5f4faeeb4fcdfb5d95291ae31
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Change-Id: I61c8d698f8cf984c648e510997498d41e7d9744a
Issue-ID: POLICY-433
Signed-off-by: Jorge Hernandez <jh1730@att.com>
|
|
Issue-ID: POLICY-292
Change-Id: Ia4d4fae4150ea12e46079aabb4bbf4e3c92c8d00
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
|