aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-02-12Fix sonars from dependency upgradeJim Hahn21-131/+83
The dependency upgrades in policy-parent caused some new sonars. In particular, initMocks() has been deprecated - replaced with calls to the Mockito Runner. Issue-ID: POLICY-2910 Change-Id: I257b74626f4393aa89d2bf1b7502478422213b71 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-10More sonars in drools-appsJim Hahn3-11/+7
Addressed the following issues: - commented-out code - don't use eq() with verify() - use class::cast lambda Issue-ID: POLICY-2910 Change-Id: I12f4f85fb226f3ddb8305105e988fa90e276e9f6 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-09Merge "Delete unused persistence.xml"Ram Krishna Verma1-43/+0
2021-02-09Delete unused persistence.xmlJim Hahn1-43/+0
Deleted the file, as it is no longer needed. Issue-ID: POLICY-3005 Change-Id: Ia8de5838440c38dc31177e316118db75965d9338 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-09Upgrade dependenciesJim Hahn4-5/+26
Added target-database property. Also moved the db-driver value out of persistence.xml and into properties. Issue-ID: POLICY-3005 Change-Id: I2c9e53c099e400c32d11632f8732e770a7abba9f Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-05Give better messages than NPE for missing dataJim Hahn2-15/+96
When data is not available to actor operations, an NPE is generally thrown. Modified the code to provide more info about what is missing than simply NPE. Issue-ID: POLICY-2913 Change-Id: Ic56376ef5fdd0f2e46c2996405fff9aafa3692b9 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-01-04Changed identifiers to concept identifiersliamfallon2-5/+7
The policy models tosca classes ToscaPolicyIdentifier and ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA concept, not just TOSCA policies so they are renamed to ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion respectively. The class ToscaPolicyTypeIdentifier is redundant and is replaced by ToscaConceptIdentifier. Issue-ID: POLICY-2900 Change-Id: Id5da4e5894a0d646f9f4b68c1e6b0476d4deae05 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-11-23Merge "Use Params makeOutcome() without targetEntity"Ram Krishna Verma2-2/+5
2020-11-20Remove legacy simulatorsJim Hahn14-1596/+0
Drools-apps now uses simulators from policy/models. Deleted the legacy simulators. Issue-ID: POLICY-2804 Change-Id: Ie118237a52a4272d2f86fbb15b320ea2175ac7f4 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-11-20Use Params makeOutcome() without targetEntityJim Hahn2-2/+5
Planning to remove the second flavor of makeOutcome() from the Params, so modifying the drools-apps code to work with the first flavor. Issue-ID: POLICY-2804 Change-Id: Iddb288f7cf53e93919e77aca8afe3869fadb0d37 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-11-20Merge "Delete preprocessed flag from actors"Pamela Dragosh9-12/+27
2020-11-18Delete preprocessed flag from actorsJim Hahn9-12/+27
Removed the "preprocessed" flag from the Actor parameters, now that the actors no longer have a startPreprocess() method. Also removed targetEntity from the parameters. Issue-ID: POLICY-2804 Change-Id: I13bc80e1b6bb22d8d21b176796ca062109ce6658 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-11-18Merge "move all bash to ash shell scripts for drools-apps"Jorge Hernandez3-7/+7
2020-11-16move all bash to ash shell scripts for drools-appsTaka Cho3-7/+7
this gerrit would be the first step to not to use any GPL-3.0 and plus license Issue-ID: POLICY-2847 Change-Id: I6787af6afd4a90d09d3cca86fa2ee7c5b6ea4eb0 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-11-16Make drools-apps event agnosticJim Hahn56-8212/+47
Removed tdjam and frankfurt controllers, which use event-specific actors. Issue-ID: POLICY-2804 Change-Id: Ica05f80bf72d039d9c4903591af7fb3793a81159 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-11-10Allow mixed case in check of prov-statusJim Hahn4-4/+58
Apparently SO/AAI in Frankfurt are setting the prov-status to "active" instead of "ACTIVE". Modified the code to ignore case when comparing. Issue-ID: POLICY-2890-prov-status2 Change-Id: I9e868d320dadcb3ac51570718d10f33d0011ae47 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-11-06Fix upcoming checkstyle issuesPamela Dragosh1-1/+1
When we upgrade to oparent, these will fail as oparent upgrades to 8.37 of puppycrawl which fixes a few bugs that should have flagged these previously. Issue-ID: POLICY-2887 Change-Id: I2ea37eef859aac08f54ffd1f4b1d6b9e702218e9 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-10-29correct filename and restructure directories for s3pTaka Cho6-5280/+41
move s3p jmx and shell script under resources remove old jmx files from the previous release Issue-ID: POLICY-2832 Change-Id: I2c1d4f2137655bc096b402b12625fa4add15ecf5 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-10-28Merge "add jmx and shell script for s3p drools-app"Jim Hahn2-0/+3429
2020-10-27Bump drools-apps master to 1.8.0 SNAPSHOTJim Hahn24-29/+29
Bumping minor version now that guilin branch has been created. Also repointed to snapshot versions for dependencies. Issue-ID: POLICY-2875 Change-Id: Ieb3f8d6ff141d3035141ab8672d3259074f432be Signed-off-by: Jim Hahn <jrh3@att.com>
2020-10-27add jmx and shell script for s3p drools-appTaka Cho2-0/+3429
modified s3p.jmx from Frankfurt to fit for Guilin. and modified shell script from Amsterdam Issue-ID: POLICY-2832 Change-Id: Id9ab2535e6ea8bce0f5f367fbf296fc215d65c9f Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-10-20Bump drools-apps to 1.7.5 SNAPSHOTJim Hahn24-24/+24
Issue-ID: POLICY-2869 Change-Id: I627c5b1c4c5f946c1187a6966b30d3943825fa71 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-10-20Release drools-apps 1.7.4 dockerJim Hahn1-0/+8
Issue-ID: POLICY-2869 Change-Id: I84c5128e0b82c72cd81540174442ceb19407dd3d Signed-off-by: Jim Hahn <jrh3@att.com>
2020-10-20Release drools-apps 1.7.4 artifactsJim Hahn1-0/+5
Issue-ID: POLICY-2869 Change-Id: Ib0d32f3c87bff3ce402a1435e2a4ef9e0dd01940 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-10-20Use release versions in drools-appsJim Hahn1-1/+1
Issue-ID: POLICY-2869 Change-Id: Ie55fb49b22b7880575395f6fa7676a508f1f2a85 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-10-20Point drools-apps to models 2.3.5Pamela Dragosh1-1/+1
Issue-ID: POLICY-2869 Change-Id: Ideb10482ffd3e670e6237305ef8ff9d0a0143257 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-10-14point to drool-pdp 1.7.4-SNAPSHOTTaka Cho1-1/+1
Issue-ID: POLICY-2864 Change-Id: I45fd53df2d143d1e082db477316b4378d8c5e6a0 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-10-10Merge "bump drools-apps to 1.7.4-SNAPSHOT"Jim Hahn24-24/+24
2020-10-10bump drools-apps to 1.7.4-SNAPSHOTTaka Cho24-24/+24
Issue-ID: POLICY-2839 Change-Id: Ie0bc82d0f8a09dc4d65e056dc7836870dae58835 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-10-10Release drools-apps 1.7.3 docker imageJim Hahn1-0/+8
Issue-ID: POLICY-2863 Change-Id: I5a42abffe141febf35e03c227683515ae4870a5d Signed-off-by: Jim Hahn <jrh3@att.com>
2020-10-10Release drools-apps 1.7.3 artifactsJim Hahn1-0/+5
Issue-ID: POLICY-2863 Change-Id: Ifef9714179ae4a19793c6599abe672a5191cc101 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-10-10Use models 2.3.4 and drools-pdp 1.7.3 releasesJim Hahn1-2/+2
Issue-ID: POLICY-2863 Change-Id: Iac66e5f4794e9d959490f205b4f00ccfa4c1d332 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-10-09Use models and drools snapshotsJim Hahn1-2/+2
Issue-ID: POLICY-2863 Change-Id: I7e436034dfaa1917b1fba050ab832b273730bb41 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-10-08Bump drools-apps to 1.7.3 snapshotTaka Cho24-24/+24
Issue-ID: POLICY-2839 Change-Id: Iafbc4a301ee8bc2b5fb10f34677f752a87997879 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-10-07release drools-apps docker 1.7.2Taka Cho1-0/+8
Issue-ID: POLICY-2839 Change-Id: Id515d64554794677ab1c83626fe0f337856498cf Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-10-07release 1.7.2 drools-apps artifactTaka Cho1-0/+5
Change-Id: Ib135c94c5702dd24908e3251fae035a7894db6de Issue-ID: POLICY-2839 Change-Id: Ie673f7c20f5a84bc7a1cdf053b51dfa373507ae6 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-10-07Point to model 2.3.2 and drools-pdp 1.7.2Taka Cho1-2/+2
Issue-ID: POLICY-2839 Change-Id: I2a405e42e81073a3862cf1a3e01a8c0deaccc36e Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-10-02Merge "Remove cds actor timeout"Pamela Dragosh1-1/+3
2020-10-01Remove cds actor timeoutRam Krishna Verma1-1/+3
During testing we found that cds actor is picking up the timeout from policy configuration. As discussed, adding a comment for now and we will remove it in next release alog with related code. Issue-ID: POLICY-2843 Change-Id: I63b589bea344ad7f33e6fc0d34f0ab331411146b Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-10-01Merge "Fix new sonars in drools-apps"Jim Hahn10-61/+101
2020-09-30Fix new sonars in drools-appsJim Hahn10-61/+101
Addressed the following sonars: - too many assertions in test method - rename test class - use static method to modify static field - use already defined constant - code always returns the same value - use assertNotSame - use appropriate class name to access static method - define a constant - extract nested try block - don't always return the same value - use remove() instead of set(null) for thread-local-storage - add @Override Issue-ID: POLICY-2852 Change-Id: Icc62acd4ad57afa2d44ed4cdca504a3ac0810228 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-09-29remove enable frankfurt controllerTaka Cho1-1/+0
In G-Rel, we will use usecases controller. only install frankfurt controller by default keep disable for frankfurt controller Issue-ID: POLICY-2849 Change-Id: I3f09a2920b2bf05af0389b56366ce7229d8113c2 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-09-14Release locks between junit testsJim Hahn5-18/+66
Tdjam junits were randomly failing. Traced it down to the fact that the locks were being released asynchronously and thus were not always released when the next test cases requested them. Also simplified logging for tdjam junit tests. Fixed the property file so it isn't overwritten by the junit tests. Changes per review comments: - changed "Pattern" to "pattern" in logback xml Issue-ID: POLICY-2789 Change-Id: I325ec69cf7affa531d3c575e3a34bc0b0e1edac7 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-09-09bump snapshot version to 1.7.2-SNAPSHOTjhh24-24/+24
Issue-ID: POLICY-2789 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I4335cf77bd4a228fe0bec2d5eb529789e8144406
2020-09-09docker release 1.7.1jhh1-0/+8
Issue-ID: POLICY-2789 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Id0fc75b4c27ec1fdd4e33eb60c784e3c63e37952
2020-09-09maven release 1.7.1jhh1-0/+5
Issue-ID: POLICY-2789 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Iad1b751d39518eb7d38b25b37d02b57f665d24e7
2020-09-09disable TdjamTest junitsjhh1-0/+2
junits consistently fail in staging jobs Issue-ID: POLICY-2789 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I968bd9ec2c3e8278358ef3c487592c0b833cef36
2020-09-09delete guard dependency for tdjamjhh2-9/+0
staging job fails as there is no guard dependency. Issue-ID: POLICY-2789 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I4d803e269c7199ddeb2ebb52df5368259e4f22cd
2020-09-08Update common/models/drools to 1.7.1/2.3.1/1.7.1jhh6-38/+3
Issue-ID: POLICY-2789 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ia78684b0f56007941ad6038d78b97bc70f9aa1bb Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-09-03Merge "update the toscapolicy in ruletest set"Ram Krishna Verma2-2/+2